- 05 Feb, 2019 13 commits
-
-
Georg Neis authored
For instance, in the case of a ScriptContext, the extension_object() getter fails. Change-Id: Id0d65bc7c44438f60e2e824535081fa785feb3c8 Reviewed-on: https://chromium-review.googlesource.com/c/1454482Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#59365}
-
peterwmwong authored
- Avoids generating ConstructByArrayLike multiple times within CreateTypedArray - Make TypedArrayInitialize a macro to avoid TFS builtin call overhead. Small reduction in builtins size: Before - 9508 TypedArrayInitialize + CreateTypedArray After - 9476 CreateTypedArray Improvements to related typed array constructor benchmarks: TypedArrays-Constructor ~5% TypedArrays-ConstructArrayLike ~2.7% Bug: v8:7161 Change-Id: I1684c3d7577afbb181ea4691caa00c60da391266 Reviewed-on: https://chromium-review.googlesource.com/c/1452239Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Cr-Commit-Position: refs/heads/master@{#59364}
-
Clemens Hammacher authored
This is a reland of 8a914846. No modifications, this CL was not the culprit. Original change's description: > [wasm] Turn deferred handles into global handles > > Each instance of {DeferredHandles} only stores a single handle anyway, > so turning them into global handles saves memory. > > R=ahaas@chromium.org > > Bug: v8:7921, v8:8423 > Change-Id: I75e0cc6ecb6d0337f1695e6bfd4b5fdcb8a2039c > Reviewed-on: https://chromium-review.googlesource.com/c/1402715 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59331} Bug: v8:7921, v8:8423 Tbr: ahaas@chromium.org Change-Id: I9111eb6405c2624779b9eaa65353ab5f438e9daf Reviewed-on: https://chromium-review.googlesource.com/c/1451930Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59363}
-
Tamer Tas authored
This reverts commit 7f92ad0a. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32/19148 Original change's description: > [test] refactor testsuite configuration > > Every testsuite configuration consist of at least 30% code duplication. > > The code age ranges from 10 years old to 5 years old. Implementing anything that > touches the testsuite code becomes a technical fight to the death. > > This CL removes all the duplication by refactoring the common functionality. > > This CL contains structural changes without any logical changes % small bug > fixes. > > R=machenbach@chromium.org > CC=yangguo@chromium.org,sergiyb@chromium.org > > Bug: v8:8174, v8:8769 > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1445881 > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59361} TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org,v8-reviews@chromium.org Change-Id: I473f0d4c6b9c0239923b8c03699dbc38b7f85030 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8174, v8:8769 Reviewed-on: https://chromium-review.googlesource.com/c/1454599 Commit-Queue: Tamer Tas <tmrts@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Tamer Tas authored
Every testsuite configuration consist of at least 30% code duplication. The code age ranges from 10 years old to 5 years old. Implementing anything that touches the testsuite code becomes a technical fight to the death. This CL removes all the duplication by refactoring the common functionality. This CL contains structural changes without any logical changes % small bug fixes. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174, v8:8769 Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 Reviewed-on: https://chromium-review.googlesource.com/c/1445881 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59361}
-
Jakob Gruber authored
For these two fields, an offset of 0 was used to mark non-existent tables. After this CL, it always contains a real offset even if the table is empty. This matches behavior of other embedded metadata (constant pool and code comments). Remnants of the old behavior still remain in WasmCode and HandlerTable. Drive-by: Update comments describing Code object layout. Drive-by: Unify naming of Code offset constants. Bug: v8:8758 Change-Id: Ia8a1f66988b6c294a026b96f4f272fc5583a8c30 Reviewed-on: https://chromium-review.googlesource.com/c/1451880Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59360}
-
Simon Zünd authored
This CL introduces Torque classes with fields around TypedArrays so CSA LoadObjectField accessors that are only used in Torque code can be removed. R=tebbi@chromium.org Bug: v8:8562 Change-Id: Ie46dad5c25bd6ac03aacef8509e22f435896d127 Reviewed-on: https://chromium-review.googlesource.com/c/1451823Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#59359}
-
Tom Tan authored
Because Windows ARM64 is in LLP64 data model, the long type as input parameter for labs is still 32-bit. std::abs has overloads for both long and long long type, which works for both LP64 and LLP64 data model (see below links). https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/abs-labs-llabs-abs64 https://en.cppreference.com/w/cpp/numeric/math/abs Bug: chromium:893460 Change-Id: I477d22d550bd92bf9dcc974ac84b4fe5222c1e13 Reviewed-on: https://chromium-review.googlesource.com/c/1448715Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#59358}
-
Jakob Gruber authored
This adds Code::has_foo() and Code::foo_size() helpers for inlined metadata sections (currently: the safepoint table, handler table, constant pool, and code comments). Prior to this, each call site had to know implementation details of the instruction area layout. Bug: v8:8758 Change-Id: I9dc391992a4bf709ee403beab8606d85540dc1be Reviewed-on: https://chromium-review.googlesource.com/c/1451838 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Daniel Clifford authored
Bug: v8:7793 Change-Id: Iaf3941b76e261308f656fb92b3c53e6cab5ad350 Reviewed-on: https://chromium-review.googlesource.com/c/1454476 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
-
Ujjwal Sharma authored
Port String.prototype.startsWith from a CPP builtin to a Torque builtin. Spec: https://tc39.github.io/ecma262/#sec-string.prototype.startswith Bug: v8:8400 Change-Id: I51aff0b3a4126c17ab4f89763019fd7e4ba665d9 Reviewed-on: https://chromium-review.googlesource.com/c/1361340 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Tamer Tas authored
Test262 has a couple of duplicated test files with the identical inside both "test262/data/test" and "test262/local-tests/test". Testrunner used to deduplicate the tests, which masked this issue. This CL removes the obsolete copies in the local-tests. R=adamk@chromium.org,yangguo@chromium.org,machenbach@chromium.org Bug: v8:8174,v8:8728 Change-Id: Iecdc40b417f237feb916f1c3a24f8def7ea11fad Reviewed-on: https://chromium-review.googlesource.com/c/1452436Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59354}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ed3546e..09cca07 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/8af4b4b..02bb14c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a1fbdff..367af22 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic46e94886b9181daa5abd9aea4deb04aab5dd390 Reviewed-on: https://chromium-review.googlesource.com/c/1453182Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#59353}
-
- 04 Feb, 2019 27 commits
-
-
Sven Sauleau authored
Remove the call to [[HasProperty]] for the shared property when threads feature is enabled. Bug: v8:8782 Change-Id: I492ed3726ea846a1a52dc3a0e0a183d9ee506e96 Reviewed-on: https://chromium-review.googlesource.com/c/1451826Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Cr-Commit-Position: refs/heads/master@{#59352}
-
Junliang Yan authored
Fix unaligned memory access error inconstant pool access during relocation. Change-Id: I960b59b226cc5f212fff4565b2c7694364f2cb54 Reviewed-on: https://chromium-review.googlesource.com/c/1452357Reviewed-by:
-
Yang Guo authored
This reverts commit 91344c5f. The original commit seems to cause some issues. TBR=machenbach@chromium.org Change-Id: I2ee3f635ad8c2edd78c4c645c075c4153fb8a8ee Reviewed-on: https://chromium-review.googlesource.com/c/1452440Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
See referenced bug. This is currently broken and blocks the roll. The CL cannot easily be reverted, so I disable code logging for now while working on a fix. R=herhut@chromium.org, sigurds@chromium.org Bug: v8:8783 Change-Id: I222981313535cadd1ddc345bdf56dfabfc328c82 Reviewed-on: https://chromium-review.googlesource.com/c/1452437Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59349}
-
Maciej Goszczycki authored
Bug: v8:7464 Change-Id: I1b33bfff02ccd1ae19f0525e8ab0f8bfe69abe17 Reviewed-on: https://chromium-review.googlesource.com/c/1451933Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Cr-Commit-Position: refs/heads/master@{#59348}
-
Toon Verwaest authored
This is 3-4x faster than using the Utf8Decoder. This matters for proper parse-time measurements using d8. Change-Id: I9870e9fbe400ec022a6eeb20491c80a2a32f8519 Reviewed-on: https://chromium-review.googlesource.com/c/1451827 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#59347}
-
Clemens Hammacher authored
Merge {Abort} into {AbortCompilation}. R=ahaas@chromium.org Bug: v8:8689 Change-Id: I091a298b1195d145fc21d2afb9d9cc9c57925f95 Reviewed-on: https://chromium-review.googlesource.com/c/1451821 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#59346}
-
Michael Achenbach authored
TBR=jgruber@chromium.org NOTRY=true Bug: v8:7777 Change-Id: I5006aee897fe0d0705e7265e714ec200e13370b1 Reviewed-on: https://chromium-review.googlesource.com/c/1451890Reviewed-by:
-
Sigurd Schneider authored
This CL adds handling for Load/StoreMessage to LoadElimination. It is handled like a Load/StoreField to an external location. Change-Id: I50f27fba9cb7ffabf1474aa409083676cef65442 Bug: v8:8183, chromium:927746 Reviewed-on: https://chromium-review.googlesource.com/c/1451879 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The flag value and {Platform::NumberOfWorkerThreads()} are already int, and we do not expect to spawn more than 2 billion threads any time soon. R=titzer@chromium.org Bug: v8:8562 Change-Id: I9c23ae1b5b9e9daab3fdb072bf98f48ea2b3f240 Reviewed-on: https://chromium-review.googlesource.com/c/1451887 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#59343}
-
Clemens Hammacher authored
This reverts commit 8a914846. Reason for revert: Seems to cause layout test failures: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%2520Mac/16246 Original change's description: > [wasm] Turn deferred handles into global handles > > Each instance of {DeferredHandles} only stores a single handle anyway, > so turning them into global handles saves memory. > > R=ahaas@chromium.org > > Bug: v8:7921, v8:8423 > Change-Id: I75e0cc6ecb6d0337f1695e6bfd4b5fdcb8a2039c > Reviewed-on: https://chromium-review.googlesource.com/c/1402715 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59331} TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I8996fd22702b5dd0485e59b54989788596293a1f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7921, v8:8423 Reviewed-on: https://chromium-review.googlesource.com/c/1451888Reviewed-by:
-
Clemens Hammacher authored
This removes the last creation of foreground tasks in the compilation state. I think this logic can be removed completely, because a) the number of background tasks is already capped at {max(1, FLAG_wasm_num_compilation_tasks)}, and b) in order to get predictable timing you can use the --predictable flag which makes all background tasks execute synchronously with foreground tasks (from the same queue). R=ahaas@chromium.org CC=mstarzinger@chromium.org Bug: v8:8050, v8:8689 Change-Id: I142af6b42f9bb9befc7c7b7d6002192d72bd7677 Reviewed-on: https://chromium-review.googlesource.com/c/1451841 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Georg Neis authored
...except for the initial function. Bug: v8:7790, chromium:928202 Change-Id: I220e13d148525734d866f8aaf0c7ef8cbeccbcb2 Reviewed-on: https://chromium-review.googlesource.com/c/1451825Reviewed-by:
-
Clemens Hammacher authored
The counters are the last use of the Isolate. Remove it by passing in the counters in a shared_ptr. This way, we can also refactor the counters later to be per engine or per process. In a follow-up CL, we can then remove the Isolate, the foreground task runner and the cancellable task manager from the compilation state. R=mstarzinger@chromium.org Bug: v8:8689, v8:8050 Change-Id: I66b4fab77f770cb8a5463244054b428eef1b7c61 Reviewed-on: https://chromium-review.googlesource.com/c/1451922 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
- fix highliting of extends clause in types - label constants as constants Change-Id: Iad1682a5c294dc1999067f4e43feb4aada7e1ced Reviewed-on: https://chromium-review.googlesource.com/c/1451924 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
peterwmwong authored
The parts that deal with allocating on heap buffers and typed array elements (FixedTypedArrayBase) remain in CSA, as it is assumed to eventually be expressed with Torque classes. This reduces overall builtins size by 508 bytes (Mac x64.release) - TypedArrayInitialize 2332 -> 1824 Bug: v8:7161 Change-Id: I5d0648b4dd79a687f77d6f4b01b236f4a0508c54 Reviewed-on: https://chromium-review.googlesource.com/c/1445215Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: I25e41548c526e93c5b0a532ca2d270b62193a557 Reviewed-on: https://chromium-review.googlesource.com/c/1448315 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#59336}
-
Clemens Hammacher authored
The compilation state is isolate-independent, so it should not cache the isolate-specific {should_log_code} flag. Instead, we log via the WasmEngine every time. If this turns out to be too expensive, we should introduce an atomic flag in the WasmEngine. R=mstarzinger@chromium.org Bug: v8:8050 Change-Id: I913ada4f86af4c6fa9cd9c5adc8d4e250f6eb7f1 Reviewed-on: https://chromium-review.googlesource.com/c/1451820Reviewed-by: -
cjihrig authored
This commit updates gen-postmortem-metadata.py to re-export the v8dbg_class_JSFunction__shared__SharedFunctionInfo constant. See: https://github.com/nodejs/node/pull/25852 Change-Id: I60f39c96f3f22d6f10ec38b0af3c975908c7b7f2 Reviewed-on: https://chromium-review.googlesource.com/c/1450144Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Change-Id: I71c5fbfbb58cd13613506acabf446d9cffc6d23b Reviewed-on: https://chromium-review.googlesource.com/c/1451837Reviewed-by:
-
Michael Achenbach authored
Bug: v8:8778 Change-Id: I384ad4387743d534a79ebad03130e8a688cc4631 Reviewed-on: https://chromium-review.googlesource.com/c/1449691Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Each instance of {DeferredHandles} only stores a single handle anyway, so turning them into global handles saves memory. R=ahaas@chromium.org Bug: v8:7921, v8:8423 Change-Id: I75e0cc6ecb6d0337f1695e6bfd4b5fdcb8a2039c Reviewed-on: https://chromium-review.googlesource.com/c/1402715 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Ross McIlroy authored
BUG=v8:7295,v8:8562 Change-Id: Ifa02ba233967ba38d4ff43576de77738001d076a Reviewed-on: https://chromium-review.googlesource.com/c/1450115Reviewed-by:
-
Takuto Ikuta authored
This is a reland of 83908b86 Fix: check V8_INTL_SUPPORT macro in js-objects.cc Original change's description: > Reland "Extract JSObject class from objects.cc" > > This is a reland of b8c821f4 > > Fix: include src/string-stream.h for compile failure > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20builder/39320 > > Original change's description: > > Extract JSObject class from objects.cc > > > > I extracted following class member functions to js-objects.cc > > * JSReceiver > > * JSObject > > * JSBoundFunction > > * JSFunction > > * JSGlobalObject > > * JSDate > > * JSMessageObject > > > > Declaration of all above class are in js-objects.h. > > > > I also moved AllocationSite::DigestTransitionFeedback used in JSObject::UpdateAllocationSite > > and ShouldConvertToSlowElements used in JSObject and JSArray > > > > This patch makes compile time of objects.cc from 17.6s to 14.1s on Z840 Linux. > > And js-objects.cc takes 8.69s for compile. > > > > Bug: v8:7629 > > Change-Id: I989f22363667445dd28d7f8c06c81ff79d6ed45f > > Reviewed-on: https://chromium-review.googlesource.com/c/1447916 > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > Reviewed-by: Marja Hölttä <marja@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#59288} > > Bug: v8:7629 > Bug: v8:8562 > Change-Id: Iac2227c5f0c5a4072d16814ecae481fb4720e4f5 > Reviewed-on: https://chromium-review.googlesource.com/c/1449951 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59318} Bug: v8:7629, v8:8562 Change-Id: If8870bd579d8597d08981a83492f60595e081a65 Reviewed-on: https://chromium-review.googlesource.com/c/1452097Reviewed-by:
-
Clemens Hammacher authored
This is a reland of a9e93572 Original change's description: > [test] Check for illegal uses of mjsunit methods > > The assertThrows and assertDoesNotThrow methods expect either a > function to execute, or a string to eval. In several tests however we > accidentally passed the *result* of the statement to be tested instead > of the code. > This CL adds check to catch such error early, and removes wrong uses. > In most places, we do not need to use assertDoesNotThrow anyway, > because exceptions are handled as test failures. > > Drive-by: Unify catch syntax in mjsunit.js and make sure to propagate > MjsUnitAssertionErrors correctly. > > R=mathias@chromium.org > > Bug: v8:8562 > Change-Id: I88894a667cbe0570774f748a9a23e8a527887a49 > Reviewed-on: https://chromium-review.googlesource.com/c/1439238 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59277} Bug: v8:8562 Change-Id: I3b26935f7b35302d499266155273ea271bf8151d Reviewed-on: https://chromium-review.googlesource.com/c/1449792Reviewed-by:
-
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: v8:8781 Change-Id: I6982170a3e4c31a6d39e6368b7a3163dbb08cee7 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1451917Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Bug: v8:8278 Change-Id: I0f6c5ca3766ce6a9ffa2a97082b875b2a3fb357f Reviewed-on: https://chromium-review.googlesource.com/c/1450122Reviewed-by:
-
