- 07 May, 2020 15 commits
-
-
Nico Hartmann authored
The code generated by TurboFan was incorrect when comparing to non-oddball undetectables using abstract equality. In particular, %GetUndetectable() == %GetUndetectable() did not return false. Bug: chromium:1051008 Change-Id: Ib62adc72a20aa6cca9ef6499d5fe7429f04623cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187498 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#67647}
-
Georg Neis authored
R=nicohartmann@chromium.org Change-Id: I55ef4e0713e0aa583ea01f1a86fee9cf0ef2c17a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184296 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#67646}
-
Nico Hartmann authored
This CL cleans up CompareOperationFeedback by replacing it with a composable set of flags. The interpreter is changed to collect more specific feedback for abstract equality, especially if oddballs are involved. TurboFan is changed to construct SpeculativeNumberEqual operator instead of the generic JSEqual in many more cases. This change has shown a local speedup of a factor of 3-10, because the specific operator is way faster than calling into the generic builtin, but it also enables additional optimizations, further improving runtime performance. Bug: v8:5660 Change-Id: I856752caa707e9a4f742c6e7a9c75552fb431d28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2162854Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org,ahaas@chromium.org Bug: v8:10408 Change-Id: Id4f5136e36ab41a18a240e31c7a43bf634be2e44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179384 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67644}
-
Nico Hartmann authored
This reverts commit fb9a19fe. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/11028 Original change's description: > cppgc: Initial marking loop > > This CL introduces: > - Worklist > - MarkingHandler to manage gc marking phase > - Integration into CollectGarbage for atomic pause GC > - MarkingVisitor for main thread marking > > Still missing from this CL: > - Proper handling for stack scanning > - Handling of previously not fully constructed objects > > Bug: chromium:1056170 > Change-Id: I70ac8534dfb898777cf3a06e3119cac8072174fd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2170526 > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67642} TBR=ulan@chromium.org,mlippautz@chromium.org,bikineev@chromium.org,omerkatz@chromium.org Change-Id: I666481f44119771be685bf2555aa0dd5eda83a01 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187502Reviewed-by:
-
Omer Katz authored
This CL introduces: - Worklist - MarkingHandler to manage gc marking phase - Integration into CollectGarbage for atomic pause GC - MarkingVisitor for main thread marking Still missing from this CL: - Proper handling for stack scanning - Handling of previously not fully constructed objects Bug: chromium:1056170 Change-Id: I70ac8534dfb898777cf3a06e3119cac8072174fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2170526 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#67642}
-
Mike Stanton authored
We know the array CodeGenerator::deoptimization_literals_ is corrupted somehow. Additional checks in place to validate. Bug: chromium:1027130 Change-Id: Ie0146003f096d24e67aeb382372bca8472548c2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182636 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Ng Zhi An authored
See https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-override.html for more on this warning. Bug: v8:10488 Change-Id: I6805441fa24c80776cf94d18ff389c4c67bb5abd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2186635 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#67640}
-
Clemens Backes authored
Currently WebAssembly breakpoint information survive disabling and re-enabling the debugger. This is different from JavaScript, where they are all removed. The frontend is expected to re-set the breakpoint then. Thus this CL remembers all wasm scripts where breakpoints have been set in the Debug object, and clears them all when the debugger gets disabled. R=bmeurer@chromium.org Bug: v8:10403 Change-Id: I5f8a8f3123727c954921920897ee7bf3b73f0ae8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184969 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#67639}
-
Simon Zünd authored
After sorting the work array but before writing the values back into the actual receiver, we have an accessor check. This accessor check needs to be stricter, in order to catch Array prototype protector cell invalidations. R=jgruber@chromium.org Bug: chromium:1077508 Change-Id: I3c3bd4711f9019f9d4423701724319eee9d800a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187171Reviewed-by:
-
Stefano Sanfilippo authored
Rollforward [compiler,api] Pass non-strings to the modifying callback when unconditional codegen is on. Original change reviewed in https://chromium-review.googlesource.com/c/v8/v8/+/1917147. Added an expect fail/pass for the tests that caused a revert in https://chromium-review.googlesource.com/c/chromium/src/+/2184229. This reverts commit dd1b1de1. Bug: chromium:1024786 Change-Id: I7db6faa4c17c232a0fafd389fc4a26e8116852c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183910 Auto-Submit: Stefano Sanfilippo <ssanfilippo@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#67637}
-
Marja Hölttä authored
There's no need for them to be in NativeContext. This CL moves the minimal subset of SFIs related to async iterators. Bug: v8:10482 Change-Id: I80a34a886387398e6565afe77ab99f389d2ccabd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184233Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Anton Bikineev authored
Returned LABs can be of size less than sizeof(FreeListEntry). Bug: chromium:1056170 Change-Id: Ib4094701472ce7cb5ee20b9fe632651570832dc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183051 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#67635}
-
Yang Guo authored
R=szuend@chromium.org Fixed: chromium:1078205 Change-Id: I16f8e19a249692fd16fd53a9a56a8f4cfed8b5c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185134 Auto-Submit: Yang Guo <yangguo@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#67634}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3c7540e..4b54ad3 Rolling v8/third_party/aemu-linux-x64: J3cO22hWB2vC_byojuODbkHgkNGvxvrCAEPaKGOx3GwC..u-v5JkP8oS3BCzku9SpOrrUqZvzXDXE3MqO_M0oKrX4C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c5ffb21..ce41a35 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/4de5413..f7df9c4 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/116e3ee..54f2e0d TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ia694918582c7894c5d0c762c88e59f83751ed4ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2187049Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#67633}
-
- 06 May, 2020 25 commits
-
-
Michael Lippautz authored
Destructors are allowed to allocate without triggering recursive garbage collections. This changes NoGCScope to provide a soft-bailout for garbage collections to avoid introducing yet another scope. Bug: chromium:1056170 Change-Id: I0fe51a21977ae954221b6b64b2f6e938ff6d3264 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185131 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Adds a public method that embedders can use to trigger garbage collections. Such garbage collections are always required to have a source and reason specifying which components calls it why. Change-Id: I6ae983f99227febc1b7f0dd15c191d5b1eaaf3f3 Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2181332Reviewed-by:
-
Gus Caplan authored
RunSingleMicrotask calls Runtime::ReportMessage, but the implementation of ReportMessage would unconditionally discard these exceptions. This CL removes all of the intermediate logic and directly calls MessageHandler::ReportMessage, restoring the ability of RunSingleMicrotask to report exceptions that occur in microtasks. Bug: v8:8326 Change-Id: I493de74383b2ab191d786611fb9eba9d27e7a243 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2162121 Commit-Queue: Gus Caplan <me@gus.host> Reviewed-by:
-
Junliang Yan authored
Bug: v8:7703 Change-Id: If2d5c2da1d653247f49e5dfb2e50850b97119b20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2170798Reviewed-by:
-
Ross McIlroy authored
BUG=chromium:1076569 Change-Id: I178e12e20f48dc4216c3f108352425e0aa91047f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2185130 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#67628}
-
Milad Farazmand authored
This CL introduces VOR and VSRO opcodes which get used for implementing F64x2Splat, I64x2Splat and F32x4Splat. Change-Id: I64b4cd340fbe9ecf6a789a91e3219b6ad83ce3f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184830Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67627}
-
Ng Zhi An authored
See https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. Bug: v8:10488 Change-Id: I3d2503b46172bc2fa310b24f04e944ff211ebf51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182310Reviewed-by:
-
Clemens Backes authored
Avoid templates, just encode all wasm opcodes as 2-byte LEB instead. R=zhin@chromium.org Bug: v8:10258 Change-Id: I3bfd5235b235a5d9366e0007e915a2c02a09b0d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182638Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#67625}
-
Ng Zhi An authored
Bug: v8:10180 Change-Id: Ia7bb052d8f259939f17c7261a5ae3f2475bcf255 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2173945Reviewed-by:
-
Ng Zhi An authored
The location of the immediates depend on the opcode length if a s128.load/store was encoded using multiple bytes. Bug: v8:10258 Change-Id: I09de8a37d442c0711de96ba4bb1746ae6732d83e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182960Reviewed-by:
-
Ng Zhi An authored
See https://chromium.googlesource.com/chromium/src/+/HEAD/styleguide/c++/c++-dos-and-donts.md#prefer-to-use. Bug: v8:10488 Change-Id: Ief62795bbce5f1e531c3f9c245e3c0294d698cbc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183272Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#67622}
-
Bill Budge authored
- Rewrites the following builtins in Torque: WasmThrow WasmRethrow WasmStackGuard WasmStackOverflow WasmTraceMemory WasmAllocateJSArray ThrowWasmTrap* builtins - Changes return type of LoadContext* functions to NativeContext, so we can more easily construct JS objects. Change-Id: Id034358f9f15e0acc58fd1f493b15d1cfd177a23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2174830 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This is a reland of 8c8e6b41 Timeouts seem unrelated. Original change's description: > [offthread] Serialize new-space objects into old space > > If an object made it into serialization, it probably deserves to be in > old space when it is deserialized. This will also make off-thread > deserialization simpler, as there is no off-thread new space. > > Bug: chromium:1075999 > Change-Id: Icabf2f0ae0a3e0205a1094dd0ffe675e69bd1d8e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184291 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67606} TBR=jgruber@chromium.org,ulan@chromium.org Bug: chromium:1075999 Change-Id: Iac4e4eebeca1c343250269cdaad17e23645e9e2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184970Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#67620}
-
Leszek Swirski authored
Bug: v8:10391 Change-Id: I4e86394c53d02eab797c2daad2ccfde6acb83bf0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2151350 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This prevents bug flooding based on differences from calling %GetOptimizationStatus in correctness tests. It is supposed to be suppressed with --allow-natives-for-differential-fuzzing. This ensures early bail-out in case the flag is forgotten at some point. The v8_sanity_checks.js file is executed before each correctness test case for this purpose. NOTRY=true Bug: chromium:1044942 Change-Id: I74a836a82562604b35e94e5e123a2a8bff939423 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184294Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
and avoid runtime calls for struct allocation. We can load the map from the instance and do the allocation in a CSA builtin. Bug: v8:7748 Change-Id: I76dfcb6c28800d69046b3d7381d3b8ba774fbf09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2169099 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Andreas Haas authored
On the PredictablePlatform, worker tasks were executed immediately instead of posting them in a task queue first. This approach caused problems because the execution of the worker task blocked progress of the posting task, and the worker task was always executed in the context of the posting task, e.g. with an already open HandleScope. With this CL, worker tasks get posted into the foreground task queue of the nullptr isolate instead of executing them immediately. The tasks of the nullptr isolate are then executed after a task of some other task queue is executed. As the worker tasks are thereby executed on the same thread as foreground tasks, the behavior is deterministic. A consequence of this approach is that each pumping the message loop of an Isolate may also execute other Isolate's background tasks. This approach is needed because we don't have a BackgroundTaskRunner but merely a CallOnWorkerThread method that doesn't know which Isolate the task corresponds to. R=clemensb@chromium.org, mlippautz@chromium.org Bug: v8:9670 Change-Id: I6847ae042146431bc2376d27280be8829f529b95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182453 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Clemens Backes authored
This reverts commit 8c8e6b41. Reason for revert: Makes Mac64 debug quite flaky: https://ci.chromium.org/p/v8/builders/ci/V8%20Mac64%20-%20debug/28766 Original change's description: > [offthread] Serialize new-space objects into old space > > If an object made it into serialization, it probably deserves to be in > old space when it is deserialized. This will also make off-thread > deserialization simpler, as there is no off-thread new space. > > Bug: chromium:1075999 > Change-Id: Icabf2f0ae0a3e0205a1094dd0ffe675e69bd1d8e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184291 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67606} TBR=ulan@chromium.org,jgruber@chromium.org,leszeks@chromium.org Change-Id: I0baca3c3b7985fcda6b9055f93111ec99c207d29 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1075999 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2183925Reviewed-by:
-
Manos Koukoutos authored
Motivation: There were three versions of type decoding for wasm in the codebase. Not all of them decoded gc types with immediates (reference types) correctly. Changes: - Refactor the wasm binary decoder for unify type decoding. - Update BranchTypeImmediate and SelectTypeImmediate to handle reference types. Reference: https://github.com/WebAssembly/gc R=jkummerow@chromium.org Bug: v8:7748 Change-Id: I33b38c911d366570ca6ef2723ded5205698e1979 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2179003 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Dan Elphick authored
This is a reland of afd9493a LSAN_IGNORE_OBJECTs for FreeListCategories are now removed. Original change's description: > [heap] Remove FreeList when sealing RO_SPACE > > This releases the FreeListCategories for each MemoryChunk when sealing > the ReadOnlySpace and deletes the FreeList. > > Additionally this also calls > ReleaseAllocatedMemoryNeededForWritableChunk for each MemoryChunk when > sealing when pointer compression is enabled even if no memory is to be > shared. > > Bug: v8:10454 > Change-Id: I45aec59f6d4fddedeb713e13095f58974cda279e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184292 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Dan Elphick <delphick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#67598} Bug: v8:10454 Change-Id: I08fcd122437c65c01af526fa8316d5c9e3ebeb3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184297 Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:10484 Change-Id: I977c5974d33472f5af20d7646ad4cf2c58049632 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182452 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#67612}
-
Jakob Gruber authored
These will be used by ic-collecting builtins called from both bytecode handlers and js-generic-lowering. For now only x64 is implemented. Bug: v8:8888 Change-Id: I12a21b40061b7cb6c9b3cbad6134e7457a6cfa44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2184237 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Nico Hartmann authored
When the input to a speculative BigInt operation was an undefined constant, no necessary type check was inserted by the RepresentationChanger. This CL fixes this. Bug: chromium:1077804 Change-Id: I3d4e15b1e018803d56e46c7b23b9d4b03832ba8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182455 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This patch unfies the finalization logic between the various unoptimized compilation paths in compiler.cc, taking the various post-processings and fixups needed for off-thread finalization and performing them in the same order for the other finalizations. It also unifies the general compilation path between streaming script compilation, main-thread script compilation, and main-thread lazy compilation, making the main-thread paths both use an iterative execution and finalization, and making all three use the same job helper methods and overall finalization helper. Bug: chromium:1011762 Change-Id: Ibe56f6d2f75a2deffbe9e0b600ded8a02293b722 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172790 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#67609}
-
Leszek Swirski authored
Move rewriting, scope analysis, and internalization, to be unconditional operations done after parsing rather than a separate compile phase. This removes some of the complexity about rememberering when to call Compiler::Analyze, and makes these paths a bit more uniform. Also, forbid allocating any more AST strings after AstValueFactory internalization, by nulling out the Zone. Add an InternalizePartial method which doesn't null out the zone for those cases where we do want to be able to allocate after internalizing (e.g. internalization before scope analysis). Change-Id: Id444246d8362a1d169baf664fc37657d9576fd96 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182458Reviewed-by:
-
