- 01 Apr, 2019 6 commits
-
-
Benedikt Meurer authored
The CheckNonEmptyString lowering was the wrong way around and would deoptimize if it doesn't see the empty string. This leads to the creation of invalid ConsStrings and also to unnecessary deopt loops with proper code. Bug: chromium:947949, v8:8834, v8:8931, v8:8939, v8:8951 Change-Id: Ib2cc4e92cc9ec7e0284d94f74d14f67f8c878dec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545908Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60542}
-
Sigurd Schneider authored
Change-Id: I0ede9f309b89cfa878a325e3f68327b1682d4ced Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1538123 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:9020 Change-Id: If32de05a48bddf5f746b2a3ea810ee350f6a7dda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541051 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60540}
-
Sigurd Schneider authored
Change-Id: I71a97bf686e9d821b607504c4211b21a4fe8234b Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545906 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60539}
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/1443de9..8059cd6 Update instructions.rst (#995) (Søren Sjørup) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/8059cd6 [interpreter] Check argument types on invoke (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/5ea9d89 [test] Add test when start function traps (#994) (Ben Smith) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/559a10d TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: Id73ec7683a566f5d206426fcfbbc75f726cbe244 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547414Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60538}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/524030d..a72af28 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/adc6ac4..82dbc02 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ie4d1344c408d094000b7a2c4f61ba6bcdbf20085 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547413Reviewed-by:
-
- 31 Mar, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/99a60dd..524030d TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7b483abcaed40e74e54bc950a03c31d12e54e04f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1547125Reviewed-by:
-
- 30 Mar, 2019 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/4406612..1443de9 [interpreter] Fix in JS conversion (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/1443de9 TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I6bd1f78bacb7b805730246fc6e3ce6bbad8ab6ca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1546929Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/c7664bb..c69a8ff Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a525b65..99a60dd Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/eda23ac..459baaf Rolling v8/buildtools/linux64:gn/gn/linux-amd64: https://chrome-infra-packages.appspot.com/gn/gn/linux-amd64/+log/git_rev..git_rev Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/aab7e31..5b63b1f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/803c869..8d3ba46 Rolling v8/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto/+log/40cc341..21a33af TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7c82fed3eac96ae2a5f09de2642b624f681d2878 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545088Reviewed-by:
-
- 29 Mar, 2019 19 commits
-
-
Milad Farazmand authored
Porting: 138d2dfc Original comment: This allows immediates to be encoded directly into instructions, rather than mov-ing constants to registers first. This patch only changes emit_{i64,i32}_add, other emit_ functions will be changed once this approach has been approved. Change-Id: I8442642126555f47a47d511f0ca9d4c00ed82da1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1546050 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60533}
-
Alexei Filippov authored
That saves some bytes on the frontend side and some cycles when generating and parsing protocol JSON for stacks. BUG=chromium:946411 Change-Id: I36b3a48b5d8246a05b877bc21f36c08803a1c304 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1542800 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#60532}
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in src/objects to 'using' declarations. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: Iec455b40e9256ee3aae867a42c0e949a338d417c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545893Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60531}
-
Deepti Gandluri authored
Change-Id: Iad000c91323b9eef799b1e17f25bd3e9d345ab2d Bug: v8:8635 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543850Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#60530}
-
Michael Achenbach authored
TBR=sigurds@chromium.org NOTRY=true Change-Id: I367705e892aea333cee4f8410b866972b7885dfc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545907Reviewed-by:
-
Michael Starzinger authored
This removes a special case for eager initialization of function tables used by asm.js modules. For such modules the table in question can never be exported. It is used to implement asm.js function tables (for details see section 6.3 - ValidateFunctionTable in the asm.js spec). Since such tables are never exported, it should be beneficial to lazily allocate the export entries. R=ahaas@chromium.org Change-Id: I5099d548fe1d2432584d1a09b756c136866d4a0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539578Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60528}
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in compiler code to 'using' declarations. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: I3baf3ecbfe2c853cb17bb479ebbf140382193b5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545896 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:8977 Change-Id: I3eed7db62e4b6fc8f8e51c5aca29c8b78439a400 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545891Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#60526}
-
Michael Starzinger authored
This fixes initialization of reference type global variables (i.e. anyref and except_ref) based on an index of another global. It extends the existing support to exception types, fixes the logic, and also fixes a missing write barrier. R=ahaas@chromium.org TEST=mjsunit/wasm/exceptions-global BUG=v8:8091 Change-Id: Ia91f1ea03be24fadf3023a5acdd073badb8dcd93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1539581 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Bug: v8:9061 Change-Id: Ib8064fc45caa362a63ffd826325c8eabf49e5608 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545898Reviewed-by:
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in heap code to 'using' declarations. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: I8a9f6e1eebdd0adca4373c866e95ebab0a1e992d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545892Reviewed-by:
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in parsing code to 'using' declarations. R=leszeks@chromium.org Bug: v8:8834 Change-Id: I0c95f83ee6897d294bd002b7a4a6277962397e90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545897Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60522}
-
Joey Gouly authored
This is a reland of e3be96d6 The failure was due to not sign extendint the immediate for 64-bit adds on 32-bit platforms. Original change's description: > [liftoff] Introduce emit_{i64,i32}_add with immediate > > This allows immediates to be encoded directly into instructions, rather than > mov-ing constants to registers first. > > This patch only changes emit_{i64,i32}_add, other emit_ functions will be changed once > this approach has been approved. > > Bug: v8:9038 > > Change-Id: I0c7306c2da0dae26f1c6e2465a9565adbf0bda84 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524482 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60506} Bug: v8:9038 Change-Id: I7dd1112827d037d900fd36cce71206388642605b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543730Reviewed-by:
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in ic code to 'using' declarations. R=ishell@chromium.org Bug: v8:8834 Change-Id: I70c74d3f20a6c15693157de5fc40bb769ef0599d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545895 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#60520}
-
Clemens Hammacher authored
Even though both are allowed in the style guide, it recommends to use 'using', as its syntax is more consistent with the rest of C++. This CL turns all typedefs in wasm code to 'using' declarations. R=ahaas@chromium.org Bug: v8:8834 Change-Id: Ibdce88a5cc31e0785cbc1b34088bd39aa3ec84b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545890Reviewed-by:
-
Santiago Aboy Solanes authored
In x64 we can use the macro ASSEMBLE_MOVX. In Arm64, we force the use of registers. B Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng,v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977 Change-Id: I98c6a12d28acca43a38a77dc3ee7af126edb64fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545889 Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
In reducers, we should avoid reductions of the form ReduceWithValue(node, replacement) return Replace(node) because such reduction does not kill the original node, so it may become subject to resurrection from some side table (in the bug referenced below it was load elimination's side table). Instead, we should use ReduceWithValue(node, replacement) return Replace(replacement) Bug: chromium:945644 Change-Id: Id210efe0d214a53241392d30b7f0eee8e7515e2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545229Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/adf96bc..a525b65 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/466efc7..eda23ac Rolling v8/buildtools/linux64:gn/gn/linux-amd64: https://chrome-infra-packages.appspot.com/gn/gn/linux-amd64/+log/git_rev..git_rev Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6d6a48a..aab7e31 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/51c0f38..803c869 Rolling v8/third_party/perfetto: https://android.googlesource.com/platform/external/perfetto/+log/b66b4e0..40cc341 Rolling v8/third_party/protobuf: https://chromium.googlesource.com/external/github.com/google/protobuf/+log/bdeb215..b68a347 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/39afd62..adc6ac4 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ia3bc8391b9cc96488e21bbd5482ac2c983578f99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545091Reviewed-by:
-
Frank Tang authored
For intl_datetime_style DesignDoc: https://goo.gl/v7n7zV Test: test/intl/date-format/constructor-date-time-style.js test/intl/date-format/constructor-date-time-style-order.js test/intl/date-format/property-override-date-time-style.js test/intl/date-format/constructor-date-style-order.js test/intl/date-format/property-override-date-style.js test/intl/date-format/constructor-time-style-order.js test/intl/date-format/property-override-time-style.js For intl_bigint Test: test/intl/bigint/tolocalestring.js https://www.chromestatus.com/feature/5742274625404928 chromium src/v8/test/intl/date-format/constructor-no-style-order.js Bug: v8:8699,v8:8702 Change-Id: Ide331e3571d5f6c230fe29b24bf6cced351cba49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541449Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#60515}
-
- 28 Mar, 2019 12 commits
-
-
Maciej Goszczycki authored
Change-Id: I6c1a2edcee54993cd73e211de8271ea6b6c42ad7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543732 Auto-Submit: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Cr-Commit-Position: refs/heads/master@{#60514}
-
Simon Zünd authored
This reverts commit 3bd49f9b. Reason for revert: Build failure on Win Bot Original change's description: > [torque] Throw exception instead of aborting if something goes wrong > > This CL enables exceptions for the Torque compiler and Torque language > server. Instead of aborting when something goes wrong during > compilation, a TorqueError is thrown, containing the error message > and a source position. The compiler executable still prints the error > and aborts, while the language server will pass this information > along to the client (not included in this CL). > > R=danno@chromium.org > > Bug: v8:8880 > Change-Id: Iad83c46fb6a91c1babbc0ae7dbd94fbe4e7f1663 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526003 > Reviewed-by: Daniel Clifford <danno@chromium.org> > Commit-Queue: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60512} TBR=danno@chromium.org,mvstanton@chromium.org,szuend@chromium.org Change-Id: Iac253da404eaf6e534267f59a42ca93667c205e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8880 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543849Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60513}
-
Simon Zünd authored
This CL enables exceptions for the Torque compiler and Torque language server. Instead of aborting when something goes wrong during compilation, a TorqueError is thrown, containing the error message and a source position. The compiler executable still prints the error and aborts, while the language server will pass this information along to the client (not included in this CL). R=danno@chromium.org Bug: v8:8880 Change-Id: Iad83c46fb6a91c1babbc0ae7dbd94fbe4e7f1663 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526003Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#60512}
-
Andreas Haas authored
R=clemensh@chromium.org Change-Id: I3bcac024578eeb556a5422d10c86843be17f5782 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543355Reviewed-by:
-
Sven Sauleau authored
This CL splits a specific test out the bigint.js test suite in order to be, eventually, ignored by the wasm-bigint proposal 32-bit support CL. Change-Id: I8ab673abfb53bac95952b11716fe4f29a4a7feaa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543352 Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Reviewed-by:
-
Clemens Hammacher authored
Instead of reporting kB/s as documented, we were computing bytes/us, i.e. MB/s, hence mostly reporting 0. This CL fixes this and renames the variables to make the units more obvious. R=titzer@chromium.org Bug: v8:8975 Change-Id: I0177a8631cc600ab1369657318944f9a215486ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543351Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60509}
-
Clemens Hammacher authored
This reverts commit e3be96d6. Reason for revert: Fails on ia32: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux/31041 Original change's description: > [liftoff] Introduce emit_{i64,i32}_add with immediate > > This allows immediates to be encoded directly into instructions, rather than > mov-ing constants to registers first. > > This patch only changes emit_{i64,i32}_add, other emit_ functions will be changed once > this approach has been approved. > > Bug: v8:9038 > > Change-Id: I0c7306c2da0dae26f1c6e2465a9565adbf0bda84 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524482 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60506} TBR=clemensh@chromium.org,martyn.capewell@arm.com,joey.gouly@arm.com Change-Id: I131b13dc7178e31919fc2fffacec72c0697d93a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9038 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543354Reviewed-by:
-
Pierre Langlois authored
This is a reland of 93716b9e Original change's description: > [snapshot] Add support for native counters. > > Counters in generated code, as enabled with --native-code-counters, do not work > in the snapshot. This adds a `v8_enable_snapshot_code_counters` build option > enabled by defaut in debug mode that allows code from the snapshot to increment > the current isolate's set of counters. > > For this to work, we need to add native code counters in the external reference > table. > > To keep the no snapshot configuration similar, we've also enabled the > --native-code-counters flag by default for debug builds. > > Change-Id: I4478b79858c9b04f57e06e7ec67449e9e3a76f53 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528998 > Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60495} Change-Id: Ib6427caf068ca196a032e3f3b97d9f9219e0fe60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1543349Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Joey Gouly authored
This allows immediates to be encoded directly into instructions, rather than mov-ing constants to registers first. This patch only changes emit_{i64,i32}_add, other emit_ functions will be changed once this approach has been approved. Bug: v8:9038 Change-Id: I0c7306c2da0dae26f1c6e2465a9565adbf0bda84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524482 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
When switching from atomicops to std::atomic, I introduced a bug that makes us miss the actual peak memory consumption, and only report the second-highest memory usage in each zone. This CL fixes that. R=petermarshall@chromium.org Bug: chromium:939724 Change-Id: I3db8eeb9719eb026cf6b4a9690c702cbc4c11bd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1541227Reviewed-by:
-
Dan Elphick authored
Previously when lazy source positions were enabled, source positions were immediately collected whenever an exception was thrown for every frame in the stack trace. This change makes source position collection trigger only when the source positions of a stack frame are actually accessed with the exception of the top frame which is still eagerly collected for now. Additionally when stack overflows occur during source position collection, the bytecode is marked with exception in the source_position_table field so it can be distinguished from the case where source position collection has never been attempted (undefined) or is not desired because the bytecode is for natives (empty_byte_array). Bug: v8:8510 Change-Id: If7ee68edbacc9e2adadf00fe5ec822a8dbe1c79a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1520721Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Mythri A authored
test/mjsunit/elements-kind.js calls %NeverOptimizeFunction followed by %OptimizeFunctionOnNextCall later. If NeverOptimize marker is set, the funciton would not be optimized even when requested through %OptimizeFunctionOnNextCall Change-Id: I37307fee7afd083953699026a82bbf12c85581ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533865 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#60503}
-
