- 07 Jun, 2021 29 commits
-
-
Marja Hölttä authored
This fix makes ObjectLiteral::CalculateEmitStore work correctly. Bug: v8:11810 Change-Id: I60f3d5cb657f4b2ca574d5224c8f1cb7a8216354 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2917040Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74986}
-
Camillo Bruni authored
Use new Script.prototype.update method to set the url and the script source. Bug: v8:11850 Change-Id: I555d4d0158cdacb7cb42efa385371454542fc2f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944438Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#74985}
-
Santiago Aboy Solanes authored
We have recursive calls such ThinStrings where we go String::Get into ThinString::Get into String::Get again for the internalized string. If we need to, we would acquire the StringAccessGuard in the first String::Get and it wouldn't be needed to be re-acquired for the second String::Get. Trying to re-acquire it would in fact be an error since we are already holding the lock. The code, however, didn't know if we acquired it or not. It was working correctly due to the way the methods were defined and called. By passing down the access guard through the Get() calls we make this interaction explicit. Also add some thin string tests to test the interaction. Bug: v8:7790 Change-Id: I1181edec1e802cb754c4d1d1ac268577257b92f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2936598 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#74984}
-
Lu Yahan authored
Change-Id: Ia1dfb428e5518343252300bf4323f24a20bb7f2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939539 Commit-Queue: Brice Dobry <brice.dobry@futurewei.com> Reviewed-by: Brice Dobry <brice.dobry@futurewei.com> Cr-Commit-Position: refs/heads/master@{#74983}
-
Andreas Haas authored
A spec test (wasm-js/global/value-get-set) requires WebAssembly.Global.value.set to throw an exception if it is called with 0 arguments. The implementation in V8, however, just checked if the first parameter is `undefined`. This implementation indeed threw an exception if 0 arguments were provided, but it also threw an exception when `undefined` is provided as a parameter. This, however, violates the spec, because globals can be reset to `undefined`. With this CL we replace the checking for `undefined` by checking the length of the arguments that get provided. R=ecmziegler@chromium.org Bug: chromium:1211342 Change-Id: Ic87a0b369dea3e49eddb8f71f2c29dc6a8f5f558 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940901Reviewed-by: Emanuel Ziegler <ecmziegler@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74982}
-
Jakob Kummerow authored
instead of recursive. JS code can construct very long chains of nested bound functions or proxies, where the previous recursive implementation could run out of stack space. Fixed: chromium:1214616 Change-Id: I764718f03030d22c0873b3ed05277d4317789093 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933668 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#74981}
-
Clemens Backes authored
When growing a memory without a maximum, we should still check against the spec'ed limit, to avoid an overflow when computing the new number of pages. R=ahaas@chromium.org Bug: chromium:1215808 Change-Id: I476b954268277e7dce1106a9b8c3c713b0d1a560 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944433Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74980}
-
Dominik Inführ authored
While no scavenger thread reads the content of an object copied by another thread, we still need memory ordering in order to read the page flags for a forwarded object. Change-Id: I831e9dccb03d32daf3c4847613614d26533ba825 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944436Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74979}
-
Michael Achenbach authored
This reverts commit 6596e8c6. Reason for revert: Main bug was fixed. Original change's description: > [infra] Switch back to Xenial on some bots > > This tests the hypothesis that the current timeout problems are on > Bionic bots only. > > Bug: v8:11818 > Change-Id: I68f84cda52ca392fbda5a400eb2bf136b7ee85a3 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2916816 > Auto-Submit: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74747} Bug: v8:11818 Change-Id: Ib5f952dc6f23f3a98bb1d79ae5ce689e288d6727 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940897 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#74978}
-
Jakob Gruber authored
.. and replace them by elements read directly from the heap object. With this change, consistency between `map` and `elements` is no longer guaranteed. Users were updated, when necessary, to deal with this, e.g. by being more careful not to read out of bounds, by inserting new `actual_elements == elements_constant` runtime checks, or through a new compilation dependency that verifies unchanged elements at finalization time. Drive-by: inline GetElementsKind into callsites. Bug: v8:7790 Change-Id: Ifba78182e185ff0d4e954e3be52f0eb24328c853 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2909655Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#74977}
-
Jakob Kummerow authored
Change-Id: I244a28e29f14b05a50c8bb10db429b16b2052aca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944432Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74976}
-
Clemens Backes authored
We currently take the sample at the moment the isolate is created. At that point, the embedder callback for taking samples is not installed yet. Hence delay taking the sample until the first module is created. This will only take samples for isolates that actually use wasm, which will reduce the overall number of samples, but will give a better picture of PKU support for Wasm. R=jkummerow@chromium.org CC=dlehmann@google.com Bug: v8:11714 Change-Id: I8a4163961c06076efd6c5dde5751682b53863c2c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944429Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74975}
-
Clemens Backes authored
This reverts commit 79d63a5e. Reason for revert: Breaks predictable: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20predictable/36887/overview Original change's description: > [wasm] Remove all implications from --predictable > > In predictable mode, we want to execute the same code as otherwise, > modulo timing. Hence remove any implications which change behaviour > (like tier-up or asynchronous compilation). > Note that --predictable is a debugging flag, so the configurations does > not need to "make sense" in production. > > R=ahaas@chromium.org > > Bug: v8:11848 > Change-Id: If74fbacadeb087d977922c41f33fd18738b50ded > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940898 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74973} Bug: v8:11848 Change-Id: I20eaf665e8ce63af8aeffe3bac7a45372ad6ab7b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2944434 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74974}
-
Clemens Backes authored
In predictable mode, we want to execute the same code as otherwise, modulo timing. Hence remove any implications which change behaviour (like tier-up or asynchronous compilation). Note that --predictable is a debugging flag, so the configurations does not need to "make sense" in production. R=ahaas@chromium.org Bug: v8:11848 Change-Id: If74fbacadeb087d977922c41f33fd18738b50ded Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940898 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74973}
-
Manos Koukoutos authored
Change-Id: Id502aa02a778d17c32996b0438ac3a7c85166430 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940892Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74972}
-
Santiago Aboy Solanes authored
Introduce EmitTSANStoreOOLIfNeeded methods which make it easier on the eyes in code-generator.cc. Also pass along the size, which lays the groundwork for the other instructions e.g. kX64Movq since we don't require the store to be a Tagged one. This creates new builtins (since we now have a version with 32 bits and another one for 64 bits stores). We can extract the common code in builtins-internal-gen.cc to de-duplicate the common code. Bug: v8:7790, v8:11600 Change-Id: I81d80b852ec96b94d170a20f6d61621743b74b32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933664Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#74971}
-
Clemens Backes authored
This is a reland of 5fd38582. It adds back all recursive implications (via --single-threaded), such that we can remove them individually in follow-up CLs and watch the state of the predictable bot. Original change's description: > [flags] Predictable should not imply single-threaded > > The --predictable flag is often used to reproduce issues, and having it > imply --single-threaded can change decisions like which compiler(s) to > use. This is because --single-threaded is meant to be set by embedders > (hence we do our best to support single-threaded execution), whereas > --predictable is a testing-only flag which should not change semantics > too much. The fact that --predictable executes everything in a single > thread is already implied by the PredictablePlatform. > > R=ahaas@chromium.org, machenbach@chromium.org > CC=jkummerow@chromium.org > > Change-Id: Ic174dd59dfdbd6aa1a410f983db05db26c944cd5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919828 > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74822} Change-Id: I7a060826761781727870dd96fffc42ced4675e76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933143 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74970}
-
Jakob Kummerow authored
This is a reland of 81dd3f42, which was a reland of 59eff3bf Original change's description: > [bigint] Karatsuba multiplication > > The Karatsuba algorithm is used for BigInts with 34 or more internal > digits, and thanks to better asymptotic complexity provides greater > speedups the bigger the inputs. > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2782283 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74916} Bug: v8:11515 Change-Id: I08f7d59dfa39fb3b532684685afd9fa750e0e84e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933666Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74969}
-
Marja Hölttä authored
Bug: v8:11525 Change-Id: I0ac9f252e0de16480036e3630edf7efefe8d8571 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928501Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#74968}
-
Mathias Bynens authored
Bug: chromium:1213927 Change-Id: I85f5559863524717355ec61694ce007a2be7c8a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931799Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#74967}
-
Clemens Backes authored
Since there is only a single thread in predictable mode, we should never wait for more work. That would be an immediate deadlock. This CL adds code to never wait, and instead checks after processing all messages that we would not need to wait (i.e. that all work was completed). This turns deadlocks into FATAL errors. R=ahaas@chromium.org Bug: v8:11848 Change-Id: If61305d634803fc43678238dc6e9d3a2f35793c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940886Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74966}
-
Jakob Kummerow authored
Strict equality checking of ValueTypes only made sense before reference types came along. Change-Id: I632f541328cb27ae87a5e3daccd4ffb9cfc8a502 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928513 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#74965}
-
Andreas Haas authored
Bug: chromium:1213097 Change-Id: If768725a5645b7d21f59845692ca5491e8674bfa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940896Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74964}
-
Dominik Inführ authored
Prepare method by taking an object as argument. In the future we can optimize this method by only sweeping the object's page. Bug: v8:11837 Change-Id: Ife1ee7949bfaf590dcc305cc4d03aa1813c07b76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940888Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74963}
-
Clemens Backes authored
This fixes a little mistake from https://crrev.com/c/2182453. In predictable mode (where we do not have any threads for executing background work) we are executing everything on the main thread, but we should never wait for background work to be spawned. Otherwise we can deadlock if the last background task spawned new foreground work, but we keep waiting for more background work to arrive. Generally, any blocking in predictable mode will block forever, because there is no one to spawn any work concurrently (foreground or background). But the blocking for foreground work has to be there for non-predictable mode, thus keep it for now, and only remove waiting for background work. R=ahaas@chromium.org Bug: v8:11848 Change-Id: I51c976f6858db8120baa4c47d28840a1041d7fea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940885Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74962}
-
Michael Achenbach authored
This reverts commit d1e1f1be. Reason for revert: Main bug was fixed. Original change's description: > [infra] Switch back to Xenial on a slow variant > > This is to mitigate flaky timeouts due to memory problems on some > Bionic bots. > > Bug: v8:11818 > Change-Id: I4758f0f167b94d81f43e183a5599a39d8545b4e1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2922245 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Auto-Submit: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74824} Bug: v8:11818 Change-Id: I9719cbcd074de44cd5fb981c40f46bf4e10adee0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2940895 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#74961}
-
Michael Lippautz authored
This aids debugging as it gives the root set a name. Bug: chromium:1164553, chromium:1186901 Change-Id: I2c2aed369823b059629b35bb170b4966b47156d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2933661 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74960}
-
Paolo Severini authored
The tests are not compatible with the --stress-background-compile flag. Bug: v8:11821 Change-Id: Iecef6a2838109fddc9f0ecc145a9f8971bc9bc3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2918214Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Paolo Severini <paolosev@microsoft.com> Cr-Commit-Position: refs/heads/master@{#74959}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/092e09c..8bf7a0b TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Ib98bf84acfa7c1c13305dcf2dfcb9a32bf1a66a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2942625Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74958}
-
- 06 Jun, 2021 2 commits
-
-
Dominik Inführ authored
This is a reland of b0c70710 The first CL got reverted because of build errors. This CL replaces the remaining usage of is_local_space() with is_compaction_space(). Supposedly this was a leftover because https://crrev.com/c/2928189 landed at roughly the same time. Original change's description: > [heap] Remove unused LocalSpace class > > LocalSpace was introduced for off-heap spaces with concurrent bytecode > compilation finalization. However, finalization ended up using > LocalHeap for concurrent allocations. LocalSpace is therefore unused > and can be removed. > > This CL removes LocalSpace and renames all mentions of local space to > compaction space. Compaction space was the only local space left. > > Change-Id: I12a8a2724f777a77ddb9957fe2d8e89febfebbaf > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2930169 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#74914} Change-Id: I993c47fe85f4140f5d6137afde2653a48047cafb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939983Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#74957}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/74cfeda..e353b02 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I2488e4e16cf75067122d61652303d6fad2b5cd25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2942922Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74956}
-
- 05 Jun, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/1da98aa..74cfeda Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/712eb08..092e09c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9705687..a5b6b2f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/af7a363..30cbc5c Rolling v8/tools/luci-go: git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0..git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418 Rolling v8/tools/luci-go: git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0..git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418 Rolling v8/tools/luci-go: git_revision:c9957ed0ce0fd363aac127056344eba1b873bad0..git_revision:2cc9805d5ad186367461ef1c4f0c59098b450418 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I202053812c034c82bfd70aa9821685eb981d6335 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939053Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#74955}
-
- 04 Jun, 2021 8 commits
-
-
Milad Fa authored
ReadLittleEndianValue needs to be used to make sure value is returned correctly on BE machines. Change-Id: I02a64cded4f5dcccd39f1109c4179bebf9231a70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2941038Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74954}
-
Manos Koukoutos authored
Replacing existing values leads to type errors and printing wrong pcs in errors. Change-Id: I513eae0a7e0cb5764d307eb172a378d328ca3660 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2936596Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74953}
-
Daan de Graaf authored
The two instructions are fused into a single Sadalp instruction, improving performance of quantized neural network operator implementations such as XNNPACK. This change also includes some formatting changes to the unit tests that were made automatically by clang-format, which I am happy to revert if preferred. Bug: v8:11546 Change-Id: I2afc8940a52186617cffd276c82733ad3020b728 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2878742 Commit-Queue: Daan de Graaf <daagra@google.com> Reviewed-by: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#74952}
-
Milad Fa authored
ReadLittleEndianValue needs to be used to assure ptrs are dereferenced correctly on BE machines. Change-Id: I420f863de1b98d5d68688614ead4847258779c9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2941022Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74951}
-
Lu Yahan authored
Change-Id: Icfef3e722d8d01f023677090dca6b899c51a46e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931580Reviewed-by: Brice Dobry <brice.dobry@futurewei.com> Commit-Queue: Brice Dobry <brice.dobry@futurewei.com> Cr-Commit-Position: refs/heads/master@{#74950}
-
Manos Koukoutos authored
So far, initializer-expression evaluation was tied to setting global values. We now need it to operate independently of globals, so that we can implement new constant expressions like struct.new, which need their arguments to be computed before they can be initialized. Changes: - Move type computation of WasmInitExpr into WasmInitExpr::type. - Fix WasmInitExpr::type kRttSub case for rtts without depth. - Introduce InstanceBuilder::EvaluateInitExpression(). - Rename InstanceBuilder::GetRawGlobalPointer() -> GetRawUntaggedGlobalPointer(). - Simplify InstanceBuilder::InitGlobals using EvaluateInitExpression(). - Introduce ValueType::is_numeric. - Add Simd128(byte*) constructor. - Introduce WasmValue::CopyTo() for numeric types. Change-Id: Ic502b611f3998187abd9fc6ec377c2954c27abdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939982 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#74949}
-
Manos Koukoutos authored
Changes: - Merge all immediates which read a u32_v index into IndexImmediate. Refactor overloaded Validate(const byte*, [Type]Immediate) functions to Validate[Type](const byte*, IndexImmediate). - Move MemoryIndexImmediate/MemoryAccessImmediate validation into their own Validate functions. Remove CheckHasMemory(), move its functionality into these Validate() functions. - Refactor MemoryInitImmediate, TableInitImmediate and CallIndirectImmediate as composite immediates. - Change field initializations for some Immediates to constructor initializers. This helps us drop some useless default constructors. - Use the correct pc in StackEffect for struct.new_default. Bug: v8:11831 Change-Id: I878f69a33f8473dc275184995b3b7b88fe0dfc8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2928498Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/master@{#74948}
-
Andreas Haas authored
R=thibaudm@chromium.org Change-Id: I6fcd78ffb2683ed92e056d67ec4ef792c0d2ec0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2939986Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#74947}
-