- 15 Nov, 2018 37 commits
-
-
Predrag Rudic authored
On MIPS and MIPS64 build began to fail after this commit: 01079cb8. Change-Id: Ib967fc0d17ce1d10fdfa97d541ce9e761508593f Reviewed-on: https://chromium-review.googlesource.com/c/1337741Reviewed-by: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#57554}
-
Mathias Bynens authored
Bug: v8:7834 Change-Id: I1986c55cb884acfce11f779a23d303cd126c43d7 Reviewed-on: https://chromium-review.googlesource.com/c/1336471Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#57553}
-
Clemens Hammacher authored
With just five cache registers, Liftoff can run out of memory on a 64bit shift. This CL solves this by using a parallel register move and pinning less registers. R=ahaas@chromium.org Bug: chromium:894307 Change-Id: I91ed0fee00ceb452841e5d1bb10905be6702dcce Reviewed-on: https://chromium-review.googlesource.com/c/1337580 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#57552}
-
Hannes Payer authored
Change-Id: Ic9be35646beb47d0074154aa2e38dc9527911b01 Reviewed-on: https://chromium-review.googlesource.com/c/1327046 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#57551}
-
Andreas Haas authored
In WasmCode::LogCode we allocate handles, but not all callers of LogCode open a HandleScope. Since the handles do not escape LogCode, we can just open a Handlescope in the function. R=herhut@chromium.org Bug: v8:8461 Change-Id: I2031b467f976a9af6f541b60af245573f33d9676 Reviewed-on: https://chromium-review.googlesource.com/c/1337736Reviewed-by: Stephan Herhut <herhut@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#57550}
-
Predrag Rudic authored
Emit Dlsa/Lsa only on revision 6 or when MSA is supported. Since we support MSA only on r6, it is the only thing that is checked. Added check if shift of Dlsa/Lsa is in range 0<shift<=31 Change-Id: Ic3902fcccc1a2e3ecc5f550ea3b7980bd2bb4c27 Reviewed-on: https://chromium-review.googlesource.com/c/1337581Reviewed-by: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#57549}
-
Jakob Gruber authored
V8 supports a mechanism to generate better profiling information for ticks in bytecode execution. Usually, these would find the IET but would not know which JS function is currently being executed. With --interpreted_frames_native_stack, we create a dedicated copy of the IET for each JS function, which the profiler can use the infer the current function. This mechanism doesn't work when IET is embedded. But JIT-less V8 will require all builtins to be embedded. This CL implements a workaround that should keep all configuration happy: We keep a full copy of IET on the root list for sole purpose of using it as a template to create copies for profiling later on. The 'real' IET builtin itself can be embedded in a follow-up CL. Change-Id: Iaf1629708f0e41c3683979245019fbd3e3153c97 Reviewed-on: https://chromium-review.googlesource.com/c/1335700 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#57548}
-
Peter Marshall authored
This test is only flaky because the js code being profiled causes a 'fast-c-call' which is a call from JS to C without an exit frame. The profiler stumbles on these and reads the stack of C++ frames when it shouldn't, causing ASAN errors. This is not actually related to the multiple isolates, so I'm changing the test to profile different JS code that does not cause these types of calls. There is already a test for fast-c-calls - NativeFrameStackTrace (which currently fails). Bug: v8:8464 Change-Id: I32818f0894e5680cf5a39779a2779eda36dfe9f1 Reviewed-on: https://chromium-review.googlesource.com/c/1337571 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57547}
-
Jakob Gruber authored
This is a reland of 0b13f0f5 Original change's description: > [snapshot] Emit the embedded blob as assembly instead of inline assembly > > The motivation behind this is that MSVC doesn't support inline assembly > on x64. Emitting the embedded blob as a plain assembly file will give us > MSVC support (and possibly faster compilation times as a side-effect). > > Bug: v8:6666,v8:8349 > Change-Id: I2e6cf072faa9ef406fe721a05b63912c655546c2 > Reviewed-on: https://chromium-review.googlesource.com/c/1329205 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57524} Tbr: yangguo@chromium.org,mvstanton@chromium.org Bug: v8:6666, v8:8349 Change-Id: Ib35696b60a9cd01bc2edf459c8e8d84716e3438d Reviewed-on: https://chromium-review.googlesource.com/c/1337733Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57546}
-
Mike Stanton authored
R=mstarzinger@chromium.org Change-Id: Ifc6411f4825b5056ab35f9b7d0a604bed4004110 Reviewed-on: https://chromium-review.googlesource.com/c/1337732Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#57545}
-
Toon Verwaest authored
Now that we always cache lookups through scope-info-backed scopes on the entry-point scope-info-backed scope, we don't need additional caching per scope-info. The one missing piece was negative lookups, but they automatically turn into DynamicGlobals which we also cache on the entry scope. The one possible difference is that we don't cache across compilation, but seems unlikely to be very beneficial. We'll keep an eye out for regressions though. Change-Id: I23186d2b085d2042fafa32fb3cca88f88c61074c Reviewed-on: https://chromium-review.googlesource.com/c/1337731 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#57544}
-
Ross McIlroy authored
With BytecodeArray flushing the SFI->BytecodeArray pointer will become pseudo weak. In order to avoid having to recompile (and potentially stack-overflow) on deoptimization, we explicitly add strong references to any BytecodeArray's we might deopt into into the DeoptimizationData, as such the BytecodeArrays won't be flushed while there is optimized code referencing it. BUG=v8:8395 Change-Id: If3336dfa9c17b7bccafdb73752c58dfa1f14a371 Reviewed-on: https://chromium-review.googlesource.com/c/1314579 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#57543}
-
Toon Verwaest authored
We'll always lookup variables in the entry scope-info-backed chain through a single entrypoint, hence we can cache any variables we create in that chain on the entry-point's VariableMap. Otherwise we always have to redo all negative lookups until we hit the scope that introduces it (the script scope being the final possible scope to introduce it). This should allow us to get rid of the ContextSlotCache as well. Change-Id: I2dc2c9c35d69f35dab3fe3d0353aba1ac68515a5 Reviewed-on: https://chromium-review.googlesource.com/c/1337729Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57542}
-
Georg Neis authored
This might have enabled our fuzzing to find the recent bug. R=bmeurer@chromium.org Bug: v8:8449 Change-Id: Iaa485061e132a9d20b995478dd9a642e2224f435 Reviewed-on: https://chromium-review.googlesource.com/c/1337588Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#57541}
-
Jakob Gruber authored
This is a reland of bf2f0a02 Original change's description: > [builtins] Support embedded builtins in nosnapshot builds > > This CL adds support for embedded builtins in nosnap builds by creating > and setting an 'embedded blob' after builtin generation. Unlike > snapshot builds, the blob is not embedded into the .text section but > located on the C++ heap. > > This makes nosnap builds more consistent with mksnapshot, and allows us > to simplify there and in serializer cctests. > > Complications arise from the different workflows we need to support: > > 1. the standard mksnapshot build process, > 2. nosnap builds (which reuse the blob created by the first Isolate), > 2. and tests with various complicated serialization workflows. > > To cover all of these cases, this CL introduces two knobs to twiddle: > > 1. A 'sticky' embedded blob which overrides compiled-in default > embedded blobs at Isolate setup. > 2. The blob lifecycle can be managed manually or through refcounting. > > These are described in more detail in isolate.cc. > > Tbr: ulan@chromium.org > Bug: v8:6666, v8:8350 > Change-Id: I3842e40cdaf45d2cadd05c6eb1ec2f5e3d83568d > Reviewed-on: https://chromium-review.googlesource.com/c/1310195 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57523} Tbr: ulan@chromium.org,yangguo@chromium.org Bug: v8:6666, v8:8350 Change-Id: I13b523c9e7406b39a3cd28465c06f17f1744a738 Reviewed-on: https://chromium-review.googlesource.com/c/1337578 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57540}
-
Toon Verwaest authored
Change-Id: Iee70b82742aa6399b211a5d3efe06b93c0508a7d Reviewed-on: https://chromium-review.googlesource.com/c/1337587Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57539}
-
Clemens Hammacher authored
We often need to create a {Vector} view of data owned by a container like {std::vector}. The canonical way to do this is this: Vector<T>{vec.data(), vec.size()} This pattern is repeating information which can be deduced automatically, like the type T. This CL introduces a {VectorOf} helper which can construct a {Vector} for any container providing a {data()} and {size()} accessor, and uses it to replace the pattern above. R=ishell@chromium.org Bug: v8:8238 Change-Id: Ib3a11662acc82cb83f2b4afd07ba88e579d71dba Reviewed-on: https://chromium-review.googlesource.com/c/1337584Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57538}
-
Toon Verwaest authored
Change-Id: Id81b028629d552e2f3ebbab8bc3ab1f0e9cff3fb Reviewed-on: https://chromium-review.googlesource.com/c/1337572Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57537}
-
Ross McIlroy authored
With Bytecode flushing, the a SharedFunctionInfo's bytecode might be flushed while the compiler is expecting it to still exist. Rather than continually getting the bytecode from the SFI, instead bottleneck the points where we get BytecodeArray from SFIs and maintain an explicit strong reference to the BytecodeArray from that point onwards to prevent flushing. BUG=v8:8395 Change-Id: I6a18adec99402838690971eb37ee0617cdc15920 Reviewed-on: https://chromium-review.googlesource.com/c/1309763 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#57536}
-
Benedikt Meurer authored
When one of the inputs to NumberMin or NumberMax is NaN we need to return NaN, ignoring whatever else was passed. Specifically we cannot lower `NumberMin(x,y)` to `(x < y) ? x : y` if `x` can be NaN. So limit this optimization to only perform the above lowering if we know that `x` is an OrderedNumber and `y` is a PlainNumber (or if the difference between zeros doesn't matter, an OrderedNumber as well). Bug: chromium:905457 Change-Id: If05f19255e14789ab0e277e072469c40e161b85b Reviewed-on: https://chromium-review.googlesource.com/c/1337576Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57535}
-
Michael Achenbach authored
The archive builder is broken since https://crrev.com/c/1330912, see: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Official%20Win64/3279 We don't need the windows cctest on the ref builds, hence this removes it. TBR=sergiyb@chromium.org Change-Id: Ic8d40bcc45b2f29884cc3fe9a2802e2b86f099a2 Reviewed-on: https://chromium-review.googlesource.com/c/1337583Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57534}
-
Jakob Gruber authored
This adds flags for the upcoming JIT-less V8. Build-time: v8_enable_jitless_mode in gn.args Runtime: --jitless command-line flag The build-time flag is expected to be removed as the implementation matures. Bug: v8:7777 Change-Id: Ieea404a14c7859a66e18175d1740d73182db9b1b Reviewed-on: https://chromium-review.googlesource.com/c/1335559 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#57533}
-
Jaroslav Sevcik authored
This fixes several problems with instanceof and constant field tracking in the compiler: - properly bailout on numbers and non-functions at @@hasInstance. - deopt on changes of @@hasInstance property. Bug: v8:8361 Change-Id: I4a1cf9e29d72076f2d37a7c703f18cb2fb8f4040 Reviewed-on: https://chromium-review.googlesource.com/c/1322449 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#57532}
-
Daniel Clifford authored
Change-Id: I0652a75f6d1f6abfb40ba9bf35afeadfd4533336 Reviewed-on: https://chromium-review.googlesource.com/c/1328801 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57531}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I57183c306a4b0b38822ae3136a8c49ab94992010 Reviewed-on: https://chromium-review.googlesource.com/c/1337575Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57530}
-
Jakob Gruber authored
This reverts commit bf2f0a02. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/21753 Original change's description: > [builtins] Support embedded builtins in nosnapshot builds > > This CL adds support for embedded builtins in nosnap builds by creating > and setting an 'embedded blob' after builtin generation. Unlike > snapshot builds, the blob is not embedded into the .text section but > located on the C++ heap. > > This makes nosnap builds more consistent with mksnapshot, and allows us > to simplify there and in serializer cctests. > > Complications arise from the different workflows we need to support: > > 1. the standard mksnapshot build process, > 2. nosnap builds (which reuse the blob created by the first Isolate), > 2. and tests with various complicated serialization workflows. > > To cover all of these cases, this CL introduces two knobs to twiddle: > > 1. A 'sticky' embedded blob which overrides compiled-in default > embedded blobs at Isolate setup. > 2. The blob lifecycle can be managed manually or through refcounting. > > These are described in more detail in isolate.cc. > > Tbr: ulan@chromium.org > Bug: v8:6666, v8:8350 > Change-Id: I3842e40cdaf45d2cadd05c6eb1ec2f5e3d83568d > Reviewed-on: https://chromium-review.googlesource.com/c/1310195 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57523} TBR=ulan@chromium.org,yangguo@chromium.org,jgruber@chromium.org Change-Id: I6e35a0cb7186fb50f1012f5c618fb8b48b24a813 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666, v8:8350 Reviewed-on: https://chromium-review.googlesource.com/c/1337577Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57529}
-
Jakob Gruber authored
This reverts commit 0b13f0f5. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32%20-%20debug/17373 Original change's description: > [snapshot] Emit the embedded blob as assembly instead of inline assembly > > The motivation behind this is that MSVC doesn't support inline assembly > on x64. Emitting the embedded blob as a plain assembly file will give us > MSVC support (and possibly faster compilation times as a side-effect). > > Bug: v8:6666,v8:8349 > Change-Id: I2e6cf072faa9ef406fe721a05b63912c655546c2 > Reviewed-on: https://chromium-review.googlesource.com/c/1329205 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57524} TBR=yangguo@chromium.org,mvstanton@chromium.org,jgruber@chromium.org Change-Id: I35f7763f86b4de01e74827a95706b969b43af55e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6666, v8:8349 Reviewed-on: https://chromium-review.googlesource.com/c/1337574Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57528}
-
Michael Starzinger authored
This avoids creating an on-heap copy for interpreter entry wrappers by directly adding the {WasmCode} into the native heap instead. It reduces compilation time as well as useless GC pressure. R=clemensh@chromium.org BUG=v8:8423 Change-Id: I91a8f3fc9fe542233d8700a58585f4715eed695a Reviewed-on: https://chromium-review.googlesource.com/c/1337570Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57527}
-
Jakob Gruber authored
Change-Id: Ia30702060cdcd63a3b429e05e700928a32824604 Reviewed-on: https://chromium-review.googlesource.com/c/1328944Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57526}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I2ec2fdb2406efeaf3b48d0c58711db7e5172aa58 Reviewed-on: https://chromium-review.googlesource.com/c/1335699 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57525}
-
Jakob Gruber authored
The motivation behind this is that MSVC doesn't support inline assembly on x64. Emitting the embedded blob as a plain assembly file will give us MSVC support (and possibly faster compilation times as a side-effect). Bug: v8:6666,v8:8349 Change-Id: I2e6cf072faa9ef406fe721a05b63912c655546c2 Reviewed-on: https://chromium-review.googlesource.com/c/1329205 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57524}
-
Jakob Gruber authored
This CL adds support for embedded builtins in nosnap builds by creating and setting an 'embedded blob' after builtin generation. Unlike snapshot builds, the blob is not embedded into the .text section but located on the C++ heap. This makes nosnap builds more consistent with mksnapshot, and allows us to simplify there and in serializer cctests. Complications arise from the different workflows we need to support: 1. the standard mksnapshot build process, 2. nosnap builds (which reuse the blob created by the first Isolate), 2. and tests with various complicated serialization workflows. To cover all of these cases, this CL introduces two knobs to twiddle: 1. A 'sticky' embedded blob which overrides compiled-in default embedded blobs at Isolate setup. 2. The blob lifecycle can be managed manually or through refcounting. These are described in more detail in isolate.cc. Tbr: ulan@chromium.org Bug: v8:6666, v8:8350 Change-Id: I3842e40cdaf45d2cadd05c6eb1ec2f5e3d83568d Reviewed-on: https://chromium-review.googlesource.com/c/1310195Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#57523}
-
Mike Stanton authored
R=jarin@chromium.org Change-Id: Ia585398db7e9c69283450def924bc10edc37448f Reviewed-on: https://chromium-review.googlesource.com/c/1335563Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#57522}
-
Frank Tang authored
Add regression test to verify array with packed, holey and dictionary elements. Change ToUnicodeStringArray to return vector<UnicodeString> instead allocate raw UnicodeString before calling. Simplify ToUnicodeStringArray to loop only once. Bug: chromium:903566 Change-Id: I7ad74179be97d3cf929d2949384dbaa8b66a9a02 Reviewed-on: https://chromium-review.googlesource.com/c/1328642 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#57521}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6600235..ccf9ff5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6b8b30c..8a6451c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/ef71a5f..f66e551 Rolling v8/tools/luci-go:infra/tools/luci/isolate/${platform}: https://chrome-infra-packages.appspot.com/infra/tools/luci/isolate/${platform}/+log/git_rev..git_rev TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id6ee2891245ec1ce147c83ba1f9715646bb15c56 Reviewed-on: https://chromium-review.googlesource.com/c/1336783Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#57520}
-
Deepti Gandluri authored
BUG:v8:6020 Change-Id: I289a43d834765635425276afb80c2361152fdcb0 Reviewed-on: https://chromium-review.googlesource.com/c/1336113 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#57519}
-
Erik Luo authored
`console.table` used to have a 1k limit on preview properties, which regressed to 100 during refactoring. This CL restores the 1k limit, and ensures that `buildEntryPreview` does not use the 1k limit. Bug: chromium:903623 Change-Id: I8fab3182a79d1bb6b662e2ff9b229db3d3a889ca Reviewed-on: https://chromium-review.googlesource.com/c/1332127Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#57518}
-
- 14 Nov, 2018 3 commits
-
-
Sergiy Byelozyorov authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/8af70c5..6600235 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0cf6ee7..6b8b30c Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/332c9ff..ef71a5f Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/2e68926..879ac09 Rolling v8/tools/luci-go:infra/tools/luci/isolate/${platform}: https://chrome-infra-packages.appspot.com/infra/tools/luci/isolate/${platform}/+log/git_rev..git_rev TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I0cbffcb71b49e1d54e2aedb19f6dab65448586a0 Reviewed-on: https://chromium-review.googlesource.com/c/1336187Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#57517}
-
Jakob Kummerow authored
Clang is known to use a lot of stack space for Debug builds, so this patch lowers the recursion depth of that test after recent changes made Debug-mode stack frames a bit larger. a bit of Debug-mode stack space. Bonus: drops an unnecessary cast from SerializeJSObject to save Change-Id: I22696a1d80a6a73b5049b018e72cc8a3d8693042 Reviewed-on: https://chromium-review.googlesource.com/c/1334448Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57516}
-
Tobias Tebbi authored
This allows to call generic callables without mentioning all type parameters, if they can be deduced from the types passed as arguments. Bug: v8:7793 Change-Id: Idb37bb6b93c48bd6344c5be19da4e5b19d29593f Reviewed-on: https://chromium-review.googlesource.com/c/1335936Reviewed-by: Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#57515}
-