- 28 Nov, 2019 26 commits
-
-
Santiago Aboy Solanes authored
Due to the ordering of the nodes to be changed, we might change the ChangeTaggedToCompressed's input before the ChangeTaggedToCompressed node itself changes. Then, we need to check for this possibility too. Bug: v8:7703 Change-Id: I2b453211dc264b509f2ea7c0cf891be50f404009 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1942607 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65248}
-
Anna Henningsen authored
Ensure that all fields of `SyntheticModule` are set before creating the exports hash table for it, because the latter may trigger garbage collection, leading to crashes. This has been causing failures in the Node.js CI over the last weeks, after making the creating of synthetic modules part of Node’s startup sequence. (I am generally not very familiar with this part of the V8 code and there might be a better way, or possibly a way to add a reliable regression test, that I am not aware of.) Refs: https://github.com/nodejs/node/issues/30498 Refs: https://github.com/nodejs/node/issues/30648 Change-Id: I32da4b7bd888c6ec1421f34f5bd52e7bad154c1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939752 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65247}
-
Jakob Gruber authored
Ports are getting easier now. This one was fairly straightforward. Bug: v8:9972 Change-Id: I69c0566060523e505e30980cb1d3d9633da976b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940257 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#65246}
-
Andreas Haas authored
The bulk-memory tests changed with recent proposal changes: OOB accesses of size 0 cause traps now. R=thibaudm@chromium.org CC=emcziegler@chromium.org Change-Id: Id3f74373839434a61d3bf346a12146aa77894a8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940159Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#65245}
-
Jakob Gruber authored
These node/edge kinds don't fit into the heap object type system; add wrapper classes for them instead. The wrapper class must be explicitly created, but is implicitly convertible to Node*. Bug: v8:9972 Change-Id: Ic6c253a95bb5705fb946ee3f35508ea70c9f0070 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940255 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
... for convenient TNode access (e.g.: PhiAt, LoadField, LoadElement). Bug: v8:9972 Change-Id: Ie6f5f204079cf7c84279d1cb015055816f301916 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940254 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Clemens Backes authored
Fix a TODO from Ben to change the macro argument order to match the actual order in wasm code. After this fix, we can remove the individual {WASM_CALL_INDIRECT[0-5]} macros and implement them via a common variadic macro. Also, rename {WASM_CALL_INDIRECT_TABLE0} to {WASM_CALL_INDIRECT_TABLE}. The name was confusing, because this macro explictly allows to set a table index different from 0. Thus, just drop the "0" in the name. The individual test changes were done via a vim macro, to avoid manual errors. R=mstarzinger@chromium.org Bug: v8:10021 Change-Id: I9f0f31511c5c6e20a0b07524bf75fe9cf1598eba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940265Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65242}
-
Jakob Gruber authored
This is an initial (and partial) step towards full typing in graph assembler. It removes all uses of SloppyTNode, starts to introduce types in the GraphAssembler base class, and makes lambda function types (for if- and for-builders) more specific. Plenty of TODOs remain; e.g. checked casts and complete typing of GraphAssembler are left to follow-up work. Bug: v8:9972 Change-Id: I780adf83b53ad76beda4726960d95ab6df13e2ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940476 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Georg Neis authored
A call to this intrinsic will produce true in the interpreter and false in optimized code. This is useful for writing tests. Change-Id: I64d06ed062027e723eca82d6f879202244f21fdf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939750 Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Milad Farazmand authored
CodeStubAssembler::ComputeSeededHash is passing key as Int32 to ComputeSeededIntegerHash, but ComputeSeededIntegerHash only accepts Uint32 value. This could cause problems on s390 and ppc because GCC expects any value less than 8 bytes sign/zero-extending to 64-bits by the caller, therefore, the static cast from uint32->uint64 will be treated as no-op (expecting zero-ext instead), which leads to unexpected behaviors. Change-Id: Icd1eecaea1415e36c0c13eef513ff69cc418f247 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940209Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#65239}
-
Michael Starzinger authored
The last use of the predicate in question was to switch builtins that implement WebAssembly runtime stubs to use hard aborts instead of normal aborts like other builtins. This is no longer needed since the builtins in question are embedded and no longer copied into WebAssembly modules. This also allows to move the {WASM_RUNTIME_STUB_LIST} macro out of the builtins-defintions.h file and into the wasm-code-manager.h file. R=clemensb@chromium.org BUG=v8:10021 Change-Id: Ib42d3731fc92df378cfce39d39e7fbdbbf722937 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940266 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Clemens Backes authored
They have been deprecated in v7.9, hence they can be removed in v8.0. R=ulan@chromium.org CC=mstarzinger@chromium.org Bug: v8:10021 Change-Id: Ic21c5ee5703b548ddcca2ffeba6c583715d3fbd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864947 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This makes sure that proper checked casts (i.e. {CAST} instead of the unsafe {UncheckedCast} before) are used for all WebAssembly runtime stubs. This is possible because the corresponding builtins are embedded and hence can use proper assertion mechanisms. R=clemensb@chromium.org BUG=v8:10021 Change-Id: I344ae8ba7dd4c5d3f5dc2467f7d58b93517d9af7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940264 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Milad Farazmand authored
Port a0b1a9cd Original Commit Message: This adds a few tests that test that the output of Liftoff is deterministic. These tests will be extended to test the debug side table in follow-up CLs. R=clemensb@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I3e3391afa73f93298d6aff47aecb8ae1e2299bd3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940208Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
Clemens Backes authored
Use {std::unique_ptr} instead of raw {malloc}ed memory. This increases readability and memory safety significantly. The only downside is that we cannot use {realloc} any more (there is no C++ replacement for that), but that should not be noticeable. Drive-by: Make fields private. R=mstarzinger@chromium.org Bug: v8:10021 Change-Id: Ie99d61fe136fc18a07aa45f38a5a9b6542308504 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940261Reviewed-by: -
Jakob Gruber authored
Very similar to the recent ArrayPrototypeForEach port, this moves the Reduce reduction, which previously operated directly on the graph, to graph assembler. Nothing too interesting here, but it's becoming clearer that we will need more flexible Branch (multiple merge values) and If (a `break` mechanism) handling in the future. Bug: v8:9972 Change-Id: Ic48c85305ba721a9a43c67f7ad13c60da310487e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1934329 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#65233}
-
Peter Marshall authored
Reverting https://chromium-review.googlesource.com/c/v8/v8/+/1741660 This fixed one bug but caused a lot of others and on balance I think reverting it is the lesser evil. This also fixed generator-relocation.js because (function*(){}).constructor is the function constructor and we try to set a breakpoint on line 3. Bug: chromium:109362, chromium:1028689 Fixes: v8:9721 Change-Id: I1bfe6ec57ce77ea7292df91266311f5c0194947e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940259 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#65232}
-
Dan Elphick authored
If V8_SHARED_RO_HEAP is set, then GetSharedMemoryStatistics now reports the size of RO_SPACE. Additionally size values for RO_SPACE are zeroed in the per-isolate Heap and Space stats. Bug: v8:7464 Change-Id: I2d6843c001b55974460d1df034f08d1ed5b0d8da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1900459 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Georg Neis authored
https://chromium-review.googlesource.com/c/v8/v8/+/1937147 removed the DCHECK in ProcessNamedPropertyAccess but forgot to remove the one in ProcessKeyedPropertAccess too. Tbr: mvstanton@chromium.org Bug: v8:7790, chromium:1029198 Change-Id: Ia313c92969fe7d5e559e34995b39834267e6b3fd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940258Reviewed-by:
-
Michael Starzinger authored
R=tebbi@chromium.org BUG=v8:10021 Change-Id: I39052fa22ea90b392a36e7841f8586c19c8ca9cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940156 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Clemens Backes authored
We implement exponential growing of the native allocations by always growing at least by the old size. This speeds up use cases that grow a table incrementally (e.g. by 1). R=mstarzinger@chromium.org CC=ecmziegler@chromium.org Bug: v8:10018 Change-Id: I580ecf1ac87f793ff4a34ba45a86ae599eb3e6f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939452Reviewed-by:
-
Santiago Aboy Solanes authored
Even though they don't generate any code, it breaks some pattern matching when these nodes are present (e.g comparisons with compressed heap objects). Bug: v8:7703 Change-Id: I9670c2b4e85b1635061b16d4b125de9ff51fd403 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940153Reviewed-by:
-
David Carlier authored
Those fields are incorrect in FreeBSD. Upstreaming local FreeBSD patches. Change-Id: I28cf6dbec1d5e4d26e62dd9a0d78d039c3e36cdb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906374Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This removes the aforementioned untyped method and switches all users to the typed TNode<> version. Those versions now contain proper checks to compare the static information against the return count and types stored in the call descriptor. R=leszeks@chromium.org BUG=v8:10021 Change-Id: I393ea6211babc100e007fb1678877d36efa7bbf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939753Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65225}
-
Zhang, Shiyu authored
This CL adds a prototype_chain_enum_cache to cache the enumeration of a prototype and its entire chain on the PrototypeInfo. It can improve for-in performance via simply merging the receiver enumeration with this cache. It improves the score of JetStream2-tagcloud-SP case by ~9% on IA Chromebook. Contributed by tao.pan@intel.com Change-Id: Ib40bfe41e772672337155584672f06fa1ba1e70d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870844 Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#65224}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5fafe92..eeb227e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/fec12b8..fa0def7 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/34267f8..f31cb80 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/8c512f2..4dca59c Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4d65f00..05979d8 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Id69c231e8af78181690ec92abeb1159f21e9da70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1941369Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65223}
-
- 27 Nov, 2019 14 commits
-
-
Joshua Litt authored
This reverts commit bd9efe1f. Reason for revert: clusterfuzz Bug: chromium:1029174 Original change's description: > [regexp] Stage match indices. > > Bug: v8:9548 > Change-Id: Id6be43433b12733e39db712559715ba30e681059 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1935207 > Commit-Queue: Joshua Litt <joshualitt@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65218} TBR=adamk@chromium.org,jgruber@chromium.org,joshualitt@chromium.org Change-Id: I098385e2dcebc7bfacd91312bcebfdb889b3d0ca No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9548 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1941137Reviewed-by:
Joshua Litt <joshualitt@chromium.org> Commit-Queue: Joshua Litt <joshualitt@chromium.org> Cr-Commit-Position: refs/heads/master@{#65222}
-
Dan Elphick authored
First this plumbs RuntimeCallStats from the OptimizingCompileDispatcher down through to PipelineCompilationJob which stashes the RuntimeCallStats on the PipelineData. Adds new RCS thread-specific counters: OptimizeAssembleCode and OptimizeBackgroundAssembleCode which are used in PipelineImpl::AssembleCode. Bug: v8:10006 Change-Id: Ieef6d32afddf4b0760e204010b09a85dfec92cf3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926030 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#65221}
-
Georg Neis authored
The serializer was missing the opportunity to process calls later constructed by JSNativeContextSpecialization::InlinePropertySetterCall and InlinePropertyGetterCall. Added a test to ensure we're not missing the data anymore. This drops the "Missing data" warnings when running ARES-6 from 1044 to only 12. Bug: v8:7790 Change-Id: Ic4b8a4cb2ac3927371b75f22de011b9957502319 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1937147Reviewed-by:
-
Johannes Henkel authored
New revision: 7a44a37f66b58358dd8ab85ccde1998fafa95e53 Upstream review: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1899564 Previously, we used a wrapper library, v8-inspector-protocol-encoding.h to inject the string<->number conversion into the cbor parser. This meant that the unittests, in third_party/inspector_protocol/crdtp/json_test.cc inadvertently did not run with the same string<->number conversion code. Thus, we missed that the production implementation would return INF for out of range double literals, as opposed to rejecting the incoming JSON. When switching the library to the build dependency on json_platform_v8.cc as it's in this change, the test immediately failed which made it trivial to fix the implementation. Old implementation: https://chromium-review.googlesource.com/c/v8/v8/+/1913424/6/src/inspector/v8-inspector-protocol-encoding.cc New implementation (checks std::isfinite): https://chromium-review.googlesource.com/c/v8/v8/+/1913424/6/third_party/inspector_protocol/crdtp/json_platform_v8.cc Change-Id: Ia48fe1f4e359eea47d0ede9ceadea1fd635292e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1913424Reviewed-by:
-
Joshua Litt authored
Bug: v8:9548 Change-Id: Id6be43433b12733e39db712559715ba30e681059 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1935207 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#65218}
-
Georg Neis authored
... in line with VirtualContext and VirtualBoundFunction. Bug: v8:7790 Change-Id: I454048ab4ddc192780a09017b8b47caf60386098 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940247 Auto-Submit: Georg Neis <neis@chromium.org> Reviewed-by:
-
Joshua Litt authored
This reverts commit 48c9ca44. Reason for revert: Possible clusterfuzz issues Bug: chromium:1028952 Original change's description: > [names] Fix some test262 name tests to conform with spec changes > > In order to reflect web reality, TC39 has made some slight changes to > name descriptors, see https://github.com/tc39/ecma262/pull/1490 for > details. V8 was mostly already in compliance with these changes, but > ThrowTypeError and anonymous classes needed some slight changes. > > Bug: v8:9646 > Change-Id: I163238954938f0c005e3adbc61b90498e01436da > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1764622 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Joshua Litt <joshualitt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63373} TBR=gsathya@chromium.org,joshualitt@chromium.org Bug: v8:9646 Change-Id: I06dd5527d30052d9c9dfc45a2862be930274aba7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939948Reviewed-by:
-
Zhao Jiazhong authored
port edd50ad2 https://crrev.com/c/1924355 Original Commit Message: In both ChangeIntPtrToSmi and ChangeInt32ToSmi we can use bitcasts instead of change nodes for Smi Tagging, when we are using 31 bit smis in 64 bit architectures with pointer compression enabled. In ChangeIntPtrToSmi we can ignore the truncation as well. Updated DecompressionOptimizer to match the new pattern. Change-Id: I309e6c7ba671499f721149e1ea1c8e153fe3b2ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939028 Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#65215}
-
Joshua Litt authored
Bug: chromium:1028475 Change-Id: I0101930e01d41b0f29fa28a257e3dc720069faff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1936835Reviewed-by:
-
David Carlier authored
Adaptation coming from the ports for upstream purposes. Change-Id: Ia1d0d6dabfd10d5840084bb90814c33ea9fb6aa8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906373Reviewed-by:
-
Ulan Degenbaev authored
This removes the marking worklist draining loop from IncrementalMarking and makes it use the one of MarkCompactCollector. Bug: chromium:973627 Change-Id: I226b4b45be7d542a82bba20162ad210dfb419c39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1940250 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#65212}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1ef02be..fec12b8 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/341d41b..34267f8 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/b627b3e..8c512f2 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Iebb343ff9117ecf7377b7c4db9073807f44b6779 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939745Reviewed-by:
-
Clemens Backes authored
In order to implement {dlsym} like functionality, toolchains might generate code that grows the table by one element at a time (e.g. Emscripten currently does that). To improve performance in such a case, we over-allocate the backing store of the {WasmTableObject}. Whenever the backing store grows, it grows at least by the old size of the table. This ensures exponentially growth, avoiding too many re-allocations. R=mstarzinger@chromium.org CC=ecmziegler@chromium.org Bug: v8:10018 Change-Id: I502d590a89f7804363938a157b7ed2189283227a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939051Reviewed-by: -
Liviu Rau authored
No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I0b0ab62625b69c3baa88d0b9850f946b901f31d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1939456 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65209}
-
