- 04 Feb, 2019 38 commits
-
-
Clemens Hammacher authored
See referenced bug. This is currently broken and blocks the roll. The CL cannot easily be reverted, so I disable code logging for now while working on a fix. R=herhut@chromium.org, sigurds@chromium.org Bug: v8:8783 Change-Id: I222981313535cadd1ddc345bdf56dfabfc328c82 Reviewed-on: https://chromium-review.googlesource.com/c/1452437Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59349}
-
Maciej Goszczycki authored
Bug: v8:7464 Change-Id: I1b33bfff02ccd1ae19f0525e8ab0f8bfe69abe17 Reviewed-on: https://chromium-review.googlesource.com/c/1451933Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Cr-Commit-Position: refs/heads/master@{#59348}
-
Toon Verwaest authored
This is 3-4x faster than using the Utf8Decoder. This matters for proper parse-time measurements using d8. Change-Id: I9870e9fbe400ec022a6eeb20491c80a2a32f8519 Reviewed-on: https://chromium-review.googlesource.com/c/1451827 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#59347}
-
Clemens Hammacher authored
Merge {Abort} into {AbortCompilation}. R=ahaas@chromium.org Bug: v8:8689 Change-Id: I091a298b1195d145fc21d2afb9d9cc9c57925f95 Reviewed-on: https://chromium-review.googlesource.com/c/1451821 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#59346}
-
Michael Achenbach authored
TBR=jgruber@chromium.org NOTRY=true Bug: v8:7777 Change-Id: I5006aee897fe0d0705e7265e714ec200e13370b1 Reviewed-on: https://chromium-review.googlesource.com/c/1451890Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59345}
-
Sigurd Schneider authored
This CL adds handling for Load/StoreMessage to LoadElimination. It is handled like a Load/StoreField to an external location. Change-Id: I50f27fba9cb7ffabf1474aa409083676cef65442 Bug: v8:8183, chromium:927746 Reviewed-on: https://chromium-review.googlesource.com/c/1451879 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#59344}
-
Clemens Hammacher authored
The flag value and {Platform::NumberOfWorkerThreads()} are already int, and we do not expect to spawn more than 2 billion threads any time soon. R=titzer@chromium.org Bug: v8:8562 Change-Id: I9c23ae1b5b9e9daab3fdb072bf98f48ea2b3f240 Reviewed-on: https://chromium-review.googlesource.com/c/1451887 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#59343}
-
Clemens Hammacher authored
This reverts commit 8a914846. Reason for revert: Seems to cause layout test failures: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%2520Mac/16246 Original change's description: > [wasm] Turn deferred handles into global handles > > Each instance of {DeferredHandles} only stores a single handle anyway, > so turning them into global handles saves memory. > > R=ahaas@chromium.org > > Bug: v8:7921, v8:8423 > Change-Id: I75e0cc6ecb6d0337f1695e6bfd4b5fdcb8a2039c > Reviewed-on: https://chromium-review.googlesource.com/c/1402715 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59331} TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I8996fd22702b5dd0485e59b54989788596293a1f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7921, v8:8423 Reviewed-on: https://chromium-review.googlesource.com/c/1451888Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59342}
-
Clemens Hammacher authored
This removes the last creation of foreground tasks in the compilation state. I think this logic can be removed completely, because a) the number of background tasks is already capped at {max(1, FLAG_wasm_num_compilation_tasks)}, and b) in order to get predictable timing you can use the --predictable flag which makes all background tasks execute synchronously with foreground tasks (from the same queue). R=ahaas@chromium.org CC=mstarzinger@chromium.org Bug: v8:8050, v8:8689 Change-Id: I142af6b42f9bb9befc7c7b7d6002192d72bd7677 Reviewed-on: https://chromium-review.googlesource.com/c/1451841 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Georg Neis authored
...except for the initial function. Bug: v8:7790, chromium:928202 Change-Id: I220e13d148525734d866f8aaf0c7ef8cbeccbcb2 Reviewed-on: https://chromium-review.googlesource.com/c/1451825Reviewed-by:
-
Clemens Hammacher authored
The counters are the last use of the Isolate. Remove it by passing in the counters in a shared_ptr. This way, we can also refactor the counters later to be per engine or per process. In a follow-up CL, we can then remove the Isolate, the foreground task runner and the cancellable task manager from the compilation state. R=mstarzinger@chromium.org Bug: v8:8689, v8:8050 Change-Id: I66b4fab77f770cb8a5463244054b428eef1b7c61 Reviewed-on: https://chromium-review.googlesource.com/c/1451922 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#59339}
-
Tobias Tebbi authored
- fix highliting of extends clause in types - label constants as constants Change-Id: Iad1682a5c294dc1999067f4e43feb4aada7e1ced Reviewed-on: https://chromium-review.googlesource.com/c/1451924 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#59338}
-
peterwmwong authored
The parts that deal with allocating on heap buffers and typed array elements (FixedTypedArrayBase) remain in CSA, as it is assumed to eventually be expressed with Torque classes. This reduces overall builtins size by 508 bytes (Mac x64.release) - TypedArrayInitialize 2332 -> 1824 Bug: v8:7161 Change-Id: I5d0648b4dd79a687f77d6f4b01b236f4a0508c54 Reviewed-on: https://chromium-review.googlesource.com/c/1445215Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Georg Neis authored
Bug: v8:7790 Change-Id: I25e41548c526e93c5b0a532ca2d270b62193a557 Reviewed-on: https://chromium-review.googlesource.com/c/1448315 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#59336}
-
Clemens Hammacher authored
The compilation state is isolate-independent, so it should not cache the isolate-specific {should_log_code} flag. Instead, we log via the WasmEngine every time. If this turns out to be too expensive, we should introduce an atomic flag in the WasmEngine. R=mstarzinger@chromium.org Bug: v8:8050 Change-Id: I913ada4f86af4c6fa9cd9c5adc8d4e250f6eb7f1 Reviewed-on: https://chromium-review.googlesource.com/c/1451820Reviewed-by: -
cjihrig authored
This commit updates gen-postmortem-metadata.py to re-export the v8dbg_class_JSFunction__shared__SharedFunctionInfo constant. See: https://github.com/nodejs/node/pull/25852 Change-Id: I60f39c96f3f22d6f10ec38b0af3c975908c7b7f2 Reviewed-on: https://chromium-review.googlesource.com/c/1450144Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#59334}
-
Michael Achenbach authored
NOTRY=true Change-Id: I71c5fbfbb58cd13613506acabf446d9cffc6d23b Reviewed-on: https://chromium-review.googlesource.com/c/1451837Reviewed-by:
-
Michael Achenbach authored
Bug: v8:8778 Change-Id: I384ad4387743d534a79ebad03130e8a688cc4631 Reviewed-on: https://chromium-review.googlesource.com/c/1449691Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Each instance of {DeferredHandles} only stores a single handle anyway, so turning them into global handles saves memory. R=ahaas@chromium.org Bug: v8:7921, v8:8423 Change-Id: I75e0cc6ecb6d0337f1695e6bfd4b5fdcb8a2039c Reviewed-on: https://chromium-review.googlesource.com/c/1402715 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Ross McIlroy authored
BUG=v8:7295,v8:8562 Change-Id: Ifa02ba233967ba38d4ff43576de77738001d076a Reviewed-on: https://chromium-review.googlesource.com/c/1450115Reviewed-by:
-
Takuto Ikuta authored
This is a reland of 83908b86 Fix: check V8_INTL_SUPPORT macro in js-objects.cc Original change's description: > Reland "Extract JSObject class from objects.cc" > > This is a reland of b8c821f4 > > Fix: include src/string-stream.h for compile failure > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20builder/39320 > > Original change's description: > > Extract JSObject class from objects.cc > > > > I extracted following class member functions to js-objects.cc > > * JSReceiver > > * JSObject > > * JSBoundFunction > > * JSFunction > > * JSGlobalObject > > * JSDate > > * JSMessageObject > > > > Declaration of all above class are in js-objects.h. > > > > I also moved AllocationSite::DigestTransitionFeedback used in JSObject::UpdateAllocationSite > > and ShouldConvertToSlowElements used in JSObject and JSArray > > > > This patch makes compile time of objects.cc from 17.6s to 14.1s on Z840 Linux. > > And js-objects.cc takes 8.69s for compile. > > > > Bug: v8:7629 > > Change-Id: I989f22363667445dd28d7f8c06c81ff79d6ed45f > > Reviewed-on: https://chromium-review.googlesource.com/c/1447916 > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > Reviewed-by: Marja Hölttä <marja@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#59288} > > Bug: v8:7629 > Bug: v8:8562 > Change-Id: Iac2227c5f0c5a4072d16814ecae481fb4720e4f5 > Reviewed-on: https://chromium-review.googlesource.com/c/1449951 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59318} Bug: v8:7629, v8:8562 Change-Id: If8870bd579d8597d08981a83492f60595e081a65 Reviewed-on: https://chromium-review.googlesource.com/c/1452097Reviewed-by:
-
Clemens Hammacher authored
This is a reland of a9e93572 Original change's description: > [test] Check for illegal uses of mjsunit methods > > The assertThrows and assertDoesNotThrow methods expect either a > function to execute, or a string to eval. In several tests however we > accidentally passed the *result* of the statement to be tested instead > of the code. > This CL adds check to catch such error early, and removes wrong uses. > In most places, we do not need to use assertDoesNotThrow anyway, > because exceptions are handled as test failures. > > Drive-by: Unify catch syntax in mjsunit.js and make sure to propagate > MjsUnitAssertionErrors correctly. > > R=mathias@chromium.org > > Bug: v8:8562 > Change-Id: I88894a667cbe0570774f748a9a23e8a527887a49 > Reviewed-on: https://chromium-review.googlesource.com/c/1439238 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59277} Bug: v8:8562 Change-Id: I3b26935f7b35302d499266155273ea271bf8151d Reviewed-on: https://chromium-review.googlesource.com/c/1449792Reviewed-by:
-
Clemens Hammacher authored
R=mstarzinger@chromium.org Bug: v8:8781 Change-Id: I6982170a3e4c31a6d39e6368b7a3163dbb08cee7 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1451917Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Bug: v8:8278 Change-Id: I0f6c5ca3766ce6a9ffa2a97082b875b2a3fb357f Reviewed-on: https://chromium-review.googlesource.com/c/1450122Reviewed-by:
-
Jakob Gruber authored
This is a reland of 0befa6d4 Original change's description: > [nojit] Check that --jitless is disabled when creating wasm code > > Drive-by: Amend wasm test skips for lite mode. > > Bug: v8:7777 > Change-Id: I23e13b65e548c19d6b24a26e0b962a9978f54ed7 > Reviewed-on: https://chromium-review.googlesource.com/c/1449616 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59314} Tbr: mstarzinger@chromium.org Bug: v8:7777 Change-Id: I0a076b36bb2e69b612df89b0f35067f299f27a7e Reviewed-on: https://chromium-review.googlesource.com/c/1451819 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This reverts commit 83908b86. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20noi18n%20-%20debug/25074 Original change's description: > Reland "Extract JSObject class from objects.cc" > > This is a reland of b8c821f4 > > Fix: include src/string-stream.h for compile failure > https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20builder/39320 > > Original change's description: > > Extract JSObject class from objects.cc > > > > I extracted following class member functions to js-objects.cc > > * JSReceiver > > * JSObject > > * JSBoundFunction > > * JSFunction > > * JSGlobalObject > > * JSDate > > * JSMessageObject > > > > Declaration of all above class are in js-objects.h. > > > > I also moved AllocationSite::DigestTransitionFeedback used in JSObject::UpdateAllocationSite > > and ShouldConvertToSlowElements used in JSObject and JSArray > > > > This patch makes compile time of objects.cc from 17.6s to 14.1s on Z840 Linux. > > And js-objects.cc takes 8.69s for compile. > > > > Bug: v8:7629 > > Change-Id: I989f22363667445dd28d7f8c06c81ff79d6ed45f > > Reviewed-on: https://chromium-review.googlesource.com/c/1447916 > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > Reviewed-by: Marja Hölttä <marja@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#59288} > > Bug: v8:7629 > Bug: v8:8562 > Change-Id: Iac2227c5f0c5a4072d16814ecae481fb4720e4f5 > Reviewed-on: https://chromium-review.googlesource.com/c/1449951 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59318} TBR=marja@chromium.org,mstarzinger@chromium.org,titzer@chromium.org,tikuta@chromium.org Change-Id: I3260edecb1434bbf9c25d89c9f9a8af02d106855 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7629, v8:8562 Reviewed-on: https://chromium-review.googlesource.com/c/1452096Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59324}
-
Clemens Hammacher authored
The most common use of {SaveContext} is to allocate this object, then immediately set the context of the isolate to another Context. Thus introduce a second class called "SaveAndSwitchContext" which implements exactly that. R=mstarzinger@chromium.org Bug: v8:8562 Change-Id: I2fca1eadd909a7afe035316ded934624273f2e21 Reviewed-on: https://chromium-review.googlesource.com/c/1448319Reviewed-by: -
Sigurd Schneider authored
As Marja suggested, this CL changes tools/locs.py in such a way that it also counts the bytes in the input file and the output file. Example output now looks similar to this: Processed 1,526 files in 24.58 sec. gen ( 31 files): 94,507 LoC ( 4,972 kB) to 2,839,311 LoC (183,777 kB) ( 30x) src ( 630 files): 371,499 LoC ( 14,743 kB) to 53,707,841 LoC ( 3,155 MB) ( 145x) test ( 381 files): 492,861 LoC ( 25,372 kB) to 36,885,988 LoC ( 2,194 MB) ( 75x) third_party ( 433 files): 239,155 LoC ( 8,683 kB) to 9,713,872 LoC (412,829 kB) ( 41x) total ( 1526 files): 1,212,675 LoC ( 54,242 kB) to 104,133,982 LoC ( 5,973 MB) ( 86x) Change-Id: I1ff5e752ee3a96d388a4393c2592aec68f834000 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/1450113 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#59322}
-
Daniel Clifford authored
In the process add missing base Torque functionality for 8-bit and 16-bit integers and Cast<> operators to make them easy to use. As a poster child, port the field declarations of SharedFunctionInfo to the class definition in base.tq. As a drive by: Add the missing GN dependency on class-definitions-from-dsl.h Bug: v8:7793 Change-Id: I76a41c2e81ffd1cbb90ac7a4ef8d4003ac86e8dc Reviewed-on: https://chromium-review.googlesource.com/c/1445882Reviewed-by:
-
Simon Zünd authored
This CL changes most Call* macros (and some others) in Array#sort to pass the context and sortState implicitly. This improves readability, especially for loads and stores. R=jgruber@chromium.org, tebbi@chromium.org Bug: v8:8567 Change-Id: I6528d080bb01ab676de3ba6a7bf8223b98b6db7f Reviewed-on: https://chromium-review.googlesource.com/c/1450114Reviewed-by:
-
Ross McIlroy authored
For compiled SFIs, finding the FunctionLiteralId is a slow operation that requires doing a binary search in the script's SFI table. Given the SFI has been flushed, it is unlikely we will need the FunctionLiteralId again, so just mark the UncompiledData has having an invalid FunctionLiteralID such that we only do the search if it is required from the UncompiledData. This addresses a significant regression on gc_latency when bytecode flushing was enabled. BUG=chromium:927038,v8:8395 Change-Id: I7123c3fe05034ff96e84f9d1d36d5f312a2a56e0 Reviewed-on: https://chromium-review.googlesource.com/c/1450118Reviewed-by:
-
Takuto Ikuta authored
This is a reland of b8c821f4 Fix: include src/string-stream.h for compile failure https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20builder/39320 Original change's description: > Extract JSObject class from objects.cc > > I extracted following class member functions to js-objects.cc > * JSReceiver > * JSObject > * JSBoundFunction > * JSFunction > * JSGlobalObject > * JSDate > * JSMessageObject > > Declaration of all above class are in js-objects.h. > > I also moved AllocationSite::DigestTransitionFeedback used in JSObject::UpdateAllocationSite > and ShouldConvertToSlowElements used in JSObject and JSArray > > This patch makes compile time of objects.cc from 17.6s to 14.1s on Z840 Linux. > And js-objects.cc takes 8.69s for compile. > > Bug: v8:7629 > Change-Id: I989f22363667445dd28d7f8c06c81ff79d6ed45f > Reviewed-on: https://chromium-review.googlesource.com/c/1447916 > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59288} Bug: v8:7629 Bug: v8:8562 Change-Id: Iac2227c5f0c5a4072d16814ecae481fb4720e4f5 Reviewed-on: https://chromium-review.googlesource.com/c/1449951Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 0befa6d4. Reason for revert: Fails in lite mode: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite/2177 Original change's description: > [nojit] Check that --jitless is disabled when creating wasm code > > Drive-by: Amend wasm test skips for lite mode. > > Bug: v8:7777 > Change-Id: I23e13b65e548c19d6b24a26e0b962a9978f54ed7 > Reviewed-on: https://chromium-review.googlesource.com/c/1449616 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59314} TBR=mstarzinger@chromium.org,jgruber@chromium.org Change-Id: Id0d43fe4b03a2992acd980fd9fa4ef114d4b6aa2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7777 Reviewed-on: https://chromium-review.googlesource.com/c/1451877Reviewed-by:
-
Simon Zünd authored
This CL makes the TypedArray#sort unit test more robust, that checks for the stable property. R=jgruber@chromium.org Bug: v8:8567 Change-Id: I8e6a729d0a8b54901535d49eb578b8b34bd6f2eb Reviewed-on: https://chromium-review.googlesource.com/c/1449695Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#59316}
-
Jakob Gruber authored
These offsets are now transported via CodeDesc. Bug: v8:8758 Change-Id: If7485c62878bc81a55c9b4ca8ce3578dab2376ce Reviewed-on: https://chromium-review.googlesource.com/c/1447717 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Drive-by: Amend wasm test skips for lite mode. Bug: v8:7777 Change-Id: I23e13b65e548c19d6b24a26e0b962a9978f54ed7 Reviewed-on: https://chromium-review.googlesource.com/c/1449616Reviewed-by:
-
Michael Achenbach authored
This replaces the "trusted" with the "jitless" correctness-fuzzing experiment. The former is a no-op already. NOTRY=true Bug: v8:8778 Change-Id: Ie9b490df27071980b2049148844b8f716bbbb1f7 Reviewed-on: https://chromium-review.googlesource.com/c/1450120Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/79e2191..ed3546e Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/3114fbc..05973b6 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I26a29a3655c00dc3b349eaf99c1262265b108048 Reviewed-on: https://chromium-review.googlesource.com/c/1451260Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#59312}
-
- 03 Feb, 2019 2 commits
-
-
Ruben Bridgewater authored
Set entries return an array with the value as first and second entry. As such these are considered key value pairs to align with maps entries iterator. So far the return value was identical to the values iterator and that is misleading. This also adds tests to verify the results and improves the coverage a tiny bit by testing different iterators. Refs: https://github.com/nodejs/node/issues/24629 R=yangguo@chromium.org Change-Id: I669a724bb4afaf5a713e468b1f51691d22c25253 Reviewed-on: https://chromium-review.googlesource.com/c/1350790 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/eb61983..79e2191 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I268f52fbf24db332be534983f49dac7ace14ac09 Reviewed-on: https://chromium-review.googlesource.com/c/1450788Reviewed-by:
-
