- 10 Jul, 2019 6 commits
-
-
Mike Stanton authored
... for building the TurboFan graph from bytecode concurrently. Bug: v8:7790 Change-Id: Iceb838990355ee76e2dabb8a00ed5464d41764c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1681120 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#62615}
-
Clemens Hammacher authored
This reverts commit 8f8ae4f8. Reason for revert: Still failing layout tests: https://ci.chromium.org/p/v8/builders/ci/V8-Blink%20Linux%2064/33036 Original change's description: > Reland: Serialize native errors > > This is a reland of https://crrev.com/c/v8/v8/+/1649257. The original > change was reverted because it conflicted with a blink-side serialization > tag. > > Make native errors serializable. > > The implementation is mostly straightforward, but there is one > exception: the stack property. Although the property is not specified, > the spec for error cloning asks us to preserve the property if > possible. This implementation serializes the property only when it is > a string, and otherwise ignores it. > > Spec: https://github.com/whatwg/html/pull/4665 > Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/f8JngIi8qYs > > Bug: chromium:970079 > Change-Id: Ic1ff07be2c5be415bfb564fa3975bc1a55a06a72 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1692366 > Reviewed-by: Simon Zünd <szuend@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62607} TBR=jbroman@chromium.org,yhirano@chromium.org,szuend@chromium.org Change-Id: Ia52b3e3997663fc293e9d217e5a56544b28d050d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:970079 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1695462Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#62614}
-
Yang Guo authored
Change-Id: Iabb9e75b62f13a3bd08114941880c1d4a7f74d8c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1687278 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#62613}
-
Peter Marshall authored
This makes it clearer what this class does, and is more consistent with the terminology used by ignition (BytecodeGenerator). Change-Id: I9085f29f437cf15605a5ae971b1fc72d6c79feaa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1692923Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#62612}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bd69e87..6016ce5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/dd686e3..5cc5f6e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/92afaf5..3b07526 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/d700357..437e100 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/686128d..7cefad2 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I9eae00dc1607c51f1a4231d5a59a42ced8eb6ed5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1694542Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#62611}
-
Ng Zhi An authored
Bug: v8:9372 Change-Id: Ia25d6a5e1950a89e945cb4fdbdf166bdfb0d3c00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1688429Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#62610}
-
- 09 Jul, 2019 28 commits
-
-
Seth Brenith authored
Bug: v8:9337 Change-Id: Ib17a205d1f0d70c0d422dd6cd85239e71355da84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1692195Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#62609}
-
Z Nguyen-Huu authored
a7732341 missed a case when receiver is Smi in TryPrototypeChainLookup. Bug: chromium:980292, chromium:980226 Change-Id: Ife6be4541d6b280253a7e87cf6f57c96efe8300f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1687283 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#62608}
-
Yutaka Hirano authored
This is a reland of https://crrev.com/c/v8/v8/+/1649257. The original change was reverted because it conflicted with a blink-side serialization tag. Make native errors serializable. The implementation is mostly straightforward, but there is one exception: the stack property. Although the property is not specified, the spec for error cloning asks us to preserve the property if possible. This implementation serializes the property only when it is a string, and otherwise ignores it. Spec: https://github.com/whatwg/html/pull/4665 Intent-to-Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/f8JngIi8qYs Bug: chromium:970079 Change-Id: Ic1ff07be2c5be415bfb564fa3975bc1a55a06a72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1692366Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#62607}
-
Z Nguyen-Huu authored
This DCHECK is unnecessary because the object can be sealed or frozen before it is set as a prototype map. The repro is Object.seal(Object);// Object is HOLEY_FROZEN_ELEMENTS const v3 = Object(); v3.__proto__ = Object; // Set prototype map bit and dictionary map bit const v6 = Object.seal(Object); // Turn Object to DICTIONARY_ELEMENTS Bug: chromium:980168 Change-Id: Iec50249d0ff0c5ed959201707b837871fcb88a02 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1687280 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#62606}
-
Tobias Tebbi authored
The slow-path emitted by the memory optimizer now checks if large object allocations were allowed before going ahead and allocating a large object. This is important because manual allocation folding in CSA must not be performed on a large object. Bug: v8:9388 Change-Id: I74b840c9c9276bd17611842e0eae7b0e58b142d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1675960 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#62605}
-
Dominik Inführ authored
Right trimming of arrays was deleting old-to-new slots during a GC pause. Disable slots removal for right trimming of arrays and ensure no more slots are deleted during a GC pause. Bug: v8:9454 Change-Id: I6268d63b82713d765247dca4aaadadfe275b7dcd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691915Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#62604}
-
Pierre Langlois authored
The info tab says that 'i' reveals outputs and 'o' reveals inputs, it should be the opposite. Bug: v8:7327 Change-Id: I1bf96653129e14ef315a01dc2c7a3083c9caa5bb Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1692929 Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Auto-Submit: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62603}
-
Santiago Aboy Solanes authored
Decompressing with Any just chooses one of the decompressions (Signed or Pointer). Since we already know which decompression it is going to choose, we save ourselves a whole bunch of instructions by just skipping that. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:7703 Change-Id: I0173931536e7ba83fa3572ceb50b176409f0b6c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691916Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#62602}
-
Ana Pesko authored
This CL changes the use of a ZoneList for keeping track of named captures in a regular expression to a ZoneMap, to optimize finding the named capture in the structure. Bug: v8:9423 Change-Id: Id952ac8f86c1dc5d69a3b0251ff724d1509879dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1687413 Commit-Queue: Ana Pesko <anapesko@google.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#62601}
-
Jakob Kummerow authored
Change-Id: Ide762b9af9bd23d376025e9b3e6f5ccab7b0f1a5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691026Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#62600}
-
Andreas Haas authored
R=mstarzinger@chromium.org Bug: v8:7581 Change-Id: I958c622387e2e3520fae051ae893623238393550 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691021 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#62599}
-
Nico Hartmann authored
TypeCheckKind may be propagated only by operators that can potentially deopt and sit in the effect chain. This CL introduces a DCHECK to detect that it is not set for other operators. Change-Id: I002c7c36ab2d2612a41a2f280927cb85c112b9b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691912 Commit-Queue: Nico Hartmann <nicohartmann@google.com> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62598}
-
Igor Sheludko authored
Tbr: verwaest@chromium.org Bug: v8:9353 Change-Id: I8164e2235ca43e203410277b86e6f166010c11d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1687673Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#62597}
-
Andreas Haas authored
R=clemensh@chromium.org Bug: v8:7581 Change-Id: I6fd538f2e90bf5a4addcfe7d8f4b427850ac6fca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690960 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#62596}
-
Tamer Tas authored
This reverts commit 1db33e5f. Reason for revert: {AttributeError} 'Namespace' object has no attribute 'experimental' Original change's description: > [browser-stories] gate features behind {experimental} flag > > Performance infra recipes use callstats.py to run web page replays. Split (v8, > infa, perf-infra) repositories make experimenting with callstats.py hard. > > This CL creates feature gating for simplifying performance infra experiments. > > R=ulan@chromium.org > > No-Try: true > Bug: v8:9448 > Change-Id: I2c3e139f4b9d6bce1ea4fdda1a44960d74d7d414 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690950 > Auto-Submit: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Tamer Tas <tmrts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62565} TBR=ulan@chromium.org,tmrts@chromium.org Change-Id: If40be01a2edebf0538ad306fa5ded0dfa2aaf147 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9448 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1692922Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#62595}
-
Clemens Hammacher authored
Instead of having hard to read reinterpret_casts all over the place, extract this to separate methods. R=mstarzinger@chromium.org Bug: v8:9396 Change-Id: Id8d47b5dda8f5b32dedfe9f76c4f526ffcff0674 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691024Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#62594}
-
Mike Stanton authored
... for concurrent graph building. This is a reland of jarin@chromium.org's CL https://chromium-review.googlesource.com/c/v8/v8/+/1682027 with support to access the source positions through a handle when running without concurrent inlining, because the positions may move due to GC allocation. Bug: v8:7790 Change-Id: I1b2cc84c8cb801cb82f1a527fce736c74c156c1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1683726Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#62593}
-
Clemens Hammacher authored
R=jgruber@chromium.org Bug: v8:9429, v8:9396 Change-Id: I0e51e8478d7232bc51bed26bc26560c6e6450366 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690946Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#62592}
-
Jakob Gruber authored
The name dictionary allocated to store named captures on the regexp result object could be too large for regular heap spaces and ConstructNewResultFromMatchInfo must thus also handle the large object case. Bug: chromium:980891 Change-Id: Ia1dbecd0a9d9d6b39f80e77680386c385d95c97c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691907Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#62591}
-
Mike Stanton authored
In the rare case that a tagged template is not initialized before optimization time, we currently cache this created template in the feedback vector. If we stop doing this, we simplify the interface usefully for concurrent compilation and pay little for it. Bug: v8:7790 Change-Id: Ifc82b0eb931a706767596febd4f4b312e167fd25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690837 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#62590}
-
Yutaka Hirano authored
This reverts commit 85bc4ef6. Reason for revert: The tag 'e' conflicts with a blink serialization tag: kFileIndexTag. Original change's description: > Serialize native errors > > Make native errors serializable. > > The implementation is mostly straightforward, but there is one > exception: the stack property. Although the property is not specified, > the spec for error cloning asks us to preserve the property if > possible. This implementation serializes the property only when it is > a string, and otherwise ignores it. > > Spec: https://github.com/whatwg/html/pull/4665 > Intent-to-Ship: <TBD> > > Bug: chromium:970079 > Change-Id: I7f36b8b4fc5dff22d726d849ccfb9748d0888365 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649257 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62584} TBR=jbroman@chromium.org,yhirano@chromium.org,adamk@chromium.org,domenic@chromium.org,szuend@chromium.org Change-Id: Ia0cc902eaa1419cdb0cfec377d8a40fa914612c9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:970079 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1692365 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#62589}
-
Ulan Degenbaev authored
This replaces non-const reference arguments by pointers. Bug: v8:9429 Change-Id: I5e5d94b020dedf3005f8d74202d31e3a50bdf754 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690943Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#62588}
-
Patrick Thier authored
EscapeRegExpPattern should return a string representation of a RegExp instance that in turn can be used to construct a new RegExp instance with the same internal state as the original one. Previous versions incorrectly escaped '/' also inside character classes (e.g. /[/]/ returned "[\/]"). This patch properly escapes '/' when necessary and omits unnecessary escapes. Bug: v8:8615, v8:1982, v8:9446 Change-Id: I4ecb993dc69d6976f4637cedf43465cd0c32e427 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1688050 Commit-Queue: Patrick Thier <pthier@google.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#62587}
-
Georg Neis authored
A few changes have been made to this feature and disabling it lets us best see its current performance impact. Bug: v8:9088 Change-Id: I54d5e09f3fcece215e29d66d5bdb3f19ba07bda0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690954Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62586}
-
Ng Zhi An authored
Bug: v8:8460 Change-Id: I837b7dc3f575d69ccbf2cd76332c0bf775724675 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1684362Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#62585}
-
Yutaka Hirano authored
Make native errors serializable. The implementation is mostly straightforward, but there is one exception: the stack property. Although the property is not specified, the spec for error cloning asks us to preserve the property if possible. This implementation serializes the property only when it is a string, and otherwise ignores it. Spec: https://github.com/whatwg/html/pull/4665 Intent-to-Ship: <TBD> Bug: chromium:970079 Change-Id: I7f36b8b4fc5dff22d726d849ccfb9748d0888365 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1649257 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#62584}
-
Simon Zünd authored
This CL changes non-const reference arguments to either a const reference, or pass-by-value combined with std::move. Bug: v8:9429 Change-Id: Iabace132f855462612ac31922fbd8b456d8ae20d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690827Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#62583}
-
Daniel Clark authored
ResolveExport and Evaluate are the final unimplemented SyntheticModule methods; with this change the implementation is complete. Test-api unit tests are also provided. Bug: v8:9292 Change-Id: Ieb7643cc5b6495dd201a51f04199d2406a703e52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1681187Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#62582}
-
- 08 Jul, 2019 6 commits
-
-
Bill Budge authored
Change-Id: Ia506f4741e6ff9f024199d1b1fa7abb7dafe2b25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1682835 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#62581}
-
Bill Budge authored
Defers some work in the non-asm.js case Change-Id: Id20863fb2af83148271408b0242d49e03be29d3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1682213 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#62580}
-
Irina Yatsenko authored
The current integration of crash keys into v8 got the dependencies wrong: it introduced into v8 a dependency on components and base. This change will allow moving the implementation into "gin" (via Platform's abstraction), which is ok to depend on components and base, while providing the default noop implementation for the embedders that don't care to collect crash keys. Gin's side: https://chromium-review.googlesource.com/c/chromium/src/+/1690003. Bug: v8:9323 Change-Id: I7b6e3e2cdc4b5f14f61ad20d2c362344d53896c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1689834 Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#62579}
-
Clemens Hammacher authored
This reverts commit 31cd5d83. Reason for revert: It breaks my heart to revert this, but it fails differently on several bots, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/26671. Original change's description: > [arraybuffer] Rearchitect backing store ownership > > This CL completely rearchitects the ownership of array buffer backing stores, > consolidating ownership into a {BackingStore} C++ object that is tracked > throughout V8 using unique_ptr and shared_ptr where appropriate. > > Overall, lifetime management is simpler and more explicit. The numerous > ways that array buffers were initialized have been streamlined to one > Attach() method on JSArrayBuffer. The array buffer tracker in the > GC implementation now manages std::shared_ptr<BackingStore> pointers, > and the construction and destruction of the BackingStore object itself > handles the underlying page or embedder-allocated memory. > > The embedder API remains unchanged for now. We use the > v8::ArrayBuffer::Contents struct to hide an additional shared_ptr to > keep the backing store alive properly, even in the case of aliases > from live heap objects. Thus the embedder has a lower chance of making > a mistake. Long-term, we should move the embedder to a model where they > manage backing stores using shared_ptr to an opaque backing store object. > > R=mlippautz@chromium.org > BUG=v8:9380,v8:9221 > > Change-Id: I48fae5ac85dcf6172a83f252439e77e7c1a16ccd > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1584323 > Commit-Queue: Ben Titzer <titzer@chromium.org> > Reviewed-by: Ben Titzer <titzer@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62572} TBR=ulan@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,titzer@chromium.org,gdeepti@chromium.org,mlippautz@chromium.org Change-Id: Ib35788ba8c31192d90cbc72df3dbc41030f109de No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9380, v8:9221 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691034Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#62578}
-
Santiago Aboy Solanes authored
Locally tested, octane results are the same or better when using branchful decompression in generated code. The biggest one is DeltaBlue in x64 which improves about 25%. x64's EarleyBoyer is another important one with ~10% improvement. Bug: v8:7703 Change-Id: Ie1edd6e216b307a1f5263b22472c0a64f76400fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690955 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#62577}
-
Andreas Haas authored
Update for a recent spec change: https://github.com/WebAssembly/reference-types/pull/38 R=binji@chromium.org Bug: v8:7581 Change-Id: I4ac4a4c351dfc100f978e1aead308cbed59149e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690832Reviewed-by: Ben Smith <binji@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#62576}
-