- 09 Aug, 2016 1 commit
-
-
yangguo authored
BUG=v8:5265 Review-Url: https://codereview.chromium.org/2218873002 Cr-Commit-Position: refs/heads/master@{#38482}
-
- 28 Jun, 2016 1 commit
-
-
yangguo authored
Removing a bad test case because: - The test case makes wrong assumptions about compilation. We now may run bytecode with the interpreter. - The test exposes internal implementation details such as pc offset of JIT code. - The test uses a runtime function specially written to cater to, and used only by this test. Being unmaintained, this runtime function is already returning bogus results, making this test useless. R=jgruber@chromium.org Review-Url: https://codereview.chromium.org/2101223002 Cr-Commit-Position: refs/heads/master@{#37312}
-
- 03 Dec, 2015 3 commits
-
-
machenbach authored
Reland of [debugger] do not restart frames that reference new.target for liveedit. (patchset #1 id:1 of https://codereview.chromium.org/1493863004/ ) Reason for revert: Didn't help... Original issue's description: > Revert of [debugger] do not restart frames that reference new.target for liveedit. (patchset #1 id:1 of https://codereview.chromium.org/1493363002/ ) > > Reason for revert: > [Sheriff] Speculative revert for https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3225 > > Original issue's description: > > [debugger] do not restart frames that reference new.target for liveedit. > > > > R=mstarzinger@chromium.org > > > > Committed: https://crrev.com/6fca870240bdbb07a365189b5eb0c98fa65b3682 > > Cr-Commit-Position: refs/heads/master@{#32572} > > TBR=mstarzinger@chromium.org,yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/1a61dab34b9849f3f70a42ce69317e22758c53a1 > Cr-Commit-Position: refs/heads/master@{#32582} TBR=mstarzinger@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1492393003 Cr-Commit-Position: refs/heads/master@{#32587}
-
machenbach authored
Revert of [debugger] do not restart frames that reference new.target for liveedit. (patchset #1 id:1 of https://codereview.chromium.org/1493363002/ ) Reason for revert: [Sheriff] Speculative revert for https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3225 Original issue's description: > [debugger] do not restart frames that reference new.target for liveedit. > > R=mstarzinger@chromium.org > > Committed: https://crrev.com/6fca870240bdbb07a365189b5eb0c98fa65b3682 > Cr-Commit-Position: refs/heads/master@{#32572} TBR=mstarzinger@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1493863004 Cr-Commit-Position: refs/heads/master@{#32582}
-
yangguo authored
R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1493363002 Cr-Commit-Position: refs/heads/master@{#32572}
-
- 12 Aug, 2015 1 commit
-
-
yangguo authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/1282793002 Cr-Commit-Position: refs/heads/master@{#30136}
-
- 31 Jul, 2015 1 commit
-
-
yangguo authored
R=cbruni@chromium.org Review URL: https://codereview.chromium.org/1265923002 Cr-Commit-Position: refs/heads/master@{#29951}
-
- 23 Jul, 2015 1 commit
-
-
yurys authored
There is already non-throwing version FrameMirror.restart and RestartFrame in the livedit-debugger.js just adds a throwing wrapper around it. Also NEEDS_STEP_IN_PROPERTY_NAME was removed, the client code can decide based on the stack_modified field if "step in" is required. Chromium side was fixed in https://codereview.chromium.org/1249013002/ BUG=None LOG=N Review URL: https://codereview.chromium.org/1247363002 Cr-Commit-Position: refs/heads/master@{#29797}
-
- 10 Dec, 2014 1 commit
-
-
yangguo authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/789163002 Cr-Commit-Position: refs/heads/master@{#25748}
-
- 22 May, 2014 1 commit
-
-
yangguo@chromium.org authored
The change relative to the previous CL is a logic change in DropActivationsInActiveThreadImpl. The previous CL skipped the matcher unless the frame was a JS frame; this was correct for MultipleFunctionTarget but not for SingleFrameTarget. I have not been able to reproduce the original failures on either architecture (ia32 or x64; stack frame dropping is unsupported on other architectures). R=yangguo@chromium.org LOG=N TEST=mjsunit/harmony/generators-debug-liveedit.js BUG= Review URL: https://codereview.chromium.org/270283002 Patch from Andy Wingo <wingo@igalia.com>. git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21419 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 May, 2014 2 commits
-
-
rossberg@chromium.org authored
Seems to crash some tests on buildbots. TBR=ishell@chromium.org CC=wingo@igalia.com,yangguo@chromium.org BUG= Review URL: https://codereview.chromium.org/273433002 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21178 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
wingo@igalia.com authored
R=yangguo@chromium.org LOG=N TEST=mjsunit/harmony/generators-debug-liveedit.js BUG= Review URL: https://codereview.chromium.org/266983004 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21174 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 17 Oct, 2013 1 commit
-
-
yangguo@chromium.org authored
Nobody should need to use $NaN, 0/0, 1/0 and void 0. R=mvstanton@chromium.org BUG= Review URL: https://codereview.chromium.org/27491002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17252 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 20 Sep, 2013 1 commit
-
-
prybin@chromium.org authored
BUG=v8:2872 R=yangguo@chromium.org Review URL: https://codereview.chromium.org/23783007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16868 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Dec, 2012 1 commit
-
-
peter.rybin@gmail.com authored
Review URL: https://codereview.chromium.org/11421100 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13123 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Jun, 2012 1 commit
-
-
peter.rybin@gmail.com authored
Review URL: https://chromiumcodereview.appspot.com/10544151 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11836 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 25 Apr, 2012 1 commit
-
-
peter.rybin@gmail.com authored
Review URL: https://chromiumcodereview.appspot.com/10185006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11439 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Jan, 2012 1 commit
-
-
erik.corry@gmail.com authored
Review URL: http://codereview.chromium.org/9231009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10407 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Nov, 2011 1 commit
-
-
lrn@chromium.org authored
Multiline conditionals must use braces. Semicolons are not optional. Review URL: http://codereview.chromium.org/8701006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@10074 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Jun, 2011 2 commits
-
-
mikhail.naganov@gmail.com authored
Breaks compilation on Linux. This reverts commit e72c5b1d69fb2cb2d5973f172666dd5d477e6f7e. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8154 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/7080029 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8149 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Jan, 2011 1 commit
-
-
peter.rybin@gmail.com authored
BUG=1013 TEST= Review URL: http://codereview.chromium.org/6017008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6274 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Dec, 2010 1 commit
-
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/5961011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6118 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 07 Dec, 2010 3 commits
-
-
kasperl@chromium.org authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5922 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
kasperl@chromium.org authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5921 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
kasperl@chromium.org authored
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5920 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Oct, 2010 1 commit
-
-
ricow@chromium.org authored
This is a cosmetic change only. Review URL: http://codereview.chromium.org/3797009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5630 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 12 Aug, 2010 1 commit
-
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/3131008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5255 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Jul, 2010 1 commit
-
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/2883020 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5015 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Apr, 2010 2 commits
-
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/1697016 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4539 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/1800007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4533 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Apr, 2010 1 commit
-
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/1672006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4467 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 19 Apr, 2010 1 commit
-
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/1652008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4441 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Apr, 2010 2 commits
-
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/1589036 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4420 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/1549041 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4419 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Apr, 2010 1 commit
-
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/1090003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4359 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 06 Apr, 2010 1 commit
-
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/1118007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4351 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 02 Apr, 2010 1 commit
-
-
peter.rybin@gmail.com authored
Review URL: http://codereview.chromium.org/1584008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4338 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 30 Mar, 2010 1 commit
-
-
kmillikin@chromium.org authored
Removed trailing whitespace using regexp replace. No other changes. Review URL: http://codereview.chromium.org/1559006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4314 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-