- 23 Oct, 2019 13 commits
-
-
Jakob Gruber authored
Bug: v8:9695 Change-Id: I401a18c84a9ec1af7e14f44004a0788cbfd4a34b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864657Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#64501}
-
Igor Sheludko authored
The CL refactors the following builtins: String.prototype.startsWith String.prototype.endsWith to use ClampToIndexRange(x, len) instead of NumberMin(NumberMax(x, 0), len). Bug: v8:8996 Change-Id: I20ab42088168e517840385cc2db435361004d9c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873702 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#64500}
-
Mu Tao authored
Port 26afd8f3 Change-Id: I4033e6bb50166d59679dddd8ba0480b4bc4b821d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1874969 Commit-Queue: Mu Tao <pamilty@gmail.com> Auto-Submit: Mu Tao <pamilty@gmail.com> Reviewed-by:
-
Clemens Backes authored
The same change on the {CopyChars} function gave an unexpected 10-20% speedup on microbenchmarks across platforms (ia32, x64, Atom_x64). This CL explores whether a similar change generally speeds up {MemCopy} and {MemMove} (only on x64 for now). If this is the case, we might be able to carefully extend the same pattern to other platforms and remove custom assembly implementations without too much regression. R=leszeks@chromium.org Bug: v8:9810 Change-Id: Ib9674807b67cd2a463680b97a91ae1b41c3be65b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871607Reviewed-by:Leszek Swirski <leszeks@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64498}
-
Mu Tao authored
Port 434f9681 Change-Id: I9e9cb8b9ca56d5af3b5ffffa5908501c9214752d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1874968 Commit-Queue: Mu Tao <pamilty@gmail.com> Auto-Submit: Mu Tao <pamilty@gmail.com> Reviewed-by:
-
Jakob Gruber authored
These counters track how often the slow path of these two builtins is hit. Exec is very permissive, its fast-path check doesn't look at the regexp prototype at all. Replace is strict; any change on the prototype will trigger the slow path. Chromium CL: https://crrev.com/c/1875250 Bug: v8:5577 Change-Id: I9807f43829981445b75b5c5d29800cbdac9bc26a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873698Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#64496}
-
Z Nguyen-Huu authored
RegExpPrototypeExecBody, RegExpPrototypeExecBodyWithoutResultFast Bug: v8:8976 Change-Id: I79f4d3e27baf5ff7aec9538fa463d810dbb75e4e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866957 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Simon Zünd authored
This CL integrates the "v8_nosnapshot" source set into the "mksnapshot" binary. The "mksnapshot" binary is the last use-site after unconditionally enabling snapshot and embedded builtins. Bug: v8:8519 Change-Id: I8e737e10a3f7729e18ac71733b811bf399ebf330 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873685Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#64494}
-
Gus Caplan authored
Bug: v8:9891 Change-Id: I5a9600b44c2363cc9681976e4ed2b86eccf35830 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1869581 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Mu Tao authored
Port a0b95232 R=xwafish@gmail.com Change-Id: I15c385a676e574f36d8c25c6f6294ac344b0af43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868557Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
Mu Tao authored
Port afbbfcbe R=xwafish@gmail.com Change-Id: Iab3a9f32d8bccddcdca8d9a874869e62ae961948 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868558 Auto-Submit: Mu Tao <pamilty@gmail.com> Reviewed-by:
-
Mu Tao authored
Port 0089006f Original Commit Message: .. similar to how it is applied in the interpreter. We reserve a stack slot for the backtrack count, increment it on each backtrack, and fail if the limit is hit. Change-Id: I51879e6cafb3c77d635fc6e84e7e2c5ce3a088e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873445 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/996a3e8..e9c43f1 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0388283..9f6271e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/53f9e09..db1e79c Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/5005010..b51014b Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/c5d85f1..aa07e59 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I52086f4e4c1226e0555dd912b89473e1448cddd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1874828Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#64489}
-
- 22 Oct, 2019 27 commits
-
-
Ng Zhi An authored
Bug: v8:9813 Change-Id: Idee4daded322731648fe51e75f3b9e8be2dcd0d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872929Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#64488}
-
Ng Zhi An authored
This is a reland of 08b26f53 Fixed the original crash, by removing a disasm for psllq and psrlq that is now handled by the macro list. Original change's description: > Clean up macros > > Move some instruction definitions into sse-instr, which is used to > generate some disasm tests, so we can remove some cases there. > > Bug: v8:9810 > Change-Id: I0615ec823396da08bc5d234cf1dabca6afd3f052 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866965 > Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> > Commit-Queue: Zhi An Ng <zhin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64441} Bug: v8:9810 Change-Id: I69335a889f5f72b76a79e4e9860835232e6e38a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872298Reviewed-by:
-
Mu Tao authored
Port 3cad6bf5 Original Commit Message: This is a reland of c7c47c68. This makes TSAN happy in addition to: Previously I presumed that the context read from a frame in the profiler was a valid context. Turns out that on non-intel we're not guaranteed that the frame is properly set up. In the case we looked at, the profiler took a sample right before writing the frame marker indicating a builtin frame, causing the "context" pointer from that frame to be a bytecode array. Since we'll read random garbage on the stack as a possible context pointer, I made the code reading the native context from it a little more defensive. Bug: v8:9860 Tbr: ulan@chromium.org, neis@chromium.org, ishell@chromium.org Original change's description: > [runtime] Move Context::native_context to the map > > Remove the native context slot from contexts by making context maps > native-context-specific. Now we require 2 loads to go from a context to the > native context, but we have 1 field fewer to store when creating contexts. > > Change-Id: I3c0d7c50c94060c4129db684f46a567de6f30e8d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1859629 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64296} R=xwafish@gmail.com Change-Id: I6496a8c5be8cbabf48cddc2d59111410f31eb75f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868774 Auto-Submit: Mu Tao <pamilty@gmail.com> Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#64486}
-
Milad Farazmand authored
Port 434f9681 R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I2b374de4d50022e88b240dbad5eddcab8cfe9547 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1874085Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
Adam Klein authored
Remove inactive contributors (cira and mnita) and add ftang and jshin. Change-Id: Ibd1e4f11553b78e1cd938a7ce8958fe5341829d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872540Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#64484}
-
Gus Caplan authored
Change-Id: Iee27a99a9627d73e10c4c85c31d07a5204808259 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864574 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#64483}
-
Andreas Haas authored
Otherwise the value cannot be used in gtests in EXPECT_GT expressions. The reason is that EXPECT_GT takes values by reference and not by value, so the declaration in v8.h is not enough. R=clemensb@chromium.org Bug: v8:9810 Change-Id: I6f85024d483701fcc65d1ccfc5254dbdbcce16c1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871606Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#64482}
-
Ng Zhi An authored
Bug: v8:9813 Change-Id: Ib78d7506fa8c8b755a8e1feccc5d948834ddc3a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873106Reviewed-by:
-
Gus Caplan authored
Change-Id: I97ccbb29f9d4d92bb2ac20402ff8240632533989 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864572 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The new predicate indicates whether the backing store was created for an ArrayBuffer or a SharedArrayBuffer. It is useful for some embedders. Bug: v8:9380 Change-Id: I804063bb8c4c17815defd6538ce6a1b32f6a4531 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873689 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#64479}
-
Liviu Rau authored
Bug: v8:9503 Change-Id: I6434685459a6b5a935a3a3598a3827959590b9e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864652Reviewed-by:
-
Victor Gomes authored
Original change's description: > [runtime] Remove extension slots from context objects > > Context objects have an extension slot, which contains further > additional data that depends on the type of the context. > > This CL removes the extension slot from contexts that don't need > them, hence reducing memory. > > The following contexts will still have an extension slot: native, > module, await, block and with contexts. See objects/contexts.h for > what the slot is used for. > The following contexts will not have an extension slot anymore (they > were not used before): script, catch and builtin contexts. > Eval and function contexts only have the extension slot if they > contain a sloppy eval. > > Bug: v8:9744 > Change-Id: I8ca56c22fa02437bbac392ea72174ebfca80e030 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863191 > Commit-Queue: Victor Gomes <victorgomes@google.com> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Auto-Submit: Victor Gomes <victorgomes@google.com> > Cr-Commit-Position: refs/heads/master@{#64372} TBR=verwaest@chromium.org,jgruber@chromium.org,ulan@chromium.org,leszeks@chromium.org,petermarshall@chromium.org Bug: v8:9744 Change-Id: I8700ed2fa62c89e86c39bb16ac3167f38ea8d63f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873695 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Hans Wennborg authored
I was just driving by and noticed these unnecessary includes. Bug: none Change-Id: I071ce08ef8a52cdeda997047ff7d9a5f47c5ba10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872394 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:4153 Change-Id: Icd346fae1dea9e56527b8669ace1aa6cfd46e87a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872393 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64475}
-
Joshua Litt authored
Currently, RegExpResult builds match indices lazily using data stored in hidden internal fields on the result object itself. Unfortunately, if an internal field is deleted, it can cause these hidden fields to migrate to a dictionary, making indexed lookup unsafe. This CL forces slow but safe lookup for these fields when lazily building indices. Bug: v8:9548, chromium:1013133 Change-Id: Ide87d9ca6a73644ced3de8e35ecac26330d365e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1871756Reviewed-by:
-
Milad Farazmand authored
Port 0089006f Original Commit Message: .. similar to how it is applied in the interpreter. We reserve a stack slot for the backtrack count, increment it on each backtrack, and fail if the limit is hit. R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ic0c0f8569b2c2596976136d96971e7fa39f9e145 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872430Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#64473}
-
Thibaud Michaud authored
R=mstarzinger@chromium.org Bug: v8:6672 Change-Id: Id8a53f6f74fa05150469c35ceba9470e75363637 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1847156Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
We should be encountering this due to TaggedEquality. DecompressionElimination used to take care of this, but it will not be present in the new system. Bug: v8:7703 Change-Id: I9fe00ee116ed1514cb4c465a8d19df6e785ef913 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1868623Reviewed-by:
-
Simon Zünd authored
This CL adds a boolean flag to Runtime.evaluate that allows REPL mode to be enabled. REPL mode hasn't landed in V8 yet, and the internal API for it is still in flux. R=yangguo@chromium.org Bug: chromium:1004193 Change-Id: I281285e225d3fd2dd4175f3dd967d6562459a203 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1866510Reviewed-by:
-
Nico Hartmann authored
Bug: chromium:1016450 Change-Id: I4801b5ffb0ebea92067aa5de37e11a4e75dcd3c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873692Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#64469}
-
Nico Hartmann authored
BigInt performance benchmarks are restructured in JSTest1.json in such a way that it is easier to run meaningful subsets of BigInt test cases. Bug: v8:9213 Change-Id: Ibf94bfb0f14cf8afa890927d97f920659e8b28d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872390 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Jakob Gruber authored
The new regexp_backtracks / V8.RegExpBacktracks counter tracks the number of backtracks performed per regexp execution. The results can help us prioritize related work. Note that we only count backtracks in the interpreter. Jitted code is ignored. With our current regexp tiering strategy, that means we count backtracks only in the first execution of each regexp. Chromium CL: https://crrev.com/c/1871601 Bug: v8:9892 Change-Id: I19146d6e9bc2355f210a050e93dd7e856ab066f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873696 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Georg Neis authored
Instead of logging when SFI inlineability is computed, log when that result is actually used. Moreover, log something in some cases where we logged nothing so far (e.g. when we can't inline due to missing feedback vector). Change-Id: Id93119f4ead17aa9e721eb4fcc20774c54178665 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873693Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#64466}
-
Thibaud Michaud authored
Block inputs are removed from the stack. Set expected stack height accordingly. R=ahaas@chromium.org Bug: v8:9867 Change-Id: I7e3fd2985c0e77e83d5551cac613788f3cf0a370 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872404 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Simon Zünd authored
Embedded builtins are now unconditionally enabled, which removes the need to differentiate between enabled/disabled embedded builtins. This Cl removes the 'embedded_builtins' variant and related *.status entries. R=machenbach@chromium.org Bug: v8:8519 Change-Id: I55d0dd54735b7cc437832af6fa2836fd6c14a317 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864936 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Igor Sheludko authored
... and refactor String.prototype.substring. This is done to simplify cleaning up callers of ConvertToRelativeIndex() in a follow-up CL. This CL also introduces Smi-overflow friendly helper function ClampToIndexRange(index: JSAny, min: uintptr, max: uintptr): uintptr which can be used in other String builtins as a better alternative to NumberMin(NumberMax(value, min), max) pattern. Bug: v8:8996, v8:4153 Change-Id: Ie1bb5ab305ebf851c033d109ffe9e6afb9418274 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1872392 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Backes authored
If a new jump table is created and lazy compilation is enabled, we need to initialize the new jump table with jumps to the lazy compile table. R=ahaas@chromium.org Bug: chromium:1016515 Change-Id: I5749470d4a08af903a6a4da13dbe5454ee6db309 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1873687Reviewed-by:
-
