- 20 Feb, 2019 1 commit
-
-
Jeff Fisher authored
New tests added for these calls: * evaluateOnCallFrame * setAsyncCallStackDepth * setBreakpoint * setVariableValue For setAsyncCallStackDepth, this change updates the test to manufacture async callstacks in a different way so that there is more than one. The previous promise chain method was broken by f61facfd. Change-Id: I9083b0b1c08849d4c7ebb5349cfa4489f551aa39 Reviewed-on: https://chromium-review.googlesource.com/c/1465118 Commit-Queue: Jeff Fisher <jeffish@microsoft.com> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#59745}
-
- 19 May, 2017 1 commit
-
-
dgozman authored
This refactoring makes it easier to write advanced tests and gives full control over what's happening to the test code. It also forces description for every test. BUG=none Review-Url: https://codereview.chromium.org/2891213002 Cr-Commit-Position: refs/heads/master@{#45412}
-
- 11 May, 2017 1 commit
-
-
kozyatinskiy authored
Creation stack trace points to the place where callback was actually chained, scheduled points where parent promise was resolved. For async tasks without creation stack (e.g. setTimeout) we continue to use scheduled as creation since usually they are the same. BUG=v8:6189 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2868493002 Cr-Original-Commit-Position: refs/heads/master@{#45198} Committed: https://chromium.googlesource.com/v8/v8/+/e118462f18a862df81a04486e13dd62997cbfc5a Review-Url: https://codereview.chromium.org/2868493002 Cr-Commit-Position: refs/heads/master@{#45266}
-
- 10 May, 2017 1 commit
-
-
kozyatinskiy authored
Revert of [inspector] use creation stack trace as parent for async call chains (patchset #2 id:20001 of https://codereview.chromium.org/2868493002/ ) Reason for revert: CHECK is too strict. Original issue's description: > [inspector] use creation stack trace as parent for async call chains > > Creation stack trace points to the place where callback was actually chained, scheduled points where parent promise was resolved. > For async tasks without creation stack (e.g. setTimeout) we continue to use scheduled as creation since usually they are the same. > > BUG=v8:6189 > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2868493002 > Cr-Commit-Position: refs/heads/master@{#45198} > Committed: https://chromium.googlesource.com/v8/v8/+/e118462f18a862df81a04486e13dd62997cbfc5a TBR=dgozman@chromium.org,alexclarke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:6189 Review-Url: https://codereview.chromium.org/2868423004 Cr-Commit-Position: refs/heads/master@{#45242}
-
- 09 May, 2017 1 commit
-
-
kozyatinskiy authored
Creation stack trace points to the place where callback was actually chained, scheduled points where parent promise was resolved. For async tasks without creation stack (e.g. setTimeout) we continue to use scheduled as creation since usually they are the same. BUG=v8:6189 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2868493002 Cr-Commit-Position: refs/heads/master@{#45198}
-
- 18 Apr, 2017 3 commits
-
-
kozyatinskiy authored
- separated V8StackTraceImpl and AsyncStackTrace, - V8Debugger owns all AsyncStackTrace and cleanup half of them when limit is reached (first created - first cleaned), - V8StackTraceImpl, AsyncStackTrace and async-task-related tables in V8Debugger have weak reference to other async stack traces. - async tasks are cleared with related async stacks. BUG=v8:6189 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2816043006 Cr-Original-Commit-Position: refs/heads/master@{#44670} Committed: https://chromium.googlesource.com/v8/v8/+/1bca73bc832c645138bd3e0306fcaa8bb44dad04 Review-Url: https://codereview.chromium.org/2816043006 Cr-Commit-Position: refs/heads/master@{#44694}
-
machenbach authored
Revert of [inspector] avoid cloning of async call chains (patchset #7 id:120001 of https://codereview.chromium.org/2816043006/ ) Reason for revert: Speculative revert. Seems to block the roll: https://codereview.chromium.org/2822983004/ Might require changing a browser test first? Original issue's description: > [inspector] avoid cloning of async call chains > > - separated V8StackTraceImpl and AsyncStackTrace, > - V8Debugger owns all AsyncStackTrace and cleanup half of them when limit is reached (first created - first cleaned), > - V8StackTraceImpl, AsyncStackTrace and async-task-related tables in V8Debugger have weak reference to other async stack traces. > - async tasks are cleared with related async stacks. > > BUG=v8:6189 > R=dgozman@chromium.org > > Review-Url: https://codereview.chromium.org/2816043006 > Cr-Commit-Position: refs/heads/master@{#44670} > Committed: https://chromium.googlesource.com/v8/v8/+/1bca73bc832c645138bd3e0306fcaa8bb44dad04 TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6189 Review-Url: https://codereview.chromium.org/2825713002 Cr-Commit-Position: refs/heads/master@{#44678}
-
kozyatinskiy authored
- separated V8StackTraceImpl and AsyncStackTrace, - V8Debugger owns all AsyncStackTrace and cleanup half of them when limit is reached (first created - first cleaned), - V8StackTraceImpl, AsyncStackTrace and async-task-related tables in V8Debugger have weak reference to other async stack traces. - async tasks are cleared with related async stacks. BUG=v8:6189 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2816043006 Cr-Commit-Position: refs/heads/master@{#44670}
-