- 22 Apr, 2016 5 commits
-
-
neis authored
The new bytecodes replace two runtime functions. They are still unsupported by the bytecode graphbuilder, though. BUG=v8:4907 LOG=n Review URL: https://codereview.chromium.org/1904933002 Cr-Commit-Position: refs/heads/master@{#35716}
-
jkummerow authored
This is a follow-up to 58429beb "Fix KeyedStore stub selection for STRING_WRAPPER_ELEMENTS". BUG=chromium:602184 LOG=n Review URL: https://codereview.chromium.org/1912443004 Cr-Commit-Position: refs/heads/master@{#35715}
-
adamk authored
The feature was deprecated in M49 and flagged off in M50. This patch removes it entirely from the codebase. Review URL: https://codereview.chromium.org/1909433003 Cr-Commit-Position: refs/heads/master@{#35714}
-
bmeurer authored
If we have to convert a float64 value to tagged representation and we already know that the value is either in Signed31/Signed32 or Unsigned32 range, then we can just convert the float64 to word32 and use the fast word32 to tagged conversion. Doing this in ChangeLowering (or the effect linearization pass) would be unsound, as the types on the nodes are no longer usable. This removes all Type uses from effect linearization. There's still some work to be done for ChangeLowering tho. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1908093002 Cr-Commit-Position: refs/heads/master@{#35713}
-
yangguo authored
This is pretty useful when debugging. There is no easy way to find the bytecode arrays on the stack. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1909663005 Cr-Commit-Position: refs/heads/master@{#35712}
-
- 21 Apr, 2016 32 commits
-
-
mtrofin authored
GetInstructionBlock shows up in some compile time-intensive profiles. Changing it to a O(1) operation. The compile benchmark confirms the improvement. BUG= Review URL: https://codereview.chromium.org/1896813003 Cr-Commit-Position: refs/heads/master@{#35711}
-
mstarzinger authored
R=machenbach@chromium.org Review URL: https://codereview.chromium.org/1908503003 Cr-Commit-Position: refs/heads/master@{#35710}
-
baptiste.afsa authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/1897213003 Cr-Commit-Position: refs/heads/master@{#35709}
-
nikolaos authored
This patch introduces new scopes in the preparser, just like they are introduced by the parser, in the following places: - blocks - try statement - switch statement - scoped statements, in several places - for statement - eager function bodies R=rossberg@chromium.org BUG= LOG=N Review URL: https://codereview.chromium.org/1906793002 Cr-Commit-Position: refs/heads/master@{#35708}
-
bmeurer authored
This way the first scheduler can properly wire them to the effect chain, as otherwise the second scheduler could schedule them such that they would be able to read uninitialized memory (once we drop the region protection in the first scheduler). R=jarin@chromium.org Review URL: https://codereview.chromium.org/1908963002 Cr-Commit-Position: refs/heads/master@{#35707}
-
jkummerow authored
Non-vectorized KeyedLoadICs used to remember whether they had seen Names as keys; Crankshaft uses this information to avoid emitting elements accesses which would always deopt. This CL restores that functionality for vector ICs. BUG=chromium:594183 LOG=y R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1912593002 Cr-Commit-Position: refs/heads/master@{#35706}
-
mstarzinger authored
This removes the CompilationInfo argument from one of the logging functions where it is unused. The long-term goal is to not pass around the CompilationInfo at all. The assumption that the CompilationInfo is available is incompatible with serialized code, where compilation has happened during building time of V8 itself. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1901353003 Cr-Commit-Position: refs/heads/master@{#35705}
-
yangguo authored
BUG=v8:4690 LOG=N Review URL: https://codereview.chromium.org/1907973002 Cr-Commit-Position: refs/heads/master@{#35704}
-
Ilija.Pavlovic authored
Fix for execution tests on simulator. Port 3518e492 Original commit message: Short external strings do not cache the resource data, and may be used for compressible strings. The assumptions about their lengths is invalid and may lead to oob reads. BUG= Review URL: https://codereview.chromium.org/1904033003 Cr-Commit-Position: refs/heads/master@{#35703}
-
bmeurer authored
The JavaScript pipeline now consists of the following steps: 1. Typed lowering. 2. Representation selection (actually SimplifiedLowering). 3. Early optimization pass (incl. JSGenericLowering). 4. Effect control linearization (not for asm.js). 5. Late optimization pass (incl. ChangeLowering). 6. Real scheduling. We should further cleanup the passes and restrict type and representation information usage to appropriate parts of the pipeline. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1907963002 Cr-Commit-Position: refs/heads/master@{#35702}
-
yangguo authored
R=vogelheim@chromium.org BUG=v8:4690 LOG=N Review URL: https://codereview.chromium.org/1910813002 Cr-Commit-Position: refs/heads/master@{#35701}
-
bmeurer authored
This operator doesn't generate any actual code, but teaches the register allocator that a certain computed pointer value is tagged. This is required to safely implement InnerAllocate (and we also use this for Allocate to be sure that we don't suddenly leak a dangling pointer into the heap somewhere). R=epertoso@chromium.org BUG=v8:4939 LOG=n Review URL: https://codereview.chromium.org/1905813003 Cr-Commit-Position: refs/heads/master@{#35700}
-
verwaest authored
BUG= Review URL: https://codereview.chromium.org/1912553002 Cr-Commit-Position: refs/heads/master@{#35699}
-
titzer authored
R=jfb@chromium.org,rossberg@chromium.org BUG= Review URL: https://codereview.chromium.org/1900153002 Cr-Commit-Position: refs/heads/master@{#35698}
-
verwaest authored
BUG=chromium:605060 LOG=n Review URL: https://codereview.chromium.org/1907953002 Cr-Commit-Position: refs/heads/master@{#35697}
-
epertoso authored
Adds a Generate method to the stubs that can be used to embed the graph directly in the bytecode handlers. Review URL: https://codereview.chromium.org/1902823002 Cr-Commit-Position: refs/heads/master@{#35696}
-
titzer authored
R=bradnelson@chromium.org,aseemgarg@chromium.org BUG= Review URL: https://codereview.chromium.org/1909513002 Cr-Commit-Position: refs/heads/master@{#35695}
-
mstarzinger authored
This check whether a function is being debugged is obsolete. For the optimization path it is covered by a bailout further down. The lookup within the optimized code map doesn't need to be covered, because that map is guaranteed to stay empty while break slots are present. R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1907923003 Cr-Commit-Position: refs/heads/master@{#35694}
-
ishell authored
[deoptimizer] Do not modify stack_fp which is used as a key for lookup of previously materialized objects. BUG=chromium:604680, v8:4698 LOG=N Review URL: https://codereview.chromium.org/1904663003 Cr-Commit-Position: refs/heads/master@{#35693}
-
jochen authored
BUG=v8:4933 R=verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1899283003 Cr-Commit-Position: refs/heads/master@{#35692}
-
clemensh authored
Since traps now throw real Error objects, we get stack traces containing <WASM> functions on top-level. The additional tests check for two traps: unreachable and memory out-of-bounds. R=ahaas@chromium.org, jfb@chromium.org, titzer@chromium.org BUG= Review URL: https://codereview.chromium.org/1878563003 Cr-Commit-Position: refs/heads/master@{#35691}
-
v8-autoroll authored
Rolling v8/buildtools to e84114dbe2b65428951c876349b6a3ff1afbfccd Rolling v8/tools/clang to 2956eca572ff0e1b181df65f71a045f061a2eb34 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review URL: https://codereview.chromium.org/1909483004 Cr-Commit-Position: refs/heads/master@{#35690}
-
zhengxing.li authored
The CL #35651 (https://codereview.chromium.org/1858323003) exposed one hiden issue in RunTruncateFloat32ToUint32 test cases and X87 failed at it. Here is the issue in RunTruncateFloat32ToUint32: For float input = static_cast<float>(*i), the x87 GCC would optimize the input viariable in float floating register for release build. The problem is: SSE float register has single precision rounding semantic While X87 register hasn't when directly use floating register value. It will cause the value of input viariable has different precision for IA32 and X87 port. So static_cast<uint32_t>(input) will be different for IA32 and X87 port too. This led to CHECK_EQ(static_cast<uint32_t>(input), m.Call(input)) fail although V8 turbofan JITTed code m.Call(input) has exactly same result in both X87 and IA32 port. So we add the following sentence to do type cast to keep the single precision for RunTruncateFloat32ToUint32 by forcing the input viariable get value from memory insread of floating register. Such as: volatile float input = static_cast<float>(*i). BUG= Review URL: https://codereview.chromium.org/1905883002 Cr-Commit-Position: refs/heads/master@{#35689}
-
machenbach authored
BUG=v8:4928 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1903043006 Cr-Commit-Position: refs/heads/master@{#35688}
-
clemensh authored
This extends the wasm test case which only checks the "simple" string-variant of the stack trace. It checks the return values of the getFunctionName, getLineNumber, getFileName and toString methods. R=machenbach@chromium.org, jfb@chromium.org, titzer@chromium.org Review URL: https://codereview.chromium.org/1875153002 Cr-Commit-Position: refs/heads/master@{#35687}
-
machenbach authored
The external snapshot target is missing a few build dependencies. TBR=vogelheim@chromium.org, yangguo@chromium.org, clemensh@chromium.org Review URL: https://codereview.chromium.org/1904013002 Cr-Commit-Position: refs/heads/master@{#35686}
-
ahaas authored
This patch provides a new implementation of popcnt and ctz in the case where the platform does not provide these instructions. Instead of building a TF graph which implements it we now call a C function. Additionally I turned on additional tests in test-run-wasm-64.cc R=titzer@chromium.org Review URL: https://codereview.chromium.org/1857363003 Cr-Commit-Position: refs/heads/master@{#35685}
-
danno authored
Move allocation-related and smi un/tagging methods into CodeStubAssembler. Review URL: https://codereview.chromium.org/1893383002 Cr-Commit-Position: refs/heads/master@{#35684}
-
yangguo authored
Port 3518e492 Original commit message: Short external strings do not cache the resource data, and may be used for compressible strings. The assumptions about their lengths is invalid and may lead to oob reads. R=bmeurer@chromium.org BUG=v8:4923,chromium:604897 LOG=N Review URL: https://codereview.chromium.org/1902393004 Cr-Commit-Position: refs/heads/master@{#35683}
-
jyan authored
Port 3518e492 Original commit message: Short external strings do not cache the resource data, and may be used for compressible strings. The assumptions about their lengths is invalid and may lead to oob reads. R=yangguo@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4923,chromium:604897 LOG=N Review URL: https://codereview.chromium.org/1911633002 Cr-Commit-Position: refs/heads/master@{#35682}
-
zhengxing.li authored
port 3518e492 (r35660) original commit message: Short external strings do not cache the resource data, and may be used for compressible strings. The assumptions about their lengths is invalid and may lead to oob reads. BUG= Review URL: https://codereview.chromium.org/1904003003 Cr-Commit-Position: refs/heads/master@{#35681}
-
bradnelson authored
BUG= https://code.google.com/p/v8/issues/detail?id=4203 BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=575167 TEST=None R=ahaas@chromium.org,isherman@chromium.org LOG=N Review URL: https://codereview.chromium.org/1895223004 Cr-Commit-Position: refs/heads/master@{#35680}
-
- 20 Apr, 2016 3 commits
-
-
rmcilroy authored
BUG=v8:4681 LOG=N Review URL: https://codereview.chromium.org/1894073007 Cr-Commit-Position: refs/heads/master@{#35679}
-
adamk authored
Our previous over-conservative answer caused us to emit hole checks in full-codegen when eagerly parsing but not when lazily parsing. With this patch, we use the positions of the BinaryOperations making up the parameter list (which are the positions of the commas) to determine the appropriate "end position" for each parameter's initializer. This means that we get accurate-enough positions for the initializers in the eager parsing step to get the same answers for hole-check-elimination that we will later during ParseLazy. In the included test case, for example: (function() { ((s = 17, y = s) => s)(); } )(); ^2 ^1 The old code would generate a hole check when trying to load |s| for assignment to |y| (because it treated the closing parentheses pointed to by "^1" as the "initialization position" of |s|). The new code uses the comma pointed to by "^2" as the initialization position of |s|. Since that occurs textually before the load of |s|, full-codegen knows it can avoid the hole check. BUG=v8:4908 LOG=n Review URL: https://codereview.chromium.org/1900343002 Cr-Commit-Position: refs/heads/master@{#35678}
-
jyan authored
Port 81a1530e Original commit message: Before frame elision, we finalized the frame shape when assembling the prologue, which is also when we prepared the frame (saving sp, etc). The frame finalization only needs to happen once, and happens to be actually a set of idempotent operations. With frame elision, the logic for frame finalization was happening every time we constructed the frame. Albeit idempotent operations, the code would become hard to maintain. This change separates frame shape finalization from frame construction. When constructing the CodeGenerator, we finalize the frame. Subsequent access is to a const Frame*. Also renamed AssemblePrologue to AssembleConstructFrame, as suggested in the frame elision CR. Separating frame setup gave the opportunity to do away with architecture-independent frame aligning (which is something just arm64 cares about), and also with stack pointer setup (also arm64). Both of these happen now at frame finalization on arm64. R=mtrofin@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review URL: https://codereview.chromium.org/1903403002 Cr-Commit-Position: refs/heads/master@{#35677}
-