1. 06 Dec, 2018 1 commit
    • tzik's avatar
      Replace %RunMicrotasks with %PerformMicrotaskCheckpoint · 07011cc4
      tzik authored
      This replaces Runtime_RunMicrotasks with Runtime_PerformMicrotaskCheckpoint.
      
      RunMicrotasks forcibly runs Microtasks even when the microtasks are suppressed,
      and may causes nested Microtasks in a problematic way. E.g. that confuses
      v8::MicrotasksScope::IsRunningMicrotasks() and GetEnteredOrMicrotaskContext().
      
      OTOH, PerformMicrotaskCheckpoint() doesn't run cause the failure as it
      respects the microtask suppressions.
      
      As all existing tests don't call RunMicrotasks() in the suppressed situation
      (like Promise.resolve().then(()=>{%RunMicrotasks();})), this change should
      not affect to these tests.
      
      Change-Id: Ib043a0cc8e482e022d375084d65ea98a6f54ef3d
      Reviewed-on: https://chromium-review.googlesource.com/c/1360095Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#58068}
      07011cc4
  2. 25 Jul, 2017 1 commit
  3. 14 Feb, 2017 1 commit
  4. 10 Jan, 2017 1 commit
  5. 03 Jan, 2017 1 commit
    • caitp's avatar
      [cleanup] remove sloppy generator/async function maps · c5234747
      caitp authored
      These maps contain exactly the same information as the strict maps, so
      this frees up a few pointers of native context space, gets rid of some
      branches in FastNewClosure, and adds missing poisoned properties tests
      for async functions.
      
      BUG=v8:2355, v8:4483
      R=adamk@chromium.org, bmeurer@chromium.org, littledan@chromium.org
      
      Review-Url: https://codereview.chromium.org/2608333002
      Cr-Commit-Position: refs/heads/master@{#42051}
      c5234747
  6. 18 Aug, 2016 1 commit
  7. 17 Aug, 2016 1 commit
    • neis's avatar
      [interpreter] Don't assume generator functions do an initial yield. · 7fe4d930
      neis authored
      Async functions are implemented via special generator functions; special in the
      sense that they generally do not immediately yield.  However, our generators
      implementation still assumed that every generator function initially yields
      (concretely: before doing the state dispatch in a loop header).  This CL fixes
      that.
      
      R=littledan@chromium.org, rmcilroy@chromium.org
      BUG=chromium:638019
      
      Review-Url: https://codereview.chromium.org/2253033002
      Cr-Commit-Position: refs/heads/master@{#38684}
      7fe4d930
  8. 22 Jul, 2016 1 commit
    • jwolfe's avatar
      Adjust whitespace to make tests oblivious to --harmony-function-tostring · 3cfd80d6
      jwolfe authored
      See discussion in https://codereview.chromium.org/2156303002/#msg8
      
      With the new --harmony-function-tostring behavior, these tests would
      fail without this change. This change makes the tests pass regardless
      of whether or not --harmony-function-tostring is used.
      
      All of these changes are simply inserting a space after the "function"
      keyword to match the current function toString behavior. When
      --harmony-function-tostring is enabled, the toString behavior matches
      the spacing used in the function declaration. With the declaration
      matching the current formatting, the toString behavior becomes
      unaffected by --harmony-function-tostring.
      
      BUG=v8:4958
      LOG=n
      
      Review-Url: https://codereview.chromium.org/2161413002
      Cr-Commit-Position: refs/heads/master@{#37959}
      3cfd80d6
  9. 01 Jul, 2016 1 commit
  10. 25 Jun, 2016 1 commit
  11. 31 May, 2016 1 commit
    • littledan's avatar
      [esnext] Fix various callsites to use is_resumable, not is_generator · 46253e74
      littledan authored
      Async functions are built out of generators, but the
      SharedFunctionInfo returns false for is_generator. is_resumable is
      the broader query. This patch fixes many parts of V8 to refer
      to is_resumable as appropriate.
      
      One incidental change is to remove a check for generators extending
      classes. This is part of a general check for constructors being the
      only thing which can extend classes, so it is removed here and the
      error message for the general case is made more accurate.
      
      BUG=v8:4483
      
      Review-Url: https://codereview.chromium.org/1996943002
      Cr-Commit-Position: refs/heads/master@{#36621}
      46253e74
  12. 17 May, 2016 2 commits