- 27 Dec, 2021 4 commits
-
-
Patrick Thier authored
This CL splits the TF type for JSFunction into CallableFunction and ClassConstructor. This differentiation allows us to lower calls to the CallFunction Builtin only for functions that we can actually call. Class Constructors are special, as they are callable but should raise an exception if called. By not lowering class constructors to calls to CallFunction (but the more generall Call) builtin, we can remove the checks for class constructors from CallFunction (in a follow-up CL). Bug: chromium:1262750 Change-Id: I399967eb03b2f20d2dcb67aef2243b32c9d3174e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3350457Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Patrick Thier <pthier@chromium.org> Cr-Commit-Position: refs/heads/main@{#78445}
-
Yujie Wang authored
- Add I8x16_Popcnt for WASM SIMD - Add vcpop_m and vfirst_m for riscv64 simulator Bug: v8:11976 Change-Id: I2b945bb947da0998663cac86f867f09d386b81a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3356201Reviewed-by: Yahan Lu <yahan@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#78444}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bf3630f..5396a95 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I47fe64a50a3fc9ec67308d09cce095811816aea3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3356042 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78443}
-
Lu Yahan authored
Port 7d3c3cfb Change-Id: Ic23388e6aa90e8db9af22bb582a99f7f37b9511b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3353680Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#78442}
-
- 26 Dec, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/fda7db7..bf3630f R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I1f90a475584886d38e0b494e94b342336dd3be42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3356040 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78441}
-
- 25 Dec, 2021 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/aad1379..fda7db7 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/390aa6f..1a34b98 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I2f7f5f1a398bfa69e09568250381d4c3da8f714a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3356038 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78440}
-
- 24 Dec, 2021 3 commits
-
-
Zhao Jiazhong authored
Change-Id: Ie08574da9b2192aa250e2cbc0efaf049c6e9026a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3354670Reviewed-by: Yu Liu <liuyu@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#78439}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6c6a973..aad1379 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/76c77ba..390aa6f Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/71d4e2f..d81ae2f R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I4c0fd1bfaeefc5a1ded7b74aaa567aa8f156b924 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3355306 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78438}
-
Zhao Jiazhong authored
Change-Id: I297647ebc8b8b3f854ee3297be7c674aef6fd800 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3354668Reviewed-by: Yu Liu <liuyu@loongson.cn> Commit-Queue: Yu Liu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#78437}
-
- 23 Dec, 2021 3 commits
-
-
Lu Yahan authored
Change-Id: I7e61221775a616943886cdb369eb9bbe5e110a32 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3347499Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#78436}
-
Lu Yahan authored
Change-Id: Ice5b9a09d4c4c1a8013cf5c0993c4ec6111f6c51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3353070Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#78435}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/773059e..6c6a973 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/db41eed..54c265e Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/9a32aee..71d4e2f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/a08f552..8b73305 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I75edd9ba53c5b1cc461de01eefa021e7044f0a18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3354415 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78434}
-
- 22 Dec, 2021 7 commits
-
-
Milad Fa authored
Wasm values are stored in memory in little endian order even on BE machines and as a result they need to be manually reversed after a load. Other such atomic ops get patched during Wasm compilation or during code-gen, this is one of the few places where a runtime call is made to C++ which requires this fix. As the the runtime stub is used on both TurboFan and Liftoff this patch will fix both cases. Up until now the cctest was passing incorrectly as it's mixing the Wasm memory buffer with TypedArrays. TypedArrays don't have the LE enforcement and use the native byte order. With this patch the test is now failing as expected and is being skipped for now. Bug: v8:12505 Change-Id: I49fac208f1fab7396b7d9911e803bc047b3b8263 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3350744Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#78433}
-
Benedikt Meurer authored
This updates the following set of console builtins in V8 to match the Console Standard (https://console.spec.whatwg.org) with respect to (potentially side effecting) type conversions: - console.debug - console.error - console.info - console.log - console.trace - console.warn - console.group - console.groupCollapsed - console.assert The V8 implementation only performs the type conversions and updates the arguments in-place with the results from the %String% constructor, %parseInt%, or %parseFloat% invocations. The actual formatting is still left completely to the debugger front-end. To give a concrete example, the following code ```js const msgFmt = { toString() { return 'Message %i' } }; console.log('LOG: %s`, msgFmt, 42); ``` sends the following parameters to the debugger front-end ```js ["LOG: %s", "Message %i", 42] ``` and it's then the job of the front-end to perform the actual string substitutions. It's also worth calling out that the console builtins are only concerned with %s, %f, %d, and %i formatting specifiers, since these are the only ones that trigger type conversions, and %o, %O, and %c can only be implemented in a meaningful way at a higher level. Fixed: chromium:1277944 Bug: chromium:1282076 Doc: https://bit.ly/v8-proper-console-type-conversions Spec: https://console.spec.whatwg.org Change-Id: I0996680811aa96236bd0d879e4a11101629ef1a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3352118Reviewed-by: Kim-Anh Tran <kimanh@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#78432}
-
Shu-yu Guo authored
Private method loads are compiled to a named load of a private brand, which always loads a BlockContext. This BlockContext holds the private methods common to all instances of a class. TurboFan currently considers JSLoadNamed to be of Type::NonInternal(). Private methods break this assumption, since BlockContext is of Type::OtherInternal(). This CL changes the typing of JSLoadNamed of private brands to be Type::OtherInternal(). Bug: v8:12500 Change-Id: I91f39747bf9422bd419d299f44152f567d8be8db Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3351167Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#78431}
-
Igor Sheludko authored
... in order to ease issues debugging. Bug: chromium:1241665 Change-Id: I7731a37e642acd0aef02570fb70faf0bc65495ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3353367Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#78430}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4edcc0a..773059e Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/603d9d1..2715a6c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/97da6b1..76c77ba Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/97a4675..9a32aee R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I845adc1117e177d690a3c2f8587df3369e1dcb55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3352630 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78429}
-
JianxiaoLuIntel authored
Design doc: https://docs.google.com/document/d/1rxM3sDd-ZiOLznqw7MvYraulAPWJSVqC_CztO4YpUTQ/edit Change-Id: I471ff31f32b7bdd22cb03005c1dcc18aa485ad77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3313793 Auto-Submit: Jianxiao Lu <jianxiao.lu@intel.com> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Cr-Commit-Position: refs/heads/main@{#78428}
-
Lu Yahan authored
This commit allows using unaligned load/store, which is more efficient for 2 bytes,4 bytes and 8 bytes memory access. Use RISCV_HAS_NO_UNALIGNED to control whether enable the fast path or not. Change-Id: I1d321e6e5fa5bc31541c8dbfe582881d80743483 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3329803Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#78427}
-
- 21 Dec, 2021 8 commits
-
-
Hannes Payer authored
Change-Id: I6a823ef3b65da2d1010a385db65e368fee9f31e0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3351788Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/main@{#78426}
-
Leszek Swirski authored
Straight-line bytecode with exactly one "next" bytecode (i.e. everything that can't affect control flow) will always have the same "out" liveness as the next bytecode's "in" liveness. For those cases, we can save a bit of time and memory by aliasing the pointers between the bytecode's out liveness and the next bytecode's in liveness, and skipping copying between them. This is done by specializing the current liveness update on whether this is the first pass (which will allocate and initialize the liveness bitvectors) or an update pass (which will revisit loops to collect liveness crossing over the back-edge, and propagate this liveness through the loop bodies). On the first pass, we can delay allocation of the out liveness until we know it needs to be union of multiple in livenesses, and on the update pass we can skip it if it is an alias. As a drive-by, tweak BitVector::CopyFrom to require copying from a vector with the same size (same as Union or Intersect), and move the only different sized vector use (in Resize) to be inline. Change-Id: Iad1b2e1b927a37ad925ef68e2a224152aaa2ba18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3350452 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#78425}
-
Hannes Payer authored
Change-Id: I5523f61627cab0ff0b921e51038396c642dad017 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3351784Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/main@{#78424}
-
Alexander Schulze authored
[infra] Increase timeout (1h → 2h) and bump shards (8 → 10) due to lower performance bots (8 → 4 cpus) Bug: chromium:1279426 Change-Id: I6e4d010ae57541b051529a76b11d265d34f36010 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3350579 Auto-Submit: Alexander Schulze <alexschulze@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/main@{#78423}
-
Lu Yahan authored
Port b36368d2 Change-Id: Icac5b041f2af423b2b81eab53bfc56644ca29374 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3347228Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#78422}
-
Lu Yahan authored
Bug: v8:12502 Change-Id: I8d1b599fc945e276b70901953368768594470204 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3343861Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#78421}
-
Lu Yahan authored
Change-Id: I8b19de82af5e3f856f22b6f79d81dc6aee8a3d38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3347231 Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#78420}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6353c5a..4edcc0a R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I4d36f128d348363ae57111cb6aa63d744262df70 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3349172 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78419}
-
- 20 Dec, 2021 13 commits
-
-
Clemens Backes authored
Shared array buffers are not tracked by the garbage collector, which makes the fuzzer run out of memory pretty quickly. Since shared memory is not needed any more for testing atomics, we can just make the memory non-shared again. This also improves the performance of the fuzzer (execs/s) by more than 2x locally. R=ahaas@chromium.org Bug: chromium:1281419 Change-Id: Ic7803617d6a14aaa698d9181327ec20b21d29faa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3350764Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78418}
-
Nico Weber authored
The motivation is being able to build Chrome/Mac/Intel on an Apple Silicon mac. Depends on https://chromium-review.googlesource.com/c/chromium/src/+/3348020 - Correctly set v8_snapshot_toolchain when targeting x64 on an arm64 host (always use the clang_ toolchain for now since that's all that's needed at the moment) - Check V8_HOST_ARCH in immediate-crash.h. In V8 terminology, "host" is the machine the snapshot generation runs on, while "target" is the machine that V8 runs on when it JITs. IMMEDIATE_CRASH runs on the host. Up to now, target arch x64 implied host arch x64 so the old code happened to work too, but this is the correct macro (and it makes this cross scenario work). - In assembler-x64.cc, only compile the code that probes the current CPU when running on an intel host. (There's an early return for snapshot generation anyways.) Bug: chromium:1280968 Change-Id: I4821a5994de8ed5f9e4f62184dc6ab6f5223bc3f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3348040Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#78417}
-
Nikolaos Papaspyrou authored
Report young generation GC statistics to the Recorder API. These will be used by Blink to populate UMA histograms. Existing UMA reporting in V8 remains as is for now and will be removed in a followup. With this CL, minor mark-compaction statistics are reported as part of V8.GC.Cycle.*.Young. Also V8.GCScavengeReason is migrated to V8.GC.Cycle.Reason.Young. This CL goes together with: https://chromium-review.googlesource.com/c/chromium/src/+/3320388 Bug: chromium:1154636 Change-Id: Ia1030c80d4bc75ac6e176ed60f838929ddb9b20f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3320430Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#78416}
-
Camillo Bruni authored
We clear the worker state in the worker thread after processing all messages (and getting the terminate signal). This could cause a race condition when interacting with the worker from the main thread. This was previously working and broke with https://crrev.com/c/3318669 - Add is_joined_ variable which is mutex guarded - Simplify Worker::State - Mutex guard task_runner_ access Bug: v8:12487 Change-Id: Ib53e5a1a636cb29db50efdb63526b0023a5ea768 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3345005Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#78415}
-
Clemens Backes authored
Without simple FP aliasing, a SIMD register will overlap with two floating-point registers. If we spill an FP register to use it for a SIMD operation, we need to make sure to also spill the "sibling" FP register. R=leszeks@chromium.org Bug: v8:12330, chromium:1271244 Change-Id: I7fdc6cb8da35d66b4862a8a913ba4ff906cf05aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3347576Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78414}
-
Clemens Backes authored
Initialize the (thread-local) memory protection key permissions for any isolate that joins the wasm engine. Otherwise it can happen that an isolate gets Wasm code from the cache without ever compiling anything (hence without ever changing memory protection key permissions), and then it would not be allowed to access (read or execute) the code. I tested this change manually on a PKU-enabled devices. The new test crashed before the fix, and completes successfully afterwards. R=ahaas@chromium.org Bug: v8:11974, chromium:1280451 Change-Id: I90dded8b4fdaa8cf34b44107291d3f525ce16335 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3347563Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78413}
-
Clemens Backes authored
After https://crrev.com/c/3315446 we allocate the memory protection key unconditionally, so the method is redundant. R=ahaas@chromium.org Bug: v8:11974 Change-Id: I205a0cda86dfaf394c68788a662241d76a3f8510 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3347562Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78412}
-
Clemens Backes authored
The mid-tier register allocator could not handle the case that the same virtual register was used for - the input corresponding to the 'same-as-input' output, and - another 'unique register' input. In this case, it cannot choose the already assigned register for the 'unique' register. Instead, it needs to allocate a new register and introduce a gap move to duplicate the input value in two different registers. FYI, the instruction where the current logic failed was: (v5(0), v6(R)) = IA32AddPair v7(R) v7(*) v8(R) v7(R) (where the last input was marked 'unique'). R=leszeks@chromium.org CC=thibaudm@chromium.org Bug: v8:12330, chromium:1272204 Change-Id: Ie4843aa9f5e027afe503e0481a4acdfa325dfe0e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3347821Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78411}
-
Alexander Schulze authored
Bug: chromium:1279426 Change-Id: Ia8ce4598da5f5f31fa282c9e7ff330b39caa68d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3350451 Auto-Submit: Alexander Schulze <alexschulze@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/main@{#78410}
-
Manos Koukoutos authored
If a name is defined for a wasm function, we retrieve it from the module and use it for tracing. Change-Id: I42da12d2476af573017daaa3f216cca8a95efbbb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3344646Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Cr-Commit-Position: refs/heads/main@{#78409}
-
Tamer Tas authored
R=machenbach@google.com,liviurau@google.com,alexschulze@google.com Bug: v8:12496, v8:11211 Change-Id: I58c224114ee9c7cde64ffed4ddf639244507db3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3333925 Auto-Submit: Tamer Tas <tmrts@chromium.org> Owners-Override: Liviu Rau <liviurau@google.com> Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/main@{#78408}
-
Clemens Backes authored
Avoid the trailing ";" after the last parallel gap move. Instead, make the semicolon part of the delimiter between moves. Before: gap ([stack:8|w32] = [constant:0];) ([edi|R|w32] = [constant:7]; [edx|R|w32] = [constant:8];) After: gap ([stack:8|w32] = [constant:0]) ([edi|R|w32] = [constant:7]; [edx|R|w32] = [constant:8]) R=mslekova@chromium.org Bug: v8:12330 Change-Id: If9f3d67f09e48f717e839fa7fb8968f20bb58b16 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3347820Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78407}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e37fef4..6353c5a R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I730283874d689afea45eb5347aa998bd50d1a478 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3350025 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78406}
-