Commits · afcfa7d2b73acdedd0ec88980842c410f66c7ad0 · Linshizhi / V8

28 Jul, 2014 12 commits

Keep new arrays allocated with 'new Array(N)' in fast mode (revisited) · afcfa7d2

danno@chromium.org authored Jul 28, 2014

Also explicit length setting with a.length = N should remain in fast mode.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/416403002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22645 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

afcfa7d2

Unbreak NaCL build · 77529ec7

svenpanne@chromium.org authored Jul 28, 2014

TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/422863004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22644 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

77529ec7

Trace every incremental marking step. · 5458a81a

ernstm@chromium.org authored Jul 28, 2014

- This information is required in the chrome trace for a GC telemetry
  benchmark.

R=hpayer@chromium.org, jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/420613006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22643 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5458a81a

Fix bogus assert in HeapIterator. · 74c35110

hpayer@chromium.org authored Jul 28, 2014

BUG=397485
LOG=n
R=jarin@chromium.org

Review URL: https://codereview.chromium.org/416403011

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22642 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

74c35110

[Auto-roll] Bump up version to 3.28.44.0 · 6fda23d3

machenbach@chromium.org authored Jul 28, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/422003002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22639 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6fda23d3

Use return value of GetPropertyAttributes to make compiler happy. · eb7c5565

hpayer@chromium.org authored Jul 28, 2014

BUG=
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/420443006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22638 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

eb7c5565

Properly propagate serialization flag when compiling hydrogen code stubs. · 82078339

yangguo@chromium.org authored Jul 28, 2014

R=mvstanton@chromium.org

Review URL: https://codereview.chromium.org/416123002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22637 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

82078339

Revert "Fix a potential overflow in SortedListBSearch". · ac078952

yangguo@chromium.org authored Jul 28, 2014

This reverts r21960.

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/422853005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22636 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ac078952

Move extra_ic_state to the PropertyICCompiler · 579dbe40

verwaest@chromium.org authored Jul 28, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/426593002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22635 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

579dbe40

Tests that the GC doesn't mistake non-pointer constant pool entries as pointers. · cc532e44

rmcilroy@chromium.org authored Jul 28, 2014

Adds a test for ConstantPoolArray to ensure that the GC
doesn't mistake non-pointer entries as pointers and try
to modify them during scavenge operations.

Also adds asserts to ConstantPoolArray::set(int, *Object) to
ensure we don't add new-space pointers in constant pool
array.

R=hpayer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22608

Review URL: https://codereview.chromium.org/396803009

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22634 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cc532e44

Reland r22460 - "Bootstrapper::DetachGlobal also need to unset g..." · d9075bf0

jochen@chromium.org authored Jul 28, 2014

| DetachGlobal detaches original context of a global proxy object.
|
| Before this patch, the constructor JSFunction still carried a
| reference to the old context after |Bootstrapper::DetachGlobal|
| call.
| This patch removes the reference by setting the constructor
| null.
|
| Review URL: https://codereview.chromium.org/397953009

TEST=http/tests/security/isolatedWorld w/ --enable-leak-detection
LOG=N
BUG=364377
R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/424703002

Patch from Kouhei Ueno <kouhei@chromium.org>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22633 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d9075bf0

Added histogram to track distribution of requested idle notifications. · e52908e4

hpayer@chromium.org authored Jul 28, 2014

BUG=397026
LOG=n
R=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/420753002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22632 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e52908e4

26 Jul, 2014 1 commit

[Auto-roll] Bump up version to 3.28.42.0 · 3db23c80

machenbach@chromium.org authored Jul 26, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/420943002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22628 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3db23c80

25 Jul, 2014 10 commits

MIPS: Restructure the IC / Handler compilers · d3da21b5

akos.palfi@imgtec.com authored Jul 25, 2014

Port r22622 (319e3252)

BUG=
R=paul.lind@imgtec.com

Review URL: https://codereview.chromium.org/414303003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22626 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d3da21b5

[Auto-roll] Bump up version to 3.28.41.0 · 85cee45e

machenbach@chromium.org authored Jul 25, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/423553002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

85cee45e

Change Has* and Get*Attributes to return Maybe<*>, indicating possible exceptions. · 4a956ab1

verwaest@chromium.org authored Jul 25, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/418383002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22624 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4a956ab1

Restructure the IC / Handler compilers · 3c873c43

verwaest@chromium.org authored Jul 25, 2014

BUG=
R=ishell@chromium.org, mvstanton@chromium.org

Review URL: https://codereview.chromium.org/411973002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22622 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3c873c43

[Auto-roll] Bump up version to 3.28.40.0 · 553e069f

machenbach@chromium.org authored Jul 25, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/419243002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22621 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

553e069f

Kraken recover after r20312. · 9444388f

ishell@chromium.org authored Jul 25, 2014

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/416393002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22620 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9444388f

[Auto-roll] Bump up version to 3.28.39.0 · 21be95fc

machenbach@chromium.org authored Jul 25, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/416333005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22618 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

21be95fc

Smi arrays are only guaranteed to be initialized in non-holey case · 3586c074

verwaest@chromium.org authored Jul 25, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/413393004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22617 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3586c074

In GrowMode, force the value to the right representation to avoid deopts... · 60df9dab

verwaest@chromium.org authored Jul 25, 2014

In GrowMode, force the value to the right representation to avoid deopts between storing the length and storing the value.

BUG=16459193
LOG=n
R=danno@chromium.org

Review URL: https://codereview.chromium.org/419683004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22616 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

60df9dab

Always trace garbage collection events in GCTracer. · d556278f

ernstm@chromium.org authored Jul 25, 2014

- always trace events in GCTracer, but only print stats when the command
  line flag is set.
- required to collect statistis that will be used to schedue garbage
  collection.
- we need to watch the perf bots after this lands, as it could regress
  performance.

R=hpayer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/410413007

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22613 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d556278f

24 Jul, 2014 17 commits

[Auto-roll] Bump up version to 3.28.37.0 · 47d6f32b

machenbach@chromium.org authored Jul 24, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/415093004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22610 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

47d6f32b

Revert "Tests that the GC doesn't mistake non-pointer constant pool entries as pointers." · 110a5fda

machenbach@chromium.org authored Jul 24, 2014

This reverts commit r22608 for breaking win and arm64, ConstantPoolExtended and ConstantPoolSmall.

BUG=
TBR=rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/415773010

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22609 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

110a5fda

Tests that the GC doesn't mistake non-pointer constant pool entries as pointers. · 59ee2de9

rmcilroy@chromium.org authored Jul 24, 2014

Adds a test for ConstantPoolArray to ensure that the GC
doesn't mistake non-pointer entries as pointers and try
to modify them during scavenge operations.

Also adds asserts to ConstantPoolArray::set(int, *Object) to
ensure we don't add new-space pointers in constant pool
array.

R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/396803009

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22608 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

59ee2de9

Use result of SetOwnPropertyIgnoreAttributes in accessors · ffd668f9

verwaest@chromium.org authored Jul 24, 2014

BUG=
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/415133003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22607 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ffd668f9

Fix issue with setters and their holders in accessors.cc · 77a37e44

verwaest@chromium.org authored Jul 24, 2014

BUG=3462
LOG=Y
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/417793002

Patch from Erik Arvidsson <arv@chromium.org>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22606 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

77a37e44

Add event statistics to GCTracer. · fc8a3bee

ernstm@chromium.org authored Jul 24, 2014

- Add method to GCTracer to compute mean and max of the last few
  Scavenger, Mark Compactor and Incremental Marking events.

R=hpayer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/410413005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22605 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fc8a3bee

Add a histogram timer around low memory notifications from API · b6182bd7

jochen@chromium.org authored Jul 24, 2014

BUG=397026
R=hpayer@chromium.org, ernstm@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/416853002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22604 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b6182bd7

Stage for-of · d409898d

yangguo@chromium.org authored Jul 24, 2014

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/417923004

Patch from Andy Wingo <wingo@igalia.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22603 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d409898d

For-of on null or undefined is an error · 029b8a23

yangguo@chromium.org authored Jul 24, 2014

The latest ES6 draft changed the behavior of for-of on null / undefined,
which for once is a simplification.

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/416033002

Patch from Andy Wingo <wingo@igalia.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22602 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

029b8a23

Revert 22595: "Keep new arrays allocated with 'new Array(N)' in fast mode" · b5a51482

danno@chromium.org authored Jul 24, 2014

Due to failures in mjsunit/array-functions-prototype-misc

TBR=verwaest@chromium.org

Review URL: https://codereview.chromium.org/417953004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22601 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b5a51482

Move GCTracer to separate files. · 70e2a040

ernstm@chromium.org authored Jul 24, 2014

- No functional changes.

R=hpayer@chromium.org
BUG=

Review URL: https://codereview.chromium.org/416543003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22600 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

70e2a040

SKIP migration tests to improve unit test time (2x) · 29338fa1

danno@chromium.org authored Jul 24, 2014

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/416003004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22599 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

29338fa1

Revert r22597 (which should have been called: "Tests that the GC doesn't... · 7cd5dbb9

rmcilroy@chromium.org authored Jul 24, 2014

Revert r22597 (which should have been called: "Tests that the GC doesn't mistake non-pointer constant pool entries as poitners.")

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/413173002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22598 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7cd5dbb9

Use heap iterator in store buffer when page was swept precisely. · 48f44b65

rmcilroy@chromium.org authored Jul 24, 2014

BUG=
R=rmcilroy@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22592

Review URL: https://codereview.chromium.org/413693002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22597 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

48f44b65

Flag for serialization when compiling code stubs if --serialize-toplevel. · 28112133

yangguo@chromium.org authored Jul 24, 2014

R=mvstanton@chromium.org
BUG=v8:3465
LOG=N

Review URL: https://codereview.chromium.org/419503002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22596 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

28112133

Keep new arrays allocated with 'new Array(N)' in fast mode · ac89b178

danno@chromium.org authored Jul 24, 2014

Also explicit length setting with a.length = N should remain in fast mode.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/397593008

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22595 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

ac89b178

Introduce NonJSProxyHolder returning Handle<JSObject> and return Handle<JSReceiver> for GetHolder · 37df96f9

verwaest@chromium.org authored Jul 24, 2014

BUG=
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/415953005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22594 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

37df96f9