- 06 Jul, 2020 14 commits
-
-
Jakob Gruber authored
This is the last batch of operators which used to embed the feedback vector as a HeapConstant: - CreateEmptyLiteralArray - LoadGlobal - LoadNamed - StoreDataPropertyInLiteral - StoreGlobal - StoreInArrayLiteral - StoreNamed - StoreNamedOwn They now take the vector as an input. In NCI mode, the vector is loaded from the closure at the beginning of the function. Bug: v8:8888 Change-Id: Ifd2d2a556db343512b61e099a73702822b1ba9f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282525 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#68695}
-
Ulan Degenbaev authored
The allocation step in FreeLinearAllocationArea may start incremental marking and mark the area to be freed, which breaks the invariant that all blocks in the free list are unmarked. Bug: v8:10679 Tbr: dinfuehr@chromium.org Change-Id: I23b92e402968361b57010a017b382747f7da673d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282537Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#68694}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I6bb37fe506b46da4d3df35df244581357498f6b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282527 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68693}
-
Jakob Gruber authored
Prior to this CL, the construct node layout was: {target, args..., new_target} The new layout is: {target, new_target, args..., feedback_vector} Having new_target at index 1 brings it closer to call node layout, which is now identical except that it has receiver at index 1. The new feedback vector input will be needed for NCI code. Affected node kinds are: - JSConstruct - JSConstructWithArrayLike - JSConstructWithSpread - JSConstructForwardVarargs (just the new_target position change) Bug: v8:8888 Change-Id: I4c68a0901d01e8862fd276c8a858799d5f4ff024 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2278475 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: -
Milad Farazmand authored
Port 871183ea Original Commit Message: - Add wasm opcode, decode and compiler code for v128.const - Add codegen implementations for v128.const on x64/Arm64 - Reuse/Rename some shuffle specific methods to handle generic 128-bit immediates - Tests R=gdeepti@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ia4990f768b6fac0ac72cf79129a53b531c9c2fa9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280541Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68691}
-
Milad Farazmand authored
With https://crrev.com/c/2277142 adding unified (de)serialization support, "cbor ParseUTF16String" is no longer being used and byte orders remain in LE format. This CL essentially reverts some of the changes made here: https://crrev.com/c/2038716 and re-adds byte swapping on BE machines. Change-Id: I3e7be6ba182e7faada3bf31dff9a89c1343abbbc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2281082Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68690}
-
Jakob Gruber authored
... in preparation for upcoming changes to 1. make construct node layout more consistent with call nodes by placing new_target (construct) in the same spot as receiver (call); and 2. adding the feedback vector input. Bug: v8:8888 Change-Id: I6cd7f50ed0b029de53af5cd82e7ecf4ba514ef65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275963 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Georg Neis authored
ForInNext can get lowered to a low-level call to the ForInFilter builtin. We currently type low-level Call nodes simply as Any, leading to a CHECK failure when the verifier expects a primitive. This CL fixes the issue simply by manually setting the type as part of the lowering. An alternative would be to have the Call typing inspect its input similar to what the JSCall typing does. We can consider this if we hit the same issue in other cases. Bug: chromium:1102053 Change-Id: I6682d8cf95c6a3ebaff9c8de677aa20ca676573f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282523Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#68688}
-
Jakob Gruber authored
Call counts (collected for call/construct feedback) are only reliable in NCI mode and thus should not be collected in default TF mode. Bug: v8:8888 Change-Id: Id83c7042f23a7390e5e00b736dfda47bdc7cf2b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276042 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Ia88596d8016ebb63d457cfc04f4feed8da37872e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2279550 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Zhao Jiazhong authored
Change-Id: If64fd25f1849cc836733a2b7317083ef63f2ccb7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2282144 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#68685}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Ic18a9ca8fcf21cf8b3dc7028cb95df95dbabf3d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275970 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Like in previous similar CLs, this also adds node wrapper classes for both. Bug: v8:8888 Change-Id: I9c83e98e3b665b72b944dec83b8854b9ef2c14a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277805 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#68683}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e1a9ece..96a6783 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/95099f4..49735e2 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaaa7c105ea86f68b9eb1cbd2cefa3f5f12fc0431 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280458Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68682}
-
- 05 Jul, 2020 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d602f57..e1a9ece TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I498c812dae9ab432ceadfdd512088c8d2a85a7a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280455Reviewed-by:
-
- 04 Jul, 2020 2 commits
-
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I82cbe300223251342f65683522d8bfac1cbe88c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275968 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a0f6c1b..d602f57 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/6b2a302..6b95167 Rolling v8/buildtools/linux64: git_revision:cd3869be2477f7ee1aa3f27f43ee934e74722dfb..git_revision:b6203d186bff6b39ac25af6c1e80e1d3f96c949a Rolling v8/third_party/aemu-linux-x64: sKz_Oq5M4tmZVE7eggzuhtTiKK3JNyylo9pt0tGLCg4C..LQ_bftKUbwaforl6s7QhdVirfTBttP4-yogIN0A6CcoC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/447d835..5f3007b TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id3bc229bd6a20430daed8726c043fca70f7a5e86 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280452Reviewed-by:
-
- 03 Jul, 2020 14 commits
-
-
Michael Lippautz authored
- Cleanup includes, fix typo, fix qualifiers. - Fix getter names of MarkerBase when only exposed for testing. Bug: chromium:1056170 Change-Id: Ibcb0f62414c9c865fa98e6d2b2c9b150aa2a361f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2281004 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68678}
-
Daniel Clifford authored
This change also makes it possible to create Torque references to elements in the context. Change-Id: I064b73dedf8463c8d92b94b0e59f3cb4e366611a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280084 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Split off MarkingWorklists and from Marker and introduce MarkerBase. MarkerBase refers just to interfaces types for passing along visitors. The concrete Marker provides the impl for these interfaces. Unified heap marker uses different marking visitors internally but provides an implementation for the same interface. Change-Id: Ibc4b2c88e2e69bd303a95da7d167a701934f4a07 Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270539 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Michael Lippautz authored
The benchmarks cover static vs dynamic tracing of an object where the header is computed statically vs using the object start bitmap, respectively. $ out/x64.release/cppgc_basic_benchmarks --benchmark_filter=Trace/* Running out/x64.release/cppgc_basic_benchmarks Run on (56 X 3500 MHz CPU s) CPU Caches: L1 Data 32 KiB (x28) L1 Instruction 32 KiB (x28) L2 Unified 256 KiB (x28) L3 Unified 35840 KiB (x2) Load Average: 0.24, 0.26, 0.26 -------------------------------------------------------- Benchmark Time CPU Iterations -------------------------------------------------------- Trace/Static 1.78 ns 1.78 ns 393324147 Trace/Dynamic 3.27 ns 3.27 ns 215078276 2020-07-03T15: 21:25+02:00 Change-Id: I8bf5a8ed71a8991873160353e26f96214c038730 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280099 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This is another case of the known .caller difference that's now added to the mapping of known issues. No-Try: true Bug: chromium:1101870 Change-Id: I6cfca6887362564f625648ba34820cb92a77efb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280087Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#68674}
-
Ulan Degenbaev authored
This adds --gc-experiment-reduce-concurrent-marking-tasks to be used in a Finch experiment. Bug: v8:10442 Change-Id: Ie2adf4faa20c99d1793907dfc6857497743f8d5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280093Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#68673}
-
Michael Lippautz authored
Output: $ out/x64.release/cppgc_allocation_benchmark --benchmark_repetitions=3 Running out/x64.release/cppgc_allocation_benchmark Run on (56 X 3500 MHz CPU s) CPU Caches: L1 Data 32 KiB (x28) L1 Instruction 32 KiB (x28) L2 Unified 256 KiB (x28) L3 Unified 35840 KiB (x2) Load Average: 0.23, 0.27, 0.27 -------------------------------------------------------------------------------- Benchmark Time CPU Iterations UserCounters... -------------------------------------------------------------------------------- Allocate/Tiny 17.0 ns 17.0 ns 40348381 bytes_per_second=55.9692M/s Allocate/Tiny 17.1 ns 17.1 ns 40348381 bytes_per_second=55.8961M/s Allocate/Tiny 17.2 ns 17.2 ns 40348381 bytes_per_second=55.3108M/s Allocate/Tiny_mean 17.1 ns 17.1 ns 3 bytes_per_second=55.7254M/s Allocate/Tiny_median 17.1 ns 17.1 ns 3 bytes_per_second=55.8961M/s Allocate/Tiny_stddev 0.112 ns 0.111 ns 3 bytes_per_second=369.571k/s Allocate/Large 40339 ns 40334 ns 17707 bytes_per_second=1.51326G/s Allocate/Large 40350 ns 40343 ns 17707 bytes_per_second=1.51292G/s Allocate/Large 40205 ns 40192 ns 17707 bytes_per_second=1.51861G/s Allocate/Large_mean 40298 ns 40290 ns 3 bytes_per_second=1.51493G/s Allocate/Large_median 40339 ns 40334 ns 3 bytes_per_second=1.51326G/s Allocate/Large_stddev 81.2 ns 84.7 ns 3 bytes_per_second=3.26614M/s 2020-07-03T09: 14:23+02:00 Change-Id: I25a55beb5ea1718af76e638b752bf7d67cfe373e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280086Reviewed-by:
-
Dan Elphick authored
To get the Isolate from a HeapObject, rather than masking off the MemoryChunk and then loading the heap from the MemoryChunk (which won't work when RO_SPACE is shared between Isolates), get the Isolate by masking off the bottom 32 bits and apply the Isolate bias. Also fixes up a stale comment and makes several methods in RootsTable and Isolate const to support this change. Bug: v8:10454 Change-Id: I5f8eb873d8486b699460223dbe3454a5dcf1854f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280088 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#68671}
-
Ross McIlroy authored
After r68405 reduced the default stack size on Arm64 a couple of tests hit stack limits on the Arm64 android bots. Reduce the argument count on these tests to avoid this issue. BUG=chromium:1099623 Change-Id: I8957043b74bd416bb78223599b1a661a4887f54a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280095 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#68670}
-
Igor Sheludko authored
Bug: v8:10506 Change-Id: I9405616566aaec47bfc47cfe2290dc6953e532ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280082 Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Change-Id: I991bcb5bc8a266ed4caa9ad4e8cb31fa6d30eef9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275966Reviewed-by:
-
Dominik Inführ authored
Introduce explicit fast path for allocation in PagedSpace. The slow path is moved into AllocateRawSlow which refills the LAB and retries the allocation. Reland of https://crrev.com/c/2277808, reverted because it broke the MSAN build in https://crrev.com/c/2275969. Bug: v8:10315 Change-Id: I7a3d32525fa12ea672c62f6297c92aaafc3d8157 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280081Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cee6c15..a0f6c1b Rolling v8/third_party/aemu-linux-x64: NwKjfDOL_ugbEGGNcm2u6NzakaOJ9ad36bFd7bUVpXIC..sKz_Oq5M4tmZVE7eggzuhtTiKK3JNyylo9pt0tGLCg4C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7bb44ab..447d835 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5b2ab91cadf0856b453eab0ff4528022b56b5f5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280445Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I1c844768e09095ad85396f1752420b616048ec36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2278473 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
- 02 Jul, 2020 9 commits
-
-
Z Nguyen-Huu authored
The change instruments code generation for Gap Solver so that these counters are run-time and didn't impact register allocation. The implementation is put behind a flag to help better register allocation analysis. Bug: v8:10663 Change-Id: Ia342d990e2b2bfc6a7653a770f670e51eef71312 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2269362 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#68664}
-
Michael Lippautz authored
This adds Google benchmark for microbenchmarking C++ code as an optional dependency. To enable, add the following to the .gclient before syncing "custom_vars": { "checkout_google_benchmark": True } Change-Id: Id0eab772dd71558906658ef4bb60e31acd665948 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275964Reviewed-by:Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68663}
-
Milad Farazmand authored
Fix GCC build because of missing header: template argument deduction/substitution failed: ../../third_party/inspector_protocol/crdtp/protocol_core.cc:123:8: note: candidate expects 3 arguments, 4 provided }); Change-Id: If977c6afc3f20c2faf40e02672b04e9679c1fda7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280243Reviewed-by: -
Michael Lippautz authored
Split off ConservativeMarkingVisitor from MarkingVisitor. After this change, MarkingVisitor and ConservativeMarkingVisitor are types that are instantiated with Marking and merely forward to MarkingState accrodingly. The two marking-related visitors can be passed along as interface types cppgc::Visitor and ConservativeTracingVisitor, respectively. Change-Id: Iad103dc3053c61d1a104a8802edd420d21cdf935 Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270538 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Split off MarkingState from MarkingVisitor. With this CL the marking implementation is moved to "MarkingState" which is the new bottleneck for marking a single object. MarkingVisitor merely forwards to MarkingState, which knows how to set the markbit and add the object to the worklist accordingly. This allows to have a "UnifiedHeapMarkingVisitor" in future which can easily reuse Marking to provide C++ marking. Change-Id: I87ebbe37e8e8cd841e872cae9dc3490e2b55c4dd Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270172Reviewed-by:
-
Manos Koukoutos authored
Also shuffle HeapType helper functionality a bit Bug: chromium:1101629, v8:7748 Change-Id: I7c27dc96f02173c73dbac7b518e7936e4e0d5bf3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275965Reviewed-by:
-
Thibaud Michaud authored
R=ahaas@chromium.org Bug: v8:7431 Change-Id: Ie416ea6048ffed792225822b053aa3ed37aa4919 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2278468Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#68658}
-
Andrey Kosyakov authored
Note that changes in test expectation come from a more verbose error diagnostics for expected errors around input parameter validation. Original change: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2270757 Bug: chromium:1099809 Change-Id: I4fc2efc9c89d0af645dad937d719fa36e1d33489 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277142Reviewed-by:
-
Seth Brenith authored
Currently, FindOptimalSpillingPos uses GetSpillState on the loop header block when attempting to find the live range that covers the top of the loop. However, GetSpillState represents the state at the end of a block, and is not written until the allocator leaves the block. So when `pos` is within the loop header block, FindOptimalSpillingPos is incorrectly recommending a split rather than recommending a spill of the live range covering the loop top. This change implements a better search for the live range that covers the beginning of the loop. Bug: v8:10606 Change-Id: I454a009b5806d1a01ee59d6d34b9e9ef8784d294 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274308Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
