1. 09 Jun, 2021 1 commit
  2. 01 Jun, 2021 1 commit
  3. 26 May, 2021 2 commits
    • Manos Koukoutos's avatar
      Reland "Reland "[wasm][bug] Fix a couple of bugs in validation of unreachable code"" · 85a5e208
      Manos Koukoutos authored
      This is a reland of 916eb869
      
      Change compared to original:
      Remove ternary operator from lambda, as this triggers a gcc bug.
      
      Original change's description:
      > Reland "[wasm][bug] Fix a couple of bugs in validation of unreachable code"
      >
      > This is a reland of 4a037f87
      >
      > Changes compared to original change: None. This seems not to create
      > problems after all.
      >
      > Original change's description:
      > > [wasm][bug] Fix a couple of bugs in validation of unreachable code
      > >
      > > Changes:
      > > - SetBlockType now instantiates the block's start merge with values of
      > >   the correct type in unreachable code.
      > > - EnsureStackArguments now keeps the existing stack values and moves
      > >   them over the new bottom values.
      > > - Drop stack size validation in Drop().
      > > - Add new tests in unreachable-validation.js.
      > >
      > > Change-Id: Ie68b3d9abb0a41d1623d4a123fb526e71941c4e7
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2902733
      > > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
      > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#74650}
      >
      > Change-Id: Id620f7fb6677b772b0dcfd38108256384db44439
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905598
      > Reviewed-by: Manos Koukoutos <manoskouk@chromium.org>
      > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#74677}
      
      Bug: v8:11819
      Change-Id: I9b8d915547ec9aee7cb5233937089d431db54c8f
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919833
      Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
      Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74797}
      85a5e208
    • Jakob Gruber's avatar
      Revert "Reland "[wasm][bug] Fix a couple of bugs in validation of unreachable code"" · 1f89ee1f
      Jakob Gruber authored
      This reverts commit 916eb869.
      
      Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20gcc/11805/overview
      
      Original change's description:
      > Reland "[wasm][bug] Fix a couple of bugs in validation of unreachable code"
      >
      > This is a reland of 4a037f87
      >
      > Changes compared to original change: None. This seems not to create
      > problems after all.
      >
      > Original change's description:
      > > [wasm][bug] Fix a couple of bugs in validation of unreachable code
      > >
      > > Changes:
      > > - SetBlockType now instantiates the block's start merge with values of
      > >   the correct type in unreachable code.
      > > - EnsureStackArguments now keeps the existing stack values and moves
      > >   them over the new bottom values.
      > > - Drop stack size validation in Drop().
      > > - Add new tests in unreachable-validation.js.
      > >
      > > Change-Id: Ie68b3d9abb0a41d1623d4a123fb526e71941c4e7
      > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2902733
      > > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
      > > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#74650}
      >
      > Change-Id: Id620f7fb6677b772b0dcfd38108256384db44439
      > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2905598
      > Reviewed-by: Manos Koukoutos <manoskouk@chromium.org>
      > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
      > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#74677}
      
      Tbr: manoskouk@chromium.org
      Change-Id: Ia24aa453735464bdd3aafca4617beabb0cbf8823
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2917601
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Auto-Submit: Jakob Gruber <jgruber@chromium.org>
      Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
      Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#74771}
      1f89ee1f
  4. 19 May, 2021 3 commits
  5. 15 Apr, 2021 1 commit
  6. 22 Mar, 2021 1 commit
  7. 30 Jan, 2019 1 commit
  8. 30 Aug, 2017 1 commit
  9. 16 Feb, 2017 1 commit
    • rossberg's avatar
      [wasm] Inspect right control frames for unreachable flag · e2b83fbb
      rossberg authored
      We were looking at the unreachable flag or stack_depth of the target frame
      instead of the current one in a couple of places (most notably BreakTo).
      This change fixes these bugs and makes us pass the latest spec tests for
      br_table validation. Also need to ensure that br_table targets have consistent
      types, which is not implied if the stack is polymorphic.
      
      R=titzer@chromium.org
      BUG=
      
      Review-Url: https://codereview.chromium.org/2696813002
      Cr-Commit-Position: refs/heads/master@{#43250}
      e2b83fbb
  10. 02 Feb, 2017 1 commit
  11. 19 Jan, 2017 2 commits