1. 14 Feb, 2017 1 commit
    • clemensh's avatar
      [asm] Fix lots of invalid asm.js tests · be1a5f75
      clemensh authored
      I identified lots of asm.js tests that are actually not valid according
      to the spec, hence they execute in default-javascript-mode.
      This CL fixes most of them by adding additional type annotations.
      
      The atomic tests are totally non-spec-compliant by expecting a fourth
      argument, and infinite-loops-taken expects a function-type parameter,
      so I did not fix those.
      I also did not fix the regression tests.
      
      R=titzer@chromium.org, bradnelson@chromium.org
      BUG=v8:4203
      
      Review-Url: https://codereview.chromium.org/2663243002
      Cr-Commit-Position: refs/heads/master@{#43179}
      be1a5f75
  2. 07 Jan, 2016 1 commit
    • neis's avatar
      [tests] Fix bogus uses of assertThrows. · 837900ef
      neis authored
      Some tests passed a string as second argument to assertThrows, expecting it to
      be matched against the exception.  However, assertThrows simply ignored these.
      (Some other tests actually seem to use that argument as a comment ...)
      
      This CL
      - changes assertThrows to fail if the second argument is not a function,
      - adds assertThrowsEquals which compares the exception to a given value using
        assertEquals
      - fixes some bogus tests that got exposed by this.
      
      R=jarin@chromium.org
      BUG=
      
      Review URL: https://codereview.chromium.org/1544793002
      
      Cr-Commit-Position: refs/heads/master@{#33159}
      837900ef
  3. 17 Oct, 2014 1 commit