- 14 Aug, 2018 19 commits
-
-
Benedikt Meurer authored
We don't need to keep JSToObject operations in the graph if there's some preceeding map check that already provides information that the input is indeed already a receiver. Change-Id: I2d04895831ff561624fbe91a2fe03bb6e5d918a5 Reviewed-on: https://chromium-review.googlesource.com/1174259Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55120}
-
Dan Elphick authored
This is reland of https://chromium-review.googlesource.com/c/v8/v8/+/1154915 with no changes since the break in chromium for ChromeOS is now fixed. Removes all V8_DEPRECATED functions that weren't recently marked as well any V8_DEPRECATE_SOON function that relied on using using the address of an object to get hold of the Isolate. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel Change-Id: Ib62d38b9201fd0dab719948cb5ae5a0a164f7013 Reviewed-on: https://chromium-review.googlesource.com/1172350Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#55119}
-
Georg Neis authored
Bug: v8:7790 Change-Id: I6792bbbf015c7ba43ddaf373803c0afdf140eb76 Reviewed-on: https://chromium-review.googlesource.com/1174269Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=machenbach@chromium.org Bug: chromium:861668 Change-Id: I099b2ff007bed8b35e13d7f52eb5d0ae390a230e Reviewed-on: https://chromium-review.googlesource.com/1174267 Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55117}
-
Sigurd Schneider authored
Bug: v8:8015 Change-Id: I8099c66108d5cc1596cb9b0a00c0ecd30765cf24 Reviewed-on: https://chromium-review.googlesource.com/1174266Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#55116}
-
Jaroslav Sevcik authored
Bug: v8:8042 Change-Id: If667f1aba335d8e296052ff94e99900d446c3b29 Reviewed-on: https://chromium-review.googlesource.com/1172772Reviewed-by:
-
Leszek Swirski authored
This reverts commit 5a389395. Reason for revert: Breaks some chromium tests. Not your fault, but it's blocking the roll so we have to fix those first -- then you can reland without changes: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug/21727 Original change's description: > [array] Move Array.p.sort to Torque and use TimSort instead of QuickSort > > This CL changes the sorting algorithm used in Array.p.sort from > QuickSort to TimSort (implemented in Torque). > > Detailed performance results can be found here: https://goo.gl/4E733J > > To save on code space, fast-paths are implemented as sets of > function pointers instead of specializing generics. > > R=cbruni@chromium.org, jgruber@chromium.org > > Bug: v8:7382, v8:7624 > Change-Id: I7cd4287e4562d84ab7c79c58ae30780630f976de > Reviewed-on: https://chromium-review.googlesource.com/1151199 > Commit-Queue: Simon Zünd <szuend@google.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55003} TBR=cbruni@chromium.org,jgruber@chromium.org,szuend@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7382, v8:7624 Change-Id: Id4002d8080648c418639d35e7b82487fa43f463d Reviewed-on: https://chromium-review.googlesource.com/1174231 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55114}
-
Andreas Haas authored
The streaming compilation cctests test streaming compilation over the public API, as far as possible. It is not required that a HandleScope is open when the API is used. Therefore the cctest should also not open a global HandleScope for a whole test but as fine-grained as possible. R=clemensh@chromium.org Bug: v8:8055 v8:8015 Change-Id: Id5e2145f2a8ba66e8d5d9021c47806aa80fc463f Reviewed-on: https://chromium-review.googlesource.com/1174258Reviewed-by:
-
Dan Elphick authored
Rather than having GDB always stop on the line containing V8_IMMEDIATE_CRASH(), walk up the stack looking for V8_Dcheck and select the frame above it. This will be the frame containing DCHECK (including related macros like DCHECK_EQ). Change-Id: I9760e7a4dd78b567dfa77ff12569d287d80ca873 Reviewed-on: https://chromium-review.googlesource.com/1172780Reviewed-by:
-
Benedikt Meurer authored
This adds support for unaligned load/store access to the DataView backing store and uses byteswap operations to fix up the endianess when necessary. This changes the Word32ReverseBytes operator to be a required operator and adds the missing support on the Intel and ARM platforms (on 64-bit platforms the Word64ReverseBytes operator is also mandatory now). This further improves the performance on the dataviewperf.js test mentioned in the tracking bug by up to 40%, and at the same time reduces the code complexity in the EffectControlLinearizer. Bug: chromium:225811 Change-Id: I7c1ec826faf46a144a5a9068f8f815a5fd040997 Reviewed-on: https://chromium-review.googlesource.com/1174252Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55111}
-
Georg Neis authored
In order to know which labels are valid continue targets, we must track the labels that immediately prefix an iteration statement. Also document some things that I had to figure out. Bug: v8:8033 Change-Id: Ia8288fd0e553a547aa0f9d1b4381bb103325bc3a Reviewed-on: https://chromium-review.googlesource.com/1172292Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#55110}
-
Benedikt Meurer authored
This reverts commit 6c7c81e0. Reason for revert: Dependent CL was reverted. Original change's description: > [turbofan] Properly zero-extend indices on 64-bit architectures. > > This was an oversight from the previous CL. It doesn't really matter > with the current code generation pattern, since the upper bits of the > index will always be zero, but that might change in the future. > > Bug: chromium:225811 > Change-Id: I568a0824cad9ce9b73a56decc15d146c7dc675a1 > Reviewed-on: https://chromium-review.googlesource.com/1174111 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55104} TBR=jarin@chromium.org,bmeurer@chromium.org Change-Id: Ib344609b0c4734c6512e6be287a5b7f80bc3f603 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:225811 Reviewed-on: https://chromium-review.googlesource.com/1174232Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55109}
-
jgruber authored
Follow-up to 17ad3ae4. Another try at exposing embedded builtin symbols on chromecrash. Bug: v8:6666, v8:7722 Change-Id: Ie715251797134be0618c0bc496ec10958f7545c3 Reviewed-on: https://chromium-review.googlesource.com/1174112Reviewed-by:
-
Leszek Swirski authored
This reverts commit c46915b9. Reason for revert: Disasm failures https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20debug/21727 Original change's description: > [turbofan] Further optimize DataView accesses. > > This adds support for unaligned load/store access to the DataView > backing store and uses byteswap operations to fix up the endianess > when necessary. This changes the Word32ReverseBytes operator to be > a required operator and adds the missing support on the Intel and > ARM platforms (on 64-bit platforms the Word64ReverseBytes operator > is also mandatory now). > > This further improves the performance on the dataviewperf.js test > mentioned in the tracking bug by up to 40%, and at the same time > reduces the code complexity in the EffectControlLinearizer. > > Bug: chromium:225811 > Change-Id: I296170b828c2ccc1c317ed37840b564aa14cdec2 > Reviewed-on: https://chromium-review.googlesource.com/1172777 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55099} TBR=sigurds@chromium.org,bmeurer@chromium.org Change-Id: If7a62e3a1a4ad26823fcbd2ab6eb4c053ad11c49 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:225811 Reviewed-on: https://chromium-review.googlesource.com/1174171Reviewed-by:
-
Andreas Haas authored
The problem was that in AsyncCompileJob::FinishModule we allocate a handle, but when this function is called from streaming compilation, then there was no HandleScope around AsyncCompileJob::FinishModule. This issue was fixed in another CL, https://crrev.com/c/1172357. This CL is just a rebase of the original CL. Original change's description: > [wasm] Implement the new API for WebAssembly.instantiateStreaming > This is the second V8 CL to refactor WebAssembly.instantiateStreaming to > make it spec compliant again. The design doc where the whole change is > discussed is available in the tracking bug. The tracking bug also > references prototype implementations of the whole change, which includes > the changes in this CL. R=starzinger@chromium.org Bug: chromium:860637 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ib0cb25488654d2b325b4f529d33b76b846c64436 Reviewed-on: https://chromium-review.googlesource.com/1172429Reviewed-by:
-
Marja Hölttä authored
BUG=v8:7308 Change-Id: I310d9453be8b90a82856c0d394442aad5527a3ae Reviewed-on: https://chromium-review.googlesource.com/1169167 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#55105}
-
Benedikt Meurer authored
This was an oversight from the previous CL. It doesn't really matter with the current code generation pattern, since the upper bits of the index will always be zero, but that might change in the future. Bug: chromium:225811 Change-Id: I568a0824cad9ce9b73a56decc15d146c7dc675a1 Reviewed-on: https://chromium-review.googlesource.com/1174111 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Hai Dang authored
This affects map, filter, every, some, indexOf and includes. Tests for those cases and more are also added. Bug: v8:8049 Change-Id: I196abd8e7e2419a2bb465f44caf4de52990ffced Reviewed-on: https://chromium-review.googlesource.com/1172346Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/6705895..016397a Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/21cd5a3..501bed8 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I6fa51528cc992f2656812baec91089543cb62e50 Reviewed-on: https://chromium-review.googlesource.com/1173758Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55102}
-
- 13 Aug, 2018 21 commits
-
-
Camillo Bruni authored
Drive-by-fix: - Remove obsolete mark_shared_functions_for_tier_up flag Bug: chromium:873728 Change-Id: I6c18b2e55068be913a3fc16932a9be0f9f02b635 Reviewed-on: https://chromium-review.googlesource.com/1173232 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55101}
-
Creddy authored
Word32Not was used instead of Word32BinaryNot which caused unecssary runtime lookup. This CL fixed the performance regression https://crrev.com/c/1145438. Bug: chromium:868799 Change-Id: I9e070de6155797e52dd9b461a9660cb003509a57 Reviewed-on: https://chromium-review.googlesource.com/1169808 Commit-Queue: Chandan Reddy <chandanreddy@google.com> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
This adds support for unaligned load/store access to the DataView backing store and uses byteswap operations to fix up the endianess when necessary. This changes the Word32ReverseBytes operator to be a required operator and adds the missing support on the Intel and ARM platforms (on 64-bit platforms the Word64ReverseBytes operator is also mandatory now). This further improves the performance on the dataviewperf.js test mentioned in the tracking bug by up to 40%, and at the same time reduces the code complexity in the EffectControlLinearizer. Bug: chromium:225811 Change-Id: I296170b828c2ccc1c317ed37840b564aa14cdec2 Reviewed-on: https://chromium-review.googlesource.com/1172777 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: v8:6922 Change-Id: I641f654f0548c2da24cdea3ffd275461ae8ce9b0 Reviewed-on: https://chromium-review.googlesource.com/1172776Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55098}
-
Benedikt Meurer authored
The DataView access methods can use the neutering protector to avoid introducing an explicit check into the optimized code to see if the backing store was neutered. Instead the optimized code has an implicit dependency on the global neutering protector which gets invalidated when the first array buffer is neutered (globally). We use the same trick for typed arrays already. Bug: chromium:225811 Change-Id: I9b3c95b3113b8fa00dcbba216ef29c84c0056951 Reviewed-on: https://chromium-review.googlesource.com/1172779 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Toon Verwaest authored
[scanner] Explicitly add one-byte characters to a one-byte literal buffer when scanning ascii identifiers Change-Id: Ia8337506d9f442d6887b6fa3c2ed17210ffd3c28 Reviewed-on: https://chromium-review.googlesource.com/1172789Reviewed-by:
-
Toon Verwaest authored
Change-Id: I0d23484d9a48a73575ca158b07b7ed1b83d4029e Reviewed-on: https://chromium-review.googlesource.com/1172774Reviewed-by:
-
Bogdan Lazarescu authored
Change-Id: I4a6d57903016323eba439cd7f959f263d6605c84 Reviewed-on: https://chromium-review.googlesource.com/1169165Reviewed-by:
-
Tobias Tebbi authored
drive-by change: fix wrong typing in CSA. Change-Id: I9234306e8568a64157b44a86a58f09e65116b298 Reviewed-on: https://chromium-review.googlesource.com/1172583 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55093}
-
Clemens Hammacher authored
After https://crrev.com/c/1172285, abortion and deletion of an {AsyncCompileJob} is the same. Hence, remove the {AbortCompileJobsOnIsolate} method and replace all uses by {DeleteCompileJobsOnIsolate}. R=ahaas@chromium.org CC=mstarzinger@chromium.org Bug: chromium:869420 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I053dc47395a257066bbca55069d53445dc28eeb9 Reviewed-on: https://chromium-review.googlesource.com/1172288Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55092}
-
Camillo Bruni authored
This should make the uses of binary vs. bitwise not very clear: - Word32BinaryNot for logical negation - Word32BitwiseNot for bitwise negation Change-Id: I3345913111da0dbdae6fdf285f090b67eb3f3afc Reviewed-on: https://chromium-review.googlesource.com/1169205 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Change-Id: If008d618d3cb27c38cf814b1858244578d0c4e84 Reviewed-on: https://chromium-review.googlesource.com/1169213Reviewed-by:
-
Bret Sepulveda authored
This patch also includes some CSS tweaks and other minor cleanup. Bug: v8:6240 Change-Id: I86e26fe53465dff6f9a706f58e565b1f1ee559da Reviewed-on: https://chromium-review.googlesource.com/1172360 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Bug: chromium:840785 Change-Id: I043df7aa5203dec27b84636c64286d68a56fba31 Reviewed-on: https://chromium-review.googlesource.com/1172428Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55088}
-
jgruber authored
Bug: v8:8015 Change-Id: Ie8265458ace8c0d12ca9d3f58afd981f1f30cd1e Reviewed-on: https://chromium-review.googlesource.com/1170826 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Andreas Haas authored
{AsyncCompileJob::FinishCompile} assumes that it is called within a {HandleScope}. This was not the case when it was called at the end of streaming compilation. R=clemensh@chromium.org Bug: chromium:860637 Change-Id: I74508e6cdfc145efb9adc76176abce1ca5713515 Reviewed-on: https://chromium-review.googlesource.com/1172357Reviewed-by: -
Predrag Rudic authored
By using NAL for reading PC instead of BAL, we are acctualy not taking branch. Thus optimizing code for instruction pipeline and address predictor. Change-Id: I574dc98390dc850443de06c928022292e2b50747 Reviewed-on: https://chromium-review.googlesource.com/1170777Reviewed-by:
Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#55085}
-
Yang Guo authored
This simplifies a bit. R=jgruber@chromium.org Change-Id: If7a433c9d2b13edf4fe4485816ac5ab06435773e Reviewed-on: https://chromium-review.googlesource.com/1172299Reviewed-by:
-
Clemens Hammacher authored
In {WasmEngine::DeleteCompileJobsOnIsolate} (triggered on isolate teardown), we are deleting the {AsyncCompileJob} with the expectation that this cancels all background compilation. Since the introduction of the CompilationState, this is not true any more. The call to {CompilationState::Abort} is missing. This CL fixes this by moving the logic from {AsyncCompileJob::Abort} to {~AsyncCompileJob}, since the former calls the latter anyway. R=ahaas@chromium.org Bug: chromium:869420 Change-Id: I4644d161270def0fe3a94d09cde0135ee420a383 Reviewed-on: https://chromium-review.googlesource.com/1172285Reviewed-by: -
Camillo Bruni authored
Bug: chromium:840785 Change-Id: I93f417084cc3ad3d1b906bdbef5dda14ead208c6 Reviewed-on: https://chromium-review.googlesource.com/1169044Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I7c55b81a21ef4bafd9ed9b1e6c68bd9110850b11 Reviewed-on: https://chromium-review.googlesource.com/1172135Reviewed-by:
-
