- 22 Jun, 2018 27 commits
-
-
Clemens Hammacher authored
In {SetLocalFromStackSlot}, we decrement the use count of the register in the target slot without updating this slot, and then call {GetUnusedRegister}. At that point, the register use counts do not match the cache state, which leads to errors later on. This CL fixes this by marking the target slot as a stack slot after reducing the register use count. It also adds a Validation which helped to find that error and will catch similar errors earlier. R=titzer@chromium.org Bug: chromium:854050, v8:6600 Change-Id: I74d3a5aa947ec4247d7b4557567f642bf4082316 Reviewed-on: https://chromium-review.googlesource.com/1111958Reviewed-by:Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53976}
-
Clemens Hammacher authored
The method does not do much, and all callers actually overwrite or delete the stack slot right after calling this method anyways, so there is no need to make the slot a stack slot first. R=titzer@chromium.org Bug: v8:6600 Change-Id: I4fd54d2ed5f86a3e011ddc2748833dc81052ef5b Reviewed-on: https://chromium-review.googlesource.com/1111848Reviewed-by:
-
Clemens Hammacher authored
This reverts commit e3229485. Reason for revert: just landed to gather perf feedback. Original change's description: > [array] Change QuickSort to TimSort for Array.p.sort > > R=jgruber@chromium.org > > Bug: v8:7382 > Change-Id: I95d2187d22c3bea4323789042b3426d65fde4999 > Reviewed-on: https://chromium-review.googlesource.com/1111959 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Simon Zünd <szuend@google.com> > Cr-Commit-Position: refs/heads/master@{#53970} TBR=jgruber@chromium.org,szuend@google.com Change-Id: I1e150e856a32039eb241a745bd7e6180f2132430 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7382 Reviewed-on: https://chromium-review.googlesource.com/1112099Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53974}
-
Dominic Farolino authored
As per https://github.com/whatwg/console/issues/27#issuecomment-289312546 and https://bugs.chromium.org/p/chromium/issues/detail?id=706804 we're leaving the console timeline/timelineEnd methods out of the specification and testing that implementations do not expose them (relevant WPTs at https://github.com/web-platform-tests/wpt/blob/master/console/console-tests-historical.any.js). Their implementations should be removed from Chrome, one of the last implementers of these legacy methods. The same goes for markTimeline, as it is deprecated in Chrome and not being included in the spec. R=bmeurer@chromium.org, kozyatinskiy@chromium.org Bug: chromium:706804 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibe05848fb664d26d16eeb5bdf6f519c1eeb4b2df Reviewed-on: https://chromium-review.googlesource.com/1082112Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#53973}
-
Deepti Gandluri authored
Cleanup decoding of flags so that invalid flags for sections other than memory are caught correctly. Bug: chromium:853453 Change-Id: Ia347d5f7672eee93ca3f6a743f06fba629f55cb5 Reviewed-on: https://chromium-review.googlesource.com/1104976 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#53972}
-
v8-ci-autoroll-builder authored
Rolling v8/test/test262/data: https://chromium.googlesource.com/external/github.com/tc39/test262/+log/7dc9215..6c2503a TBR=adamk@chromium.org,gsathya@chromium.org Change-Id: I3570f7a9c1e553ea124eea3cf2381dd9a2659fef Reviewed-on: https://chromium-review.googlesource.com/1111902Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#53971}
-
Simon Zünd authored
R=jgruber@chromium.org Bug: v8:7382 Change-Id: I95d2187d22c3bea4323789042b3426d65fde4999 Reviewed-on: https://chromium-review.googlesource.com/1111959Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#53970}
-
Igor Sheludko authored
Bug: v8:7754 Change-Id: I0c74b4025d9e52f3580e2da6bd7ac2b8ec2ee620 Reviewed-on: https://chromium-review.googlesource.com/1104469 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Cr-Commit-Position: refs/heads/master@{#53969}
-
Ivica Bogosavljevic authored
ArraySpliceTorque builtin triggers generation of MIPS specific trampolines due to its large size, and this code is not PIC and cannot be isolate independent. This CL is a workaround that marks ArraySpliceTorque as isolate dependent on MIPS64. Bug: v8:7882 Change-Id: I0b5764236268c2529e149b275dcf382dab709682 Reviewed-on: https://chromium-review.googlesource.com/1111847 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 20f33823. Reason for revert: Fails on win32: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32/14437 Original change's description: > [wasm] Enable Liftoff by default on ia32 and x64 > > R=titzer@chromium.org, hablich@chromium.org > > Bug: v8:6600, chromium:787421 > Change-Id: Ia8ae56ddef3b27b0721d5a66ff19abe098a2c6ca > Reviewed-on: https://chromium-review.googlesource.com/1109899 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Reviewed-by: Michael Hablich <hablich@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53965} TBR=titzer@chromium.org,hablich@chromium.org,clemensh@chromium.org Change-Id: I0edc228a88bc74624338852826a90f1f9b6eda0b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6600, chromium:787421 Reviewed-on: https://chromium-review.googlesource.com/1112017Reviewed-by:
-
Georg Neis authored
Use V8_INLINE and V8_NOINLINE instead. R=sigurds@chromium.org TBR=yangguo@chromium.org TBR=hpayer@chromium.org Change-Id: I1ccfcdc2178ded15ec730ab0577c4fc96a76a4f9 Reviewed-on: https://chromium-review.googlesource.com/1111840 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#53966}
-
Clemens Hammacher authored
R=titzer@chromium.org, hablich@chromium.org Bug: v8:6600, chromium:787421 Change-Id: Ia8ae56ddef3b27b0721d5a66ff19abe098a2c6ca Reviewed-on: https://chromium-review.googlesource.com/1109899Reviewed-by:
Michael Hablich <hablich@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53965}
-
Igor Sheludko authored
Bug: v8:5269, v8:7754 Change-Id: Iadbf7e1174e4cfe9f53310e7e499cc90ed27843b Reviewed-on: https://chromium-review.googlesource.com/1110372 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL changes the syntax for external constants to better reflect for what they are actually used. Drive-by change: Ran the format tool on base.tq. R=danno@chromium.org, tebbi@chromium.org Bug: v8:7793 Change-Id: Ie49c28b9c95a05846a2d9801f01b11e5a58d72d9 Reviewed-on: https://chromium-review.googlesource.com/1111706Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#53963}
-
Simon Zünd authored
This CL moves every method definition with >5 LoC from declaration-visitor.h to declaration-visitor.cc. R=tebbi@chromium.org Bug: v8:7793 Change-Id: I61b5672c9662608fd33c3a23af6176cfa9791295 Reviewed-on: https://chromium-review.googlesource.com/1111709Reviewed-by:
-
Michael Starzinger authored
This changes the WebAssembly pipeline to no longer expect source position tables for {WasmCode} to be allocated on the GC'ed heap. R=clemensh@chromium.org BUG=v8:7721 Change-Id: Ib2c6e3d0840e47b83809f60519c0d1b94af186af Reviewed-on: https://chromium-review.googlesource.com/1109686 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: -
Igor Sheludko authored
Bug: v8:5269, v8:7754 Change-Id: I5cde20c269b60145b20e9cfbbd94bcaf3fac6feb Reviewed-on: https://chromium-review.googlesource.com/1110132Reviewed-by:
-
Clemens Hammacher authored
Before flipping the flag, some tests need to be adapted. This CL prepares these tests, such that the flag flip CL really just flips a flag. R=titzer@chromium.org, hablich@chromium.org Bug: v8:6600, chromium:787421 Change-Id: I8030df69cda5f3fb81354350a37f65c0d1c669bd Reviewed-on: https://chromium-review.googlesource.com/1110363Reviewed-by:
-
Igor Sheludko authored
Bug: v8:7754 Change-Id: I6e1461d5e4214b5649f850166c3a988019098465 Reviewed-on: https://chromium-review.googlesource.com/1110126 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Peter Marshall authored
We can just call these builtins from CSA with the CallBuiltin helper which calls Builtins::CallableFor. Bug: v8:7754 Change-Id: I11cc9db37aba1b81dc4000600fed84fa84b6ff39 Reviewed-on: https://chromium-review.googlesource.com/1110130 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#53957}
-
Sigurd Schneider authored
This CL adds the BUILTIN kind specific flag is_off_heap_trampoline to Code objects. Code objects hence know whether they are off-heap trampolines, and can decide whether they need to return the off-heap instruction start or not without looking at the builtin index and/or considering the existence of an embedded blob. Bug: v8:6666 Change-Id: I0fbc540a2624ed5fa8256b807299e2fe4b907dda Reviewed-on: https://chromium-review.googlesource.com/1109691 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Georg Neis authored
This partially reverts commit bffe040e, which bypassed the cache globally. Now we bypass it only in Turbofan. R=jarin@chromium.org Bug: v8:7790, chromium:854976 Change-Id: I62a9904c06915f6f6e4a6b628dc3dcba5151bb87 Reviewed-on: https://chromium-review.googlesource.com/1109969Reviewed-by:
-
Clemens Hammacher authored
This prologue is not needed any more now that we have the jump table. If optimized code exists, we will not even enter the Liftoff code any more, but instead jump to the optimized code right away. This also allows to remove the {WASM_CODE_TABLE_ENTRY} relocation info kind. R=mstarzinger@chromium.org Bug: v8:7758 Change-Id: I0449693d7434088fb264104fe59365d7ca2b74c6 Reviewed-on: https://chromium-review.googlesource.com/1110222Reviewed-by: -
Georg Neis authored
The dependency is unnecessary. Also add a DCHECK that effectively ensures that the instance size can't change. NOPRESUBMIT=true Bug: v8:7790 Change-Id: Ib68ed044f2f87a0b8b83f4110756f3d3ad96c530 Reviewed-on: https://chromium-review.googlesource.com/1110121 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#53953}
-
Yang Guo authored
TBR=machenbach@chromium.org Bug: v8:7877 Change-Id: Id890681e70cea8beef89ea2df2578255906fb7f6 Reviewed-on: https://chromium-review.googlesource.com/1110136 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Yang Guo authored
TBR=clemensh@chromium.org Bug: v8:7879 Change-Id: Ib8c394fc7696d1eaf831cbfd31e5aada26aa3a9b Reviewed-on: https://chromium-review.googlesource.com/1111698 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Yang Guo authored
TBR=binji@chromium.org Bug: v8:7876 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I95b1a674cb9852f9840e502ceffabbd6fcb689b7 Reviewed-on: https://chromium-review.googlesource.com/1111697Reviewed-by:
-
- 21 Jun, 2018 13 commits
-
-
Eric Holk authored
This change adds an addition 2GiB of guard region in front of guarded WebAssembly memories. This provides defense in depth against code generation errors, such as accidental sign extension of a 32-bit value. As we consider supporting 4GiB WebAssembly memories, this is an important line of defense. Change-Id: Ica643c01ef28b5d2a01fbbd46273442545d8448e Reviewed-on: https://chromium-review.googlesource.com/1108503 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
-
Junliang Yan authored
Port 0f5a0719 Original Commit Message: This CL reverts commit 38bec2ea and implements the same functionality via Assembler::RecordRelocInfo. R=sigurds@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I5a6d65bb2cc7cdaf1b982b3fb05cbb01b2099db2 Reviewed-on: https://chromium-review.googlesource.com/1110154Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#53948}
-
Bill Budge authored
- Handles zip, unzip, and transpose shuffles/swizzles. - Adds punpck* instructions to assembler. Bug: v8:6020 Change-Id: If124b7a7462ffd0470347b54ce4a93c01667e384 Reviewed-on: https://chromium-review.googlesource.com/1084069Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#53947}
-
Clemens Hammacher authored
This CL adds a builtin which receives an int32 argument and returns the int32 result. Internally, it checks whether the argument is in the valid smi range, then calls the runtime function with the smi argument and converts the return value back from smi to int32. This saves a lot of code in the wasm TF builder and in Liftoff. R=mstarzinger@chromium.org Bug: v8:6600 Change-Id: Icddcb020eae74c767a75090feb4939275432c007 Reviewed-on: https://chromium-review.googlesource.com/1107711 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Dan Elphick authored
Pass Isolate directly into CallHandlerInfo methods so that calls to GetHeap can be removed. Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: If28fbbd65530b01b69786c3e743754cff3b1ba3a Reviewed-on: https://chromium-review.googlesource.com/1107926Reviewed-by:
-
Leszek Swirski authored
Bug: v8:7786 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: Ic00953a5375f60b61a093234c03ce0df41dbe228 Reviewed-on: https://chromium-review.googlesource.com/1110125Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#53944}
-
Tobias Tebbi authored
This removes error messages about missing _True labels, and instead tries find overloads for the branch protocol and a normal function call at the same time. The branch protocol is only considered if there are _True and _False in the context and the overload returns never. In addition, it prints all macro names of operator overloads if none was matching. Bug: v8:7793 Change-Id: Id81712f5b7f2af6765e23bb1f37438f141a79316 Reviewed-on: https://chromium-review.googlesource.com/1109839Reviewed-by:
-
Yang Guo authored
TBR=binji@chromium.org Bug: v8:7876 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ic98cb9a8f54980e563b765356adfd2653965ff9a Reviewed-on: https://chromium-review.googlesource.com/1110135Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ib8725fb5d7cd6909c522e3dca015e192a3dc6b01 Reviewed-on: https://chromium-review.googlesource.com/1110124Reviewed-by:
-
Yang Guo authored
TBR=clemensh@chromium.org Bug: v8:7872 Change-Id: I1f61e1ec7ffd86c7e8f74821fa0c4cd59bef57b2 Reviewed-on: https://chromium-review.googlesource.com/1110134Reviewed-by:
-
Georg Neis authored
Also add a DCHECK to a branch that can only be taken for the null prototype. R=sigurds@chromium.org Change-Id: Ib94fe8f25ecfd1a4baa576915e6edfa60bcd771b Reviewed-on: https://chromium-review.googlesource.com/1109961 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Rodrigo Bruno authored
Bug: chromium:845409 Change-Id: Ica0f7417a0d695900fa0578cd1248499ffa55f08 Reviewed-on: https://chromium-review.googlesource.com/1109965 Commit-Queue: Rodrigo Bruno <rfbpb@google.com> Reviewed-by:
-
Yang Guo authored
This reverts commit 18d0d7f6. Reason for revert: Tentative revert. This has somehow broken the custom snapshot build https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/19822 Original change's description: > Ship Symbol.prototype.description > > Intent to ship: > https://groups.google.com/forum/#!msg/v8-users/9U2kEQw8pb8/Sn91yUx5BQAJ > > Bug: v8:7807 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Ia9e73495b08b432371dfb0ccc571af969ae4d59f > Reviewed-on: https://chromium-review.googlesource.com/1107210 > Commit-Queue: Joyee Cheung <joyee@igalia.com> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53933} TBR=kozyatinskiy@chromium.org,gsathya@chromium.org,luoe@chromium.org,joyee@igalia.com Change-Id: I28835d35d594ed8e14d824627e6aadb0360618f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7807 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1110237Reviewed-by:
-
