- 20 Sep, 2018 1 commit
-
-
Sam Clegg authored
Previously we only supported strings and not filenames. This changes the default to filename and adds a new `type: string` which can be passed `options` to allow for strings to be passed in test code. See: https://developer.mozilla.org/en-US/docs/Web/API/Worker/Worker Bug: v8:8020 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie8818885c5c5c071b6614852322cb45aeb01a647 Reviewed-on: https://chromium-review.googlesource.com/1185980 Commit-Queue: Sam Clegg <sbc@chromium.org> Reviewed-by: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#56056}
-
- 19 Jul, 2018 2 commits
-
-
Ben Smith authored
The previous change to futex.js will spawn too many workers in d8 in some test configurations, which will throw an error. This CL works around that by spawning fewer workers for the Atomics.notify tests. TBR=adamk@chromium.org Bug: v8:7338 Change-Id: I0f3583781e5352b4d6672d43a087dc56d920122d Reviewed-on: https://chromium-review.googlesource.com/1142895Reviewed-by: Ben Smith <binji@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#54536}
-
Ben Smith authored
At the May 2018 TC39 meeting, they decided to rename Atomics.wake to Atomics.notify. This change adds Atomics.notify as an alias, but does not remove Atomics.wake, which will be removed later. This allows for embedders to use either name to prevent breaking tests. When the tests are switched over, we can remove Atomics.wake. Bug: v8:7883 Change-Id: If057ebff162bde975c6e1b60d83a4662f144e81f Reviewed-on: https://chromium-review.googlesource.com/1142290 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#54534}
-
- 31 May, 2017 1 commit
-
-
Ben Smith authored
Bug: chromium:724973 Change-Id: I227b30b50f92fac7d6cf3ec3369e324282352ccb Reviewed-on: https://chromium-review.googlesource.com/514348Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#45643}
-
- 13 Mar, 2017 1 commit
-
-
binji authored
This reverts the previous revert, commit 5a04f4fd. Previously reverted changes: > Revert "[SAB] Move Atomics builtins to C++" > > This reverts commit 2b9840d8. > > Revert "[SAB] Remove unreachable Uint8Clamped atomics paths" > > This reverts commit d1160fb1. > > Revert "Remove tiny unit test for MinSimple/MaxSimple" > > This reverts commit 837760ec. > > Revert "Remove infrastructure for experimental JS natives" > > This reverts commit 8cfe45b6. These changes were reverted to improve a perf regression on a Chrome bot. Since then, the regression has reappeared, then disappeared again all from seemingly unrelated changes. BUG=v8:6033 TBR=adamk@chromium.org,hpayer@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2732213005 Cr-Commit-Position: refs/heads/master@{#43758}
-
- 27 Feb, 2017 1 commit
-
-
binji authored
perf regression. See crbug.com/695653 for more info. Revert "[SAB] Move Atomics builtins to C++" This reverts commit 2b9840d8. Revert "[SAB] Remove unreachable Uint8Clamped atomics paths" This reverts commit d1160fb1. Revert "Remove tiny unit test for MinSimple/MaxSimple" This reverts commit 837760ec. Revert "Remove infrastructure for experimental JS natives" This reverts commit 8cfe45b6. BUG=695653 TBR=hablich@chromium.org Review-Url: https://codereview.chromium.org/2715223003 Cr-Commit-Position: refs/heads/master@{#43462}
-
- 20 Feb, 2017 1 commit
-
-
littledan authored
This patch refactors the Atomics builtins so that they are implemented as C++ builtins rather than experimental JS builtins. Previously, each of these functions called out to a runtime function, so no significant change in performance is anticipated. The goal of this patch is to remove the last user of experimental JS builtins so that the mechanism can be removed, for performance reasons. The patch includes a drive-by fix of a check-fail. For the most part, the patch is just moving code without modification from runtime-atomics.cc to builtins-sharedarraybuffer.cc . BUG=v8:5880 Review-Url: https://codereview.chromium.org/2698813004 Cr-Commit-Position: refs/heads/master@{#43335}
-
- 01 Feb, 2017 1 commit
-
-
binji authored
Also if the count is not specified, it should wake all waiters. BUG=v8:4777 Review-Url: https://codereview.chromium.org/2659083004 Cr-Commit-Position: refs/heads/master@{#42871}
-
- 27 Jan, 2017 1 commit
-
-
binji authored
Review-Url: https://codereview.chromium.org/2643723010 Cr-Commit-Position: refs/heads/master@{#42749}
-
- 23 Jan, 2017 1 commit
-
-
binji authored
Atomics.wait is a function which may block, which is not allowed on the main thread. Since V8 doesn't know whether a particular isolate is the "main thread", this CL adds an option to Isolate::CreateParams to choose whether this function is allowed. Review-Url: https://codereview.chromium.org/2642293002 Cr-Commit-Position: refs/heads/master@{#42611}
-
- 13 Jul, 2016 1 commit
-
-
binji authored
* Rename Atomics.futexWait -> Atomics.wait * Rename Atomics.futexWake -> Atomics.wake * Remove Atomics.futexWakeOrRequeue * Return value of Atomics.wait is now a string: "ok", "not-equal" or "timed-out" * Update comments that reference URL for ecmascript_sharedmem to https://github.com/tc39/ecmascript_sharedmem Review-Url: https://codereview.chromium.org/2143443002 Cr-Commit-Position: refs/heads/master@{#37727}
-
- 25 Mar, 2016 1 commit
-
-
binji authored
BUG=v8:4737 LOG=n R=jarin@chromium.org Review URL: https://codereview.chromium.org/1676613002 Cr-Commit-Position: refs/heads/master@{#35074}
-
- 20 Nov, 2015 1 commit
-
-
pan.deng authored
BUG=v8:4555 LOG=N Review URL: https://codereview.chromium.org/1462833002 Cr-Commit-Position: refs/heads/master@{#32142}
-
- 01 Sep, 2015 1 commit
-
-
binji authored
Having both flags is tedious, and it is unlikely you'd ever want them separately. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1304163010 Cr-Commit-Position: refs/heads/master@{#30523}
-
- 17 Jul, 2015 1 commit
-
-
binji authored
BUG=chromium:497295 R=jarin@chromium.org LOG=n Review URL: https://codereview.chromium.org/1208933006 Cr-Commit-Position: refs/heads/master@{#29736}
-