- 06 Jul, 2022 18 commits
-
-
Michael Achenbach authored
Remove configs for bots that were removed. Dedicated focal bots and x86 gcc bots. Bug: chromium:1307180, v8:13005 Change-Id: I482829f6644642b3d9fe1b380b2a3edaba2045d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747869Reviewed-by:
Alexander Schulze <alexschulze@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#81561}
-
Shu-yu Guo authored
Change-Id: I7996f49f5358d8be684a39b64020bc6bef82b7bb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3739228 Commit-Queue: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/main@{#81560}
-
Shu-yu Guo authored
Code in client heaps can embed pointers to shared objects. In non-shared GC, these pointers can be weak. During shared GC, unconditionally consider Code-embedded client->shared pointers as strong so we don't have to deoptimize and clear embedded objects in all client Isolates' Code instances. Bug: v8:13027 Change-Id: Id34d7e707153191639e8e531fc12d917b9382a26 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3739231Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#81559}
-
Andy Wingo authored
See https://github.com/WebAssembly/stringref/issues/1. Bug: v8:12868 Change-Id: Icd197b4872a72ae84878b2ac48a66f7026ab90cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3745369 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81558}
-
Joyee Cheung authored
When the failed access callback is configured but it doesn't throw, we should return instead of expecting an exception, otherwise it would crash because there isn't one. This patch also adds --throw-on-failed-access-check and --noop-on-failed-access-check in d8 to mimic the behavior of the failed access check callback in chromium. Bug: chromium:1339722 Change-Id: Ie1db9d2fb364c6f8259eb9b8d81a21071c280a80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3737305 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#81557}
-
Manos Koukoutos authored
Mainly src/compiler-dispatcher, src/d8, src/debug, src/runtime. Drive-by: Restore CONDITIONAL_WRITE_BARRIER invocation, which was accidentally changed. Bug: v8:13006 Change-Id: If07334b654b9ba2d4bec14a11cfdeeb1aa953b7d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3745402 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
Fix some issues with nested suspenders: - Fix scratch register conflict when returning from an inner suspender - The outer suspender should stay in 'Active' state - Suspenders should become 'Inactive' when they return CC=ahaas@chromium.org Bug: v8:12191 Change-Id: Ic6c6108c4f8df3d32417d7813eb04e0e2a46d27a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3743386Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#81555}
-
Clemens Backes authored
The streaming decoder did not properly check the ordering of sections relative to the code section. This CL fixes that for both empty and non-empty code sections. The special path for empty code sections is not actually needed, so remove it to simplify code paths. Drive-by: 1. Refactor the existing code for checking section ordering to make it more structured and readable. 2. Ensure that we either call {DecodeCodeSection} or {StartCodeSection}, but not both. 3. Remove {set_code_section}, merge it into {StartCodeSection}. 4. Simplify calls to {CalculateGlobalOffsets} (make them unconditional and remove one redundant one). R=ahaas@chromium.org Bug: chromium:1336380 Change-Id: Ia2c5c115d43d2b5315e3b3c9e4a21175a36aa326 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747860Reviewed-by: -
Danylo Boiko authored
General: - Graph view refactoring Turboshaft: - Blocks representation - Inline nodes representation - Minimum required turboshaft toolbox actions - Layout caching Bug: v8:7327 Change-Id: I2ac07965ac775c68c522cfc9367b7ce0ff18672a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3726287Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Danylo Boiko <danielboyko02@gmail.com> Cr-Commit-Position: refs/heads/main@{#81553}
-
Michael Achenbach authored
GCC warnings are already treated as failures on other bots. They don't add value on the coverage bot and only block creating reports. Bug: v8:13005 Change-Id: I2d55288a4790e8cd508cdb8340265c696e44b671 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747864Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#81552}
-
Liu Yu authored
Port commit 8559a04f Change-Id: I74bbbaddb196bba0945cc857e708534e4eb3f9b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747466Reviewed-by:
-
Michael Achenbach authored
There is already a builder v8_linux64_header_includes_dbg blocking CQ and a CI counterpart for this feature. Also switching it on for gcc doesn't add value, just a slow-down of the gcc bots. No-Try: true Bug: v8:13005 Change-Id: Id20112928b8db406ce998cf463ddb3f95aa8e361 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747859 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#81550}
-
Jakob Kummerow authored
Speculative fix as I can't repro the failures locally. Change-Id: I0a06ee02435e5131c44c7b4bef142cb4385d3243 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747861 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#81549}
-
Michael Achenbach authored
This is a workaround to silence gcc failures stemming from googletest headers. Bug: chromium:1307180 Change-Id: Ia6eb08f170f65c2fde6e4c287f9781d9df559b35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3738220Reviewed-by:
-
Michael Achenbach authored
No-Try: true Bug: v8:13005 Change-Id: Ie941d501ca6bdb8dc40d2188fb62741440fa6caf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3747857 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9ea9d49..f855a2b R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I6dfb1ac58aad1c11620d42efcd9e0c340eaae762 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3746083 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81546}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/android_sdk/public: PGPmqJtSIQ84If155ba7iTU846h5WJ-bL5d_OoUWEWYC..IPzAG-uU5zVMxohpg9-7-N0tQC1TCSW1VbrBFw7Ld04C Rolling v8/third_party/fuchsia-sdk/sdk: version:8.20220701.2.1..version:8.20220705.3.1 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: Id0df943e5c230c0ad061fe88716c646756ab8d37 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3746082 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#81545}
-
Lu Yahan authored
Port commit 8559a04f Change-Id: Ibeafd18e3bed0907536b93d1fd4c5db98bef41ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3746292 Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#81544}
-
- 05 Jul, 2022 22 commits
-
-
Milad Fa authored
Changes for TF instruction selector will be pasted in the CL comments and will get applied once all relaxed opcodes have been implemented in codegen/liftoff. Change-Id: I61f393b4df7d6b2dbe14632e71b3f317379b4ae6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3743507 Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Reviewed-by:
Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#81543}
-
ishell@chromium.org authored
Bug: v8:13038 Change-Id: I98832b00523535b57cde67d4d389aa361bc19a46 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3745405Reviewed-by:
-
Nikolaos Papaspyrou authored
Minor bug fix in alias support (crrev.com/c/3723506), which broke modes with suffixes, e.g. x64.release-css or x64.rel-css No-Try: True Change-Id: I16fdc83dde269f66f4bb7260de0d2649aaece27e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3732929 Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#81541}
-
Michael Lippautz authored
GCInfoTable is a process-global table storing Oilpan type information. Table operations may fail in OOM scenarios which were previously just caught in regular CHECKs. Change to use a global OOM handler that is set up to use V8's handler. Bug: chromium:1283199 Change-Id: Id33263ef7cd4028d60a071f5ab3b165e59ac9593 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3745368Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
This is a reland of commit 2d74bfa4 Difference compared to original: Restore one needed include. Original change's description: > Remove some unused includes > > Mostly src/api, src/asmjs. src/ast, src/base, src/wasm. > > Bug: v8:13006 > Change-Id: If4e85afe003fda9f8a681077827c3502e939fe57 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3742702 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81523} Bug: v8:13006 Change-Id: I88c45059572fa25af4e0999f479ba5c28572db7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3746077Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#81539}
-
snek authored
Load current Memory start/size off of the wasm instance when entering fast calls, so they can use that info for whatever they need to do. Fast calls from JS set the memory to null, and the memory does not need to be piped from wasm to slow callbacks as wasm always calls the fast function. Change-Id: Ibfa33cdd7dba85300f95cbdacc9a56b3f7181663 Bug: chromium:1052746 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3719005Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Luis Fernando Pardo Sixtos authored
Atomics.load, Atomics.store, and Atomics.exchange now accept shared array objects as their 1st argument. Currently these are implemented in C++ and not yet in CSA. Bug: v8:12547 Change-Id: I54ed8816a696a4f45dda964739b1cfd917d39dc0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3723974Reviewed-by:
Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Andy Wingo authored
To make an array from a string, we were passing an interior pointer to the array's contents to NewStringFromUtf8 -- but the allocation could cause that interior pointer to become invalid. As part of the fix, also start to refactor to put the notion of UTF-8 variants closer to unibrow. This will allow us to unify more UTF-8/WTF-8/sloppy UTF-8 code paths. Bug: v8:12868, v8:13028, v8:13036 Change-Id: I61f53a6882b5ebe1d0b38594412cb35ff0e28a94 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3742701 Commit-Queue: Andy Wingo <wingo@igalia.com> Reviewed-by:
-
Milad Fa authored
Port 84e078c6 Original Commit Message: This CL implements checks in case EnforceRange is requested for a given parameter by using TryTruncate* operators. It implements 2 such truncations on x64 and arm64 - TryTruncateFloat64ToInt32 and TryTruncateFloat64ToUint32. R=mslekova@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com BUG= LOG=N Change-Id: Iaf6834b9cfe3d43298adfe2c71ec3d55aa14f935 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3743467Reviewed-by:
-
jameslahm authored
... objects/intl-unittest. Bug: v8:12781 Change-Id: I225054f5d0071f28d5b4d1efe8698ce5d0276c0c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3725448Reviewed-by:
-
Jakob Kummerow authored
Unused as of this CL; users will follow. Bug: v8:12917 Change-Id: I82658ea8a401834a5b3661068766bbdfec54d5a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3726214Reviewed-by:
-
Jakob Kummerow authored
Change-Id: I3ae32354c592e4a605f1d0c34f4dd3d9cad16795 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3745404 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
jameslahm authored
... utils/identity-map-unittest. Bug: v8:12781 Change-Id: I875de2b1e589ec72d724a6d0745a5d615344b510 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3724792Reviewed-by:
-
Marja Hölttä authored
Bug: chromium:1309467,chromium:1308360,v8:9237 Change-Id: I77b004e263a9bed98a0dfe5936bdad055bde36a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3745365Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#81530}
-
Maya Lekova authored
This is a reland of commit 84e078c6. It fixes an undefined behaviour and guards against NaNs in d8-test.cc. Original change's description: > [fastcall] Support EnforceRange annotation > > This CL implements checks in case EnforceRange is requested for a > given parameter by using TryTruncate* operators. It implements 2 such > truncations on x64 and arm64 - TryTruncateFloat64ToInt32 and > TryTruncateFloat64ToUint32. > > Bug: chromium:1052746 > Change-Id: I32f34d9dc1265af568cc576663620a8f7f8245f6 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3721618 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81512} Bug: chromium:1052746, chromium:1341851, chromium:1341891 Change-Id: I21e0e452c92cc93f8b06985a335f409855be0546 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3743518Reviewed-by:
-
Junliang Yan authored
Change-Id: Id10cfdb8f3a380eb1cd39be569e152b3ebe41b44 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3735166Reviewed-by:
-
Jakob Kummerow authored
Fixed: chromium:1341180 Change-Id: Ib475310b18c31e5e3e0fc5e52dab736ebb6ac55a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3738745Reviewed-by:
-
Manos Koukoutos authored
This reverts commit 2d74bfa4. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20debug%20builder/7403/overview Original change's description: > Remove some unused includes > > Mostly src/api, src/asmjs. src/ast, src/base, src/wasm. > > Bug: v8:13006 > Change-Id: If4e85afe003fda9f8a681077827c3502e939fe57 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3742702 > Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> > Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/main@{#81523} Bug: v8:13006 Change-Id: I7579dc3805ed4cbcd56488c31450c7941b430b1a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3746076 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Hao Xu authored
Smi handler in LoadIC is decoded to IntPtrT and result in sign-extending Smi's value when pointer compression is enabled. This CL avoid this sign-extension by decoding the Smi to Int32T. Change-Id: I3ddd6dcec8654d6c13d472a077a55698359d126a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3740481 Commit-Queue: Hao A Xu <hao.a.xu@intel.com> Reviewed-by:
-
Omer Katz authored
Extract AllocationCounter (which manages the allocation observers) out of Space and pass it on initialization. AllocationCounter will instead be a field of the subclasses (e.g. PagedSpace, NewSpace). This will allow to reuse the same AllocationCounter for the NewSpace and PagedSpaceBase parts of PagedNewSpace (crrev.com/c/3641178). Bug: v8:12612 Change-Id: Ie6ed10d1b138a5724cf9b469ab9c943518850ad4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3745403 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
Mostly src/api, src/asmjs. src/ast, src/base, src/wasm. Bug: v8:13006 Change-Id: If4e85afe003fda9f8a681077827c3502e939fe57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3742702Reviewed-by:
-
Jakob Kummerow authored
Prints information about sections in a given module and their sizes. Change-Id: I3bf02f0c8be53756364db4d2dada60bc8a510815 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3743447Reviewed-by:
-
