- 07 May, 2019 6 commits
-
-
Maya Lekova authored
The call to EnsureSourcePositionsAvailable for a given SharedFunctionInfo is now done in the serializer for each SFI that is marked as serialized for compilation. This will enable brokerization of the JSInliner class. Change-Id: I7821a50fcac8a3e19386e98758f2b0dea3023bb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1582400 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#61260}
-
Jakob Gruber authored
This reverts commit efd8c2d9. Reason for revert: Performance regressions (chromium:958035) Original change's description: > Remove --win64-unwinding-info flag and always generate unwind info on Win/x64 > > The generation of unwind info to enable stack walking on Windows/x64 > (https://chromium-review.googlesource.com/c/v8/v8/+/1469329) was implemented > behind a temporary flag, in order to coordinate these changes with the > corresponding changes in Chromium. > > The required changes to Chromium > (https://chromium-review.googlesource.com/c/chromium/src/+/1474703) have also > been merged, so we can now remove the flag and enable the generation of stack > unwinding info by default on Windows/x64. > > Bug: v8:3598 > Change-Id: I88814aaeabecc007f5262227aa0681a1d16156d5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1573138 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Paolo Severini <paolosev@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#61020} TBR=ulan@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,paolosev@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Tbr: ulan@chromium.org,mstarzinger@chromium.org,paolosev@microsoft.com Bug: v8:3598, chromium:958035 Change-Id: Ia86a230ee83080ed8ace43e4641c8c1013043df4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598748 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#61259}
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/6281d0d..27799cd Fix bikeshed build (#1014) (Ben Smith) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/27799cd [spec] Fix typo (#1011) (Galaxtone) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/6172038 TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I65c6da974440bc368993d221824372489cdc787a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598528Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#61258}
-
Milad Farazmand authored
This reverts commit b51404a8. Reason for revert: Need to revert this change due to a revert on this commit: 18100666 Original change's description: > PPC/S390: [typedarray] Make JSTypedArray::length authoritative. > > Removing NumberToSize on PPC and S390. > > Port ad44c258 > > Change-Id: Ic5d3132f1bb396f07a26399d2e3f6aca4689aa3f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1554227 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60691} TBR=jarin@chromium.org,titzer@chromium.org,petermarshall@chromium.org,bmeurer@chromium.org,miladfar@ca.ibm.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Idd6cf715ce25ed35f9cb55c70e20183072c660d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598308Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#61257}
-
Yu Yin authored
Change-Id: I98ebc42a7dc343abc471d04c606b6746f6cae18a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596047Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Yu Yin <xwafish@gmail.com> Cr-Commit-Position: refs/heads/master@{#61256}
-
Yu Yin authored
mips load/store instructions can only handle when the memory offset is in range [int16_min, int16_max], when beyond this range, we can use macro instructions which will adjust base and offset first. Change-Id: I84319b7fef9de8d0b8f507374654e38827503bdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596046Reviewed-by:
-
- 06 May, 2019 29 commits
-
-
Alexander Neville authored
Change-Id: If464c03c16e322fa4268a511fa984bb143b65a50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594290 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#61254}
-
Johannes Henkel authored
New revision: 2039736177ee11d96a096cdab9c58cc1d78faa43 This modifies roll.py to update namespaces and header guards. Also I'm removing --reverse, to avoid making this more complicated. third_party/encoding/encoding{.h,cc} are already up to date, since I manually propaged them earlier. So this is why this change is only updating the template. Change-Id: I5ddb075c9d6dad28b5665348023860683e964841 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596392Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61253}
-
Z Duong Nguyen-Huu authored
Bug: v8:8996 Change-Id: Ie4b17928fcb9d426bade5afc1238d24bc75ec13e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594275 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
Peter Wong <peter.wm.wong@gmail.com> Cr-Commit-Position: refs/heads/master@{#61252}
-
Georg Schmid authored
R=tebbi@chromium.org Change-Id: I1003a4f4a0e9227618e685a2fb56ead2083709a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594731 Commit-Queue: Georg Schmid <gsps@google.com> Reviewed-by:
-
Toon Verwaest authored
It's not necessarily helpful, and can actually cause pretty bad performance and memory usage. I moved up the next_ field to where allocation_ used to be since apparently the alignment caused by it has huge impact on perf (>10% diff...) at least on my machine. Change-Id: I1026a2e954d061b1a178f6a733d8ef81ae6d0cab Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594432 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#61250}
-
Michael Achenbach authored
Error messages are unspecified in JavaScript and occasional small differences in the compared configurations lead to an unjustified maintenance burden of correctness-fuzzing issues. This CL replaces most error messages with a fixed suppression message during correctness fuzzing (behind a flag). The flag covering all extra behavior for correctness fuzzing is now renamed to --correctness-fuzzer-suppressions. Bug: chromium:958668,chromium:946476 Change-Id: Iba1197f765138a962d5bbb176730322e5a411707 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594730 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Original change's description: > [runtime] Inline SeqOneByteSubStringKey IsMatch and AsHandle > > The performance actually matters to JSON parsing and this improves it by a % or > 2. > > In the longer run we should probably share the IsMatch implementation in > StringTableKey directly and call a virtual GetBytes on the key implementation. > > Change-Id: I838a106f9c8c52f0385057a52a8c0b9141ae025b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1589977 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Auto-Submit: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61183} Change-Id: I3fc73b4d123f193f7c2ce3078b0b030a652efc17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596735 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
This is a reland of b0c4a876 Original change's description: > [json] Speed up json parsing > > - scan using raw data pointers + GC callback > - scan using scanner tables > - cap internalizing large string values > - inline fast transitioning logic > > Fixes previous CL by moving AllowHeapAllocation to callers of > ReportUnexpectedCharacter where needed to make it clear we need to exit. > > Tbr: ulan@chromium.org > Change-Id: Icfbb7cd536e0fbe153f34acca5d0fab6b5453d71 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591778 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61159} Change-Id: I0d713e02d243723df2d2a7c252eae44a6648b6b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596444Reviewed-by:
-
Jaroslav Sevcik authored
Bug: v8:7790 Change-Id: I513c3ba048eafb7ca5bfa2fb63e35143f49643ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596736 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Jakob Gruber authored
Until this CL, the Memory benchmark was the only one to be based on a cctest runner; all others use d8. Besides being a tedious exception to the rule, this caused issues such as described in the linked bug (summary: refbuilds are built with v8_static_library, and neither cctests nor unittests support this configuration). Here, we move the Memory benchmark into a d8 runner. Bug: v8:9189, chromium:957029 Change-Id: I9b45ff36f4842cb0bdef2c1c4b0184c5509d3385 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588464 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#61245}
-
Clemens Hammacher authored
To reduce physical memory consumption, discard code pages that are fully freed. To determine pages which only become fully free after several freed wasm code objects, this CL adds a {DisjointAllocationPool} to track all freed code ({freed_code_space_} in {NativeModule}). R=mstarzinger@chromium.org Bug: v8:8217 Change-Id: I22ad92d2c0bd4469e92f0dfd5aec05c03b5a47d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594728 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Clemens Hammacher authored
This deprecates the variant taking an int argument. Chromium was switched to the size_t variant in https://crrev.com/c/1583747 and https://crrev.com/c/1587597. Pdfium was switched here: https://pdfium-review.googlesource.com/c/pdfium/+/53996 R=ulan@chromium.org Change-Id: I0f4e007b2edc7a176bd8865600bfd5e70b838c3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581640Reviewed-by:
-
Ben L. Titzer authored
R=jarin@chromium.org Change-Id: I47b506599ae338e8323ef0def63db3b2004ac798 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594562Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#61242}
-
Georg Neis authored
This fixes a performance regression. Bug: v8:9197, chromium:958730 Change-Id: I70a59dd85d74275b967a196e9ab4623293b92756 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596446Reviewed-by:
-
Frederik Gossen authored
The interpreter accesses code directly from the code manager. With lazy validation, however, this code is not guaranteed to exist. The interpreter now checks for this and compiles it lazily if needed. It also handles exceptions that may arise from lazy validation. Bug: v8:9003 Change-Id: I37c365f0a4d755ed55630d01c8526f2a3efa9a9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594567Reviewed-by:
-
Michael Starzinger authored
This fixes the source position printed in the stack trace for exceptions thrown from within Wasm code. Specifically this affects the stack trace attached to the exception object, as well as the message propagated to the console. Both are tested by the new message test. R=clemensh@chromium.org TEST=message/fail/wasm-exception-throw BUG=v8:8091 Change-Id: I5b2f76191cf47457ac113dce9d9601a8a810ee19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591603Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7793 Change-Id: If419ec5659e98ebeba454417d097a7981ac3da65 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596729Reviewed-by:
-
Yang Guo authored
R=petermarshall@chromium.org Change-Id: Ib0cfb056ed328a4c6cb0851921f913613b3f1a51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591611Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61237}
-
Clemens Hammacher authored
Use the existing move assignment operator instead. R=ulan@chromium.org Bug: v8:9183 Change-Id: Id7a4427da2bbf92d2954faba06e24afe64cb9818 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594729Reviewed-by:
-
Clemens Hammacher authored
It was a std::list for no obvious reason. This CL turns it into a vector, which is the standard data structure we use if we don't have any special requirements. R=mstarzinger@chromium.org Change-Id: Iefc321db9327e0743772dd804e2325266a9bff64 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594727Reviewed-by:
-
Simon Zünd authored
This CL improves SourcePosition support inside the Torque compiler. It starts with the parser, where the SourcePosition of the MatchedInput now encompasses all tokens, not just the first one. Second, AST nodes can now be created with an explicit source position. This can be used to forward the "all encompassing" source position via MatchedInput -> ParseResultIterator to AST nodes. Third, declarables are extended to hold two different SourcePositions: - One represents the whole declarable. For a macro this would inlcude the body as well as the signature. - The other is the SourcePosition of the identifying part of a declarable. In most cases this is the name. For the rest this will stay invalid. R=sigurds@chromium.org, tebbi@chromium.org Bug: v8:7793 Change-Id: I509f83aeef7a040d0ea6363b5b7c31ff1b11f47b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591600 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: -
Simon Zünd authored
This CL extends the stack frame API to include a flag to distinguish between user and V8 builtin frames. The intention is to extend the API in a later CL, so stack traces include builtin frames. This flag gives embedders more control what to do with builtin frames. R=jgruber@chromium.org, yangguo@chromium.org Bug: v8:8742 Change-Id: Ieda5782dd2073c1e7fd49492bfdfa829a43dc710 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1583723Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Frederik Gossen authored
Remove DCHECK because the interpreter may still have activations when the isolate is torn down. This can happen in particular, when {quit} is called in d8. A test for this will follow when v8:9209 is resolved. Change-Id: Ia3ab0daa061d6427df3f778ba5fb195218910280 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594560 Commit-Queue: Frederik Gossen <frgossen@google.com> Reviewed-by: -
Georg Neis authored
Change-Id: I842e6f311e0c95ea7e6256737d0f009a639b0d21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1587382Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#61231}
-
Balaram Makam authored
FNMUL is efficient arm64 instruction, which can save 1 cycle by optimizing FNEG(FMUL x y)) to FNMUL x y and FMUL((FNEG x) y) to FNMUL x y Change-Id: If25d9de1253098b17033a9d8736ff6a1c06601f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1572681 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
-
Simon Zünd authored
This CL adds navigation support for labels in "goto" statements. Similar to labels listed in the "otherwise" clause of call expression, definitions of such a label can be found in two places: - The signature of the current macro. - A label block of a "try" statement that surrounds the "goto". R=sigurds@chromium.org Bug: v8:8880 Change-Id: I6c5ebea0b0f80b1882e6672bbb0f45196a7201ba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594433 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL adds navigation support for labels listed in the "otherwise" part of a call expression. There are two places where a definition for such a label can be found: - The signature of the current macro (caller) - A label block of a "try" statement that surrounds the call expression. R=tebbi@chromium.org Bug: v8:8880 Change-Id: If8849ad29abcf94f301d7a51e3e52c5517601bc0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593295 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: -
Yu Yin authored
port https://crrev.com/c/1588461 to mips. Change-Id: I40c92d080e7acb8a6af786a6b979ddc2e9b635ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596044Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Yu Yin <xwafish@gmail.com> Cr-Commit-Position: refs/heads/master@{#61227}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/341d5fc..dd46a42 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: If28cac0a72a578a3a9a044b134e4b15f496e65a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596230Reviewed-by:
-
- 05 May, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4d9947d..341d5fc TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I3accdb1d3610e042c47540881e46907f1803ae56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1595775Reviewed-by:
-
- 04 May, 2019 3 commits
-
-
Sergiy Belozorov authored
Overall, total test runtime that was wasted due to timeouts is 3420 seconds in the last 2 weeks. Even with 4 retries, assuming all of them time out, needed additional capacity is under 2 hours per week. Based on this analysis, I think it's safe to land this CL. Note that this is not intended as a long-term solution of the timeout problem, but rather a temporary solution to prevent ongoing errors. Proper investigation and correct long-term solution are still needed and tracked in the bug. R=machenbach@chromium.org, tmrts@chromium.org Bug: chromium:841700 Change-Id: Id16e6b784fa85bb9e28ed8c6b267b583636e2dc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593342Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
Ben Smith authored
See the similar fix for memory_copy_wrapper here: https://chromium-review.googlesource.com/c/v8/v8/+/1584326 Bug: chromium:957405 Change-Id: I49e321186e40fd874f10d08e0e5a53aa225cfa19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1590386Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#61223}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/aba3ab5..4d9947d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/bf6e6c9..cca9447 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9c06201..ccd2b4d Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/0ab75b6..2335bfa Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/aa60736..1b65f4e TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Iaa7fe2bd1ea4dae640934bc079a71c6c72696cbe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1595354Reviewed-by:
-
- 03 May, 2019 1 commit
-
-
Z Duong Nguyen-Huu authored
Bug: v8:8996 Change-Id: I86104991d9732157c1fbdff273046bf4f7e0186f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593853 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
