- 17 Aug, 2016 1 commit
-
-
bakkot authored
Reland of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (patchset #2 id:170001 of https://codereview.chromium.org/2113593002/ ) Reason for revert: WebGL tests have been updated and rolled (at https://codereview.chromium.org/2227023002), so this should no longer fail outdated tests. Original issue's description: > Revert of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (patchset #8 id:140001 of https://codereview.chromium.org/2090353003/ ) > > Reason for revert: > Speculative revert to unblock roll: https://codereview.chromium.org/2107223003/ > > Original issue's description: > > Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. > > > > The spec was modified to relax some requirements which implementors had not been > > enforcing. Part of this process involved introducing a new abstract operation > > ToIndex, which had partial overlap with our existing semantics as well as some > > differences (most notably treating undefined as 0). Test262 tests were introduced to > > check for the new semantics, some of which we were failing. This patch amends the > > parts of our implementation corresponding to specification algorithms which use > > ToIndex to follow its semantics precisely. > > > > BUG=v8:4784,v8:5120 > > > > Committed: https://crrev.com/09720349ea058d178521ec58d0a5676443a5a132 > > Cr-Commit-Position: refs/heads/master@{#37406} > > TBR=littledan@chromium.org,adamk@chromium.org,bakkot@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4784,v8:5120 > > Committed: https://crrev.com/b1f7f1f4e41a723d5f997738a07e35a031713b8f > Cr-Commit-Position: refs/heads/master@{#37417} TBR=littledan@chromium.org,adamk@chromium.org,hablich@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4784,v8:5120 Review-Url: https://codereview.chromium.org/2247073004 Cr-Commit-Position: refs/heads/master@{#38689}
-
- 30 Jun, 2016 1 commit
-
-
hablich authored
Revert of Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. (patchset #8 id:140001 of https://codereview.chromium.org/2090353003/ ) Reason for revert: Speculative revert to unblock roll: https://codereview.chromium.org/2107223003/ Original issue's description: > Amend DataView, ArrayBuffer, and TypedArray methods to use ToIndex. > > The spec was modified to relax some requirements which implementors had not been > enforcing. Part of this process involved introducing a new abstract operation > ToIndex, which had partial overlap with our existing semantics as well as some > differences (most notably treating undefined as 0). Test262 tests were introduced to > check for the new semantics, some of which we were failing. This patch amends the > parts of our implementation corresponding to specification algorithms which use > ToIndex to follow its semantics precisely. > > BUG=v8:4784,v8:5120 > > Committed: https://crrev.com/09720349ea058d178521ec58d0a5676443a5a132 > Cr-Commit-Position: refs/heads/master@{#37406} TBR=littledan@chromium.org,adamk@chromium.org,bakkot@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4784,v8:5120 Review-Url: https://codereview.chromium.org/2113593002 Cr-Commit-Position: refs/heads/master@{#37417}
-
- 29 Jun, 2016 1 commit
-
-
bakkot authored
The spec was modified to relax some requirements which implementors had not been enforcing. Part of this process involved introducing a new abstract operation ToIndex, which had partial overlap with our existing semantics as well as some differences (most notably treating undefined as 0). Test262 tests were introduced to check for the new semantics, some of which we were failing. This patch amends the parts of our implementation corresponding to specification algorithms which use ToIndex to follow its semantics precisely. BUG=v8:4784,v8:5120 Review-Url: https://codereview.chromium.org/2090353003 Cr-Commit-Position: refs/heads/master@{#37406}
-
- 18 Nov, 2013 3 commits
-
-
dslomov@chromium.org authored
R=jkummerow@chromium.org BUG=v8:3013 LOG=Y Review URL: https://codereview.chromium.org/74583003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17840 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
This reverts commit r17838 for breaking arm build. TBR=jkummerow@chromium.org Review URL: https://codereview.chromium.org/75213005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17839 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
dslomov@chromium.org authored
R=jkummerow@chromium.org BUG=v8:3013 LOG=Y Review URL: https://codereview.chromium.org/74583003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17838 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Jul, 2013 1 commit
-
-
dslomov@chromium.org authored
Also fix typo in error message id. R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/20030004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15865 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Jul, 2013 1 commit
-
-
dslomov@chromium.org authored
We now use DoubleTo(U)Int32 that follows ES specification. R=titzer@chromium.org,rossberg@chromium.org Review URL: https://codereview.chromium.org/18703007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15659 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Jul, 2013 1 commit
-
-
dslomov@chromium.org authored
ES6 spec for DataView is not fully finished, but Blink, WebKit and Firefox agree in that for DataView use of getters/setters with no arguments should result in exceptions, while undefined offset argument is the same as zero. R=bmeurer@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/18313007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15607 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 24 Jun, 2013 1 commit
-
-
dslomov@chromium.org authored
Update typed arrays behavior to match ES6 rev 15. Remove TO_POSITIVE_INTEGER and throw on negative length arguments. R=rossberg@chromium.org Review URL: https://codereview.chromium.org/17572009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15298 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 21 Jun, 2013 1 commit
-
-
dslomov@chromium.org authored
R=rossberg@chromium.org Review URL: https://codereview.chromium.org/17153011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15269 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-