- 07 Apr, 2022 13 commits
-
-
Clemens Backes authored
Use C++17's std::conjunction together with std::is_same instead. R=leszeks@chromium.org Bug: v8:12425 Change-Id: I75a973f14f0642b00d390aa6ab4eb1ce0208c074 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568478Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79848}
-
Dominik Inführ authored
We can perform these DCHECKs on all pages, not just pages in old space. Bug: v8:12760 Change-Id: I202e1a96190d305b86c69cd6616bdb5ecc812044 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574560Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#79847}
-
Jakob Kummerow authored
This adds feedback collection to count the number of executions of call_direct instructions in Liftoff code. The purpose is better inlining decisions in Turbofan, which are enabled by having call count information for all kinds of calls. The new feature is gated on --wasm-speculative-inlining. While direct calls don't need to speculate about their target, the whole feedback collection infrastructure depends on that flag. Bug: v8:12166 Change-Id: Ie24a988fcea631f370188dc21e60a5fac923dd3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571807Reviewed-by:
Manos Koukoutos <manoskouk@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/main@{#79846}
-
Clemens Backes authored
Some test variants and fuzzers set their own GC interval, so the flag specified in the regression test causes flag contradictions. The test failure was flaky anyway, so this change is only a slight reduction in reproducability, and the test will still be used as seed for the fuzzers. R=machenbach@chromium.org Bug: chromium:1313475 Change-Id: I7c7084ab34fe46d691b841921d42a487cc8a1cad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3576114Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79845}
-
Nikolaos Papaspyrou authored
Minor MC heap verification requires heap iterability. This however was not directly ensured. Coincidentally, there was an unrelated call to `Heap::Verify` that ensured `Heap::MakeHeapIterable` had been called, so the precondition was met. This call was moved to an earlier point by https://crrev.com/c/3497318 and, because of that, some combination of flags now results in a crash. This CL fixes the issue by directly ensuring heap iterability. It also moves back the call to `Heap::Verify`, so that it takes place inside the GC safepoint. Bug: v8:12768 Change-Id: I2c66de0d0a735b84dd9435ff503e78bb3611ce55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3569224Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#79844}
-
Clemens Backes authored
They can be replaced by std::conjunction and c++17 folding expressions. R=tebbi@chromium.org Bug: v8:12425 Change-Id: I109ac904245aab431f11752eff5129fd4361de8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3570428Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79843}
-
Georgia Kouveli authored
Callee saved registers do not include the LR anymore, so we can now remove the last place where we pass a non-default template argument to PushCPURegList/PopCPURegList (in the code generator). This makes the template argument redundant, so we can remove the template altogether. Change-Id: I07f0c0a10840817df8a5afc1dc74330e290ce5bf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571816Reviewed-by:
Jakob Linke <jgruber@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/main@{#79842}
-
Dominik Inführ authored
Turn this assertion also on for release builds for now. This shouldn't regress sweeping performance because we do the same work as in the last release. Bug: v8:12760 Change-Id: I02f78157d20780f46bb4aebf59ce96a7b52f0a27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571810Reviewed-by:
-
Marja Hölttä authored
Bug: v8:11111 Change-Id: I722702faa062e6083496d55cd96ee33d3952998b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571809Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#79840}
-
Camillo Bruni authored
Change-Id: I97d29623e163ceee450814f03fba745d478082ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574550 Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#79839}
-
jiepan authored
Bug: v8:12228 Change-Id: Iab09881d9c8bcd851fd89bf5d6bbd3f2cfb0f3d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3303808Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Jie Pan <jie.pan@intel.com> Cr-Commit-Position: refs/heads/main@{#79838}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e5b74ea..38ea770 Rolling v8/buildtools/linux64: git_revision:5eb3845ec2d8296b4f41da4eca85302eb111fe69..git_revision:ab9104586734cb45aa77c70ca5042edbcc9f6aa5 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/1850510..ac492da Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/ec5b008..5ff11ff Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/b8a4c0b..ba94bbe Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/3b1df9d..c61f267 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/bd06a4f..3436376 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I74d1f9ea47a455438c1371227238bb25784775ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3573514 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79837}
-
Lu Yahan authored
Port d36f596e Change-Id: I13c9d23bb06841e1f6cbb07c68968fb3cc9eb01a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3573784 Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Reviewed-by:
ji qiu <qiuji@iscas.ac.cn> Commit-Queue: ji qiu <qiuji@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#79836}
-
- 06 Apr, 2022 27 commits
-
-
Corentin Pescheloche authored
This CL adds support for interacting with CpuProfile with their integer id. A String ID is problematic because it forces an allocation when stopping or cancelling a Profiler which can happen during a GC when this is not allowed. Change-Id: I9a8e754bd67214be0bbc5ca051bcadf52bf71a68 Bug: chromium:1297283 Co-Authored-By:
Nicolas Dubus <nicodubus@fb.com> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3522896Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Auto-Submit: Corentin Pescheloche <cpescheloche@fb.com> Commit-Queue: Corentin Pescheloche <cpescheloche@fb.com> Cr-Commit-Position: refs/heads/main@{#79835}
-
David Benjamin authored
Bug: v8:12518 Change-Id: Ie22303416749affc0629d60fbed6f9dc4288b09d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3494443Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/main@{#79834}
-
Shu-yu Guo authored
Bug: v8:12744 Change-Id: I3e356c16554e8bc19afc06b18f4afd7fed2f228e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3563540 Commit-Queue: Shu-yu Guo <syg@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
-
Kevin Babbitt authored
Embedders can currently specify a callback for OOM errors during Isolate initialization. However, there are cases where an OOM error can be thrown in a context where we don't have access to an Isolate, for example on a task posted to a worker thread. This CL introduces an initialization API to allow the embedder to specify a process-wide OOM callback. Bug: chromium:614440 Change-Id: I326753d80767679f677e85104d9edeef92e19086 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3561916Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/main@{#79832}
-
Michael Lippautz authored
IM::Finalize() was merely finishing marking through the incremental marking in the atomic pause. Avoid the Hurry() call since the marking worklists would anyways be drained with parallel marking. Bug: v8:12775 Change-Id: Ice72a8bb5f900368eadec7f62bf18e03d568454b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574547Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Jakob Gruber authored
With kLazy deopts gone, we can remove the stored DeoptimizeKind from Deoptimize nodes and all related spots - all Deoptimize nodes are eager deopts. Bug: v8:12765 Change-Id: I8e727e046c498198e50d9b7dba25442fb54f5da9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568456 Auto-Submit: Jakob Linke <jgruber@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Also add a mixin for using the single-threaded default platform instead of swapping it in with SetPlatformForTesting. Bug: v8:12781 Change-Id: I304303e58ed713e5558d108cd7eb826c17abb40f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574553 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Alexander Schulze authored
Currently, v8_presubmit uses the system version of depot_tools for C++ and JS linting. This is an issue for branches which rely on a specific depot_tools version for linting. This CL proposes the use of the depot_tools version defined in DEPS. This change was evaluated in https://crrev.com/c/3571813. The first v8_presubmit attempt uses the system-defined depot_tools version, while the second attempt is rebased on this CL and uses the DEPS defined version. Bug: v8:12743 Change-Id: I87e14ea5c1e3dc20b34106ff56f608d55ec3253d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571805Reviewed-by:
Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/main@{#79828}
-
Seth Brenith authored
Currently, the category named “(compiled code)” contains Code, SharedFunctionInfo, and Script objects. However, there are various other object types that are allocated per script function, such as BytecodeArray and FeedbackVector. There are also plain FixedArrays which are used for function-specific data such as polymorphic feedback and code deoptimization data. I propose we move all of this to the “(compiled code)” category, because this memory usage is related to the number of functions in the script, the size of those functions, and/or the number of times those functions have been called. Bug: v8:12769 Change-Id: Ib5e0265a9ef88063596c17419f5b65f683156c52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3569876Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/main@{#79827}
-
Camillo Bruni authored
This is no longer actively used. Change-Id: I88b0695732ead8652a21ed5d59f3d9752c0c88d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574551Reviewed-by:
-
Clemens Backes authored
A worker might be terminated while creating a new Realm. While this was handled mostly correctly already, a DCHECK was places slightly too early, which is fixed by this CL. Also, we avoid printing an error message if we fail to install an extension due to isolate termination. As this is externally triggered, it's not really an error condition. R=jkummerow@chromium.org Bug: chromium:1313475 Change-Id: I67b7fd27002d9b9a33439378d8336fefb2a2371a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571811Reviewed-by:
-
Omer Katz authored
A lot of the space/chunk methods can be trivially marked as const. There are more methods that can be made const but these will require creating new const object iterators, so those are left out for now. Bug: v8:12612 Change-Id: I753b8b3f7a200ecf255596c7825917e4eb600b81 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571815Reviewed-by:
-
Marja Hölttä authored
Looks like historical leftovers from the time when we had "pixel arrays" and external array elements kinds. See https://codereview.chromium.org/1262583002 Bug: v8:11111 Change-Id: I288d47ae802218737bd6226cbb999c3289d1dbaf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574548Reviewed-by:
-
Dominik Inführ authored
This CL only refactors code in the sweeper without changing behavior. This method can be simplified by moving duplicate code into new methods. Also move definition of FreeRangesMap into TypedSlotSet and replace all usages of that raw map type with that type-alias. Since we are already here, remove the unused argument in Sweeper::FreeAndProcessFreedMemory. Bug: v8:12760 Change-Id: Ifa1848b456aef7955eccbaafc00df55fbcbc385c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574542Reviewed-by:
-
Benedikt Meurer authored
Similar to what we did for FunctionMirror before in https://crrev.com/c/2887508, we also need to avoid running user JavaScript for DateMirrors. This also refactors the ToDateString logic a bit. Fixed: chromium:1311613 Change-Id: I793b86106765550a9aa449f85f0766840081cc58 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571896Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/main@{#79821}
-
Leszek Swirski authored
Change the unittest runner to no longer uncondtionally set up a default platform in the "environment", but to instead make platform set-up part of the "mixin" framework for test fixtures. Requires modifying some tests that expect the platform to be available, and all flag implications resolved, before the mixin constructors run. We still keep the environment for setting up the process for cppgc. This process setup can only be done once per process, so it can no longer use the platform -- that's ok though, the page allocator used by cppgc's process initialisation doesn't have to be the same as the platform's so we can just pass in a separate new one. Change-Id: Ic8ccf39722e8212962c5bba87350c4b304388a7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571886Reviewed-by:
-
Omer Katz authored
TearDown was actually redundant and can be replaced with the dtor. Bug: v8:12612 Change-Id: Idc4a77c3f20372a53b0003cda6fb00ae7ec0035c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571806Reviewed-by:
-
Clemens Backes authored
Replace by std types defined in <type-traits> since C++17. R=mslekova@chromium.org Bug: v8:12425 Change-Id: I7ec8454634ecb63a3da4f93412d7a6c5002bb7c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3572045Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79818}
-
Hannes Payer authored
Bug: v8:12503 Change-Id: I81d02231b7e40fb0ed487de128ffaedcd3cd2126 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571898Reviewed-by:
-
Camillo Bruni authored
Reduce the dispatching overhead in the hottest loop when parsing log-lines. - Using a JSMap we can avoid internalizing strings - Preprocess the dispatch table and only have varArgs or functions as parsers - string[] seems to be slightly faster than string.charAt() Bug: v8:10644 Change-Id: I03b13bdeecda1ad037191ff74e05142ceeb6533c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571890Reviewed-by:
Patrick Thier <pthier@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#79816}
-
Clemens Backes authored
The 'ForRegs' method is not needed for clarity of the code, it's pretty clear what to construct a register list from. Hence turn the static {LiftoffRegList::ForRegs} method into a constructor. This makes the code more concise. Also, turn the for loop into a C++17 folding expression, which might generate better code because the loop will automatically be unrolled. R=thibaudm@chromium.org Bug: v8:12425 Change-Id: Ic4446f23022db5f17420303d45b9c15fa5daff60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3572041Reviewed-by:Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79815}
-
Dominik Inführ authored
This CL adds additional checks for typed slots cleanup in the sweeper: 1) Old-to-old typed slots should never be removed during sweeping. Such slots are only ever recorded on live code objects (which are never e.g. right-trimmed or invalidated). 2) Old-to-new typed slots should never be removed when sweeping lazily or concurrently. New space is empty after a full GC, therefore the old-to-new typed slots are also cleared during a full GC. The main thread can record new slots but not in free memory. Bug: v8:12760 Change-Id: I7b507c862e43a15437e8ee609c6c2af0abf3a5ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3568479Reviewed-by:
-
Clemens Backes authored
This is a reland of commit 54e360d1. The two WasmGC cctests which require SSE4.1 support in Liftoff are now skipped, so we can keep disallowing any bailout (even for missing CPU features) in --liftoff-only. Original change's description: > [wasm] --liftoff-only should disable --wasm-dynamic-tiering > > A Liftoff only configuration should never tier up to TurboFan, hence add > a proper implication to disable dynamic tiering if --liftoff-only is > set. > Also, add a DCHECK to ensure we never accidentally compile with TurboFan > if --liftoff-only is set. > > R=jkummerow@chromium.org > > Bug: v8:12281 > Change-Id: Ia9b81add503cc939f59fde3f4d3bb67252facf2c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3569741 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79779} Bug: v8:12281 Change-Id: I334bd81f75c3ef6d31b6117da5ef59a33fb46ae2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3572043Reviewed-by:
-
Clemens Backes authored
Remove the pre-C++17 implementation of void_t, just use std::void_t now. R=omerkatz@chromium.org Bug: v8:12425 Change-Id: Iabf72f1540ddb4db666e5a74f169f73546241c1f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571888Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#79812}
-
Stephen Roettger authored
Change from V8_DEPRECATE_SOON to V8_DEPRECATED. It turned out that we don't have to make changes in chrome code, so we can go to deprecated right away. Bug: chromium:1310790 Change-Id: I1bd529536d3a0098f11f13b3e44fe3dbc80eed04 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571897Reviewed-by:
-
Leszek Swirski authored
This reverts commit 8ba60b7a. Reason for revert: code_serializer failures: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20debug/38940/overview Original change's description: > [string] Non-transitioning shared strings > > Instead of transitioning shared strings to ThinString on > internalization, use a forwarding table to the internalized string and > store the index into the forwarding table in the string's hash field. > > This way we don't need to handle concurrent string transitions that > modify the underlying string data. > > During stop-the-world GC, live strings in the forwarding table are > migrated to regular ThinStrings. > > Bug: v8:12007 > Change-Id: I6c6f3d41c6f644e0aaeafbf25ecec5ce0aa0d2d8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3536647 > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Jakob Linke <jgruber@chromium.org> > Reviewed-by: Shu-yu Guo <syg@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Patrick Thier <pthier@chromium.org> > Cr-Commit-Position: refs/heads/main@{#79801} Bug: v8:12007 Change-Id: I740904f3edfc395331f06c7218e89476b06b0563 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3574543 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#79810}
-
Leszek Swirski authored
Change-Id: Ibc256e202a75f7dbcba27dad2b591cf45738b005 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3571900 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
