- 16 Sep, 2019 28 commits
-
-
Peter Marshall authored
Remove CollectSample() and SetIdle(), advance deprecation of GetCallUid() Change-Id: Idb8c4f4d14bc5318a430e3549aaff7a41a911557 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1805641Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#63805}
-
Bruce Dawson authored
For the last few months Chrome has been seeing many "impossible" crashes on Intel Gemini Lake, family 6 model 122 stepping 1 CPUs. These crashes only happen with 64-bit Chrome and only happen in the prologue of two functions. The crashes come and go across different Chrome versions. Analysis of most of the crashes shows that the address of the crashing instruction follows some patterns: When crashing in GetFieldIndex() the last byte of the address is always 1c, 5c, 9c, or dc. When crashing in UpdateCaches (fewer unique samples) the last byte of the address is always 5d or 9d. The address of the function is 0xc or 0xd bytes earlier so the crashing functions always start with an address that ends in 10, 50, 90, or d0. Those addresses are for the crashes on a load of the __security_cookie. The crashes also occasionally happen on the two instructions that follow the __security_cookie load in which case the crashing instruction's address has been seen to end with 23 or a3. This corresponds to a function start address of 10 or 90. Since the crash involves reading incorrect instruction bytes when crossing a 16-byte boundary and since the crash appears to only happen with particular 16-byte alignments it seems reasonable to force the function's alignments to a multiple of 32 to see if this reliably avoids the crashes. This change uses the gcc/clang __attribute__ directive to force 32-byte alignment. I have tested this change enough to verify that it triggers the desired alignment (with up to 31 "int 3" instructions added for padding) but since I have never reproduced this crash I have no way of testing its efficacy. Bug: chromium:968683, chromium:964273 Change-Id: Ia6e1c6d1e044b84d274817374b25523303e78b51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803775Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#63804}
-
Joshua Litt authored
The first land did not correctly handle exceptions for already evaluated modules. Original description: Implements AsyncModules in SourceTextModule. However, there is no support in the parser or D8 for actually creating / resolving AsyncModules. Also adds a flag '--top-level-await,' but the only external facing change with the flag enabled is that Module::Evaluate returns a promise. Bug: v8:9344 Change-Id: I24725816ee4a6c3616c3c8b08a75a60ca9f27727 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1797658 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#63803}
-
Clemens Hammacher authored
This randomizes new memory allocations and reservations. It's currently used to test far jump tables in wasm better, but might be helpful generally for testing arbitrary virtual memory layouts. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: Ie60b7c6dd3c4cd0f3b9eb8e2172912e0851c357d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803340 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#63802}
-
Jakob Kummerow authored
Bug: v8:3770,v8:9666 Change-Id: I7b7652887d6b60fbb80e1100834bc7c9df0544d8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1792909 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#63801}
-
Artem Serov authored
This is a reland of 2869d9de Original change's description: > [turbofan,arm64] Add float loads poisoning. > > Also extend load poisoning testing for arm and arm64. > > This is a port of I1ef202296744a39054366f2bc424d6952c3bbe9d, > originally introduced for arm. > > Change-Id: I7d317bba6be633dd1e563daa7231d3c5e930f8e4 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1691032 > Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63519} Change-Id: I8155456f6ad571897f6274a86e58fec6cd66ee7d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800583Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/master@{#63800}
-
Jose Dapena Paz authored
blink::BlinkCloneableMessage declares default implementation of move operator/assign operator that requires v8_inspector::V8StackTraceId to declare its move constructor/assign operator too. Bug: chromium:819294 Change-Id: Iaf626ee8245efcba372a17cdf2de448e691d41d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796062 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
-
Tobias Tebbi authored
Bug: chromium:996097 Change-Id: I2d3bb6e1b844c1ffae0a5e44b1125593402fb7be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1806675 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This CL adds a flag to reduce the initial code space reservation size (--wasm-max-initial-code-space-reservation), and adds a test which creates at least four separate code spaces and calls between them. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: I1b4c430266962eb94dbe4b381f46b03c2ec07fc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1782999 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Joshua Litt authored
Bug: v8:9647 Change-Id: Ib6449fadc42130a019788ba3a22e93bfd0de789b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803514 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
-
Joshua Litt authored
Bug: v8:9463 Change-Id: Ife5ea730166e76bdbe8b18eac1eb5688b7aaf150 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800513 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by:
-
Dan Elphick authored
Changes the Array(Includes|IndexOf)(Holey|Packed)Doubles builtins to first check the input array is not empty before attempting to cast it to a FixedDoubleArray as an empty array of doubles can be backed by a FixedArray. Bug: chromium:1004061 Change-Id: I12f302afa9596fb8a5581849662cd67fcc06f92b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1806676Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#63794}
-
Victor Gomes authored
Disable a flaky test. This is a reland of cbf028e8 Bug: v8:9714 Change-Id: Ifc136ad80bd7f2a0ae67a15e688a3d08ceed3c44 Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1806915 Auto-Submit: Victor Gomes <victorgomes@google.com> Reviewed-by:
-
Clemens Hammacher authored
If a new code space is added after functions have already been compiled, we need to initialize the new jump tables to contain all these functions. R=mstarzinger@chromium.org Bug: v8:9477 Change-Id: Ie960966ec5ad667e0626f86eceb7c2b4da72e5bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803337 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Also TNodify: - LoadJSPrimitiveWrapperValue - GetSuperConstructor - InstanceOf BUG=v8:6949,v8:9396 Change-Id: I4b39b418cdf01bd72e35441f037d16ede9c89ce9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803639 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#63791}
-
Clemens Hammacher authored
Ensure that the "padding" (actually needed for crashpad) is allocated at the beginning of the new code space. R=ahaas@chromium.org Bug: v8:9477 Change-Id: I44b9e9feb559788e286fd5c57df90db7cf7f5340 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803650 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Maya Lekova authored
Bug: chromium:1003730 Change-Id: Id8ca302b0b17ce08821507bb686bf241416eee67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1806913 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
A local build with g++ 8.3.0 failed with two warnings. This CL fixes them. The errors were: 1) error: 'char* strncat(char*, const char*, size_t)' output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation] 2) error: 'char* strncpy(char*, const char*, size_t)' specified bound depends on the length of the source argument [-Werror=stringop-overflow=] R=petermarshall@chromium.org Bug: v8:9396 Change-Id: I175a72435becd694e4151a64e538084ec17d8500 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803636Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63788}
-
Ross McIlroy authored
The current JSObject type is too specific as it can also be passed proxy objects. BUG=chromium:1003919,v8:6949 Change-Id: I2766868543827fc5ee6f99f3b120c7ffe9cfed39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803651 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#63787}
-
Jakob Kummerow authored
This reimplements the "--time" option of run-tests.py to print the 20 slowest tests, on top of json_test_results infrastructure just like the bots do it. Additionally this CL speeds up a bunch of slow tests. Bug: v8:9396 Change-Id: I40797d2c8c3bfdd310b72f15cd1a035844b7c6f3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803635 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#63786}
-
Liviu Rau authored
Removed all references to builds [v8_mips_compile_rel, V8 Mips - builder, V8 Mips - big endian - nosnap] from configuration files in master branch. Also removed dead code and unused artifacts that resulted from the above mentioned changes. Bug: v8:8858 Change-Id: If9f8d9db433a50997f35219ef4ea9d8a91a1a495 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798431Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#63785}
-
Maya Lekova authored
Bug: v8:9396 Change-Id: Icfaa04f02f1d3114cd42ad42e97572ac3cf8f985 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801841Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#63784}
-
Victor Gomes authored
Uses templates to dispath the allocation flag statically. Bug: v8:9714 Change-Id: I1998ae47be2f7d872d34b3bc2390d01cbfad6afa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801848 Auto-Submit: Victor Gomes <victorgomes@google.com> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Dan Elphick authored
All converted except for two calls to PrepareValueForWriteToTypedArray. Bug: v8:6949, v8:9396 Change-Id: I3c695b8067487bd8845e38cf760519bef1f37f2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803351 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Mu Tao authored
Port 0a8ddb13 Original Commit Message: If the jump is too large for a near jump, we patch the far jump table instead, and patch the (near) jump table to jump to the far jump table slot. Change-Id: Id9f12dee885b369a4946642301720d110dfe4f31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803641 Auto-Submit: Mu Tao <pamilty@gmail.com> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#63781}
-
Igor Sheludko authored
Bug: v8:9708, v8:9396 Change-Id: Id957a937a6801292dd31972dd16b188951aa05c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803350Reviewed-by:
-
Georg Neis authored
This reverts commit 46f9d400. Reason for revert: as planned Original change's description: > Reland "[turbofan] Temporarily disable future=>concurrent_inlining" > > This is a reland of ce421122. > Speculatively relanding, because the failure seems unrelated. > > Original change's description: > > [turbofan] Temporarily disable future=>concurrent_inlining > > > > ... in order to reset the benchmarks now that we are actually running > > in the background. > > > > Bug: v8:7790 > > Change-Id: Ifa811fbcc51eccef790e6215d330f8b45c31a492 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801836 > > Reviewed-by: Georg Neis <neis@chromium.org> > > Commit-Queue: Georg Neis <neis@chromium.org> > > Auto-Submit: Maya Lekova <mslekova@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#63741} > > Bug: v8:7790 > Change-Id: I49316516b300e6d2754043848d95ac5511fc6015 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801849 > Reviewed-by: Georg Neis <neis@chromium.org> > Commit-Queue: Georg Neis <neis@chromium.org> > Auto-Submit: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63755} TBR=neis@chromium.org,mslekova@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7790 Change-Id: Ic31f1bf47c0b00ec497452fd29d8c09a32e14316 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803642Reviewed-by:
-
Liviu Rau authored
No-Try: true Bug: v8:9396 Change-Id: Ife254c964a418b5a2c666acf618b66e5273f31d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800284 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by:
-
- 15 Sep, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5966abc..ecd1092 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9d25ad4..73ec83f TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ie6097de34386108c51e80f45fe5f687f5b510bdd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1805514Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#63777}
-
- 14 Sep, 2019 2 commits
-
-
Peter Marshall authored
- Get rid of a bunch of unnecessary friend classes. This required making the constructor public - Remove log_events_ field which is not used - Use unique_ptr for owned members - Use make_unique instead of bare constructors - Use a scoped vector instead of a unique ptr to array for the dynamically sized array of WasmModules Bug: v8:9396 Change-Id: Icdca904e7227d2ce2d75caf092f259d47ff15809 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803339Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/3732ed1..5966abc Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2d75cf6..9d25ad4 Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/c7a03da..cad3bc4 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/6706ebf..27f1edd TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I563cfd03b18f3feb452ab5852434737c4a19c315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1805014Reviewed-by:
-
- 13 Sep, 2019 9 commits
-
-
Shu-yu Guo authored
Install intrinsic default prototypes for Intl.ListFormat, Intl.PluralRules, Intl.RelativeTimeFormat, and Intl.Segmenter. Observable when attempting to construct cross-realm via a new.target with a non-Object .prototype property. Bug: v8:9712 Change-Id: I77ae75e5ea1ee8e9a01cf5788b664a5945aa1f7e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1801252Reviewed-by:
-
Milad Farazmand authored
Port 213504b9 Original Commit Message: The code fields in a JSRegExp object now either contain irregexp compiled code or a trampoline to the interpreter. This way the code can be executed without explicitly checking if the regexp shall be interpreted or executed natively. In case of interpreted regexp the generated bytecode is now stored in its own fields instead of the code fields for Latin1 and UC16 respectively. The signatures of the jitted irregexp match and the regexp interpreter have been equalized. R=pthier@google.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ia2a80ce927afa644441c0749add0fc35111eb720 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803657Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#63773}
-
Michael Achenbach authored
TBR=yangguo@chromium.org NOTRY=true NOPRESUBMIT=true Change-Id: I20d3a60e406c47725b9c02da69912fcf84cb7166 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803638 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:8460 Change-Id: I2a96d5bad3dbcfe6a437931d7e9756646610f74b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796319Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#63771}
-
Dan Elphick authored
Convert all but 4 Node*s to TNode and all Variables to TVariable. In the process this also deletes several unused functions. Bug: v8:6949, v8:9396 Change-Id: I83db40eefacf8a4a1b155249c5bb8217e6c7da83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803347 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 0a8ddb13 Original Commit Message: If the jump is too large for a near jump, we patch the far jump table instead, and patch the (near) jump table to jump to the far jump table slot. R=clemensh@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ic42dfea83799ba6aae1d6d32607391393353815a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1802742Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
Frank Tang authored
By rolling icu to faee8bc which contains the upstream CLDR fix. Bug: v8:992694 Change-Id: I073d15396fa0e7c5054aa4e0806e5842228955f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1799424Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
After https://crrev.com/c/1800575 and https://crrev.com/c/1803343, which tried to fix this on occuring compile errors, this CL systematically adds the <memory> include to each header that uses {std::unique_ptr}. R=sigurds@chromium.org TBR=mlippautz@chromium.org,alph@chromium.org,rmcilroy@chromium.org,verwaest@chromium.org Bug: v8:9396 Change-Id: If7f9c3140842f9543135dddd7344c0f357999da0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803349Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#63767}
-
Santiago Aboy Solanes authored
Follow-up CL that finishes TNodifying builtins collection gen. Added a TODO in CSA since I was encountering errors when trying to return a JSIteratorResult. Bug: v8:6949, v8:9396 Change-Id: I1e8a9cf8bce54327dd1fad5bd9531058f096469d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803344 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
