- 10 Dec, 2019 1 commit
-
-
Simon Zünd authored
Bug: v8:10021 Change-Id: Ieffa39c09e028b9c0f91f1823ea6e89f81fec4cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1948707 Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#65394}
-
- 09 Dec, 2019 18 commits
-
-
Bartek Nowierski authored
NOTE! This re-introduces the following change with a modification that detached_window_time_in_seconds is initialized with 0, instead of current time. https://chromium-review.googlesource.com/c/v8/v8/+/1924000 Bug: chromium:1018156 Change-Id: I6d0880e0355d2cb08dbf4f2ef92c8fcead03f9ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958344Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#65393}
-
Milad Farazmand authored
The API thread_cputime() is only defined but not yet implemented on IBMi. Change-Id: I8ea7ff724e749f537b54e75a00d718500807ca8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1957831Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#65392}
-
Leszek Swirski authored
We use the compilation entry point as a caching scope for deserializing lookups, to avoid redundantly iterating over parent scopes when accessing the same variable multiple times. However, this caching scope messes with lookups that are looking for lexical name conflicts, as opposed to just resolving variables. In particular, it messes with name conflict lookups and sloppy block function hoisting checks, when there are other scopes in the way, e.g. function f() { let x; try { throw 0; } catch (x) { // This catch is the entry scope // Naive use of caches will find the catch-bound x (which is // a VAR), and declare 'no conflict'. eval("var x;"); // Naive use of caches will find the catch-bound x (which is // a VAR), and determine that this function can be hoisted. eval("{ function x() {} }"); } } Previously, we worked around this by avoiding cache uses for these lookups, but this had the issue of instead caching the same variable multiple times, on different scopes. In particular, we saw: function f() { with ({}) { // This with is the entry scope, any other scope would do // though. // The conflict check on `var f` caches the function name // variable on the function scope, the subsequent 'real' // lookup of `f` caches the function name variable on the // entry i.e. with scope. eval("var f; f;"); } } With this patch, we change the caching behaviour to cache on the first non-eval declaration scope above the eval -- in the above examples, this becomes the parent function "f". For compilations with no intermediate non-decl scopes (no with or catch scopes between the function and eval) this becomes equivalent to the existing entry-point-based caching. This means that normal lookups do have to (sometimes) iterate more scopes, and we do have to be careful when using the cache to not use it for lookups in these intermediate scopes (a new IsOuterScope DCHECK guards against this), but we can now safely ignore the cache scope when doing the name-collision lookups, as they only iterate up to the outer non-eval declaration scope anyway. Bug: chromium:1026603 Bug: chromium:1029461 Change-Id: I9e7a96ce4b8adbc7ed47a49fba6fba58b526235b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955731 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#65391}
-
Leszek Swirski authored
This reverts commit 026a0c21. Reason for revert: Reverting due to https://crbug.com/1029461 Original change's description: > [parser] Fix variable caching for conflict lookup > > During conflict lookup (for lexical variables and sloppy block function > hoisting), we cache the looked-up variable on the current scope if the > lookup goes through a ScopeInfo. However, for variable lookup during > scope analysis, we use the "entry point" as the cache. > > Since both lookups can create Variables, this can cause us to create > duplicate variables, e.g. a duplicate function name variable in the > attached test. > > Instead, for ScopeInfo conflict lookups we can cache the result on the > function's outer scope, which shoud be equivalent to the entry point. > > As a (necessary) drive-by, we can terminate the lookup early if we find > a VAR with the same name, as we can safely assume that its existence > means that it doesn't conflict, which means that our variable can't > conflict either. > > Bug: chromium:1026603 > Change-Id: I19f80f65597ba6573ebe0b48aa5698f55e5c3ea1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1928861 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65138} TBR=leszeks@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:1026603 Bug: chromium:1029461 Change-Id: Id7f5dd342e32e1bb57c51b3748feff32ee0ba41d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958014Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65390}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4f02786..b1050d1 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/c3cb105..8953fbe TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: If375ec3ca9676c651ec7097a431e101aad5ff843 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955992Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65389}
-
Clemens Backes authored
This reverts commit c4cf2ea4. Reason for revert: Seems to cause more regressions than improvement. Let's see what the perf bots say about the revert. Original change's description: > [codegen] Remove redundant xorpd instructions > > It seems like they were originally added in https://crrev.com/23654026 > (Sep 2013) to break dependences in the OOO pipeline. This code pattern > was then later copied for other instructions too > (https://crrev.com/1424333002). > The reason for the xorpd is not mentioned in the code though, and I > found no other compiler doing this. So maybe it's obsolete by now, and > only increases code size. > > Let's remove them and see if we get any performance regressions. > > R=ahaas@chromium.org > CC=yangguo@chromium.org > > Change-Id: I0e6d65afa67f0ee286e5b0ba95c91092c5261c8f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926427 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65077} TBR=yangguo@chromium.org,ahaas@chromium.org,clemensb@chromium.org Bug: chromium:1027876, chromium:1027449 Change-Id: I533729722e294dbe567222b1c4084df6b864d2ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958053Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65388}
-
Clemens Backes authored
Instead of using hard-coded clang flags (which are missing important flags and are thus not that useful), use the flags for some unrelated C++ file. R=ahaas@chromium.org No-Try: true Change-Id: I516df9431e8aad1a63e832aa28450475193fd404 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955549 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65387}
-
Liviu Rau authored
No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Iae100d8f9676f2f387d915ab6e70fa31d7ad30af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955551 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65386}
-
Dominik Inführ authored
Before this CL a byte was used per bucket to store whether the bucket is possibly empty or not. This CL changes this such that each bucket only needs a single bit. PossiblyEmptyBuckets is now a word in the page header. If more bits are needed than fit into a single word, an external bitmap is allocated using AlignedAlloc. Storing this on the page header, allows to remove initial_buckets from the SlotSet. The SlotSet allocation is then again a power-of-2 in release mode. Reland of https://crrev.com/c/1906376: Incorrect DCHECK was removed. WordsForBuckets was simplified and a test was added for it. Bug: chromium:1023139 Change-Id: I9a08e03a9c10e5781a146b9a28dab38824aad91f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954391Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#65385}
-
Clemens Backes authored
This removes the --experimental-wasm-sat-f2i-conversions flag. This feature is shipped since v7.5. R=ahaas@chromium.org Change-Id: I354d9528be40caac77cd4e41adcd39d013448339 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958009Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65384}
-
Michael Achenbach authored
Some fuzz test cases set Math.min to a different function. Let the fake typed array constructors remember the original Math.min. No-Try: true Bug: chromium:1024815 Change-Id: Ia389439fe6757f2497e22187042c5cdf1d1c649f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958050 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#65383}
-
Ng Zhi An authored
Mostly for f32x4 instructions. Bug: v8:9561 Change-Id: I3a3dc06305acb9e336c494fc399cf5d21518c0e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950488Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#65382}
-
Clemens Backes authored
This caused compile errors since https://crrev.com/c/1934407: ld.lld: error: undefined symbol: v8::debug::AccessorPair::CheckCast(v8::Value*) >>> referenced by debug-interface.h:578 (../../src/debug/debug-interface.h:578) >>> obj/test/cctest/cctest_sources/test-debug.o:(TestGetPrivateMethodsAndAccessors()) R=verwaest@chromium.org CC=joyee@igalia.com Change-Id: I4a727ddd2673c75ec16368459114cfcafdd18912 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955595 Auto-Submit: Clemens Backes <clemensb@chromium.org> Reviewed-by: Joyee Cheung <joyee@igalia.com> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#65381}
-
Simon Zünd authored
This CL is a prepatory step towards moving the stack locals blacklist from the DebugEvaluateContext to the respective {ScopeInfo} objects. The locals blacklist is used during local debug evaluate to decide whether a context lookup can advance the context chain upwards, or if lookup needs to stop at the current scope. This CL also introduces a "Recreate" static helper method, that allows an existing ScopeInfo to be cloned, but with a locals blacklist attached. This will be needed since blacklists are only created on-demand during debugging. R=leszeks@chromium.org Bug: chromium:1027475, v8:9938 Change-Id: I673dbc99ce9fdc84cb5cda3f9710ba2b76ab92ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946349 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#65380}
-
Simon Zünd authored
R=yangguo@chromium.org Change-Id: Ia58394ec14b34dcd9641d6cf3a810ac272431801 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958006 Commit-Queue: Simon Zünd <szuend@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#65379}
-
Clemens Backes authored
For each wasm feature flag, this adds a link to the proposal repository, and states who is the v8-side owner of the implementation. For stated and shipped features, it also sais since which v8 version this is the case. It also adds some documentation about the meaning of the three categories (experimental, stages, shipped). R=mstarzinger@chromium.org, adamk@chromium.org No-Try: true Change-Id: Idbb26eb9e68c7a81aed0e1c1b1d12d5de40d7c2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954395 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#65378}
-
Zhang, Shiyu authored
This is a reland of 5253d7bf Original change's description: > [runtime] Cache prototype chain enumerable keys in PrototypeInfo > > This CL adds a prototype_chain_enum_cache to cache the enumeration of a > prototype and its entire chain on the PrototypeInfo. It can improve for-in > performance via simply merging the receiver enumeration with this cache. > > It improves the score of JetStream2-tagcloud-SP case by ~9% on IA Chromebook. > > Contributed by tao.pan@intel.com > > Change-Id: Ib40bfe41e772672337155584672f06fa1ba1e70d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1870844 > Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65224} Change-Id: I93b74727c46abbaab163324c50fbd977fcc9bb36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955232Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Shiyu Zhang <shiyu.zhang@intel.com> Cr-Commit-Position: refs/heads/master@{#65377}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/51a024f..c3cb105 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I8a81064241961d90f3d9c4dce490a90d060eeb49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955990Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65376}
-
- 07 Dec, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/35a759a..4f02786 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/447ab8a..51a024f Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fe18a43..6b52dc2 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/d1940b1..57e481c Rolling v8/tools/luci-go: git_revision:7d11fd9e66407c49cb6c8546a2ae45ea993a240c..git_revision:37a855b64d59b7f079c9a0e5368f2757099d14d3 Rolling v8/tools/luci-go: git_revision:7d11fd9e66407c49cb6c8546a2ae45ea993a240c..git_revision:37a855b64d59b7f079c9a0e5368f2757099d14d3 Rolling v8/tools/luci-go: git_revision:7d11fd9e66407c49cb6c8546a2ae45ea993a240c..git_revision:37a855b64d59b7f079c9a0e5368f2757099d14d3 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ie906df3d577d1b5de1e520d2ac9b1a50d08c68dd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955988Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65375}
-
- 06 Dec, 2019 17 commits
-
-
Anton Bikineev authored
This fixes DCHECK build with --noincremental-marking flag. Change-Id: If1e8f9ec09bd91e628c3e92bbcd40f6960473f5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955598Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#65374}
-
David Carlier authored
This check is useful for preventing a segfault upon usage of this argument. Change-Id: I3cc77f84d7e3ca2a96ec36a50bddb9c2eadeb62f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1946336Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65373}
-
Ross McIlroy authored
Change-Id: I9be7c10193553088b72b6303408636b4fea64f5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955594Reviewed-by: Dan Elphick <delphick@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#65372}
-
Seth Brenith authored
This change is the first part of adding Torque support for a "bitfield struct", which represents a set of bitfields packed together into an integer value. With this change, Torque can generate the list of BitField template specializations that allow runtime code to use the bitfield values. The flags used in SharedFunctionInfo are converted to Torque to exercise this functionality. Bitfield values are not yet accessible directly from Torque code. Bug: v8:7793 Change-Id: I9e4a3df7c847111b6e02e513f175dbf938b0be35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1949047 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#65371}
-
Clemens Backes authored
This adds a method to generate the debug side table via Liftoff, and adds first tests that check that the number of entries is as expected. These tests will be extended in a follow-up CL to test the actual content of the debug side table. R=mstarzinger@chromium.org Bug: v8:10019 Change-Id: I393ffabed3408463ffba232a66e2dffd7dd74f15 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954390 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#65370}
-
Dan Elphick authored
Add --benchmark option to allow selecting a benchmark other v8.browsing_desktop. If not using the default, the options to generate v8 runtime call stats will be automatically added. Adds --stdev option to calculate the standard deviation of the results in the table. Add --device and --browser option that are passed through to run_benchmark. Change-Id: I8c57c9eba7aea84108a2e3d4fdd098a7695cad53 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955588Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#65369}
-
Joshua Litt authored
Bug: v8:9838 Change-Id: Ib2741501330629a29c1f3fe4f4a93a73982ab4de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1929400 Commit-Queue: Joshua Litt <joshualitt@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#65368}
-
Anna Henningsen authored
The recently introduced usage of `std::logical_and` requires this. This un-breaks building Node.js with the current V8 master branch on FreeBSD. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1940476 Refs: https://github.com/nodejs/node-v8/issues/124 Change-Id: Ic9d63c40e1b533f7f1c59a05f8577ee0bb0d6aa1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955584Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65367}
-
Igor Sheludko authored
... broken during porting to Torque here https://chromium-review.googlesource.com/c/v8/v8/+/1891610 Bug: chromium:1028538 Bug: v8:8906 Bug: v8:4153 Change-Id: I0fb33299832964a1990e9e60a351aa88e246b3a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955585 Commit-Queue: Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Auto-Submit: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#65366}
-
Deepti Gandluri authored
Change-Id: I607e9565e29b2159c1783cd58fb5a2e19c02b221 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955524 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65365}
-
Clemens Backes authored
Sign extension opcodes are already tested in the interpreter since https://crrev.com/c/1083337, thus remove the obsolete TODO. R=gdeepti@chromium.org No-Try: true Change-Id: I08323b9d43fa46d1fcf9965e5106a68767f695b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954400 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#65364}
-
Ulan Degenbaev authored
The cache adds a strong pointer from a code object to closures and thus can leak arbitrary objects. Bug: chromium:1030043 Tbr: yangguo@chromium.org Change-Id: I8ce90119fa97eaea59d42e7fae5acd336b5fe5d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954392 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#65363}
-
Ng Zhi An authored
Adds AVX codegen for f64x2 min, max, qfma, and qfms. Bug: v8:9561 Change-Id: Id32ba8d4367e4f9b3cccea2bc7ce24dfb04ec188 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950487Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#65362}
-
Ng Zhi An authored
Bug: v8:10021 Change-Id: Ibececfd23b852d7cecf609f6ae1a4b01ea8b55f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1950485Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#65361}
-
Simon Zünd authored
This is a reland of 5bddc0e1 The original CL was speculatively reverted as it was suspected to cause failures on the non-determinism bot. This was ultimately confirmed to not be the case, so this CL is safe to reland as-is. Original change's description: > Implement top-level await for REPL mode > > Design doc: bit.ly/v8-repl-mode > > This CL allows the usage of 'await' without wrapping code in an async > function when using REPL mode in global evaluate. REPL mode evaluate > is changed to *always* return a Promise. The resolve value of the > promise is the completion value of the REPL script. > > The implementation is based on two existing mechanisms: > - Similar to async functions, the content of a REPL script is > enclosed in a synthetic 'try' block. Any thrown error > is used to reject the Promise of the REPL script. > > - The content of the synthetic 'try' block is also re-written the > same way a normal script is. This is, artificial assignments to > a ".result" variable are inserted to simulate a completion > value. The difference for REPL scripts is, that ".result" is > used to resolve the Promise of the REPL script. > > - ".result" is not returned directly but wrapped in an object > literal: "{ .repl_result: .result}". This is done to prevent > resolved promises from being chained and resolved prematurely: > > > Promse.resolve(42); > > should evaluate to a promise, not 42. > > Bug: chromium:1021921 > Change-Id: I00a5aafd9126ca7c97d09cd8787a3aec2821a67f > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1900464 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Simon Zünd <szuend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#65273} TBR: yangguo@chromium.org,verwaest@chromium.org Bug: chromium:1021921 Change-Id: I95c5dc17593161009a533188f91b4cd67234c32f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954388Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#65360}
-
Zhao Jiazhong authored
port 785fa6b4 https://crrev.com/c/1947350 Change-Id: I76e7d7b0afcea14bee7e11c8317ede5f4c880d1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1951281 Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Reviewed-by: Zhi An Ng <zhin@chromium.org> Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65359}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4538ab6..35a759a Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/989b615..447ab8a Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/9212599..fe18a43 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ia4997c1b485d3a842a97766c8c5af631917247b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954064Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#65358}
-
- 05 Dec, 2019 3 commits
-
-
Milad Farazmand authored
Change-Id: Id9e9142a8ff185309b91dcfff70dae8ccf8b5166 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1954244Reviewed-by: Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#65357}
-
Johannes Henkel authored
New revision: f5a3199a3f37c7e48a9ffdbee04aa5c8f38d2889 Use crdtp::span<uint8_t> instead of const ProtocolMessage&. (V8) Also includes a PR which moves Serializable into the crdtp library and adds a simple test. Hadn't rolled this yet. Upstream review: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1952196 Change-Id: If78bc8f11be8fb248dd66babc0190870312f7ec4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1952158 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#65356}
-
Gus Caplan authored
In 5742da05, the toString property was accidentally applied to all NativeError prototypes, when it should only be inherited from Error.prototype. Refs: https://github.com/tc39/ecma262/issues/1794 Bug: v8:10017 Change-Id: I2af9a31f463deb9871dd7a4a5a2e4dd7485ed38c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1933054Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#65355}
-