1. 11 Dec, 2018 1 commit
  2. 22 Feb, 2018 1 commit
    • Peter Marshall's avatar
      [typedarray] Fix IterableToList when Number has an iterator · aaa78c33
      Peter Marshall authored
      IterableToListCanBeElided checked that the input was always a HeapObject
      but this is not true when an iterator symbol is defined on the Number
      prototype, meaning Smi and HeapNumber can also be passed in.
      
      Added a regression test for the crash and some correctness tests for
      smi and double input to TA.from.
      
      Also factored out the tests in typedarray-from.js that modify global
      state e.g. protector cells, so that one iteration of the top level
      loop does not interfere with the next.
      
      Bug: chromium:814643
      Change-Id: I364d11f011faf8370446f905a35a945d47e4477f
      Reviewed-on: https://chromium-review.googlesource.com/930962Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#51461}
      aaa78c33
  3. 19 Feb, 2018 1 commit
    • Peter Marshall's avatar
      [typedarray] Port TypedArray.from to CSA. · 81a3742a
      Peter Marshall authored
      Factor out IterableToList into a helper stub to save space. There are
      two callers now, TypedArrayFrom and ConstructByIterable, and it is
      ~2.5kb so we save space by doing this.
      
      Increase test coverage to cover more of the branching in CSA.
      
      This is doesn't follow the control flow in the spec exactly - see the
      big code comment for an explanation.
      
      Change-Id: Ief39e93c4202cb7bf0e28a39dc6aa81b8b9c59d2
      Reviewed-on: https://chromium-review.googlesource.com/908755
      Commit-Queue: Peter Marshall <petermarshall@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#51377}
      81a3742a
  4. 01 Jul, 2015 1 commit
  5. 18 May, 2015 1 commit
    • dehrenberg's avatar
      Add TypedArray.from method · cc3f59db
      dehrenberg authored
      This function creates a new way to make TypedArrays based on existing
      iterable or Array-like objects, analogous to Array.from. The patch
      implements the function and adds tests.
      
      R=arv@chromium.org
      BUG=v8:3578
      LOG=Y
      
      Review URL: https://codereview.chromium.org/1132163011
      
      Cr-Commit-Position: refs/heads/master@{#28456}
      cc3f59db