- 07 Jan, 2017 3 commits
-
-
littledan authored
Previously, the Intl implementation tracked types two ways: - In the intl_initialized_marker_symbol - In various named properties of the intl_impl_object_symbol value As far as I can tell, these will never disagree with each other, modulo bugs in Intl itself. This patch removes the second type checking system. This reland includes a fixed type check for Intl.DateTimeFormat.prototype.formatToParts , which is the only Intl method which is not bound. All future methods will follow this pattern. BUG=v8:5751,chromium:677055, v8:4962 CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng Review-Url: https://codereview.chromium.org/2600913002 Cr-Commit-Position: refs/heads/master@{#42118}
-
littledan authored
This patch provides improved infrastructure for developing test262 tests together with V8. It has three parts: - The test262 test runner is updated to look for local versions of tests in the /test/test262/local-tests directory, which mirrors /test/test262/data. Additional tests can be added there and are run together with tests from upstream. Upstream tests can be locally updated by using the same name in local-tests; if a same-named test exists, then only the local version will be run. The local-tests directory is in the V8 repository, unlike the contents of the data directory, so tests can be added in the same patch as something else. - The tool /test/test262/upstream-local-tests.sh is added to create a patch against the test262 respository based on a patch which changes the local-tests directory. - The tool /test/test262/prune-local-tests.sh is added to remove redundant local tests on a test262 roll. See design doc: https://docs.google.com/document/d/16bj7AIDgZLv4WOsUEzQ5NzcEN9_xo095e88Pz8FC5rA/edit Review-Url: https://codereview.chromium.org/2611793002 Cr-Commit-Position: refs/heads/master@{#42117}
-
mtrofin authored
BUG= Review-Url: https://codereview.chromium.org/2619113002 Cr-Commit-Position: refs/heads/master@{#42116}
-
- 06 Jan, 2017 12 commits
-
-
mtrofin authored
Separated: - decoding of locals - loop assignment analysis - determination of opcode length as statics that work on a Decoder. Neither need the context of a Module, and were used in scenarios where one wasn't available either. Changed BodyLocalDecls to match the usecases for the type. In all but one (a printer), we want the list (in order of declaration, with repetitions) of types of locals. Removed a now-unnecessary constructor for the WasmFullDecoder. BUG= Review-Url: https://codereview.chromium.org/2610813009 Cr-Commit-Position: refs/heads/master@{#42115}
-
adamk authored
Previously the message was "this is not defined" which is nonsensical. BUG=v8:4407 Review-Url: https://codereview.chromium.org/2614053002 Cr-Commit-Position: refs/heads/master@{#42114}
-
gsathya authored
BUG=v8:5343 Review-Url: https://codereview.chromium.org/2616673003 Cr-Commit-Position: refs/heads/master@{#42113}
-
adamk authored
Variables requiring initialization are already forced into ignition, so all the code supporting hole checks in full-codegen and ast-graph-builder is dead. R=bmeurer@chromium.org BUG=v8:5657 Review-Url: https://codereview.chromium.org/2615033002 Cr-Commit-Position: refs/heads/master@{#42112}
-
adamk authored
The attached chromium bug suggests that turning this on via a flag regressed a perf test. Having previously run into slowdowns due to experimental JS natives, my suspicion is that this regression can be fixed by including the new builtins in the snapshot. My intention is to land this patch to see if the regression goes away on the bots. Given the nature of this feature, it seems low-risk to remove the runtime flag. If need be, it would be trivial to craft a patch to remove these two methods from String.prototype if we run into web compat issues during the release (note that no release branch has yet picked up this feature). BUG=v8:4954, chromium:677444 Review-Url: https://codereview.chromium.org/2610853010 Cr-Commit-Position: refs/heads/master@{#42111}
-
mtrofin authored
BUG= Review-Url: https://codereview.chromium.org/2618743004 Cr-Commit-Position: refs/heads/master@{#42110}
-
gsathya authored
Also moves most of the runtime function into TF. There are lots of runtime calls but they happen only for the debug case so it's fine. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2611083002 Cr-Commit-Position: refs/heads/master@{#42109}
-
bjaideep authored
CmplSmiLiteral should be used to compare smi R=joransiu@ca.ibm.com, jyan@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2614663009 Cr-Commit-Position: refs/heads/master@{#42108}
-
martyn.capewell authored
Remove unused size variable from disassembler. BUG= Review-Url: https://codereview.chromium.org/2615633004 Cr-Commit-Position: refs/heads/master@{#42107}
-
littledan authored
Our test infrastructure ignores missing tests which are listed in status files. Sometimes, tests are removed and status file lines are not updated. This patch adds a presubmit check for status files addressing JavaScript tests to not reference missing tests. It also cleans up existing violations. R=machenbach Review-Url: https://codereview.chromium.org/2610353002 Cr-Commit-Position: refs/heads/master@{#42106}
-
mtrofin authored
Removing "limit_", using just "end_". BUG= Review-Url: https://codereview.chromium.org/2613193002 Cr-Commit-Position: refs/heads/master@{#42105}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9cde9c9..87eca92 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/0ec6dce..5b3c04d TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2619503002 Cr-Commit-Position: refs/heads/master@{#42104}
-
- 05 Jan, 2017 25 commits
-
-
adamk authored
R=gsathya@chromium.org Review-Url: https://codereview.chromium.org/2612373002 Cr-Commit-Position: refs/heads/master@{#42103}
-
gsathya authored
This patch adds parsing of spread object property. -- Changes ParsePropertyName to parse Token::ELLIPSIS. -- Throws if rest is encountered by setting a pattern error. -- Adds a new PropertyKind enum (SPREAD) -- Adds a new ObjectLiteralProperty::kind (SPREAD) -- Adds a new harmony-object-spread flag and protects the parser code with it. -- Adds a new runtime function called CopyDataProperties -- Does not add any support for this feature in fullcodegen. -- Ignition calls out to a runtime function CopyDataProperties to perform spread operation. -- Move FastAssign from builtins-objects.cc to objects.cc -- Refactor Builtin_ObjectAssign to use SetOrCopyDataProperties Object rest will be implemented in a follow on patch. BUG=v8:5549 Review-Url: https://codereview.chromium.org/2606833002 Cr-Commit-Position: refs/heads/master@{#42102}
-
jyan authored
R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2617733003 Cr-Commit-Position: refs/heads/master@{#42101}
-
jyan authored
CmpLogicalP only compares lower 32-bit, but smi is in upper 32-bit R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2611193002 Cr-Commit-Position: refs/heads/master@{#42100}
-
jyan authored
x86 automatically truncates the shift amount to be 5-bits. But not all architectures do that. R=rossberg@chromium.org, jarin@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2616743002 Cr-Commit-Position: refs/heads/master@{#42099}
-
adamk authored
R=rmcilroy@chromium.org BUG=v8:5799 Review-Url: https://codereview.chromium.org/2612903002 Cr-Commit-Position: refs/heads/master@{#42098}
-
adamk authored
R=littledan@chromium.org BUG=v8:5367 Review-Url: https://codereview.chromium.org/2611063002 Cr-Commit-Position: refs/heads/master@{#42097}
-
adamk authored
R=bmeurer@chromium.org BUG=v8:5657 Review-Url: https://codereview.chromium.org/2609863006 Cr-Commit-Position: refs/heads/master@{#42096}
-
jochen authored
TBR=machenbach@chromium.org BUG=5803 Review-Url: https://codereview.chromium.org/2611143002 Cr-Commit-Position: refs/heads/master@{#42095}
-
rdevlin.cronin authored
BUG=None Review-Url: https://codereview.chromium.org/2609173005 Cr-Commit-Position: refs/heads/master@{#42094}
-
jochen authored
R=machenbach@chromium.org BUG=chromium:645890 Review-Url: https://codereview.chromium.org/2614983002 Cr-Commit-Position: refs/heads/master@{#42093}
-
epertoso authored
Revert of [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms (patchset #3 id:40001 of https://codereview.chromium.org/2605863002/ ) Reason for revert: Breaks wasm benchmark (http://crbug.com/v8/5798). Original issue's description: > [turbofan] Improve codegen for 8- and 16-bit memory comparisons on Intel platforms > > Recognize and emit in-memory comparisons of 8-bit and 16-bit values with > immediate values that fit. > > LOG=N > R=epertoso@chromium.org > > Review-Url: https://codereview.chromium.org/2605863002 > Cr-Commit-Position: refs/heads/master@{#41971} > Committed: https://chromium.googlesource.com/v8/v8/+/be11812c53ff6c8ce320887bc76a3b60d8103695 TBR=danno@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2618443003 Cr-Commit-Position: refs/heads/master@{#42092}
-
jochen authored
BUG=v8:5215 R=vogelheim@chromium.org,marja@chromium.org Review-Url: https://codereview.chromium.org/2618503002 Cr-Commit-Position: refs/heads/master@{#42091}
-
jochen authored
This turns hangs on win_dbg into actually crashes R=machenbach@chromium.org BUG= Review-Url: https://codereview.chromium.org/2613033002 Cr-Commit-Position: refs/heads/master@{#42090}
-
jochen authored
The destructors of the parse info, compile info, and compilation job might still access the zone BUG=none R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2616883003 Cr-Commit-Position: refs/heads/master@{#42089}
-
leszeks authored
Add a more efficient encoding for state values that have a large number of optimized-out inputs. Review-Url: https://codereview.chromium.org/2509623002 Cr-Commit-Position: refs/heads/master@{#42088}
-
marja authored
This makes the context allocation less pessimistic in case of name clash. This is also required for being able to skip inner functions. BUG=v8:5501, v8:5516 Review-Url: https://codereview.chromium.org/2610823003 Cr-Commit-Position: refs/heads/master@{#42087}
-
jochen authored
We can't have "main" in a static library. so just include the small fuzzer.cc in all simple fuzzers BUG=none R=machenbach@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2608243005 Cr-Commit-Position: refs/heads/master@{#42086}
-
bmeurer authored
We need to check both sides for abstract equality of receivers in optimized code, otherwise we don't handle implicit conversions and undetectable objects correctly. R=jarin@chromium.org BUG=v8:5802 Review-Url: https://codereview.chromium.org/2612213002 Cr-Commit-Position: refs/heads/master@{#42085}
-
jochen authored
BUG=v8:5215 R=marja@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2608163006 Cr-Commit-Position: refs/heads/master@{#42084}
-
franzih authored
BUG= Review-Url: https://codereview.chromium.org/2613723002 Cr-Commit-Position: refs/heads/master@{#42083}
-
franzih authored
Add a feedback vector slot for computed property names in object and class literals. Introduce new slot kind for storing computed property names. Change StaDataPropertyInLiteral to use the accumulator (again), so we don't exceed Bytecodes::kMaxOperands. We assume that most computed property names are symbols. Therefore we should see performance improvements, even if we deal with monomorphic ICs only. This CL only collects feedback but does not use it in Reduce() yet. BUG=v8:5624 Review-Url: https://codereview.chromium.org/2587393006 Cr-Commit-Position: refs/heads/master@{#42082}
-
zhengxing.li authored
port 72c37076(r42034) original commit message: Currently the CompileLazy builtin checks the SFI expliciltly for FCG code. This means if the SFI has bytecode we have to go through to the runtime to install the interpreter entry trampoline into the JSFunction object. Modify the builtin to always put the SFI code object into the JSFunction unless it's the lazy compile stub on the SFI as well. BUG= Review-Url: https://codereview.chromium.org/2614533003 Cr-Commit-Position: refs/heads/master@{#42081}
-
zhengxing.li authored
port d3ed71ed(r42021) original commit message: Don't fallback to the %StrictEqual / %Equal runtime functions for the generic CompareIC slow path, but use the (new) StrictEqual and Equal builtins instead. This avoids a performance cliff when mixing input types for strict equality sites. BUG= Review-Url: https://codereview.chromium.org/2612693002 Cr-Commit-Position: refs/heads/master@{#42080}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/dd74acb..9cde9c9 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/a067dd2..9e6944a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/432074b..0ec6dce TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2617683002 Cr-Commit-Position: refs/heads/master@{#42079}
-