- 14 Nov, 2016 2 commits
-
-
bjaideep authored
TestBit sets cr0 therefore need to pass that to the branch instruction. This got exposed with testcase added in CL https://codereview.chromium.org/2497573003/ R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2495853003 Cr-Commit-Position: refs/heads/master@{#40948}
-
bjaideep authored
Port 1915762c Original commit message: These JavaScript operators were special hacks to ensure that we always operate on Smis for the magic for-in index variable, but this never really worked in the OSR case, because the OsrValue for the index variable didn't have the proper information (that we have for the JSForInPrepare in the non-OSR case). Now that we have loop induction variable analysis and binary operation hints, we can just use JSLessThan and JSAdd instead with appropriate Smi hints, which handle the OSR case by inserting Smi checks (that are always true). Thanks to OSR deconstruction and loop peeling these Smi checks will be hoisted so they don't hurt the OSR case too much. Drive-by-change: Rename the ForInDone bytecode to ForInContinue, since we have to lower it to JSLessThan to get the loop induction variable goodness. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2502503002 Cr-Commit-Position: refs/heads/master@{#40947}
-
- 13 Nov, 2016 2 commits
-
-
ishell authored
BUG=v8:5561 Review-Url: https://codereview.chromium.org/2488673004 Cr-Commit-Position: refs/heads/master@{#40946}
-
jbroman authored
Several weeks have now passed since it was deprecated; Chromium does not call it. BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2478863002 Cr-Commit-Position: refs/heads/master@{#40945}
-
- 12 Nov, 2016 2 commits
-
-
jochen authored
That way we don't have to update the perf tests whenever the exact configuration changes. R=mvstanton@chromium.org,hablich@chromium.org,danno@chromium.org BUG= Review-Url: https://codereview.chromium.org/2420053002 Cr-Commit-Position: refs/heads/master@{#40944}
-
jbroman authored
BUG=chromium:148757 Review-Url: https://codereview.chromium.org/2492943002 Cr-Commit-Position: refs/heads/master@{#40943}
-
- 11 Nov, 2016 34 commits
-
-
jwolfe authored
BUG=v8:5051 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2484223004 Cr-Commit-Position: refs/heads/master@{#40942}
-
gsathya authored
- Creates a new promise-utils.{h, cc} which refactors out the logic to create resolving functions. This is shared between the runtime functions and builtins. - Changes PromiseResolveThenableJobInfo to store the context since we no longer create the resolving functions in JS. - Changes EnqueuPromiseResolveThenableJob to take in the promise and not the callbacks. BUG=v8:5343 Review-Url: https://codereview.chromium.org/2487053002 Cr-Commit-Position: refs/heads/master@{#40941}
-
ynovikov authored
Review-Url: https://codereview.chromium.org/2491373003 Cr-Commit-Position: refs/heads/master@{#40940}
-
bbudge authored
- Adds VmovExtended, VswpExtended methods to MacroAssembler. These methods use only VFP registers to perform s-register moves. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2497483002 Cr-Commit-Position: refs/heads/master@{#40939}
-
yangguo authored
Review-Url: https://codereview.chromium.org/2494993002 Cr-Commit-Position: refs/heads/master@{#40938}
-
leszeks authored
Previous: https://codereview.chromium.org/2491773006 BUG=v8:5512 Review-Url: https://codereview.chromium.org/2498643002 Cr-Commit-Position: refs/heads/master@{#40937}
-
yangguo authored
GetSharedFunctionInfo will compile inner functions if we get the compile-eager hint, even if the shared function info already exists, and the function already has been compiled. This breaks suspended generator objects. R=mstarzinger@chromium.org, neis@chromium.org BUG=v8:5575 Review-Url: https://codereview.chromium.org/2494043002 Cr-Commit-Position: refs/heads/master@{#40936}
-
mlippautz authored
BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2493803002 Cr-Commit-Position: refs/heads/master@{#40935}
-
yangguo authored
R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2492713005 Cr-Commit-Position: refs/heads/master@{#40934}
-
neis authored
This CL removes the ParseInfo argument from FetchFreeVariables, since it seems to have become unnecessary. R=verwaest@chromium.org BUG= Review-Url: https://codereview.chromium.org/2491373004 Cr-Commit-Position: refs/heads/master@{#40933}
-
verwaest authored
Methods in the runtime that enumerate over properties should never deal with private symbols. Most commonly such methods only loop over enumerable properties. This fix avoids accidentally handling private symbols in methods that only deal with enumerable properties. Methods that need to look at non-enumerable properties as well still have to manually filter private symbols (e.g., the KeyAccumulator). BUG=chromium:664411 Review-Url: https://codereview.chromium.org/2499593002 Cr-Commit-Position: refs/heads/master@{#40932}
-
ulan authored
BUG=v8:5614 Review-Url: https://codereview.chromium.org/2496913002 Cr-Commit-Position: refs/heads/master@{#40931}
-
leszeks authored
Fixes incorrect checks for handle validity when checking the compiled code, as well as incorrect uses of tst in arm and ppc flag checking code. Also adds a test that the tier-up works correctly. Reland of https://codereview.chromium.org/2448933002 BUG=v8:5512 Review-Url: https://codereview.chromium.org/2497573003 Cr-Commit-Position: refs/heads/master@{#40930}
-
ishell authored
BUG=v8:5561 Review-Url: https://codereview.chromium.org/2489433003 Cr-Commit-Position: refs/heads/master@{#40929}
-
hpayer authored
BUG=chromium:648973, chromium:648568 Review-Url: https://codereview.chromium.org/2493083003 Cr-Commit-Position: refs/heads/master@{#40928}
-
ulan authored
BUG=v8:5614 Review-Url: https://codereview.chromium.org/2481013010 Cr-Commit-Position: refs/heads/master@{#40927}
-
rmcilroy authored
Revert of [compiler] Enable shared function marking by default (patchset #1 id:1 of https://codereview.chromium.org/2491773006/ ) Reason for revert: Revert because it depends on https://codereview.chromium.org/2478323002/ which has been reverted. Original issue's description: > [compiler] Enable shared function marking by default > > BUG=v8:5512 TBR=bmeurer@chromium.org,leszeks@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5512 Review-Url: https://codereview.chromium.org/2491643006 Cr-Commit-Position: refs/heads/master@{#40926}
-
mlippautz authored
R=ulan@chromium.org BUG= Review-Url: https://codereview.chromium.org/2493173003 Cr-Commit-Position: refs/heads/master@{#40925}
-
franzih authored
ToName conversion, i.e., ToPropertykey() is the identify for strings and symbols. BUG=v8:5623 Review-Url: https://codereview.chromium.org/2494073002 Cr-Commit-Position: refs/heads/master@{#40924}
-
bmeurer authored
This adds a new ExternalPointer type, which is an Internal type that is used for ExternalReferences and other pointer values, like the pointers into the asm.js heap. It also adds a PointerConstant operator, which we use to represents these raw constants (we can probably remove that particular operator again once WebAssembly ships with the validator). R=mvstanton@chromium.org BUG=v8:5267,v8:5270 Review-Url: https://codereview.chromium.org/2494753003 Cr-Commit-Position: refs/heads/master@{#40923}
-
ahaas authored
According to the spec data segments are allowed even if the memory size is zero. However, if one of the data segments has a length greater than 0, then module instantiation should fail. I also changed the exception type in LoadDataSegments to TypeError, because that's the exception type for all exceptions which can happen during instantiation. R=titzer@chromium.org, rossberg@chromium.org TEST=cctest/test-run-wasm-module/EmptyMemoryEmptyDataSegment, cctest/test-run-wasm-module/EmptyMemoryNonEmptyDataSegment Review-Url: https://codereview.chromium.org/2483053005 Cr-Commit-Position: refs/heads/master@{#40922}
-
jkummerow authored
A SmiUntag() was missing when loading the old backing store's length. BUG=chromium:664469 Review-Url: https://codereview.chromium.org/2492783004 Cr-Commit-Position: refs/heads/master@{#40921}
-
leszeks authored
BUG=v8:5512 Review-Url: https://codereview.chromium.org/2491773006 Cr-Commit-Position: refs/heads/master@{#40920}
-
bmeurer authored
Revert of [compiler] Fix flipped boolean checks in marked tier-up (patchset #7 id:120001 of https://codereview.chromium.org/2478323002/ ) Reason for revert: Breaks deopt fuzzer: https://build.chromium.org/p/client.v8/builders/V8%20Deopt%20Fuzzer/builds/14872/steps/Deopt%20Fuzz%20on%20Ubuntu-12.04/logs/stdio Original issue's description: > [compiler] Fix flipped boolean checks in marked tier-up > > Fixes incorrect checks for handle validity when checking the compiled > code, as well as incorrect uses of tst in arm and ppc flag checking > code. Also adds a test that the tier-up works correctly. TBR=rmcilroy@chromium.org,leszeks@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2492523007 Cr-Commit-Position: refs/heads/master@{#40919}
-
ulan authored
BUG=v8:5614 Review-Url: https://codereview.chromium.org/2493183002 Cr-Commit-Position: refs/heads/master@{#40918}
-
jgruber authored
This CL adds support for: * conditional breaks in setBreakpoint, * locals in frame.local{Count,Name,Value}, * evaluation on a frame in frame.evaluate, * and more detailed scope information in scopeObject. Uses of several functions that are not covered by the inspector protocol and are only used in tests have been removed. Local handling has been modified to also include arguments as locals. Inspector differs in this regard from our FrameDetails in that arguments are always shown as locals. Argument-related functions were removed. BUG=v8:5530 Review-Url: https://codereview.chromium.org/2491543002 Cr-Commit-Position: refs/heads/master@{#40917}
-
ulan authored
BUG=v8:5614 Review-Url: https://codereview.chromium.org/2493173002 Cr-Commit-Position: refs/heads/master@{#40916}
-
leszeks authored
Fixes incorrect checks for handle validity when checking the compiled code, as well as incorrect uses of tst in arm and ppc flag checking code. Also adds a test that the tier-up works correctly. Review-Url: https://codereview.chromium.org/2478323002 Cr-Commit-Position: refs/heads/master@{#40915}
-
ulan authored
BUG=v8:5614 Review-Url: https://codereview.chromium.org/2492793005 Cr-Commit-Position: refs/heads/master@{#40914}
-
titzer authored
This CL moves all heap-allocated WASM data structures, both ones that are bonafide JSObjects and ones that are FixedArrays only, into a consistent place with consistent layout. Note that not all accessors are complete, and I haven't fully spread the new static typing goodness to all places in the code. R=ahaas@chromium.org,rossberg@chromium.org CC=gdeepti@chromium.org,mtrofin@chromium.org,clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/2490663002 Cr-Commit-Position: refs/heads/master@{#40913}
-
jkummerow authored
And decouple hydrogen-instructions.h from code-stubs.h. This avoids all of Crankshaft being recompiled when code-stub-assembler.h changes. Review-Url: https://codereview.chromium.org/2498563002 Cr-Commit-Position: refs/heads/master@{#40912}
-
mstarzinger authored
This enables the on-stack replacement mechanism from Ignition bytecode to TurboFan optimized code by default. The runtime profiler is now allowed to arm OSR points in bytecode. R=rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2432413004 Cr-Commit-Position: refs/heads/master@{#40911}
-
mythria authored
Fast case the monomorphic case, by marking the additional checks as deferred blocks. This increases the code size by about 50 bytes, but the monmorphic case requires one fewer jump and the all the code is contiguous, so may help caching. Also cleanup call and new bytecode handlers by changing some of the Branches to GotoIf/Unless for better readability. BUG=v8:4280 Review-Url: https://codereview.chromium.org/2487573005 Cr-Commit-Position: refs/heads/master@{#40910}
-
bmeurer authored
Utilize the string length protector to deoptimize if the resulting string length for string addition overflows. This way we generate less code here and avoid holding on to the lazy frame state, and thus potentially reduce the number live ranges. BUG=v8:5267,v8:5404 R=yangguo@chromium.org Review-Url: https://codereview.chromium.org/2491943004 Cr-Commit-Position: refs/heads/master@{#40909}
-