- 23 Aug, 2018 19 commits
-
-
Maya Lekova authored
This reverts commit b10a967f. Reason for revert: Breaks a TSAN bot - https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20TSAN/22122 Original change's description: > [wasm] Add feature counter for threads and shared memory > > This adds a feature counter for WASM shared memory (i.e. the presence > of the "shared" bit in a WASM module's memory section) and the usage > of WASM threads opcodes (i.e. wake/wait and atomics). > > This CL also plumbs the WasmFeatures through the compilation pipeline > to detect features as functions are being compiled. > > R=ahaas@chromium.org, ulan@chromium.org > BUG=chromium:868844 > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I854f932d3adb16e4fd87196fe2a193950295b856 > Reviewed-on: https://chromium-review.googlesource.com/1186329 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Ben Titzer <titzer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55337} TBR=ulan@chromium.org,titzer@chromium.org,ahaas@chromium.org Change-Id: Id011b6707b3359598621b315b87171644132b0ab No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:868844 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1186421Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#55340}
-
Bret Sepulveda authored
When switching log files, if a function was selected the timeline would attempt to draw its ticks and would usually crash. It would also preserve the selected section of the timeline. This patch wipes out the current state when loading a new log file, with the exception of the current mode (Summary, Bottom up, etc). As a consequence, the timeline size is now calculated in TimelineView.render so it will always be drawn at the right size. Bug: v8:6240 Change-Id: Ie15dd9b225901c8f4df614444458ae2aeaf74ccc Reviewed-on: https://chromium-review.googlesource.com/1186340Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#55339}
-
jgruber authored
This is another step towards a kRootRegister on ia32 and removes kRootRegister from generic interface descriptors. Drive-by: Better error message for type mismatches in machine graph verification. Drive-by: Use PreserveRootIA32 register config for all builtins. Bug: v8:6666 Change-Id: I920d4d6f3085da9734f6aa3bd3ee020abbc289fc Reviewed-on: https://chromium-review.googlesource.com/1186330Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55338}
-
Ben L. Titzer authored
This adds a feature counter for WASM shared memory (i.e. the presence of the "shared" bit in a WASM module's memory section) and the usage of WASM threads opcodes (i.e. wake/wait and atomics). This CL also plumbs the WasmFeatures through the compilation pipeline to detect features as functions are being compiled. R=ahaas@chromium.org, ulan@chromium.org BUG=chromium:868844 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I854f932d3adb16e4fd87196fe2a193950295b856 Reviewed-on: https://chromium-review.googlesource.com/1186329Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55337}
-
Simon Zünd authored
This CL fixes wrong parentheses that caused the sort-length benchmark to generate "random" arrays that only contained zeroes. R=ishell@chromium.org Change-Id: Ie2a564da037425a4ef9c2417597cdc13b497e32b Reviewed-on: https://chromium-review.googlesource.com/1186332Reviewed-by:
-
Peter Marshall authored
Changing reported_errors_ from a ZoneList to a ZoneVector caused regressions in Octane/CodeLoad and some other parsing benchmarks. This could be because we don't give the vector an initial size. Change-Id: I42c6ae063681dc3490dbab260085e801e24ac569 Reviewed-on: https://chromium-review.googlesource.com/1186328Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#55335}
-
Florian Sattler authored
This patch inlines some functions that improve parse time on code-load an jquery. Bug: v8:7926 Change-Id: Ida98b5d63fae9205282c23037aebb4ab2d38a7e2 Reviewed-on: https://chromium-review.googlesource.com/1184917Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55334}
-
Igor Sheludko authored
This reverts commit bf1e47e6. Reason for revert: chromium:876631 Original change's description: > [ptr-compr] Switch Smis to 31-bit on 64-bit platforms. > > This is prerequisite for V8 heap pointer compression. > > Bug: v8:7703 > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng > Change-Id: I2cdf02bd4cd535beb78a5db5b7cbdf67433a6d16 > Reviewed-on: https://chromium-review.googlesource.com/1181136 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55269} TBR=ulan@chromium.org,ishell@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7703 Change-Id: I6d8662a6ff0b352e4975d31330d63a705ed55cd5 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1186341Reviewed-by:
-
jgruber authored
A first baby-step towards embedded builtins on ia32. This adds the initial implementation for indirect load functionality (they still depend on embedded external references to get the roots pointer). External reference operands still directly embed external references. We can change these sites to be root-relative once the root register exists. Drive-by: replace raw jmp(HeapObject), call(HeapObject), mov(HeapObject) uses by their macro-assembler counterparts and add sanity-checks to ensure we're not calling them by accident when generating isolate-independent code. Bug: v8:6666 Change-Id: Ide11273721bcdaaee06934eedeca9f39346d1d50 Reviewed-on: https://chromium-review.googlesource.com/1170687 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Florian Sattler authored
Removed redundant parameters and Converted stack of bools to bitfield Bug: v8:8015 Change-Id: Ieaf144994b6d5c40bdb264ae57c0d7520d4a9148 Reviewed-on: https://chromium-review.googlesource.com/1185196Reviewed-by:
-
Michael Achenbach authored
NOTRY=true TBR=mslekova@chromium.org,sigurds@chromium.org Bug: v8:7783 Change-Id: I87be7e03b11365eb958fcdb3f031195ada3e57d8 Reviewed-on: https://chromium-review.googlesource.com/1186324Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55330}
-
Hannes Payer authored
This reverts commit 7f3f7e8a. Reason for revert: performance Original change's description: > [heap] Use std::atomic for page flags. > > Bug: chromium:852420,chromium:852420 > Change-Id: I873666df415c6b4919f8b3385494c9a08f105188 > Reviewed-on: https://chromium-review.googlesource.com/1170700 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55055} TBR=ulan@chromium.org,hpayer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:852420 Change-Id: I89fcd085395fa372ae9fb254e55954ff3b7ca4d7 Reviewed-on: https://chromium-review.googlesource.com/1184982Reviewed-by:
-
jgruber authored
And other related cleanups (additional asserts, use named register constants instead of the raw register name where appropriate). Drive-by: Unset kOffHeapTrampolineRegister (it's unused on ia32). Bug: v8:6666 Change-Id: Id2b94e0b9dbfa5d3bbacc80ec7424d38c4145658 Reviewed-on: https://chromium-review.googlesource.com/1185011 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Florian Sattler authored
Bug: v8:8015 Change-Id: I2ee074559484b9865dc1a27e6ea697ca311ee7ee Reviewed-on: https://chromium-review.googlesource.com/1185198Reviewed-by:
-
Ross McIlroy authored
Change-Id: I461810a3f531de8d094a56f75d8d8bdcb2ccd418 Reviewed-on: https://chromium-review.googlesource.com/1185194Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#55326}
-
Simon Zünd authored
The CL was reverted because it broke some tests in ChromeOS. > [array] Move Array.p.sort to Torque and use TimSort instead of QuickSort > > This CL changes the sorting algorithm used in Array.p.sort from > QuickSort to TimSort (implemented in Torque). > > Detailed performance results can be found here: https://goo.gl/4E733J > > To save on code space, fast-paths are implemented as sets of > function pointers instead of specializing generics. > > R=cbruni@chromium.org, jgruber@chromium.org > > Bug: v8:7382, v8:7624 > Change-Id: I7cd4287e4562d84ab7c79c58ae30780630f976de > Reviewed-on: https://chromium-review.googlesource.com/1151199 > Commit-Queue: Simon Zünd <szuend@google.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55003} Bug: v8:7382, v8:7624 Change-Id: Ic7a3230f3708177774b0760f08b7659d83ec5505 Reviewed-on: https://chromium-review.googlesource.com/1184901 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
-
Georg Neis authored
R=jarin@chromium.org Bug: v8:7790 Change-Id: Id057b31fca7db4c63ae3dd6bb111f8a7e5a1f78b Reviewed-on: https://chromium-review.googlesource.com/1184925 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Frank Tang authored
This reverts commit 41b3955f. Bug: v8:7961 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I1755c5d53f8ea26982b6b9f8e18ede86c1d27aa7 Reviewed-on: https://chromium-review.googlesource.com/1183951Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#55323}
-
Frank Tang authored
Bug: v8:8030, v8:8031 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Iaac58cc3a692ea9d7c986b24414403b57d00b904 Reviewed-on: https://chromium-review.googlesource.com/1180084Reviewed-by:
-
- 22 Aug, 2018 21 commits
-
-
Benedikt Meurer authored
This adds the missing support for HOLEY_DOUBLE_ELEMENTS to both `Array#find()` and `Array#findIndex()`. The implementation just deopts whenever it hits a double hole. In order to prevent deoptimization loops we add feedback to the CheckFloat64Hole operator, which also addresses the TODO in the `%ArrayIteratorPrototype%.next()` lowering. This provides a speed-up of up to 8x in microbenchmarks when using `Array#find()` or `Array#findIndex()` on HOLEY_DOUBLE_ELEMENTS arrays. Bug: chromium:791045, v8:1956, v8:6587, v8:7165, v8:8015 Change-Id: I1be22d3fcba56c676a81dc31a9042f8123ef3a55 Reviewed-on: https://chromium-review.googlesource.com/1183906Reviewed-by:
-
Junliang Yan authored
Change-Id: Id203bb297547002a41e18d621b59ce4237f88e5a Reviewed-on: https://chromium-review.googlesource.com/1183976Reviewed-by:
Muntasir Mallick <mmallick@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#55320}
-
Georg Neis authored
This feature is still far from doing what its name suggests, but we want to get test coverage. R=hablich@chromium.org, jarin@chromium.org Bug: v8:7790 Change-Id: I93c5c312e3dc84d04eb311ac17e078dc940471c8 Reviewed-on: https://chromium-review.googlesource.com/1185095Reviewed-by:
-
Ali Ijaz Sheikh authored
Change-Id: I29795e6df81f8ec719bdf62e5625cc06717861a5 Reviewed-on: https://chromium-review.googlesource.com/1183960Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ali Ijaz Sheikh <ofrobots@google.com> Cr-Commit-Position: refs/heads/master@{#55318}
-
Peter Marshall authored
We should probably discourage random access given that it isn't constant time for this data structure. You can always still do it via the Find() function if you really need to - at least the weird interface tells you that something strange is going on. Change-Id: I5e20cf9172afaa9265f1a6e38f619543b65614f2 Reviewed-on: https://chromium-review.googlesource.com/1184916Reviewed-by:
-
Camillo Bruni authored
This is a reland of 8fa7f9ed Original change's description: > [runtime] Improve for-in performance > > - Add fast-path String conversion for Smi (which is the most common case) > This improves for-in by ~10% on non-initialized enum-caches > - Don't use the NumberStringCache for large indices to not overflow the cache > during key collection. This improves worst-case performance by ~2.5x > - Drop number_to_string_native and number_to_string_runtime counters > > Bug: v8:7717 > Change-Id: Ic1ff385e3374e6a7e7e7bdb9ae75fb8c238105d1 > Reviewed-on: https://chromium-review.googlesource.com/1167049 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55233} Bug: v8:7717 Change-Id: Ie29041b20ca4a06b8e74a4378e7c1118373072ae Reviewed-on: https://chromium-review.googlesource.com/1183721 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Peter Marshall authored
We use a ZoneVector because we do a fair amount of random access e.g. in ExpressionClassifier::Accumulate() so the vector is better suited than ZoneChunkList as it has constant time random access. Bug: v8:6333 Change-Id: I83e1de60ee8fe319cfa5ce77fc5f5f86beb5307d Reviewed-on: https://chromium-review.googlesource.com/1054672Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#55315}
-
Ross McIlroy authored
TBR=yangguo@chromium.org Change-Id: Iadeb5828daf4db341c58534ff2b23141f241dfb9 Reviewed-on: https://chromium-review.googlesource.com/1184841 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Peter Marshall authored
This flag causes turbofan to generate more detailed line information for optimized code. This might have caused regressions in Sunspider and and Jetstream. This speculative revert will help us find out. Bug: chromium:875677, chromium:875723 Change-Id: I26cf68e94b66b9bd2c024c5f4be427f3033a59da Reviewed-on: https://chromium-review.googlesource.com/1185018Reviewed-by:
-
Hai Dang authored
The conditions checked by the CSA IsFastJSArrayWithNoCustomIteration is actually stronger than that of the runtime IterableToListCanBeElided. In particular, while IterableToListCanBeElided only checks that the prototype has no element when the array is holey, IsFastJSArrayWithNoCustomIteration always requires that the prototype has no element. Bug: v8:7980 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I28b086428d79682392413fb4182923184d7c1836 Reviewed-on: https://chromium-review.googlesource.com/1183671 Commit-Queue: Hai Dang <dhai@google.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Andreas Haas authored
As far as I understand the TODO, it has been resolved already some lines below: if (kEnableDebug) { VerifyCodeRangeIsDisjoint(data); } bug: v8:8015 R=titzer@chromium.org Change-Id: I3686ad609b7c04e56b14ad2d1ccb265ac260bac7 Reviewed-on: https://chromium-review.googlesource.com/1185012Reviewed-by:Ben Titzer <titzer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#55311}
-
jgruber authored
This adds a kRuntimeCallArgvRegister definition in platform-specific macro assemblers and unifies interface descriptor initialization. Bug: v8:6666 Change-Id: I6fd98bf9ac46083dd2e557ab558d0a5117dd7b94 Reviewed-on: https://chromium-review.googlesource.com/1185003Reviewed-by:
-
Dan Elphick authored
This is a reland of 957854dd Relanding now that pdfium has been fixed when non-standard flags are used. Original change's description: > Reland "[cleanup] Reland: Remove deprecated functions" > > This reverts commit 717b9385. > > Reason for revert: Cast build is now fixed > > Original change's description: > > Revert "[cleanup] Reland: Remove deprecated functions" > > > > This reverts commit c8376b00. > > > > Reason for revert: Still borked: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/cast_shell_linux/114796 > > > > Original change's description: > > > [cleanup] Reland: Remove deprecated functions > > > > > > This is reland of https://chromium-review.googlesource.com/c/v8/v8/+/1154915 > > > with no changes since the break in chromium for ChromeOS is now fixed. > > > > > > Removes all V8_DEPRECATED functions that weren't recently marked as well > > > any V8_DEPRECATE_SOON function that relied on using using the address of > > > an object to get hold of the Isolate. > > > > > > Reviewed-on: https://chromium-review.googlesource.com/1172350 TBR=yangguo@chromium.org Bug: v8:7786 Change-Id: Ic877155da3e4b280cc48e7dca9dc8dd78667a3d8 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.chromium.try:linux-chromeos-dbg;luci.chromium.try:linux-chromeos-rel Reviewed-on: https://chromium-review.googlesource.com/1177861Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#55309}
-
jgruber authored
Even in the restricted config, we can still end up having to print certain non-allocatable registers, e.g. if required by a FIXED_REGISTER policy. The names list needs to contain all general register names. Change-Id: I70104d6ba02779437de14eca01dc1900c159aa6a Reviewed-on: https://chromium-review.googlesource.com/1184846Reviewed-by:
-
Hannes Payer authored
This reverts commit f29fbf35. Reason for revert: <INSERT REASONING HERE> Original change's description: > [heap] Provide memory order relaxed accessor of page flags. > > Bug: chromium:874437,chromium:852420 > Change-Id: I4f484a6bb7072804dbcaacab77d25ba7a3fe338f > Reviewed-on: https://chromium-review.googlesource.com/1183188 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Hannes Payer <hpayer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55287} TBR=ulan@chromium.org,hpayer@chromium.org Change-Id: I5703641fd99a9dc79e2819af1597d4440e2e9990 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:874437, chromium:852420 Reviewed-on: https://chromium-review.googlesource.com/1185161Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55307}
-
Maya Lekova authored
Example failure: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Android%20Arm64%20-%20N5X/279 NOTRY=true NOTREECHECKS=true TBR=petermarshall@chromium.org,sigurds@chromium.org Change-Id: I25243a7f5e6db5661f61b9ac2ceb64fb8264142f Reviewed-on: https://chromium-review.googlesource.com/1185002Reviewed-by:
-
Sigurd Schneider authored
This reverts commit 7dc828b2. Reason for revert: breaks no-i18n build: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20noi18n%20-%20debug/22340 Original change's description: > Stop logging Builtin functions as LazyCompile. > > Builtin functions were being logged via both LogCodeObjects and > LogCompiledFunctions. The latter assumes the code in question has a > Name and so would end up logging an unattributable entry. This patch > stops logging that entry. > > Bug: v8:8061 > Change-Id: I20e5a853b8a214a91191fa644083bac7af9dc2c4 > Reviewed-on: https://chromium-review.googlesource.com/1177759 > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55302} TBR=bsep@chromium.org,jgruber@chromium.org,petermarshall@chromium.org Change-Id: I27e1ed75fea95914640f9618b1fd0c1fd7d8f6a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8061 Reviewed-on: https://chromium-review.googlesource.com/1184981Reviewed-by:
-
Sigurd Schneider authored
Some recent runs had the test passing, which painted the bot red. NOTRY=true NOTREECHECKS=true TBR=mstarzinger@chromium.org,rmcilroy@chromium.org Bug: v8:8040 Change-Id: Icc289f6615be299e9e401bc42e16a2e712f1445c Reviewed-on: https://chromium-review.googlesource.com/1184902Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:6666 Change-Id: I18258069703c225f2480bc5f81950b5b8f96fd4b Reviewed-on: https://chromium-review.googlesource.com/1179757 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
Builtin functions were being logged via both LogCodeObjects and LogCompiledFunctions. The latter assumes the code in question has a Name and so would end up logging an unattributable entry. This patch stops logging that entry. Bug: v8:8061 Change-Id: I20e5a853b8a214a91191fa644083bac7af9dc2c4 Reviewed-on: https://chromium-review.googlesource.com/1177759Reviewed-by:
-
Maya Lekova authored
This reverts commit 7fb6109b. Reason for revert: Speculatively reverting because of https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8-Blink%20Linux%2064%20(dbg)/13264 Original change's description: > [scanner] Add Skip to be used after successful Peek > > Change-Id: Ic3df370e2859bf77572b34a314ad8ed17b75b942 > Reviewed-on: https://chromium-review.googlesource.com/1183485 > Commit-Queue: Toon Verwaest <verwaest@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55279} TBR=leszeks@chromium.org,verwaest@chromium.org Change-Id: Ie1825cb4c971d2ec6a00b7ce3384c97ebbf885ce No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1184922Reviewed-by:
-
