Skip to content

V
V8
Switch branch/tag
  1. 19 Jun, 2019 1 commit
    • Simon Zünd's avatar
      Fix flaky Array#reduce mjsunit test · 6df0af84
      Simon Zünd authored 
      This CL fixes a flaky mjsunit test, that exercises Array#reduce with
sealed arrays in TurboFan. The flake was caused by temporary objects,
whos maps didn't live long enough. The code object of the function
under test holds weakly onto this maps. With a low enough gc interval,
the maps, and thus the code object, get cleaned up before the
{assertOptimized} can execute.

The fix is simply to assign these temporary objects to variables.

Bug: v8:9374
Change-Id: I43da8ba6b0194872b176e27617d9ca7fbfe43ec2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1666989
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#62269}
      6df0af84
  3. 18 Jun, 2019 1 commit
  5. 13 Jun, 2019 1 commit
  7. 04 Jun, 2019 1 commit
  9. 05 Mar, 2019 1 commit
    • Mike Stanton's avatar
      [Builtins] Array.prototype.reduce missing length check · 2222a9d6
      Mike Stanton authored 
      In the recent port of reduce() and reduceRight(), a check for a length
change during the loop (standard for iterating builtins) was omitted.

We did get array bounds check protection, however it didn't expose
the issue in our tests because the bounds check is against the
backing store length, not against the length in the referring JSArray.

Also added a test for reduceRight().

R=jgruber@chromium.org

Bug: chromium:937676
Change-Id: I76e22e0d71965bff84a0822b1df5dc818a00b50e
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1503732Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Michael Stanton <mvstanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60033}
      2222a9d6
  11. 05 Mar, 2018 1 commit
  13. 25 Jan, 2018 1 commit
  15. 19 Jan, 2018 1 commit
  17. 15 Jan, 2018 1 commit
  19. 21 Dec, 2017 2 commits
  21. 15 Sep, 2017 1 commit
  23. 21 Mar, 2017 1 commit
  25. 22 Oct, 2014 1 commit
  27. 27 Mar, 2014 1 commit
  29. 14 Nov, 2012 1 commit
  31. 31 May, 2011 1 commit
  33. 09 Jul, 2009 1 commit
  35. 21 Apr, 2009 2 commits