- 01 Feb, 2017 14 commits
-
-
petermarshall authored
Rename to Construct and ConstructWithSpread, to match the names of the JSOperators used. Unfortunately, I can't find a way for auto-formatting to stay happy unless we change the indentation for the whole BYTECODE_LIST macro. Review-Url: https://codereview.chromium.org/2663963003 Cr-Commit-Position: refs/heads/master@{#42840}
-
bmeurer authored
We already had an optimization in the CommonOperatorReducer that would duplicate a Return with Phi, EffectPhi and Merge inputs into the respective branches. But we can also do the same if the effect input of the Return dominates all branches, i.e. if the Return and Phi nodes are the only users of the Merge node. This helps with the awkward code generation that we currently observe for || and && in return position. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2668903002 Cr-Commit-Position: refs/heads/master@{#42839}
-
jgruber authored
This implements storing named captures on the regexp result object. For instance, /(?<a>.)/u.exec("b") will return a result such that: result.group.a // "b" https://tc39.github.io/proposal-regexp-named-groups/ BUG=v8:5437 Review-Url: https://codereview.chromium.org/2630233003 Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#42532} Committed: https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1fcf154 Review-Url: https://codereview.chromium.org/2630233003 Cr-Original-Original-Commit-Position: refs/heads/master@{#42570} Committed: https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e502396c Review-Url: https://codereview.chromium.org/2630233003 Cr-Original-Commit-Position: refs/heads/master@{#42676} Committed: https://chromium.googlesource.com/v8/v8/+/8bf52534f6bf86821a1589dcbcb7335052c1f94f Review-Url: https://codereview.chromium.org/2630233003 Cr-Commit-Position: refs/heads/master@{#42838}
-
jgruber authored
BUG= Review-Url: https://codereview.chromium.org/2659573002 Cr-Commit-Position: refs/heads/master@{#42837}
-
petermarshall authored
Review-Url: https://codereview.chromium.org/2662263002 Cr-Commit-Position: refs/heads/master@{#42836}
-
marja authored
BUG=v8:5516 Review-Url: https://codereview.chromium.org/2666053003 Cr-Commit-Position: refs/heads/master@{#42835}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/02f71fd..47e07d6 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/c302711..a7cc7a3 Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/986b4e8..4ee31ea TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2663373002 Cr-Commit-Position: refs/heads/master@{#42834}
-
bradnelson authored
Previously we allowed unreachable returns to be skipped. This won't work if we strictly follow the spec. BUG=None TEST=Manual against more strict wasm validation R=titzer@chromium.org,rossberg@chromium.org Review-Url: https://codereview.chromium.org/2668873003 Cr-Commit-Position: refs/heads/master@{#42833}
-
bbudge authored
Revert of [Turbofan] Macro-ize instruction selection for ia32. (patchset #1 id:1 of https://codereview.chromium.org/2669683002/ ) Reason for revert: Breaks Issue 1398 Original issue's description: > [Turbofan] Macro-ize instruction selection for ia32. > - Uses macros to reduce code duplication. > - Uses calls to VisitRO, VisitRR, VisitRROFloat, and VisitFloatUnop to > reduce code bloat. > > LOG=N > BUG=v8:4124 > > Review-Url: https://codereview.chromium.org/2669683002 > Cr-Commit-Position: refs/heads/master@{#42830} > Committed: https://chromium.googlesource.com/v8/v8/+/5e6eb91d0d66c9a118f1cc576accb649a17c5a9d TBR=titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Review-Url: https://codereview.chromium.org/2664403002 Cr-Commit-Position: refs/heads/master@{#42832}
-
bbudge authored
Revert of [Turbofan] Macro-ize instruction selection for x64. (patchset #1 id:1 of https://codereview.chromium.org/2668753004/ ) Reason for revert: Breaks array_concat Original issue's description: > [Turbofan] Macro-ize instruction selection for x64. > - Uses macros to reduce code duplication. > - Uses calls to VisitRO and VisitRR to reduce code bloat. > > LOG=N > BUG=v8:4124 > > Review-Url: https://codereview.chromium.org/2668753004 > Cr-Commit-Position: refs/heads/master@{#42828} > Committed: https://chromium.googlesource.com/v8/v8/+/e8e2e3c826d42490f809e1c45750bbb438b60d8c TBR=titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Review-Url: https://codereview.chromium.org/2668053004 Cr-Commit-Position: refs/heads/master@{#42831}
-
bbudge authored
- Uses macros to reduce code duplication. - Uses calls to VisitRO, VisitRR, VisitRROFloat, and VisitFloatUnop to reduce code bloat. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2669683002 Cr-Commit-Position: refs/heads/master@{#42830}
-
bbudge authored
- Uses macros to reduce code duplication. - Uses calls to VisitRR and VisitRRR to reduce code bloat. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2668633003 Cr-Commit-Position: refs/heads/master@{#42829}
-
bbudge authored
- Uses macros to reduce code duplication. - Uses calls to VisitRO and VisitRR to reduce code bloat. LOG=N BUG=v8:4124 Review-Url: https://codereview.chromium.org/2668753004 Cr-Commit-Position: refs/heads/master@{#42828}
-
gsathya authored
Throw a syntax error on "new import(1)" expression. Adds a new error msg as well. BUG=v8:5785 Review-Url: https://codereview.chromium.org/2661113002 Cr-Commit-Position: refs/heads/master@{#42827}
-
- 31 Jan, 2017 26 commits
-
-
jwolfe authored
Also updated some tests due to the change. The general pattern is when a trailing comma is expected to cause a SyntaxError, an additional comma was added. BUG=v8:5051 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2638513002 Cr-Commit-Position: refs/heads/master@{#42826}
-
marja authored
BUG=v8:5516 R=vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2661173003 Cr-Commit-Position: refs/heads/master@{#42825}
-
marja authored
[parser] Skipping inner funcs: make preparser scope analysis test work w/ destructuring declarations. If hidden scopes are ignored, the scopes and variable produced by the PreParser already matched the scopes and variables produced by the Parser. BUG=v8:5516 R=vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2663043003 Cr-Commit-Position: refs/heads/master@{#42824}
-
machenbach authored
Revert of [wasm] include JS conformance tests in Wasm mjsunit tests (patchset #5 id:80001 of https://codereview.chromium.org/2660903003/ ) Reason for revert: http://crbug.com/687279 Original issue's description: > [wasm] include JS conformance tests in Wasm mjsunit tests > > BUG= > > Review-Url: https://codereview.chromium.org/2660903003 > Cr-Commit-Position: refs/heads/master@{#42821} > Committed: https://chromium.googlesource.com/v8/v8/+/eb9b5edffb8c5acb0abdff0729901f95dbd3ccac TBR=mtrofin@chromium.org,titzer@chromium.org,bradnelson@chromium.org,eholk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2663063005 Cr-Commit-Position: refs/heads/master@{#42823}
-
binji authored
BUG=v8:4741 Review-Url: https://codereview.chromium.org/2658143003 Cr-Commit-Position: refs/heads/master@{#42822}
-
eholk authored
BUG= Review-Url: https://codereview.chromium.org/2660903003 Cr-Commit-Position: refs/heads/master@{#42821}
-
gsathya authored
Rewrites import expression into a runtime call. Uses peekahead to determine if parsing an import declaration or import expression. The runtime call doesn't actually do the import yet, will be added in follow on patch. Adds a new --harmony-dynamic-import flag. Adds a ignore_error_msg parameter to the test runner to ignore the discrepancy in the error messages while parsing import expression with parser and pre parser. This discrepancy will actually never happen in real code. BUG=v8:5785 Review-Url: https://codereview.chromium.org/2661933003 Cr-Commit-Position: refs/heads/master@{#42820}
-
marja authored
BUG=v8:5501 Review-Url: https://codereview.chromium.org/2661233002 Cr-Commit-Position: refs/heads/master@{#42819}
-
bjaideep authored
R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2661133004 Cr-Commit-Position: refs/heads/master@{#42818}
-
bjaideep authored
Port 56429fc1 Original Commit Message: Introduced MachineType::TaggedSigned() and TaggedPointer(). The idea is to quit using the representational dimension of Type, and instead encode this information in the MachineRepresentation (itself lightly wrapped in MachineType, along with MachineSemantic). There are three parts to the whole change: 1) Places that set the machine representation - constant nodes, loads nad stores, global object and native context specialization. 2) Places that propagate type/representation - this is representation inference (aka simplified lowering). At the end of this process we expect to have a MachineRepresentation for every node. An interesting part of this is phi merging. 3) Places that examine representation - WriteBarrier elimination does this. Currently it's looking at the Type representation dimension, but as a part of this change (or in a soon-to-follow change) it can simply examine the MachineRepresentation. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/2662223003 Cr-Commit-Position: refs/heads/master@{#42817}
-
machenbach authored
Revert of [test] Add back lsan leak detection (patchset #4 id:60001 of https://codereview.chromium.org/2592663004/ ) Reason for revert: Breaks mac asan. Need to keep leak check off on mac. Original issue's description: > [test] Add back lsan leak detection > > BUG=chromium:662388 > TBR=yangguo@chromium.org, glider@chromium.org, titzer@chromium.org > > Review-Url: https://codereview.chromium.org/2592663004 > Cr-Commit-Position: refs/heads/master@{#42815} > Committed: https://chromium.googlesource.com/v8/v8/+/e196d00df587b6513eb79059cd96e259dd0a763f TBR=yangguo@chromium.org,glider@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:662388 Review-Url: https://codereview.chromium.org/2667993002 Cr-Commit-Position: refs/heads/master@{#42816}
-
machenbach authored
BUG=chromium:662388 TBR=yangguo@chromium.org, glider@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/2592663004 Cr-Commit-Position: refs/heads/master@{#42815}
-
bmeurer authored
With this fix we generate straightline code again for the fast case, just like Crankshaft. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2666893003 Cr-Commit-Position: refs/heads/master@{#42814}
-
neis authored
A previous CL (https://codereview.chromium.org/2634123002) did that for let-declared variables. This CL also does it for var- and function-declared variables. BUG=v8:5636 Review-Url: https://codereview.chromium.org/2656753003 Cr-Commit-Position: refs/heads/master@{#42813}
-
petermarshall authored
Revert of [Test] Do a set number of runs to trigger optimisation for SuperSpread. (patchset #1 id:1 of https://codereview.chromium.org/2669523002/ ) Reason for revert: Causes test timeouts. Original issue's description: > [Test] Do a set number of runs to trigger optimisation for SuperSpread. > > BUG=v8:5895 > > Review-Url: https://codereview.chromium.org/2669523002 > Cr-Commit-Position: refs/heads/master@{#42811} > Committed: https://chromium.googlesource.com/v8/v8/+/d4c22c3084f55a0c0baf88362f7ef652a7dc450b TBR=bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5895 Review-Url: https://codereview.chromium.org/2669553002 Cr-Commit-Position: refs/heads/master@{#42812}
-
petermarshall authored
BUG=v8:5895 Review-Url: https://codereview.chromium.org/2669523002 Cr-Commit-Position: refs/heads/master@{#42811}
-
bmeurer authored
The KeyedStoreMode that we get out of the FeedbackNexus doesn't necessarily need to apply when we have "static knowledge" about the receiver, i.e. when the receiver is a known JSTypedArray, but the KEYED_STORE_IC has seen only JSArray instances so far. The DCHECK was too restrictive in this case, since we can just ignore the KEYED_STORE_IC mode (like we ignore the maps). BUG=chromium:685050 R=ishell@chromium.org Review-Url: https://codereview.chromium.org/2668643002 Cr-Commit-Position: refs/heads/master@{#42810}
-
bmeurer authored
We were missing a case for Tagged->TaggedSigned conversions when the input type is known to be Type::SignedSmall. BUG=chromium:687029 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2666863002 Cr-Commit-Position: refs/heads/master@{#42809}
-
mstarzinger authored
These counters were used during the initial implementation to gather statistics about comparative effectiveness of the two escape analysis approaches in practice. The counters are not thread-safe and cannot be used for the analysis any longer as it is now running off main thread. We deprecate the counters in question in favor of maintaining deferred statistics until the need for such statistics arises again. R=bmeurer@chromium.org BUG=chromium:685942 Review-Url: https://codereview.chromium.org/2667453003 Cr-Commit-Position: refs/heads/master@{#42808}
-
clemensh authored
This will be used for perf tests: https://chromereviews.googleplex.com/565327014/ R=titzer@chromium.org, bradnelson@chromium.org Review-Url: https://codereview.chromium.org/2663713003 Cr-Commit-Position: refs/heads/master@{#42807}
-
bmeurer authored
We cannot eliminate unused CheckFloat64Hole nodes, since loading from a holey array can have side-effects, i.e. triggering getters in the prototype chain. R=mvstanton@chromium.org BUG=chromium:686737 Review-Url: https://codereview.chromium.org/2665123002 Cr-Commit-Position: refs/heads/master@{#42806}
-
bmeurer authored
This is essentially a port of http://crrev.com/2403003002 to TurboFan, adding support for fast access to JSGlobalObject properties through the current native contexts' JSGlobalProxy. It's a slightly bigger change, since JSNativeContextSpecialization and JSGlobalObjectSpecialization needs merging for this to work, as due to different type feedback layout we cannot just turn a JSLoadNamed into JSLoadGlobal operator (and same for JSStoreNamed vs. JSStoreGlobal). This part of the change is mostly mechanical. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng R=ishell@chromium.org, jochen@chromium.org BUG=chromium:634276,v8:5267 Review-Url: https://codereview.chromium.org/2664853002 Cr-Commit-Position: refs/heads/master@{#42805}
-
jkummerow authored
Review-Url: https://codereview.chromium.org/2663713002 Cr-Commit-Position: refs/heads/master@{#42804}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/3dada45..02f71fd Rolling v8/third_party/catapult: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+log/c3f2575..986b4e8 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/0b3a445..960cc3e TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2661143002 Cr-Commit-Position: refs/heads/master@{#42803}
-
eholk authored
Previously this information was encoded in a FixedArray dangling off the Code object. This extra field seems to be responsible for increased memory usage, as seen in the linked bugs. In this change, we instead encode this in the RelocInfo and remove the field from the Code object. BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=678583 BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=671180 BUG= https://bugs.chromium.org/p/chromium/issues/detail?id=670733 Review-Url: https://codereview.chromium.org/2651833003 Cr-Commit-Position: refs/heads/master@{#42802}
-
gdeepti authored
R=bradnelson@chromium.org, ahaas@chromium.org BUG=5553 Review-Url: https://codereview.chromium.org/2662153002 Cr-Commit-Position: refs/heads/master@{#42801}
-