- 23 May, 2018 6 commits
-
-
Michael Starzinger authored
By now we no longer call {CodeStub} targets directly from WebAssembly code and hence can remove support for serializing and deserializing such call sites. R=clemensh@chromium.org Change-Id: Ibfea9fce178d49f4e739a049a6767031da3c9569 Reviewed-on: https://chromium-review.googlesource.com/1066013 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#53299}
-
Peter Marshall authored
The current profiling mode (called kLeafNodeLineNumbers in this CL) produces a tree, with each node representing a stack frame that is seen in one or more samples taken during profiling. These nodes refer to a particular function in a stack trace, but not to a particular line or callsite within that function. This CL adds a new more (called kCallerLineNumbers) which produces a different profile tree, where each stack trace seen during profiling, including the line number, has a unique path in the tree. The profile tree was previously keyed on CodeEntry*. Now it is keyed on the pair of CodeEntry* and line_number, meaning it has distinct nodes for those combinations which exist, and each distinct stack trace that was sampled is represented in the tree. For optimized code where we have inline frames, there are no line numbers for the inline frames in the stack trace, causing duplicate branches in the tree with kNoLineNumberInfo as the reported line number. This will be addressed in follow-ups. Bug: v8:7018 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I512e221508f5b50ec028306d212263b514a9fb24 Reviewed-on: https://chromium-review.googlesource.com/1013493 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#53298}
-
Michael Achenbach authored
TBR=jgruber@chromium.org NOTRY=true Bug: v8:7783 Change-Id: I4887d520fe97a03189977e39d5db944175c759d0 Reviewed-on: https://chromium-review.googlesource.com/1068673Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53297}
-
Marja Hölttä authored
Previous version: https://chromium-review.googlesource.com/1049606 This version is exactly the same as the previous; a bugfix ( https://chromium-review.googlesource.com/c/v8/v8/+/1069127 ) makes relanding possible. BUG=v8:7308 TBR=ishell@chromium.org, tebbi@chromium.org, leszeks@chromium.org, ulan@chromium.org Change-Id: If7d455ceb6af0505a44b4fc52c52143e51cd115a Reviewed-on: https://chromium-review.googlesource.com/1070027Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#53296}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b5df251..4389c9c Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/49edbd3..12f7d6b Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/083eb25..ebdd0db Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/08d5b1f..145d057 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic1022e9d81d7e90559693648b6fc85af53937240 Reviewed-on: https://chromium-review.googlesource.com/1069470 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#53295}
-
Mathias Bynens authored
The TC39 committee reached consensus to rename `flatten` to `flat` during the May 22nd meeting. The corresponding patch to the proposal is here: https://github.com/tc39/proposal-flatMap/commit/093eacc7fe0906e70f7626bf6c7d6e9dfc53cce9 Bug: v8:7220 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie8049ae4d4589a4ae7fe3d203053cef798c135e4 Reviewed-on: https://chromium-review.googlesource.com/1069467Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#53294}
-
- 22 May, 2018 22 commits
-
-
Tobias Tebbi authored
Change-Id: Ie61c8fa51c7c13ab74c4c97ed6803be7f879a549 Reviewed-on: https://chromium-review.googlesource.com/1069088 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#53293}
-
Tobias Tebbi authored
Change-Id: I80dd313ac3a5809d363adff9cf11ac31b04648dd Reviewed-on: https://chromium-review.googlesource.com/1068876 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Vasili Skurydzin authored
Change-Id: I97cdf61a15c2141d3c552a792ac08c9865f272ff Reviewed-on: https://chromium-review.googlesource.com/1066307 Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#53291}
-
Junliang Yan authored
Port 813094ac Original Commit Message: This is not web compatible, so let's delete the code. R=gsathya@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I8cbe561b176c25900d4e40eb8912e5c0b4c44410 Reviewed-on: https://chromium-review.googlesource.com/1069170Reviewed-by:
-
Sigurd Schneider authored
Change-Id: I6d84e7ef500aecd83a77ed2ce3fed4e15b29b7ac Reviewed-on: https://chromium-review.googlesource.com/1065881 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#53289}
-
Hannes Payer authored
Replaces the anchor page circular doubly linked list with a doubly linked list pointing to nullptr on its ends. Fixes a memory leak when rewinding pages. The large pages list will move to the new list implementation in a follow-up CL. Change-Id: I2933a5e222d4ca768f4b555c47ed0d7a7027aa73 Reviewed-on: https://chromium-review.googlesource.com/1060973 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Marja Hölttä authored
If it points to a new space object which doesn't get scavenged, we need to drop the reference. BUG=v8:7308, v8:7768 Change-Id: I4485a7abcac3a26781811cc9bf134fd80e5f35b5 Reviewed-on: https://chromium-review.googlesource.com/1069127 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: v8:7766 Change-Id: If96c5b278ef25f2b8729a4abc81defb598b444ee Reviewed-on: https://chromium-review.googlesource.com/1066558Reviewed-by:
-
Deepti Gandluri authored
Change-Id: I488b47a51ef79c97545576fcc7d58e9147deb664 Reviewed-on: https://chromium-review.googlesource.com/1067677Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#53285}
-
Simon Zünd authored
This CL adds grammar support for function pointers to generic builtins. It also instantiates generic specializations when they are only used in an assignment to a function pointer. Example: builtin GenericBuiltinTest<T: type>(c: Context, param: T): Object { return Null; } let fnptr: builtin(Context, Smi) => Object = GenericBuiltinTest<Smi>; Change-Id: Ib7e5f47ffc05f14eb5d0b789936587263dfb961d Reviewed-on: https://chromium-review.googlesource.com/1068731 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#53284}
-
Simon Zünd authored
This CL adds a benchmark where the array to sort undergoes multiple element kind transitions before it is sorted. R=jgruber@chromium.org Bug: v8:7382 Change-Id: I5196a33139a5f3b833719c2a111dc9a521bdb37c Reviewed-on: https://chromium-review.googlesource.com/1066012 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#53283}
-
Tobias Tebbi authored
We already had to introduce TypeAlias to allow types to be const. With TypeAlias, there is no need for types to be declarable themselves. Change-Id: Ia718482f6c121b5316aca819368e6d048283e5e8 Reviewed-on: https://chromium-review.googlesource.com/1068734 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7779 Change-Id: Iabe5b74900885d489309fdfe25674a29e8690965 Reviewed-on: https://chromium-review.googlesource.com/1068745 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
The wrappers for imports are not accessible through the code() accessor, so avoid tracing them for now. BUG=chromium:844745 R=ahaas@chromium.org Change-Id: I63fe447091ba3c202e3ffcfddfa645049a0b83cf Reviewed-on: https://chromium-review.googlesource.com/1068739 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: Ic1c4a10a251a8243fc337dc149eb057a29cace2b Reviewed-on: https://chromium-review.googlesource.com/1065670 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Peter Marshall authored
This map is often quite small and holds small items (ints) so wastes quite a bit of overhead in the backing tree representation. This CL changes the std::map to a sorted vector of pairs. This reduces the size significantly (2.13 MiB -> 598 KiB on the node server example). Bug: v8:7719 Change-Id: Ic829693f007732ae145fae02850a1ed913cd941e Reviewed-on: https://chromium-review.googlesource.com/1064233 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#53278}
-
Andreas Haas authored
R=titzer@chromium.org Change-Id: Ifffa4ddb671ab337d75952515b6f5e55033bbd7d Reviewed-on: https://chromium-review.googlesource.com/1068040Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#53277}
-
Sigurd Schneider authored
This CL re-uses pipeline naming for --trace-turbo phase naming. Bug: v8:7327 Change-Id: I87efb01170ed5d3add7a79c9f38542e9cba6c493 Reviewed-on: https://chromium-review.googlesource.com/1064237 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#53276}
-
Michael Achenbach authored
This migrates test configs for all remaining trybots. All migrated builders are not on CQ, hence, they don't run regularly. Therefore, some shard configs are too low by now and are also upgraded in this CL to match their CI counterparts. This also sets the --gc-stress flag for all tests on gc stress builders explicitly, since the infra-side configuration (which sets it per builder) will be deleted soon. NOTRY=true Bug: chromium:830557 Change-Id: Id8a9505fcd2c848ec659c7401cbbe9224feaf5d2 Reviewed-on: https://chromium-review.googlesource.com/1065674Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#53275}
-
Michael Lippautz authored
This is to allow testing object stats collection. No-try: true Bug: v8:7760 Change-Id: I1e5318f18bfb3799b90c0ee0aec6df87a794b32c Reviewed-on: https://chromium-review.googlesource.com/1065478 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d28bd70..b5df251 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1d08c64..49edbd3 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/679372d..c893c7e TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I37f185f145ee138d152758376da38fd12d322673 Reviewed-on: https://chromium-review.googlesource.com/1067992 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
ToDirectStringAssembler::PointerToData returns a raw pointer, which is invalidated when GC moves the original string and hence must not be accessed after any allocations. This fixes the bug introduced in b4ebbc57 / r53260. Bug: chromium:845060 Tbr: jgruber@chromium.org Change-Id: I248d0dd2a275bf9308269b3f65d00c4c4c3d4292 Reviewed-on: https://chromium-review.googlesource.com/1068213 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#53272}
-
- 21 May, 2018 3 commits
-
-
Mathias Bynens authored
The ECMAScript ⊃ JSON proposal shipped in V8 v6.6 and Chrome 66. Bug: v8:7418 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id8979d0cec6d61ef4a7e9982142a3f3dcf7c326b Reviewed-on: https://chromium-review.googlesource.com/1067857Reviewed-by:
-
Mathias Bynens authored
The ECMAScript ⊃ JSON proposal doesn’t affect LineContinuation grammar. These tests verify that the behavior remains the same when the --harmony-subsume-json feature flag is enabled. Bug: v8:7418 Change-Id: Iec5cb1bc112f278481ba1202f0c2b8693917843a Reviewed-on: https://chromium-review.googlesource.com/1067463Reviewed-by:
-
Peter Marshall authored
It seems that the output on snapshot failure has changed, so failed snapshots were no longer being automatically re-run in gdb. Change-Id: I321a6055b5683db31d215b9c30827f4badca3df7 Reviewed-on: https://chromium-review.googlesource.com/1066058Reviewed-by:
-
- 20 May, 2018 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a071784..d28bd70 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/669dcb1..1d08c64 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I270b86ba6f048eeaa8e77658c0b1a14b7fd1621a Reviewed-on: https://chromium-review.googlesource.com/1067123Reviewed-by:
-
- 19 May, 2018 1 commit
-
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/0676f76..a071784 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/78fd930..669dcb1 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3f0591d..083eb25 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/b0e0b84..f61e46d Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/a67a084..679372d Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/8822987..833f5eb TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I46b469b09b81ad3106ae4526d2996d2babec080a Reviewed-on: https://chromium-review.googlesource.com/1066895Reviewed-by:
-
- 18 May, 2018 7 commits
-
-
Aseem Garg authored
R=gdeepti@chromium.org,bbudge@chromium.org,clemensh@chromium.org,titzer@chromium.org BUG=v8:6020 Change-Id: I25676d4f8a7ea7b1e02a54abe009faec0eb2c6db Reviewed-on: https://chromium-review.googlesource.com/1018840 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
-
Vincent Belliard authored
Bug: v8:6600 Change-Id: I64ab212badf1b54d3e50466b74b30eb2866fbc9e Reviewed-on: https://chromium-review.googlesource.com/1060345Reviewed-by:
-
Sathya Gunasekaran authored
This is not web compatible, so let's delete the code. Bug: v8:5536 Change-Id: I50506d37dcdff1f7f95577c47adcec653cc1f06e Reviewed-on: https://chromium-review.googlesource.com/1064740 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Vincent Belliard authored
For AArch64, clean correctly the pools when the compilation is aborted Bug: v8:6600 Change-Id: I4bacdbeae49290ece0ce1bf47319bf7076fec37c Reviewed-on: https://chromium-review.googlesource.com/1066151 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
This requires changing the way stubs and builtins are encoded in tags, as for arm64 we only have 26 bits to encode a PC-relative offset. With the previous encoding scheme the builtin ids were shifted by 16 bits and ended up exceeding this range. Change-Id: I0f396390a622ea67b890d2dd47ca12e00092e204 Reviewed-on: https://chromium-review.googlesource.com/1059209 Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Reviewed-by:
-
Georg Neis authored
Command-line flags can be parsed in two modes. In the mode used by Chrome, an unrecognized flag causes the remaining arguments to be ignored. This is different from how d8 parses flags. Example: 1) d8 --enable-slow-asserts --trace-ic 2) content_shell --js-flags='--enable-slow-asserts --trace-ic' Assuming we compiled without ENABLE_SLOW_DCHECKS, in (1) we get a warning that --enable-slow-asserts is unknown. Nevertheless, --trace-ic will be enabled. In (2), we get an error that --enable-slow-asserts is unknown but --trace-ic will NOT be enabled (and neither does content_shell abort). This inconsistency is obviously very confusing. With this CL, we will at least print any flags that got ignored. Change-Id: I22bdb06d2b0accc234b3f5d596458809de364bce Reviewed-on: https://chromium-review.googlesource.com/1066010 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Choongwoo Han authored
Optimize String.p.split for the case when the separator is empty and the subject is a direct one-byte string. Bug: v8:7103 Change-Id: Ica277d2c426679a1f77a1ef8ecb523bd596f65fb Reviewed-on: https://chromium-review.googlesource.com/1045950 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
