- 14 Dec, 2018 21 commits
-
-
Daniel Clifford authored
In the process, add the bint type (which stands for Best-INTeger), which implements Torque's idea of CSA's ParameterMode. It maps to a different type on 32-bit (Smi) and 64-bit (intptr). There are convert operators that are either no-ops or conversions to-and-from Smi and intptrs on the each platform, depending on the underlying type for bint. This allows Torque code to git most of the benefits of ParameterMode without having to explicitly pass around the mode, since it is almost always OptimalMode anyways. Change-Id: I92e08adc1d79cb3e24576c96f9734aec1af54162 Reviewed-on: https://chromium-review.googlesource.com/c/1361160 Commit-Queue: Daniel Clifford <danno@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#58253}
-
Jakob Kummerow authored
in preparation for incrementally transitioning their subclasses. Bug: v8:3770 Change-Id: I5ed6adb1969bc1ec7125571fea443834ca255c22 Reviewed-on: https://chromium-review.googlesource.com/c/1377453 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#58252}
-
Jakob Kummerow authored
along with subclasses: Tuple2, Tuple3, FeedbackCell, AccessorPair. The latter two can be separated out later if desired. Bug: v8:5402 Change-Id: I4e1a6d2621cc6f96b5da208cff0da7cd5de91672 Reviewed-on: https://chromium-review.googlesource.com/c/1371038Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#58251}
-
peterwmwong authored
Enable --harmony-string-matchall by default. String.prototype.matchAll behaves similarly to String.prototype.match, but returns a full regexp result object for each match in a global or sticky regexp. This offers a simple way to iterate over matches when access to e.g. capture groups is needed. const string = 'a b c'; const regex = /[ac]/g; for (const match of string.matchAll(regex)) { console.log(`${match[0]} at ${match.index}`); } // a at 0 // c at 4 More information can be found here: https://github.com/tc39/proposal-string-matchall Drive-by: Update debug evaluate side effect expectations to handle String.p.matchAll and RegExp.p[@@matchAll] Bug: v8:6890 Change-Id: Ie3e712af66689936b7d2a15df705b792ccf06bd3 Reviewed-on: https://chromium-review.googlesource.com/c/1377774Reviewed-by:Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
tzik authored
For builtins-mips64.cc, add a static cast to resolve the ambiguity of "0" around Operand(int64_t) and Operand(const char*). For mips{,64}/macro-assembler-mips{,64}.cc, remove extra references to masm. Change-Id: I9ce94c682c64b48501386029a912b0f5e32e268d Reviewed-on: https://chromium-review.googlesource.com/c/1378365Reviewed-by: -
Jeremy Roman authored
Also fail early if we detect that we've previously run out of memory and thus corrupted the buffer. Add a unit test for this kind of case. Bug: chromium:914731 Change-Id: Iaaf3927209bffeab6fe8ba462d9dd9dad8cbbe2f Reviewed-on: https://chromium-review.googlesource.com/c/1377449Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#58248}
-
Predrag Rudic authored
Compiler didn't know whether to choose definition of Operand method with pointer argument or integer argument defined in src/mips64/assembler-mips64.h Change-Id: I0887df6ce7aa6ba6be166d415b1b5574368b3a4a Reviewed-on: https://chromium-review.googlesource.com/c/1378180Reviewed-by:
Sreten Kovacevic <skovacevic@wavecomp.com> Commit-Queue: Predrag Rudic <prudic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#58247}
-
Ross McIlroy authored
BUG=v8:8293 Change-Id: Ic2424d55ad04f5a92953c2c6d639ed8178a628b4 Reviewed-on: https://chromium-review.googlesource.com/c/1373779Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#58246}
-
Jakob Gruber authored
In preparation for upcoming work on Torque function pointers. This table will be used to look up the entry address in order to call there directly without going through the (on-heap) trampoline. Bug: v8:7777 Change-Id: If713430c843e85371a5aaef8a3bfb5da9e0ea903 Reviewed-on: https://chromium-review.googlesource.com/c/1378172Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The vector of callbacks can only be accessed from main threads. Otherwise we get flaky data races. Those showed up after removing the finisher task (https://crrev.com/c/1335553/2). R=mstarzinger@chromium.org Bug: v8:7921 Change-Id: I0429ae87427601952723f6e3ad1e02eb0e59a6e1 Reviewed-on: https://chromium-review.googlesource.com/c/1378174 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Tamer Tas authored
R=machenbach@chromium.org CC=yangguo@chromium.org Bug: v8:8491 Change-Id: I8379825c194e588da582a3000201eea75b59140a Reviewed-on: https://chromium-review.googlesource.com/c/1371826 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58243}
-
Yang Guo authored
This ensures that we have a clean slate when updating to newer V8. TBR=machenbach@chromium.org Bug: v8:8584 Change-Id: I37f6e4a42738e5e9ea5bfdca5465d6a3e984fe65 Reviewed-on: https://chromium-review.googlesource.com/c/1378169Reviewed-by:
-
Clemens Hammacher authored
Avoid the indirection via the signature, instead specialize per signature. On a microbenchmark run locally, this speeds up Liftoff by ~5% and validation by ~15%. R=titzer@chromium.org Bug: v8:8423 Change-Id: Ia0e9ab0dcaa759e4ed4dcd46d2e6f16e65790915 Reviewed-on: https://chromium-review.googlesource.com/c/1373778Reviewed-by:
-
peterwmwong authored
Incremental step towards the removal of JS Natives. This CL Moves the initialization of InternalPackedArray functions and prototype out of prologue.js and into bootstrapper. Bug: v8:7624 Change-Id: I7a2a1afbd1721ddc9bc9ac677c03f0817e4f1418 Reviewed-on: https://chromium-review.googlesource.com/c/1374995Reviewed-by:
-
Camillo Bruni authored
Do not set the name property on any function or classes. This is not required as per spec #sec-__proto__-property-names-in-object-initializers. Bug: v8:7773 Change-Id: Iade96573690e5b14b60434c37683f782cf9cb2cb Reviewed-on: https://chromium-review.googlesource.com/c/1375912Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#58239}
-
Clemens Hammacher authored
When selecting the frame above the V8_Dcheck method (at the DCHECK location), it helps enormously to immediately see the error message generated by the DCHECK. This extends the dcheck_stop_handler to find and print this message. Drive-by: Speed up the handler by stopping after the first V8_Dcheck frame. R=mstarzinger@chromium.org Bug: v8:8562 Change-Id: If3a8f3aaab6a0014006ccac7260f37d5d90363c5 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1378170Reviewed-by:
-
Alessandro Pignotti authored
ProtectedLoad/ProtectedStore opcodes are used in WebAssembly to represent memory accesses. Since they are not part of the allowed opcodes in OwnedByAddressingOperand it is not possible to take advantage of addressing modes to encode common patterns for the pointer input value. R=jarin@chromium.org Bug: v8:8508 Change-Id: Ic62bf13fed7b1d86afb112d9aa59cd7073a28e72 Reviewed-on: https://chromium-review.googlesource.com/c/1354458 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#58237}
-
Maya Lekova authored
Remove a DCHECK that got triggered in the rare condition that GC kicks in during CompilationDependencies::Commit, changing the pretenuring decision, thus leading to deoptimization. To make sure this rare case is properly handled, add a new FLAG_pretenure_during_compilation and a cctest that simulates it predictably. R=jarin@chromium.org,mvstanton@chromium.org Bug: v8:8520 Change-Id: If83f8a3d4659a694357b3869c931c7d7c164fd1a Reviewed-on: https://chromium-review.googlesource.com/c/1363143 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#58236}
-
Stephan Herhut authored
Now, we also print the fixed ranges, which are used to model fixed register constraints. Change-Id: Ife25529c911eaf950a33a4c099636a8f8925308e Reviewed-on: https://chromium-review.googlesource.com/c/1375913Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#58235}
-
Jakob Kummerow authored
The new ObjectPtr design makes non-inlined helper functions a little more expensive because "this" is always a pointer where pass-by-value would be more efficient, which is an issue for functions whose size puts them right at the threshold of getting inlined or not. String::Get falls into this category when called from RegExpFlagsFromString. In this case, we can do even better than restoring inlineability by fine-tuning the control flow a bit. This should repair the regression in crbug.com/910573 Bug: chromium:910573 Change-Id: Ie6b68ef01cd978ec502d8d6c1da788c77422dce7 Reviewed-on: https://chromium-review.googlesource.com/c/1369087 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
-
Frank Tang authored
Add bit flags to remember hourCycle Reorder the code in JSDateTimeFormat::Initialize Implement the hourCycle option resolutions Fix intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle in test262 Bug: v8:7482 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Idc136276da89b95df6ae864161b114e34f9dcae8 Reviewed-on: https://chromium-review.googlesource.com/c/1253101 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#58233}
-
- 13 Dec, 2018 19 commits
-
-
Sigurd Schneider authored
This is a reland of 9c0a4858 Original change's description: > Reland "Reland "[code-comments] Put code comments into the code object"" > > This is a reland of ed3d6472 > > This reland fixes that padding at the end of Wasm instruction streams > triggered asserts in the code printer. > > Original change's description: > > Reland "[code-comments] Put code comments into the code object" > > > > This is a reland of e774cffe > > > > This reland disables a test as v8:8548 is blocking it, which was > > broken by a recent CL. CQ did not catch this because the merge-base > > CQ used did not yet contain the CL that caused v8:8548. > > > > Original change's description: > > > [code-comments] Put code comments into the code object > > > > > > Code comments in the snapshot can now be enabled with gn > > > arg 'v8_enable_snapshot_code_comments' > > > > > > Bug: v8:7989 > > > Change-Id: I8bd00cafa63132d00d849394c311ba15e6b6daf3 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1329173 > > > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#58020} > > > > TBR=mvstanton@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tebbi@chromium.org > > > > Bug: v8:7989, v8:8548 > > Change-Id: I464fc897205fefdf2dfc2eadc54d699c4e08a0e9 > > Reviewed-on: https://chromium-review.googlesource.com/c/1361166 > > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#58028} > > Bug: v8:7989, v8:8548 > Change-Id: I254f55ff687ad049f8d92b09331ed26a2bd05d7d > Reviewed-on: https://chromium-review.googlesource.com/c/1371784 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58221} TBR=jgruber@chromium.org,mstarzinger@chromium.org Bug: v8:7989, v8:8548, v8:8593 Change-Id: I4f7ffc98e0281c7b744eb4a04ba0763896c7b59b Reviewed-on: https://chromium-review.googlesource.com/c/1375919Reviewed-by:
-
Sergiy Belozorov authored
This reverts commit 0b971dc2. Reason for revert: not needed anymore Original change's description: > [tools] Add vpython config for run-tests.py > > R=machenbach@chromium.org > > Bug: v8:7187 > Change-Id: I9c64d637501f074464b1fe3637df50be447603ab > Reviewed-on: https://chromium-review.googlesource.com/1098934 > Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#53875} TBR=machenbach@chromium.org,sergiyb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7187 Change-Id: I55d34e65c32e4ae8864ff883870d82803aa11355 Reviewed-on: https://chromium-review.googlesource.com/c/1377049Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#58231}
-
Ross McIlroy authored
Also disables --stress-flush-bytecode on some mjsunit tests which fail when bytecode flushing is stressed due to test invariants. Bug=v8:8395 Change-Id: If627910214b3c266e7776340ba182829148e8289 Reviewed-on: https://chromium-review.googlesource.com/c/1372071Reviewed-by:
-
Stephan Herhut authored
This change adds labels to the various global handles used by the wasm compilation. Labels show up in retaining path information when debugging lifetime issues. Change-Id: I9aee20647868b5b758412d231c817909e4130d8c Reviewed-on: https://chromium-review.googlesource.com/c/1372124Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 9c0a4858. Reason for revert: Seems to break nosnap debug: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/22228 Original change's description: > Reland "Reland "[code-comments] Put code comments into the code object"" > > This is a reland of ed3d6472 > > This reland fixes that padding at the end of Wasm instruction streams > triggered asserts in the code printer. > > Original change's description: > > Reland "[code-comments] Put code comments into the code object" > > > > This is a reland of e774cffe > > > > This reland disables a test as v8:8548 is blocking it, which was > > broken by a recent CL. CQ did not catch this because the merge-base > > CQ used did not yet contain the CL that caused v8:8548. > > > > Original change's description: > > > [code-comments] Put code comments into the code object > > > > > > Code comments in the snapshot can now be enabled with gn > > > arg 'v8_enable_snapshot_code_comments' > > > > > > Bug: v8:7989 > > > Change-Id: I8bd00cafa63132d00d849394c311ba15e6b6daf3 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1329173 > > > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#58020} > > > > TBR=mvstanton@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tebbi@chromium.org > > > > Bug: v8:7989, v8:8548 > > Change-Id: I464fc897205fefdf2dfc2eadc54d699c4e08a0e9 > > Reviewed-on: https://chromium-review.googlesource.com/c/1361166 > > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#58028} > > Bug: v8:7989, v8:8548 > Change-Id: I254f55ff687ad049f8d92b09331ed26a2bd05d7d > Reviewed-on: https://chromium-review.googlesource.com/c/1371784 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58221} TBR=mvstanton@chromium.org,mstarzinger@chromium.org,sigurds@chromium.org,jgruber@chromium.org Change-Id: I681a3c63120c6ab953bfe9cd2b07bcf560ebfdee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7989, v8:8548 Reviewed-on: https://chromium-review.googlesource.com/c/1375916 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This reverts commit c1bf25bb. Reason for revert: We got many regressions: https://chromeperf.appspot.com/group_report?rev=58157 Original change's description: > Enable 31bit Smis everywhere > > This is a experiment to see how performance is impacted. If we tank > too much, we can revert this change. > > Change-Id: I01be33f5dd78aee6a5beecdc62adbaa6c3850eb1 > Bug: v8:8344 > Reviewed-on: https://chromium-review.googlesource.com/c/1355279 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58157} TBR=jarin@chromium.org,sigurds@chromium.org,ishell@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8344 Change-Id: I407cb99743a08452edcecfc2e945ef98509e8d32 Reviewed-on: https://chromium-review.googlesource.com/c/1375911Reviewed-by:
-
Mathias Bynens authored
This ensures V8 at least throws the correct exception for these tests, even if it happens at the wrong phase (i.e. at runtime instead of at parse time). Bug: v8:8467 Change-Id: I101aa2c7e073a56163c29e96e6c47f6ff0a01e53 Reviewed-on: https://chromium-review.googlesource.com/c/1375909Reviewed-by:
-
Michael Starzinger authored
R=herhut@chromium.org BUG=v8:8091 Change-Id: Ia4353dff0726a4c317c8e5e41617d93df193705f Reviewed-on: https://chromium-review.googlesource.com/c/1375849Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#58225}
-
Michael Starzinger authored
This overlays the "arguments count" and the "deoptimization index" fields within a safepoint entry. It allows for a larger value of arguments count to be stored in entries that do not contain a deoptimization index. Currently the arguments count is unused in TurboFan, but it will be used to handle reference type arguments in WebAssembly code. R=ahaas@chromium.org BUG=v8:7581 Change-Id: I1e1d5af7e69288f046dc327de5d6e0466fc9ceaf Reviewed-on: https://chromium-review.googlesource.com/c/1371829 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:8592 Change-Id: I60d9454e9696ac22ebdbdcc1023942698d4c94bc Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/1375910Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58223}
-
Clemens Hammacher authored
When finishing a one-armed if, the else state has to be merged into the end state. We did this before by switching to the else state, then doing the merge. This CL changes this to avoid the switch. Drive-by: Add a few missing "const" qualifiers. The style guide forbids non-const l-value references. R=titzer@chromium.org Bug: v8:8423, v8:6600 Change-Id: Iab2aeca393147fba55493bebabd27bc4d77baa0f Reviewed-on: https://chromium-review.googlesource.com/c/1375656Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#58222}
-
Sigurd Schneider authored
This is a reland of ed3d6472 This reland fixes that padding at the end of Wasm instruction streams triggered asserts in the code printer. Original change's description: > Reland "[code-comments] Put code comments into the code object" > > This is a reland of e774cffe > > This reland disables a test as v8:8548 is blocking it, which was > broken by a recent CL. CQ did not catch this because the merge-base > CQ used did not yet contain the CL that caused v8:8548. > > Original change's description: > > [code-comments] Put code comments into the code object > > > > Code comments in the snapshot can now be enabled with gn > > arg 'v8_enable_snapshot_code_comments' > > > > Bug: v8:7989 > > Change-Id: I8bd00cafa63132d00d849394c311ba15e6b6daf3 > > Reviewed-on: https://chromium-review.googlesource.com/c/1329173 > > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#58020} > > TBR=mvstanton@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tebbi@chromium.org > > Bug: v8:7989, v8:8548 > Change-Id: I464fc897205fefdf2dfc2eadc54d699c4e08a0e9 > Reviewed-on: https://chromium-review.googlesource.com/c/1361166 > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58028} Bug: v8:7989, v8:8548 Change-Id: I254f55ff687ad049f8d92b09331ed26a2bd05d7d Reviewed-on: https://chromium-review.googlesource.com/c/1371784 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Different threads check this flag multiple times per function, and currently all of them synchronize on a single mutex. It's not even a reader-writer-lock, hence they might block each other just for checking whether an error has been set. Threads don't rely on precise information here, this is just a check to abort early if compilation failed anyway. Also in the current implementation, no ordering is guaranteed on this error field. We can avoid taking the mutex by turning the field into an atomic pointer. It will be updated at most once, from nullptr to the first error detected. To check whether an error is set, we can even use relaxed memory order, since we won't look into the object behind the pointer. R=titzer@chromium.org Bug: v8:8423 Change-Id: I71354c8d463a57c219eb21e53136556ae787ebd4 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel Reviewed-on: https://chromium-review.googlesource.com/c/1375661 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
This enables Turbofan's machine graph constant folding and branch reduction on CSA/Torque code. Bug: v8:7793 Change-Id: I5ada63d0c6d920e5f900b8e9255d884c799a9c1e Reviewed-on: https://chromium-review.googlesource.com/c/1373785 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Change-Id: I71c6e52229cae2aba0a5aec1844c0643484354e5 Reviewed-on: https://chromium-review.googlesource.com/c/1375657Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#58218}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e250719..8ee3e8b Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/6fdf92b..2640923 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/149e7c6..368ebf1 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e760411..7fa4fbc Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/7914672..21261c5 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Icee1968139aefa20bb0416e324b02ac4d594c349 Reviewed-on: https://chromium-review.googlesource.com/c/1375002Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58217}
-
Ross McIlroy authored
BUG=v8:8395 Change-Id: I6e4c7550d71f4fe8b4df36a0a5794f89bf94d70a Reviewed-on: https://chromium-review.googlesource.com/c/1373774Reviewed-by:
-
Igor Sheludko authored
for accessing compressed on-heap slots with corresponding contents. Bug: v8:7703 Change-Id: Icb314f02f4d5e8d70b997dec02ee9a9568af5d5d Reviewed-on: https://chromium-review.googlesource.com/c/1370040Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 09c49ee0. Reason for revert: Still breaks the node.js bot. Original change's description: > Reland "[build] Pull binutils via DEPS" > > This is a reland of 98bbb636 > > Original change's description: > > [build] Pull binutils via DEPS > > > > This pulls binutils from a subtreed repository of Chromium: > > https://chromium.googlesource.com/chromium/src/third_party/binutils/ > > > > Bug: chromium:718157 > > Change-Id: I532c7e84d83f716728e4f9f715cfdb82ea5d5f98 > > Reviewed-on: https://chromium-review.googlesource.com/c/1370043 > > Reviewed-by: Yang Guo <yangguo@chromium.org> > > Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> > > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#58180} > > Bug: chromium:718157, v8:8584 > Change-Id: I1c9773bc5fa0a629e35db5151e535e63839f2801 > Reviewed-on: https://chromium-review.googlesource.com/c/1375655 > Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58213} TBR=machenbach@chromium.org,yangguo@chromium.org,sergiyb@chromium.org Change-Id: I1935f4aef0d6eb4f58e25197d14ccf2c2c645b15 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:718157, v8:8584 Reviewed-on: https://chromium-review.googlesource.com/c/1375659Reviewed-by:
-
