- 19 Jan, 2020 3 commits
-
-
Michael Lippautz authored
- Fix copying of already initialized nodes - Add better verification - Add tests for moving/copying onto already initialized nodes Bug: chromium:1040038 Change-Id: I0c144fcfe980d7542cf6803e4dc861e3fd4ca708 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2007278Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#65858}
-
Ulan Degenbaev authored
Currently the object is freed in the destructor of Heap but that is too late because the global handles that are used by the object have been destroyed. This fixes a bug that was introduced in 802420. Bug: chromium:1043530,chromium:1043535 Tbr: dinfuehr@chromium.org Change-Id: I980da7b499f1c853ca41a4ef28d02a1f403d4eeb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2010104 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
This adds a new API function that can be customized by the embedder by providing a delegate that defines contexts to be measured and reports the results to JS. A memory measurement request is carried out as follows: 1) MeasureMemory(delegate) invocation enqueues a new request in MemoryMeasurement::received_ and schedules a delayed GC task. 2) At the start of the next GC (that is triggered either by the GC schedule or by the delayed task) each request in received_ moves to processing_. Per-context marking worklists are created for each native context that was selected by the delegates (using the ShouldMeasure predicate). 3) At the end of the GC the sizes of the native contexts are recorded for each request in processing_. The requests move to the done_ list and result reporting task is scheduled. 4) When the result reporting task runs it invokes the MeasurementComplete function of each delegate in done_. Bug: chromium:973627 Change-Id: I0254cae693c5b8fab7c85a9eca0a3a128210b6c4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1981493 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#65856}
-
- 18 Jan, 2020 1 commit
-
-
Adam Klein authored
I'm not actively reviewing parser or API changes these days, so these watchlists aren't really helping anyone. Change-Id: I7babfeabf0f2bff914e7ab03d1f875e57a10ce47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2008399 Auto-Submit: Adam Klein <adamk@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#65855}
-
- 17 Jan, 2020 26 commits
-
-
Johannes Henkel authored
This adds a DCHECK into v8-inspector-session-impl.cc, covering what we previously checked within ConvertCBORToJSON. Upstream reviews: "Separate the lightweight check for CBOR messages from ParseCBOR." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2001536 "Remove Exported::writeBinary." https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2005797 New Rev: ac6919eb836521a96cc18931f0bf270d8c1b53a1 Change-Id: I52076a8f77b27c24c3afb35c40afbbe94e0ca05c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002935Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#65854}
-
Santiago Aboy Solanes authored
They were disabled when enabling pointer compression due to a bug (See v8:9568), and they were never re-enabled. Fixes: v8:9568 Bug: v8:9568, v8:7703 Change-Id: I3918ec57726ab9a7f943ab8506636cc95c376c20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2007496 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65853}
-
Milad Farazmand authored
Port aa12b60b R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I7844b3f356d7f9f0ad1688880bd1f3420438e181 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2007899Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#65852}
-
Ross McIlroy authored
One remaining Node* remains in EmitElementStore which will need to wait for templated versions of StoreElement. BUG=v8:10021 Change-Id: I6422b8dbfd1989cfc7587c2b180e542fbdb56382 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2007271Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#65851}
-
Milad Farazmand authored
Port 9ff2de44 R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Iadbdd2ae87ac4b37b36ed5fac14777e48133437e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2008180Reviewed-by:
-
Ng Zhi An authored
Bug: v8:10082 Change-Id: I745cb99ba12d4e8c0ecd9a89bfa596f1bc1f9597 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980835 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#65849}
-
Ng Zhi An authored
Add a cctest to verify correct treatment of functions which return SIMD. This exercises the MoveToReturnRegisters logic, where we need to add a new case for fp pairs. FinishCall also needs to handle fp pairs. Small cleanup to rename needs_reg_pair to needs_gp_reg_pair to be clear, and add a new helper needs_fp_reg_pair. Drive-by fix for cctest to assert that the tests are compiled with Liftoff. Bug: v8:9909 Change-Id: I0cd7a1a90e97372ea85e7668f2298d4fa2d76f4f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2006021 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65848}
-
Ulan Degenbaev authored
The function can be invoked in a background task and has to take the page mutex to sweep it. Bug: chromium:1040700 Change-Id: I552fd636ca62f45496dc6c663a0a12d428eb2e20 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2007273Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#65847}
-
Ng Zhi An authored
Bug: v8:9813 Change-Id: I0436c6a90284559a110e99476c12ae39183c961e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1994382 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#65846}
-
Ng Zhi An authored
This is useful when generating mjsunit tests from the fuzzer, since without the prefix bytes, the opcodes are invalid. This affects the json output for tracing turbofan, so the source view in turbolizer will see this prefix as well. Change-Id: Icd112e0d140c13f96530797da721650201e00660 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2006392Reviewed-by:
-
Steve Blackburn authored
Bug: v8:9533 Change-Id: I09a929839ca5cbad3f1a3154c6f143b242095ffa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1995276Reviewed-by:
-
Steve Blackburn authored
Bug: v8:9533 Change-Id: I11ae71b552d2ba96606e99261092d99dc92e680f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1995266 Commit-Queue: Steve Blackburn <steveblackburn@google.com> Reviewed-by:
-
Dominik Inführ authored
Split the linked list of array buffer extensions into two lists for young and old JSArrayBuffers. Process young extensions during the minor GC pause. When promoting JSArrayBuffers into the old gen, move the extension into the old linked list as well. Bug: v8:10064 Change-Id: I07275ffe7ba918c9b2d6d0648a6d1b59e4fa4891 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1997438 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Similar to TracedReference, support TracedGlobal on stack as well. Bug: chromium:1040038 Change-Id: If3400a2df8b4a11410032bd5ad1b7bed64063b93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2005071 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Peter Marshall authored
This was written before lazy feedback vectors and expects that the feedback vector is always present. Instead just return undefined and do nothing if there is no feedback vector. Change-Id: I1ffddd672576cb794eda2d5922b574a8be65d579 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2007492Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#65840}
-
Michael Achenbach authored
The contructor arguments were omitted for Android in a previous CL, which broke the Android builder. TBR=tmrts@chromium.org Bug: v8:8292 Change-Id: I266826e2531ba421161d6cd2241eae34b07e7521 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2007494Reviewed-by:
-
Georgia Kouveli authored
Memory access offsets are unsigned. Sign-extending them incorrectly treats some large offsets as negative numbers and results in out-of-bounds errors for in-bounds accesses. This caused a failure in test/mjsunit/wasm/huge-memory.js for arm64, and for x64 with --nowasm_trap_handler. Change-Id: If58fead1d115f16ba4a6c3680252111fba6843d1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002821 Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Reviewed-by:
-
Michael Achenbach authored
This prints the same details about a process when attempting to kill it as when termination fails with an exception. This will make it easier to correlate the two and to see which might be hanging. Bug: v8:8292 Change-Id: I4b6a50386d4e9d84ded55cf262f19529138654a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2006092Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65837}
-
Jakob Kummerow authored
Not just the large virtual allocation but *all* memory operations should handle resource exhaustion gracefully. Bug: chromium:1042943 Change-Id: I8d36a3d7fa267b588b35b927172bfe56f64fffd2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2007489 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
Peter Marshall authored
Previously these would silently fail unless the caller checked the .error property of the return value. There are no tests that check iteractions with non-existent methods so this should always be an error at the test runner level, rather than relying on clients to check the error. 1. Fix the tests that accidentally call methods that don't exist. 2. Change the test runner so that it prints an error and ends the test. 3. Add a test that the test runner does #2. Bug: v8:10134 Change-Id: Idd619950a057290c565d58fba6db3ddbcaf2c5eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2006093 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#65835}
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: chromium:1041841 Change-Id: I4a5010fbf58a812e724ab95f2552dd4b6887113f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2004612 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
-
Bill Ticehurst authored
The change at https://chromium-review.googlesource.com/c/v8/v8/+/1993971 introduced some new exports, but it appears the wrong macro was used for the component being built (V8_BASE_EXPORT rather than V8_EXPORT_PRIVATE) This breaks DLL builds (at least on MSVC, which I just fixed via https://chromium-review.googlesource.com/c/v8/v8/+/1996157). Adding Leszek who made the change, and Ulan and Toon as area OWNERS. Bug: v8:8791 Change-Id: I916553992f7d42cba0f4d8ae46b014df6c5ef633 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2005528 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
That way we don't need to generate bytecode for it. Change-Id: Ie7e17f283cf5a096ab98c4fd01fd346b56b83576 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2004611Reviewed-by:
-
Clemens Backes authored
This was used for debugging only. The DevTools frontend now receives the raw wasm bytes, and disassembles the functions it needed. The inspector change was done in https://crrev.com/c/1991481. This CL removes all code which is now dead in v8. R=ahaas@chromium.org, bmeurer@chromium.org Change-Id: I2d433613f1270a1ddac9af0bae8d990ef190712a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2005072Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65831}
-
Michael Achenbach authored
TBR=nicohartmann@chromium.org No-Try: true Change-Id: I4a0e07c3f45868fbfbb233349292e137769f6f51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2006091Reviewed-by:
-
Ng Zhi An authored
Add a cctest that contains a function with a SIMD parameter, and calls that function. This will exercise two cases in Liftoff which involves preparing to call the function, and processing the SIMD parameters of the function. The tricky case here is ARM, which requires an FP pair. Most of the logic added is to check the RegClass/type and construct the right type of LiftoffRegister to use. As a drive-by, added SIMD case to the various backends' Move implementation. This is not exercised by the test case, requires more complicated function setup. Bug: v8:9909 Change-Id: I1d01e8c3bee0cf336d1a8ff537317c77aedfdac0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2004369 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
- 16 Jan, 2020 10 commits
-
-
Santiago Aboy Solanes authored
Since: 1) The Int32Add will only look at the lower bits 2) The output of this instruction will clear the top bits (in the same way that the movl does) then the truncation is not needed. Change-Id: Ic611ce435ff6216ce8b75bb7316af4372e3290e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2000747Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#65828}
-
Z Nguyen-Huu authored
Re-use set breakpoint logic for wasm script to set breakpoint to first breakable position of given wasm function. Bug: v8:9724 Change-Id: Ibd6b59d5b93c6895f71f0114291bf78db03aee0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2001564 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Pierre Langlois authored
We had a --log-instruction-stats option which would count executed instructions, splitting them into categories. We haven't used this for some years so we're proposing to just remove the code so it doesn't bitrot and allows further cleanups. Change-Id: If24d11608823e24689ea02f09f5e93b4a5acd636 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002819Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#65826}
-
Ng Zhi An authored
Add 64-bit data size support to SHL and SHR, add simulator logic to support new data size, and fix disasm. For the disasm fix, casting size / 16 to NeonSize no longer works when given a size of 64, it is 4, but should be 3. Change-Id: I5bd1ce254cd3ff4b86159837087f22b2ed06703e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1994180Reviewed-by:
-
Ng Zhi An authored
Bug: v8:10082 Change-Id: Ieabb0ebeec14091844b3d30b9b1684a249db7bdc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980949Reviewed-by:
-
Michael Lippautz authored
Previously, V8 was just relinking nodes which broke when a move involves an on-stack reference as such nodes have different semantics. The solution is to create new internal nodes when necessary. Bug: chromium:1040038 Change-Id: Ia5b3866ae68d014beb30972c4266aa5bae6559fc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002546 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Bill Ticehurst authored
Add the necessary V8_EXPORT_PRIVATE attributes and a few other minor changes to make building DLLs with MSVC happy. (Note: Debug builds still seem to be failing in Torque, but this fixes Release builds). Bug: v8:8791 Change-Id: Ia4d5372fd1cb961e6268a2b5c089bcd17822f1e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1996157Reviewed-by:
-
Clemens Backes authored
This makes Liftoff inspection (scope reporting) also use the decoded names of locals, which are now stored in a C++ data structure (see https://crrev.com/c/2002541). The call to {SetOwnPropertyIgnoreAttributes} had to be replaced by a proper lookup first, to handle integer names and duplicate names correctly. The test already covered these cases. The test was extended by another unnamed local to also test the generation of default names in case no name is provided. R=thibaudm@chromium.org Bug: v8:10019 Change-Id: I475bb4db9a32c39203180e9c8d3f8181c3882138 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002544 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#65821}
-
Sigurd Schneider authored
TimeTicks cannot convert to other timeunits, only TimeDelta can do that. Chrome's version of TimeBase introduced a `since_origin` helper that essentially converts a TimeTicks object in to a TimeDelta with the corresponding duration. This CL ports that helper to V8 and cleans up a couple of places where we used `timestamp - 0` to convert a TimeTicks object to a TimeDelta. Change-Id: I540ced876ac3e727dfdedf7b838a272cc40d6954 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1993282 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#65820}
-
Clemens Backes authored
We were decoding the names of locals into a C++ data structure, and then generated a FixedArray out of that, stored in the on-heap WasmDebugInfo. In order to support name lookup for debugging with Liftoff, where no WasmDebugInfo will be present, this CL refactors the C++ data structure to allow direct lookups and stores it in the C++ DebugInfo structure. With this CL, the names are still only used from the old interpreter-based debugging path. A follow-up CL will then also use it from Liftoff. R=thibaudm@chromium.org Bug: v8:10019 Change-Id: I1397021b5d69b9346fc26f5e83653360f428c5e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002541 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
