- 06 Apr, 2018 21 commits
-
-
Ben L. Titzer authored
This change makes lifetime management of WasmCode much simpler. By using the WasmInstanceObject as the context for WASM code execution, including the pointer to the memory base and indirect function tables, this keeps the instance alive when WASM code is on the stack, since the instance object is passed as a parameter and spilled onto the stack. This is in preparation of sharing the code between instances and isolates. Bug: v8:7424 R=mstarzinger@chromium.org Change-Id: Ia35a3ce91a8f6135767fa764e185cde8bbc889f4 Reviewed-on: https://chromium-review.googlesource.com/997932 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52436}
-
Dan Elphick authored
This moves: * the main oddballs (null, undefined, hole, true, false) as well as their supporting maps (also adds hole as an internalized string to make this work). * most of the internalized strings * the struct maps * empty array * empty enum cache * the contents of the initial string table * the weak_cell_cache for any map in RO_SPACE (and eagerly creates the value avoid writing to it during run-time) The StartupSerializer stats change as follows: RO_SPACE NEW_SPACE OLD_SPACE CODE_SPACE MAP_SPACE LO_SPACE old 0 0 270264 32608 12144 0 new 21776 0 253168 32608 8184 0 Overall memory usage has increased by 720 bytes due to the eager initialization of the Map weak cell caches. Also extends --serialization-statistics to print out separate instance type stats for objects in RO_SPACE as shown here: Read Only Instance types (count and bytes): 404 16736 ONE_BYTE_INTERNALIZED_STRING_TYPE 2 32 HEAP_NUMBER_TYPE 5 240 ODDBALL_TYPE 45 3960 MAP_TYPE 1 16 BYTE_ARRAY_TYPE 1 24 TUPLE2_TYPE 1 16 FIXED_ARRAY_TYPE 1 32 DESCRIPTOR_ARRAY_TYPE 45 720 WEAK_CELL_TYPE Bug: v8:7464 Change-Id: I12981c39c82a7057f68bbbe03f89fb57b0b4c6a6 Reviewed-on: https://chromium-review.googlesource.com/973722 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52435}
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:829774 Change-Id: I85ea46a68f620dfd7db04e881b6363ef260392f7 Reviewed-on: https://chromium-review.googlesource.com/999490Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52434}
-
Michael Starzinger authored
Now that all WebAssembly code (including its lazy compile stub) has been moved off the garbage-collected heap, we can determine the taggedness of parameters purely from the {Code::Kind} and no longer need a dedicated flag for it. R=clemensh@chromium.org BUG=v8:6792 Change-Id: If40b6763d042c19b937391fac8301a03b8ccc891 Reviewed-on: https://chromium-review.googlesource.com/999416Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#52433}
-
Michael Achenbach authored
This will allow setting v8_debug from within a Chromium release bot. Bug: chromium:828846 Change-Id: I714291feaa9ba90daba871ca9a12e6651bcd7dfa Reviewed-on: https://chromium-review.googlesource.com/999486 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52432}
-
Michael Achenbach authored
This reverts commit cfd7df1b. Reason for revert: Seems to flush out more problems: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20cfi/builds/14390 Original change's description: > Reland "Enable cfi-icall on the v8 CFI bots" > > This is a reland of 9a7e9cf2 > > Original change's description: > > Enable cfi-icall on the v8 CFI bots > > > > BUG=v8:7164 > > > > Change-Id: I7522ba6ac2bde89c84bcd49bc116a432091a2938 > > Reviewed-on: https://chromium-review.googlesource.com/990802 > > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#52343} > > Bug: v8:7164 > Change-Id: Ia883adedf9d54e4a2518d66c85799354d930990e > Reviewed-on: https://chromium-review.googlesource.com/996133 > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52425} TBR=machenbach@chromium.org,clemensh@chromium.org,vtsyrklevich@chromium.org Change-Id: I5a45756f7e2e74ac50ae9fb93716b9083cdf4379 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7164 Reviewed-on: https://chromium-review.googlesource.com/999633Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52431}
-
Clemens Hammacher authored
Remove redundant argument, add a DCHECK and explicitly specify the capture list of the lambdas. R=ahaas@chromium.org Bug: v8:7570 Change-Id: I09fc6004ffc5cdc7b4c153748ed95e86ae85aaa2 Reviewed-on: https://chromium-review.googlesource.com/998098Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52430}
-
Dan Elphick authored
When serializing/deserializing RO_SPACE objects in CodeSerializer use BackReferences to avoid re-allocating inside RO_SPACE. Change-Id: Ie9063a43a4f758f0401ad59dfcc61c4b759591bc Reviewed-on: https://chromium-review.googlesource.com/997837 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52429}
-
Jakob Gruber authored
This reverts commit 0340874b. Reason for revert: Tentative revert for https://crbug.com/v8/7626 Original change's description: > [debug] add runtime side effect check for StaCurrentContextSlot > > R=yangguo@chromium.org > > Bug: v8:7588 > Change-Id: If78f6dd460c7423923800a98d44520c1bf71663c > Reviewed-on: https://chromium-review.googlesource.com/996236 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52398} TBR=yangguo@chromium.org,kozyatinskiy@chromium.org Change-Id: I77a679649a6149607aefd44f6b7f3f6dfe548776 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7588 Reviewed-on: https://chromium-review.googlesource.com/998036Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52428}
-
Simon Zünd authored
Inlines nameOrSourceURL and locationFromPosition of the Script object at call sites. R=jgruber@chromium.org Bug: v8:7624 Change-Id: If217d4c1412fa22aaa856a017f73be4c803e70ac Reviewed-on: https://chromium-review.googlesource.com/997741 Commit-Queue: Simon Zünd <szuend@google.com> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52427}
-
Michael Lippautz authored
The byte_length of ArrayBuffers may be a heap number. This length is needed for freeing a buffer during tear down, implying that ArrayBuffers need to be freed before regular space tear down can remove actual pages. Bug: v8:7623 Change-Id: Iab91843e48c50276a2e110915f69cf9e6c24ef8f Reviewed-on: https://chromium-review.googlesource.com/997776 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52426}
-
Vlad Tsyrklevich authored
This is a reland of 9a7e9cf2 Original change's description: > Enable cfi-icall on the v8 CFI bots > > BUG=v8:7164 > > Change-Id: I7522ba6ac2bde89c84bcd49bc116a432091a2938 > Reviewed-on: https://chromium-review.googlesource.com/990802 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52343} Bug: v8:7164 Change-Id: Ia883adedf9d54e4a2518d66c85799354d930990e Reviewed-on: https://chromium-review.googlesource.com/996133Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52425}
-
Mythri authored
--cache=code produces and consume cache in different isolates. Earlier we created a new isolate for the run consuming the code cache. This cl changes to create a new isolate when producing the code cache so that RunShell works as expected. Change-Id: I1c73aab2bee429aafdcc52a68ddcf742edfcd652 Reviewed-on: https://chromium-review.googlesource.com/997694 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52424}
-
Vlad Tsyrklevich authored
BUG=v8:7164 Change-Id: I00f5fc6452901538a04315b93550be9bf03a9dd2 Reviewed-on: https://chromium-review.googlesource.com/996406Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52423}
-
Sigurd Schneider authored
This reverts commit 370d95dc. Reason for revert: Unexpected performance regressions Original change's description: > [turbofan] Enable Promise constructor inlining by default > > Bug: v8:7584 > Change-Id: I7443c28c74676ee1f27550674c8f712594e21cc7 > Reviewed-on: https://chromium-review.googlesource.com/992314 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52341} TBR=mstarzinger@chromium.org,jarin@chromium.org,sigurds@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7584 Change-Id: I821d73475d3e62d0e1ee1233d8e18c1f854e26bc Reviewed-on: https://chromium-review.googlesource.com/999413Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#52422}
-
Myles Borins authored
Various fixes necessary to get the script working with V8 6.6 Upstreamed from https://github.com/nodejs/node/pull/19201 Change-Id: Ic7819eb17cf4be8380b8c1811e569236244e7400 Reviewed-on: https://chromium-review.googlesource.com/996858 Commit-Queue: Myles Borins <mborins@google.com> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52421}
-
Michael Achenbach authored
This reverts commit f9a2e24b. Reason for revert: gc stress failures not all fixed by follow up. Original change's description: > [cleanup] Refactor the Factory > > There is no good reason to have the meat of most objects' initialization > logic in heap.cc, all wrapped by the CALL_HEAP_FUNCTION macro. Instead, > this CL changes the protocol between Heap and Factory to be AllocateRaw, > and all object initialization work after (possibly retried) successful > raw allocation happens in the Factory. > > This saves about 20KB of binary size on x64. > > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Icbfdc4266d7be8b48d2fe085f03411743dc6a0ca > Reviewed-on: https://chromium-review.googlesource.com/959533 > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52416} TBR=jkummerow@chromium.org,yangguo@chromium.org,mstarzinger@chromium.org,hpayer@chromium.org Change-Id: Idbbc53478742f3e9525eee83342afc6aedae122f No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/999414Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52420}
-
Michael Achenbach authored
This reverts commit 8be6842c. Reason for revert: gc stress still broken: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/18635 https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gc%20stress/builds/15893 Original change's description: > Fix GC stress after r52416 > > Allocating elements and/or property backing stores can, due to retrying, > cause a JSObject that has just been allocated in new space to be promoted > to old space, so skipping the write barrier is now an invalid optimization. > > Tbr: hpayer@chromium.org > Change-Id: I4a1eacbd59912dd4aa9069b0636f683fb4674231 > Reviewed-on: https://chromium-review.googlesource.com/998799 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52417} TBR=jkummerow@chromium.org,hpayer@chromium.org Change-Id: I2c29f34ea8ae950985c1638c21003e1025db06be No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/999512Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52419}
-
Michael Achenbach authored
This reverts commit ad221d14. Reason for revert: Layout test failures: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/22780 Original change's description: > [wasm] Always enable guard regions on 64-bit platforms > > This change makes full 8 GiB guard regions always enabled on 64-bit > platforms. > > Additionally, since all Wasm memory allocation paths have some form of > guard regions, this removes and simplifies most of the logic around > whether to enable guard regions. > > This is a reland of https://crrev.com/c/985142. > > Bug: v8:7619 > Change-Id: I8bf1f86d6f89fd0bb2144431c7628f15a6b00ba0 > Reviewed-on: https://chromium-review.googlesource.com/996466 > Reviewed-by: Brad Nelson <bradnelson@chromium.org> > Commit-Queue: Eric Holk <eholk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52412} TBR=bradnelson@chromium.org,eholk@chromium.org Change-Id: Ic15d14c6fa69300bc0fdc036b9fee8ecf65fd397 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7619 Reviewed-on: https://chromium-review.googlesource.com/999412Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52418}
-
Jakob Kummerow authored
Allocating elements and/or property backing stores can, due to retrying, cause a JSObject that has just been allocated in new space to be promoted to old space, so skipping the write barrier is now an invalid optimization. Tbr: hpayer@chromium.org Change-Id: I4a1eacbd59912dd4aa9069b0636f683fb4674231 Reviewed-on: https://chromium-review.googlesource.com/998799Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#52417}
-
Jakob Kummerow authored
There is no good reason to have the meat of most objects' initialization logic in heap.cc, all wrapped by the CALL_HEAP_FUNCTION macro. Instead, this CL changes the protocol between Heap and Factory to be AllocateRaw, and all object initialization work after (possibly retried) successful raw allocation happens in the Factory. This saves about 20KB of binary size on x64. Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Icbfdc4266d7be8b48d2fe085f03411743dc6a0ca Reviewed-on: https://chromium-review.googlesource.com/959533 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52416}
-
- 05 Apr, 2018 19 commits
-
-
Camillo Bruni authored
This is another small step towards detaching the JSFunction from Contexts. In order to not break the debugger protocol we need the inferred name on the ScopeInfo chain. This CL might increase memory usage slightly, given that the inferred name field is duplicated on the ScopeInfo. Bug: v8:7066, chromium:818642 Change-Id: I0dd9f18ae69791f774cf835669afa50491f7433b Reviewed-on: https://chromium-review.googlesource.com/995792 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#52415}
-
Hannes Payer authored
Bug: chromium:814144 Change-Id: Idd729757608a714921254874af98a4a201340870 Reviewed-on: https://chromium-review.googlesource.com/981146Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#52414}
-
Junliang Yan authored
R=joransiu@ca.ibm.com Change-Id: I28c7f3d018a03adb843b0426510c2ba669324b76 Reviewed-on: https://chromium-review.googlesource.com/996593Reviewed-by: Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#52413}
-
Eric Holk authored
This change makes full 8 GiB guard regions always enabled on 64-bit platforms. Additionally, since all Wasm memory allocation paths have some form of guard regions, this removes and simplifies most of the logic around whether to enable guard regions. This is a reland of https://crrev.com/c/985142. Bug: v8:7619 Change-Id: I8bf1f86d6f89fd0bb2144431c7628f15a6b00ba0 Reviewed-on: https://chromium-review.googlesource.com/996466Reviewed-by: Brad Nelson <bradnelson@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#52412}
-
Junliang Yan authored
Port 71018812 Original Commit Message: This is a reland of 7a2c3713 Original change's description: > [debug] introduced runtime side effect check > > This CL demonstrates minimum valuable addition to existing debug evaluate > without side effects mechanism. > With this CL user can evaluate expressions like: > [a,b] // create any kind of temporary array literals > [a,b].reduce((x,y) => x + y, 0); // use reduce method > [1,2,3].fill(2); // change temporary arrays > > The core idea: any change of the object created during evaluation without > side effects is side effect free. As soon as we try to store this temporary > object to object existed before evaluation we will terminate execution. > > Implementation: > - track all objects allocated during evaluation and mark them as temporary, > - patch all bytecodes which change objects. > > A little more details (including performance analysis): [1]. > > [1] https://docs.google.com/document/d/10qqAtZADspPnpYa6SEdYRxrddfKIZJIzbLtGpsZQkRo/edit# > > Bug: v8:7588 > Change-Id: I69f7b96e1ebd7ad0022219e8213211c7be72a111 > Reviewed-on: https://chromium-review.googlesource.com/972615 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52370} R=kozyatinskiy@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I8706efa53d0bbf7d12e48f4f0c4ac387b5faa97b Reviewed-on: https://chromium-review.googlesource.com/998180Reviewed-by: Joran Siu <joransiu@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#52411}
-
Clemens Hammacher authored
Use 64-bit addition if the pointer size is 8, use 32-bit addition otherwise. R=titzer@chromium.org CC=sreten.kovacevic@mips.com Change-Id: I129cc29454726b7be45ecea13484212cc4f72eea Reviewed-on: https://chromium-review.googlesource.com/998552Reviewed-by: Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52410}
-
Eric Holk authored
The bug was fixed in https://crrev.com/c/995796, but this CL adds a regression test to make sure it stays fixed. Bug: chromium:827806 Change-Id: I9f4aed364bbd310af4253da457887a8b8015533a Reviewed-on: https://chromium-review.googlesource.com/993237Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#52409}
-
Xiaoyin Liu authored
The v8_base project can't be loaded in Visual Studio 2017 because "src/zone/zone-allocator.h" is listed twice. R=jgruber@chromium.org, yangguo@chromium.org Change-Id: Ide2f27a7f8ffd3c57deb7f9ae16c55122d999d06 Reviewed-on: https://chromium-review.googlesource.com/998346Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52408}
-
Fabrice de Gans-Riberi authored
|is_posix| will be switched to false for Fuchsia, this is a preliminary change. Bug: chromium:812974 Change-Id: I2ae8e5ef4270cd0acbc7c69bb46d1be9ed4a5c5e Reviewed-on: https://chromium-review.googlesource.com/988253Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#52407}
-
Pierre Langlois authored
The AssembleMove and AssembleSwap tests would only perform moves on stack parameters. This limits us to testing with slots that are likely to be in range of loads and stores. As well as only testing memory accesses with positive offsets relative to the frame pointer. This patch addresses these limitations by moving half of the stack parameters into spill slots, to then perform moves on them. Additionally, to increase ranges, we create articial space between each spilled slot. As a drive-by, allow giving custom names to code objects created with the CodeAssemblerTester. It helps a lot inspecting disassembly. And finally, this CL uncovered a bug where I had forgotten to initialize FixedArrays, which would make the incremental marker crash. Bug: v8:6848 Change-Id: Ic1954c1896130f6c55e09a3068bf341cc4c68670 Reviewed-on: https://chromium-review.googlesource.com/980613 Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#52406}
-
Eric Holk authored
Bug: chromium:828293 Change-Id: I37002c308738eef1366d82a90b7b29d6e44d6c48 Reviewed-on: https://chromium-review.googlesource.com/996585 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52405}
-
Marja Hölttä authored
Previous: https://chromium-review.googlesource.com/972962 BUG=v8:7308 Change-Id: I6882e36ad9f9360d006937a2f41b07839a73a768 Reviewed-on: https://chromium-review.googlesource.com/995014Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#52404}
-
peterwmwong authored
Proposal repo: https://github.com/tc39/proposal-string-matchall - Add new builtins StringPrototypeMatchAll and RegExpPrototypeMatchAll - Add new object RegExpStringIterator Bug: v8:6890 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I9fad71900cf30e8632258c309df1c7a638ea4600 Reviewed-on: https://chromium-review.googlesource.com/981893 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#52403}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I510c8e771ab1c84d094205e247054d8057d2dc85 Reviewed-on: https://chromium-review.googlesource.com/997845Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#52402}
-
Camillo Bruni authored
This CL further lowers the kMaxEmptyFactor constant to more aggressively shrink the StringTable when it's empty. Bug: v8:5443, chromium:818642 Change-Id: I1c263a0afd7e6bed8a8bb857db032bf126c3ef4b Reviewed-on: https://chromium-review.googlesource.com/995473Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#52401}
-
Yang Guo authored
This is a small step towards making node build on Windows. Bug: v8:6105 R=machenbach@chromium.org Change-Id: I8d3a9b1830bb012d846a791fddc8d1d8d830515e Reviewed-on: https://chromium-review.googlesource.com/980950 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#52400}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Iac827a4fc82f9b810af9d67c4aa5757925edc3c5 Reviewed-on: https://chromium-review.googlesource.com/997742Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#52399}
-
Alexey Kozyatinskiy authored
R=yangguo@chromium.org Bug: v8:7588 Change-Id: If78f6dd460c7423923800a98d44520c1bf71663c Reviewed-on: https://chromium-review.googlesource.com/996236 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#52398}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: Ibe6c203aa3ebdbbd8d3ca1f9f0ddfa7f89d79c71 Reviewed-on: https://chromium-review.googlesource.com/997835 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#52397}
-