1. 23 Jun, 2020 1 commit
  2. 25 Jun, 2019 1 commit
  3. 12 Apr, 2019 1 commit
  4. 18 Mar, 2019 1 commit
  5. 12 Feb, 2019 1 commit
    • Tamer Tas's avatar
      [testrunner] enable the progress indicator · baeb4e32
      Tamer Tas authored
      Using test generators meant that we had to remove the progress indicator since
      the total number of tests weren't known before-hand.
      
      This CL implements a progress indicator using test number estimations.
      
      cctest and unittests progress indicator is accurate, however estimating
      means the progress will terminate over 100% in big test suites and sometimes
      under 100%.
      
      R=machenbach@chromium.org
      CC=​sergiyb@chromium.org,yangguo@chromium.org
      
      Bug: v8:8769
      Change-Id: I40ca5b40f9b1223376d33707f0945900ea98cea3
      Reviewed-on: https://chromium-review.googlesource.com/c/1460471
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59538}
      baeb4e32
  6. 06 Feb, 2019 2 commits
    • Tamer Tas's avatar
      [testrunner] migrate testsuites to lazy loading · 8c30a2cc
      Tamer Tas authored
      V8 test suites return tests by loading them into memory up-front. Up-front
      loading has memory and loading-time overhead for the testrunner.
      
      This CL converts the test-suites to load tests during the test run in parallel.
      
      After CL, most test suites start running immediately and all test suites start
      running after 3 seconds on a modern SSD.
      
      This CL eliminates the 200 MiB memory spikes that causes memory problems in mac
      minis.
      
      Overhead of running test262 before CL:
      Line #    Mem usage     Increment   Line Contents
      =================================================
         264  225.760 MiB 195.8.000 MiB         tests = self._load_testsuite_generators(args, options)
      -------------------------------------------------
      Overhead of running test262 after CL:
      Line #    Mem usage    Increment   Line Contents
      ================================================
         264   28.840 MiB    0.000 MiB         tests = self._load_testsuite_generators(args, options)
      -------------------------------------------------
      
      R=machenbach@chromium.org
      CC=​​​yangguo@chromium.org,sergiyb@chromium.org
      
      Bug: v8:8174, v8:8552, v8:8728
      Change-Id: Iab540b9410239b05dc80b4a5228db25d8b8fb3b9
      Reviewed-on: https://chromium-review.googlesource.com/c/1454478
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarSergiy Belozorov <sergiyb@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59408}
      8c30a2cc
    • Tamer Tas's avatar
      Reland "Reland "[test] refactor testsuite configuration"" · df630e67
      Tamer Tas authored
      This is a reland of 81eec150
      
      Original change's description:
      > Reland "[test] refactor testsuite configuration"
      >
      > This is a reland of 7f92ad0a
      >
      > Original change's description:
      > > [test] refactor testsuite configuration
      > >
      > > Every testsuite configuration consist of at least 30% code duplication.
      > >
      > > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > > touches the testsuite code becomes a technical fight to the death.
      > >
      > > This CL removes all the duplication by refactoring the common functionality.
      > >
      > > This CL contains structural changes without any logical changes % small bug
      > > fixes.
      > >
      > > R=machenbach@chromium.org
      > > CC=yangguo@chromium.org,sergiyb@chromium.org
      > >
      > > Bug: v8:8174, v8:8769
      > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#59361}
      >
      > Bug: v8:8174, v8:8769
      > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7
      > Reviewed-on: https://chromium-review.googlesource.com/c/1454485
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Commit-Queue: Tamer Tas <tmrts@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59369}
      
      Bug: v8:8174, v8:8790
      Change-Id: I38ab9d37bca76057441a970f26e2102e4387a857
      Reviewed-on: https://chromium-review.googlesource.com/c/1454724
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59387}
      df630e67
  7. 05 Feb, 2019 4 commits
    • Tamer Tas's avatar
      Revert "Reland "[test] refactor testsuite configuration"" · ea4412ad
      Tamer Tas authored
      This reverts commit 81eec150.
      
      Reason for revert: windows mozilla test failures
      
      Original change's description:
      > Reland "[test] refactor testsuite configuration"
      > 
      > This is a reland of 7f92ad0a
      > 
      > Original change's description:
      > > [test] refactor testsuite configuration
      > > 
      > > Every testsuite configuration consist of at least 30% code duplication.
      > > 
      > > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > > touches the testsuite code becomes a technical fight to the death.
      > > 
      > > This CL removes all the duplication by refactoring the common functionality.
      > > 
      > > This CL contains structural changes without any logical changes % small bug
      > > fixes.
      > > 
      > > R=machenbach@chromium.org
      > > CC=yangguo@chromium.org,sergiyb@chromium.org
      > > 
      > > Bug: v8:8174, v8:8769
      > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#59361}
      > 
      > Bug: v8:8174, v8:8769
      > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7
      > Reviewed-on: https://chromium-review.googlesource.com/c/1454485
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Commit-Queue: Tamer Tas <tmrts@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59369}
      
      TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org
      
      Change-Id: I8f5650b5f46be299c004e2fa8b708fa2c17a4dc2
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8174, v8:8769
      Reviewed-on: https://chromium-review.googlesource.com/c/1454607Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59370}
      ea4412ad
    • Tamer Tas's avatar
      Reland "[test] refactor testsuite configuration" · 81eec150
      Tamer Tas authored
      This is a reland of 7f92ad0a
      
      Original change's description:
      > [test] refactor testsuite configuration
      > 
      > Every testsuite configuration consist of at least 30% code duplication.
      > 
      > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > touches the testsuite code becomes a technical fight to the death.
      > 
      > This CL removes all the duplication by refactoring the common functionality.
      > 
      > This CL contains structural changes without any logical changes % small bug
      > fixes.
      > 
      > R=machenbach@chromium.org
      > CC=yangguo@chromium.org,sergiyb@chromium.org
      > 
      > Bug: v8:8174, v8:8769
      > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59361}
      
      Bug: v8:8174, v8:8769
      Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7
      Reviewed-on: https://chromium-review.googlesource.com/c/1454485Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59369}
      81eec150
    • Tamer Tas's avatar
      Revert "[test] refactor testsuite configuration" · 97068800
      Tamer Tas authored
      This reverts commit 7f92ad0a.
      
      Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32/19148
      
      Original change's description:
      > [test] refactor testsuite configuration
      >
      > Every testsuite configuration consist of at least 30% code duplication.
      >
      > The code age ranges from 10 years old to 5 years old. Implementing anything that
      > touches the testsuite code becomes a technical fight to the death.
      >
      > This CL removes all the duplication by refactoring the common functionality.
      >
      > This CL contains structural changes without any logical changes % small bug
      > fixes.
      >
      > R=​machenbach@chromium.org
      > CC=​yangguo@chromium.org,sergiyb@chromium.org
      >
      > Bug: v8:8174, v8:8769
      > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      > Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#59361}
      
      TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org,v8-reviews@chromium.org
      
      Change-Id: I473f0d4c6b9c0239923b8c03699dbc38b7f85030
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:8174, v8:8769
      Reviewed-on: https://chromium-review.googlesource.com/c/1454599
      Commit-Queue: Tamer Tas <tmrts@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59362}
      97068800
    • Tamer Tas's avatar
      [test] refactor testsuite configuration · 7f92ad0a
      Tamer Tas authored
      Every testsuite configuration consist of at least 30% code duplication.
      
      The code age ranges from 10 years old to 5 years old. Implementing anything that
      touches the testsuite code becomes a technical fight to the death.
      
      This CL removes all the duplication by refactoring the common functionality.
      
      This CL contains structural changes without any logical changes % small bug
      fixes.
      
      R=machenbach@chromium.org
      CC=yangguo@chromium.org,sergiyb@chromium.org
      
      Bug: v8:8174, v8:8769
      Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2
      Reviewed-on: https://chromium-review.googlesource.com/c/1445881
      Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#59361}
      7f92ad0a
  8. 15 Jan, 2019 1 commit
  9. 11 Jan, 2019 2 commits
  10. 04 Jan, 2019 1 commit
  11. 01 Feb, 2018 2 commits
  12. 31 Jan, 2018 1 commit
    • Michal Majewski's avatar
      Reland "[test] Random seed processor" · 5ede3cb5
      Michal Majewski authored
      This is a reland of 0db74d49.
      
      Original change's description:
      > [test] Random seed processor
      > 
      > 1. --total-timeout-sec now available for ./run-tests.py. It can be
      > useful with infinite seed stressing
      > 2. random seed dropped from the context. Now JSON progress indicator
      > gets it from the list of command args.
      > 
      > Bug: v8:6917
      > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      > Change-Id: I73e535bc8face9b913c696b8d5e3a246fa231004
      > Reviewed-on: https://chromium-review.googlesource.com/888524
      > Commit-Queue: Michał Majewski <majeski@google.com>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#50964}
      
      Bug: v8:6917
      Change-Id: I1ea376a4abffce5ab65f4834ea7e6d6011765ffa
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Reviewed-on: https://chromium-review.googlesource.com/894204Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Michał Majewski <majeski@google.com>
      Cr-Commit-Position: refs/heads/master@{#50978}
      5ede3cb5
  13. 30 Jan, 2018 2 commits
  14. 29 Jan, 2018 1 commit
  15. 26 Jan, 2018 2 commits
  16. 25 Jan, 2018 2 commits
  17. 15 Jan, 2018 1 commit
  18. 12 Jan, 2018 1 commit
  19. 04 Jan, 2018 2 commits
    • Michal Majewski's avatar
      [test] Check output on the worker process. · 9f7d440e
      Michal Majewski authored
      I added additional exception logging in the execution.py since
      errors in processing results were really difficult to debug.
      
      There is a problem on Windows with class serialization when
      it comes from dynamically loaded module. To fix it I moved all
      output processors to the tools/testrunner/outproc/ and import
      them in test/*/testcfg.py.
      
      Bug: v8:6917
      Change-Id: Ida604641d659b006e91faf1d56a37769ec47f5f3
      Reviewed-on: https://chromium-review.googlesource.com/842784
      Commit-Queue: Michał Majewski <majeski@google.com>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50361}
      9f7d440e
    • Michael Achenbach's avatar
      Revert "Revert "[test] Move has unexpected output to outproc."" · c1e9bc02
      Michael Achenbach authored
      This reverts commit 1685b5d2.
      
      Reason for revert: Was probably caused by infra change:
      https://crrev.com/c/845781
      
      Original change's description:
      > Revert "[test] Move has unexpected output to outproc."
      > 
      > This reverts commit 71605b3e.
      > 
      > Reason for revert: Seems to break static-initializers step:
      > https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/22156
      > 
      > Original change's description:
      > > [test] Move has unexpected output to outproc.
      > > 
      > > Expected outcomes optimized to serialize [PASS] as None.
      > > 
      > > Keeping expected outcomes inside output processors should be
      > > optimized in the future. Few possible optimizations:
      > > - separate classes for tests that are expected to PASS - done as
      > > an example in mozilla test suite.
      > > - cache output processors inside testcase.
      > > - share output processors between copies of the same test - needs
      > > some updates to the create_variant to update outproc only if
      > > expected outcomes changed.
      > > 
      > > Bug: v8:6917
      > > Change-Id: Ie73f1dcdf17fdfc65bce27228f818b1dd1e420c9
      > > Reviewed-on: https://chromium-review.googlesource.com/843025
      > > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > > Cr-Commit-Position: refs/heads/master@{#50347}
      > 
      > TBR=machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com
      > 
      > Change-Id: Ice1f3aee0a26f7f38996459d38fd6e0bd964113d
      > No-Presubmit: true
      > No-Tree-Checks: true
      > No-Try: true
      > Bug: v8:6917
      > Reviewed-on: https://chromium-review.googlesource.com/849572
      > Reviewed-by: Bill Budge <bbudge@chromium.org>
      > Commit-Queue: Bill Budge <bbudge@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#50348}
      
      TBR=bbudge@chromium.org,machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com
      
      Change-Id: I7a522b6487de6e96985d223524533493eb9171f0
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:6917
      Reviewed-on: https://chromium-review.googlesource.com/848975Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50350}
      c1e9bc02
  20. 03 Jan, 2018 2 commits
    • Bill Budge's avatar
      Revert "[test] Move has unexpected output to outproc." · 1685b5d2
      Bill Budge authored
      This reverts commit 71605b3e.
      
      Reason for revert: Seems to break static-initializers step:
      https://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/22156
      
      Original change's description:
      > [test] Move has unexpected output to outproc.
      > 
      > Expected outcomes optimized to serialize [PASS] as None.
      > 
      > Keeping expected outcomes inside output processors should be
      > optimized in the future. Few possible optimizations:
      > - separate classes for tests that are expected to PASS - done as
      > an example in mozilla test suite.
      > - cache output processors inside testcase.
      > - share output processors between copies of the same test - needs
      > some updates to the create_variant to update outproc only if
      > expected outcomes changed.
      > 
      > Bug: v8:6917
      > Change-Id: Ie73f1dcdf17fdfc65bce27228f818b1dd1e420c9
      > Reviewed-on: https://chromium-review.googlesource.com/843025
      > Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#50347}
      
      TBR=machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com
      
      Change-Id: Ice1f3aee0a26f7f38996459d38fd6e0bd964113d
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: v8:6917
      Reviewed-on: https://chromium-review.googlesource.com/849572Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
      Commit-Queue: Bill Budge <bbudge@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50348}
      1685b5d2
    • Michal Majewski's avatar
      [test] Move has unexpected output to outproc. · 71605b3e
      Michal Majewski authored
      Expected outcomes optimized to serialize [PASS] as None.
      
      Keeping expected outcomes inside output processors should be
      optimized in the future. Few possible optimizations:
      - separate classes for tests that are expected to PASS - done as
      an example in mozilla test suite.
      - cache output processors inside testcase.
      - share output processors between copies of the same test - needs
      some updates to the create_variant to update outproc only if
      expected outcomes changed.
      
      Bug: v8:6917
      Change-Id: Ie73f1dcdf17fdfc65bce27228f818b1dd1e420c9
      Reviewed-on: https://chromium-review.googlesource.com/843025
      Commit-Queue: Michael Achenbach <machenbach@chromium.org>
      Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#50347}
      71605b3e
  21. 21 Dec, 2017 1 commit
  22. 20 Dec, 2017 1 commit
  23. 19 Dec, 2017 3 commits
  24. 18 Dec, 2017 1 commit
  25. 15 Dec, 2017 1 commit
  26. 14 Dec, 2017 1 commit
  27. 13 Dec, 2017 1 commit