- 11 Aug, 2015 7 commits
-
-
yangguo authored
R=mstarzinger@chromium.org BUG=chromium:517592 LOG=N Review URL: https://codereview.chromium.org/1285793002 Cr-Commit-Position: refs/heads/master@{#30104}
-
saper authored
The following errors come up when compiling v8 with clang 3.7 on FreeBSD/amd64: src/runtime/runtime-i18n.cc:629:37: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Smi *' is not allowed local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:131:20: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Object *' is not allowed Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:1989:18: error: reinterpret_cast from 'nullptr_t' to 'Address' (aka 'unsigned char *') is not allowed Address base = reinterpret_cast<Address>(NULL); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +add myself to the AUTHORS file. BUG= Review URL: https://codereview.chromium.org/1277353002 Cr-Commit-Position: refs/heads/master@{#30103}
-
mstarzinger authored
This is the first step of turning the v8.h file into a normal header instead of an include-the-world header. The new rule is that no other header files are allowed to include v8.h, which is enforced by DEPS. Also the number of includes inside the v8.h file has been drastically reduced. Basically the last missing piece is the inclusion of the big objects-inl.h file. This in turn makes many headers follow the IWYU principle. R=bmeurer@chromium.org,hpayer@chromium.org,titzer@chromium.org Review URL: https://codereview.chromium.org/1282503003 Cr-Commit-Position: refs/heads/master@{#30102}
-
yangguo authored
Revert of [turbofan] Various fixes to allow unboxed doubles as arguments in registers and on the stack. (patchset #7 id:120001 of https://codereview.chromium.org/1263033004/ ) Reason for revert: This CL breaks MIPS (roll blocker). https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20mipsel%20-%20sim/builds/2061/steps/Check/logs/Run_Int32_Select_1 Original issue's description: > [turbofan] Various fixes to allow unboxed doubles as arguments in registers and on the stack. > > R=jarin@chromium.org > BUG= > > Committed: https://crrev.com/71409be5395f867bbca0f6998bf6caa175cd8192 > Cr-Commit-Position: refs/heads/master@{#30091} TBR=jarin@chromium.org,titzer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1284853002 Cr-Commit-Position: refs/heads/master@{#30101}
-
v8-autoroll authored
Rolling v8/tools/clang to b66ad18bb147f02b74b207358140371382b0ef35 TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1281053003 Cr-Commit-Position: refs/heads/master@{#30100}
-
binji authored
BUG=chromium:518747 R=mstarzinger@chromium.org LOG=n Review URL: https://codereview.chromium.org/1277543006 Cr-Commit-Position: refs/heads/master@{#30099}
-
adamk authored
R=littledan@chromium.org BUG=v8:4304 LOG=n Review URL: https://codereview.chromium.org/1282013002 Cr-Commit-Position: refs/heads/master@{#30098}
-
- 10 Aug, 2015 18 commits
-
-
machenbach authored
Revert of Make run-tests.py warn when it's not testing anything (patchset #1 id:1 of https://codereview.chromium.org/1283513003/ ) Reason for revert: Some bots that don't run tests (by design) don't return the test results json anymore which makes the infrastructure side fail now. Original issue's description: > Make run-tests.py warn when it's not testing anything > > I've often been confused by an "all passed" run of the test script > when it turned out that either all the tests I cared about were skipped > or, more likely, I mistyped the name(s) of the tests I wanted to run. > This patch aims to fix that (and gives a useful diagnostic for the > "all matched tests were skipped" case). > > R=machenbach@chromium.org > NOTRY=true > > Committed: https://crrev.com/1b1de2d221a0ed23e529e91bf9fa3dc287acb2ca > Cr-Commit-Position: refs/heads/master@{#30095} TBR=jkummerow@chromium.org,adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1283593005 Cr-Commit-Position: refs/heads/master@{#30097}
-
rmcilroy authored
Moves the creation of the interpreter table early on during initialization to ensure that even on nosnap builds it still gets allocated in the first page. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1278413002 Cr-Commit-Position: refs/heads/master@{#30096}
-
adamk authored
I've often been confused by an "all passed" run of the test script when it turned out that either all the tests I cared about were skipped or, more likely, I mistyped the name(s) of the tests I wanted to run. This patch aims to fix that (and gives a useful diagnostic for the "all matched tests were skipped" case). R=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1283513003 Cr-Commit-Position: refs/heads/master@{#30095}
-
adamk authored
R=machenbach@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1279613005 Cr-Commit-Position: refs/heads/master@{#30094}
-
mstarzinger authored
R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1283833002 Cr-Commit-Position: refs/heads/master@{#30093}
-
mstarzinger authored
This is a first step towards constraining down the heap interface to just the heap.h file. Note that many includes still leak through that file to the global "src" directory, but there now is a single place controlling which declarations leak that way. Especially inclusion of inline header files within "heap" has been limited drastically. R=hpayer@chromium.org,mlippautz@chromium.org Review URL: https://codereview.chromium.org/1281233003 Cr-Commit-Position: refs/heads/master@{#30092}
-
titzer authored
R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/1263033004 Cr-Commit-Position: refs/heads/master@{#30091}
-
mstarzinger authored
R=mlippautz@chromium.org Review URL: https://codereview.chromium.org/1284643003 Cr-Commit-Position: refs/heads/master@{#30090}
-
hpayer authored
BUG=chromium:507211 LOG=n Review URL: https://codereview.chromium.org/1257653011 Cr-Commit-Position: refs/heads/master@{#30089}
-
bmeurer authored
R=yangguo@chromium.org BUG=chromium:516423 LOG=n Review URL: https://codereview.chromium.org/1277153003 Cr-Commit-Position: refs/heads/master@{#30088}
-
rmcilroy authored
BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1269683002 Cr-Commit-Position: refs/heads/master@{#30087}
-
bmeurer authored
R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1281533003 Cr-Commit-Position: refs/heads/master@{#30086}
-
bmeurer authored
R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1277693004 Cr-Commit-Position: refs/heads/master@{#30085}
-
yangguo authored
R=jkummerow@chromium.org BUG=chromium:517778 LOG=Y Review URL: https://codereview.chromium.org/1278353002 Cr-Commit-Position: refs/heads/master@{#30084}
-
mlippautz authored
BUG= Review URL: https://codereview.chromium.org/1281923002 Cr-Commit-Position: refs/heads/master@{#30083}
-
bmeurer authored
TurboFan is now a requirement and supported by all backends, so we don't need those macros (plus all the machinery on top) anymore. R=jarin@chromium.org Review URL: https://codereview.chromium.org/1282763002 Cr-Commit-Position: refs/heads/master@{#30082}
-
bmeurer authored
The !IS_SPEC_OBJECT(x) check implies both IS_STRING(x) and IS_SIMD_VALUE(x), and generates shorter/better code. So we can safely remove the redundant checks. R=rossberg@chromium.org Review URL: https://codereview.chromium.org/1278873007 Cr-Commit-Position: refs/heads/master@{#30081}
-
bmeurer authored
No need to provide TO_INT32/TO_UINT32 functions for every native context, as they can be implemented in terms of TO_NUMBER more easily and efficiently. Also remove the obsolete TO_BOOLEAN_FUN_INDEX from the native contexts. Review URL: https://codereview.chromium.org/1275013004 Cr-Commit-Position: refs/heads/master@{#30080}
-
- 08 Aug, 2015 3 commits
-
-
jkummerow authored
When a (prototype) map registers as a user of its own prototype, it now remembers the index in that prototype's registry where it is listed. This remembered index is used on un-registration to find the right slot to clear without walking the entire registry. Compaction of the registry must update all entries' remembered indices. BUG=chromium:517778,chromium:517406 LOG=n R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1276353004 Cr-Commit-Position: refs/heads/master@{#30079}
-
jkummerow authored
Use a hash map instead of a list for faster lookups. BUG=chromium:517406 LOG=n R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1279763006 Cr-Commit-Position: refs/heads/master@{#30078}
-
v8-autoroll authored
Rolling v8/tools/clang to c956d7970bf6637cb34f17ff64c375b6591d5940 TBR=machenbach@chromium.org Review URL: https://codereview.chromium.org/1276023003 Cr-Commit-Position: refs/heads/master@{#30077}
-
- 07 Aug, 2015 12 commits
-
-
jkummerow authored
Only walk the heap clearing KeyedStoreICs when the dictionary in question belongs to an object that's used as a prototype. This is a temporary mitigation until we have a way to clear such ICs without having to walk the heap. BUG=v8:4335 LOG=y R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1275363002 Cr-Commit-Position: refs/heads/master@{#30076}
-
yangguo authored
Currently, looking up a lexical context variable requires looking up the variable name and then checking its mode. This can be a bottleneck in Runtime_DeclareGlobals, even when no lexical context variables are declared. R=rossberg@chromium.org BUG=crbug:517778 LOG=N Review URL: https://codereview.chromium.org/1281883002 Cr-Commit-Position: refs/heads/master@{#30075}
-
rossberg authored
Fixes the use of eval calls in strict parameter lists in particular. R=adamk@chromium.org BUG=v8:811 LOG=N Review URL: https://codereview.chromium.org/1276273002 Cr-Commit-Position: refs/heads/master@{#30074}
-
Djordje.Pesic authored
Also clean up variable naming in min_max and other tests. Fix class_fmt in mips64 assembler test for proper NaN checking Review URL: https://codereview.chromium.org/1276813004 Cr-Commit-Position: refs/heads/master@{#30073}
-
littledan authored
Reland patch originally reviewed at https://codereview.chromium.org/1268553003/ This new patch marks a test [PASS, FAIL] since it passes on some platforms. Review URL: https://codereview.chromium.org/1273883005 Cr-Commit-Position: refs/heads/master@{#30072}
-
mstarzinger authored
R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1281903002 Cr-Commit-Position: refs/heads/master@{#30071}
-
mstarzinger authored
Note that this tests performed unnecessary many iterations which led to long runtimes in debug mode and also caused flaky GCs during that would cause the optimized code map to be flushed and violated assumptions. R=yangguo@chromium.org BUG=v8:4363 LOG=N Review URL: https://codereview.chromium.org/1280973002 Cr-Commit-Position: refs/heads/master@{#30070}
-
rossberg authored
Was fixed by https://chromium.googlesource.com/v8/v8/+/826f8da55fb868a365d047a4a653eb8ff2bfc14e R=mstarzinger@chromium.org BUG=517455 LOG=N Review URL: https://codereview.chromium.org/1280953002 Cr-Commit-Position: refs/heads/master@{#30069}
-
mstarzinger authored
R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1278113004 Cr-Commit-Position: refs/heads/master@{#30068}
-
mlippautz authored
With --harmony-proxies enabled, embedded pointers in optimized code can point to a JSProxy (via a cell). Since JSProxy can morph into JSObject we need to align the expectations of weak vs strong refs. With this patch we also treat JSPRoxy as weak ref (like JSObject) and therefore properly record a dependency on it, so that once the cell pointing to it becomes unreachable we deoptimize the corresponding code. BUG=v8:4359 LOG=N Review URL: https://codereview.chromium.org/1270393003 Cr-Commit-Position: refs/heads/master@{#30067}
-
mstarzinger authored
R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1269313003 Cr-Commit-Position: refs/heads/master@{#30066}
-
titzer authored
Rationale: The {kind} of a call descriptor describes what the {target} being called is--i.e. a JSFunction, code object, or address. That kind materially dictates the instruction(s) generated for an outgoing call. The other flags on a call descriptor should describe specific properties (like whether a roots register is valid or not) so that backend logic doesn't have to switch over the kind, but is informed directly of what it wants to know. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1268273003 Cr-Commit-Position: refs/heads/master@{#30065}
-