- 16 Oct, 2017 1 commit
-
-
Clemens Hammacher authored
Use the (D)CHECK_{EQ,NE,GT,...} macros instead of (D)CHECK with an embedded comparison. This gives better error messages and also does the right comparison for signed/unsigned mismatches. This will allow us to reenable the readability/check cpplint check. R=yangguo@chromium.org Bug: v8:6837, v8:6921 Change-Id: I0c2deaea3f2ff5b5b25ba658470850534f1900ac Reviewed-on: https://chromium-review.googlesource.com/681435 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#48594}
-
- 11 Apr, 2017 1 commit
-
-
yangguo authored
Before serializing an external string for a native source, we replace its resource field with the type and index of the native source. Upon deserialization, we restore the resource. This change also removes the native source caches with a more straight- forward mechanism to find the resource type and index. R=ulan@chromium.org Review-Url: https://codereview.chromium.org/2807023003 Cr-Commit-Position: refs/heads/master@{#44545}
-
- 13 Mar, 2017 1 commit
-
-
binji authored
This reverts the previous revert, commit 5a04f4fd. Previously reverted changes: > Revert "[SAB] Move Atomics builtins to C++" > > This reverts commit 2b9840d8. > > Revert "[SAB] Remove unreachable Uint8Clamped atomics paths" > > This reverts commit d1160fb1. > > Revert "Remove tiny unit test for MinSimple/MaxSimple" > > This reverts commit 837760ec. > > Revert "Remove infrastructure for experimental JS natives" > > This reverts commit 8cfe45b6. These changes were reverted to improve a perf regression on a Chrome bot. Since then, the regression has reappeared, then disappeared again all from seemingly unrelated changes. BUG=v8:6033 TBR=adamk@chromium.org,hpayer@chromium.org,yangguo@chromium.org Review-Url: https://codereview.chromium.org/2732213005 Cr-Commit-Position: refs/heads/master@{#43758}
-
- 27 Feb, 2017 1 commit
-
-
binji authored
perf regression. See crbug.com/695653 for more info. Revert "[SAB] Move Atomics builtins to C++" This reverts commit 2b9840d8. Revert "[SAB] Remove unreachable Uint8Clamped atomics paths" This reverts commit d1160fb1. Revert "Remove tiny unit test for MinSimple/MaxSimple" This reverts commit 837760ec. Revert "Remove infrastructure for experimental JS natives" This reverts commit 8cfe45b6. BUG=695653 TBR=hablich@chromium.org Review-Url: https://codereview.chromium.org/2715223003 Cr-Commit-Position: refs/heads/master@{#43462}
-
- 24 Feb, 2017 1 commit
-
-
adamk authored
Now that no harmony-flagged features are implemented in experimental JS, most of this is simply dead code. As PostExperimentals() is no longer needed, I also removed the use of Import() in the debug context, allowing the deletion of PostDebug() along with PostExperimentals(); cleanup code is moved to the end of PostNatives. Also gets rid of some longer-dead code in prologue.js related to TypedArrays, and some duplicate code for setting up SharedArrayBuffer builtins. Review-Url: https://codereview.chromium.org/2705293004 Cr-Commit-Position: refs/heads/master@{#43418}
-
- 19 May, 2016 1 commit
-
-
yangguo authored
The cached resource data pointer is a source of non-determinism when creating the snapshot. Long-term we may not keep the native source in memory anyways, so caching the resource data pointer will not be possible. R=ulan@chromium.org BUG=v8:4886 LOG=N Review-Url: https://codereview.chromium.org/1990183002 Cr-Commit-Position: refs/heads/master@{#36361}
-
- 02 Dec, 2015 1 commit
-
-
danno authored
* Add a sibling interface to InterpreterAssembler called CodeStubAssembler which provides a wrapper around the RawMachineAssembler and is intented to make it easy to build efficient cross-platform code stubs. Much of the implementation of CodeStubAssembler is shamelessly stolen from the InterpreterAssembler, and the idea is to eventually merge the two interfaces somehow, probably moving the InterpreterAssembler interface over to use the CodeStubAssembler. Short-term, however, the two interfaces shall remain decoupled to increase our velocity developing the two systems in parallel. * Implement the StringLength stub in TurboFan with the new CodeStubAssembler. Replace and remove the old Hydrogen-stub version. * Remove a whole slew of machinery to support JavaScript-style code stub generation, since it ultimately proved unwieldy, brittle and baroque. This cleanup includes removing the shared code stub context, several example stubs and a tangle of build file changes. BUG=v8:4587 LOG=n Review URL: https://codereview.chromium.org/1475953002 Cr-Commit-Position: refs/heads/master@{#32508}
-
- 20 Aug, 2015 1 commit
-
-
domenic authored
Embedders would use these for features which must be able to be turned off at runtime, despite being compiled into V8. They can be turned on and off by the embedder using the --experimental_extras flag, e.g. via v8::SetFlagsFromString. R=yangguo@chromium.org, mlippautz@chromium.org, hpayer@chromium.org BUG=chromium:507137 LOG=Y Review URL: https://codereview.chromium.org/1284413002 Cr-Commit-Position: refs/heads/master@{#30260}
-
- 18 Aug, 2015 1 commit
-
-
mstarzinger authored
R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1303463002 Cr-Commit-Position: refs/heads/master@{#30222}
-