Commits · a5f0489e5d5c86f867411424d4f721c0ff6c683b · Linshizhi / V8

26 May, 2014 4 commits

Fix memory leak in the debugger. · a5f0489e

yangguo@chromium.org authored May 26, 2014

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/297373002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21479 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a5f0489e

Some progress on translating toolchain.gypi to gn · b4394e5b

jochen@chromium.org authored May 26, 2014

BUG=none
R=brettw@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/299173002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21478 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b4394e5b

Fix leak in debug mirror cache. · 32f433c1

yangguo@chromium.org authored May 26, 2014

When fetching loaded scripts, mirror objects are created and cached.
If the cache is not cleared, it holds script objects alive.

This also fixes a minor issue with script unloading.

R=ulan@chromium.org
BUG=376534
LOG=N

Review URL: https://codereview.chromium.org/296953005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21477 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

32f433c1

LoadUint32() doesn't need a scratch register. · cdcee29e

bmeurer@chromium.org authored May 26, 2014

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/293363005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21476 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cdcee29e

23 May, 2014 24 commits

MIPS: Fix r21470 “Reland r21442 Inobject slack tracking is done on a... · b2fc4595

plind44@gmail.com authored May 23, 2014

MIPS: Fix r21470 “Reland r21442 Inobject slack tracking is done on a per-closure basis instead of per-shared info basis."

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/297093002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21471 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b2fc4595

MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis... · 50e9d22a

plind44@gmail.com authored May 23, 2014

MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared info basis."

Port r21457 (8db39a8)

Original commit message:
This fixes inobject slack tracking for prototype inheritance pattern that uses closures.

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/294973013

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21470 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

50e9d22a

Introduce x87 port · 9c485e18

danno@chromium.org authored May 23, 2014

Support x87-only platform (ia32 without SSE)

R=danno@chromium.org

Review URL: https://codereview.chromium.org/293743005

Patch from Weiliang Lin <weiliang.lin@intel.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21469 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9c485e18

Allow HPushArgument to handle more than one argument. · 8d334ed1

alexandre.rames@arm.com authored May 23, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/296113008

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21468 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8d334ed1

Fix representation inference for mutable double boxes. · cf448aa1

mstarzinger@chromium.org authored May 23, 2014

R=jarin@chromium.org
BUG=v8:3307
TEST=mjsunit/regress/regress-3307
LOG=N

Review URL: https://codereview.chromium.org/298723014

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21467 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cf448aa1

Check for cached transition to ExternalArray elements kind. · 45ab7d52

dslomov@chromium.org authored May 23, 2014

R=ishell@chromium.org, verwaest@chromium.org
BUG=v8:3337
LOG=Y

Review URL: https://codereview.chromium.org/291193011

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21466 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

45ab7d52

Provide a helper to generate multiple Lithium instructions for one Hydrogen instruction. · 18412a83

alexandre.rames@arm.com authored May 23, 2014

R=jkummerow@chromium.org, ulan@chromium.org

Review URL: https://codereview.chromium.org/296993002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21465 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

18412a83

Cleanup after inobject slack tracking improvement. · 7c55f645

ishell@chromium.org authored May 23, 2014

1) %SetExpectedNumberOfProperties() function removed.
2) Obsolete SharedFunctionInfo::BeforeVisitingPointers() removed.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/289283018

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21464 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7c55f645

Skip dead blocks/instructions in store elimination. · 238a2489

bmeurer@chromium.org authored May 23, 2014

Also improve tracing.

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/297933002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21463 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

238a2489

Tiny steps towards a non-local 'Merge removable simulates' phase. · 98864249

svenpanne@chromium.org authored May 23, 2014

Distinguish copying/merging of the state. Better tracing.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/299883003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21462 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

98864249

Revert "Make v8::TryCatch able to consume natively thrown exceptions (again)." · a2082b25

mstarzinger@chromium.org authored May 23, 2014

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/296133013

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21461 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a2082b25

Support ES6 weak collections in heap profiler · 7741fe04

yurys@chromium.org authored May 23, 2014

BUG=chromium:376196
LOG=Y
R=alph@chromium.org, yangguo@chromium.org

Review URL: https://codereview.chromium.org/294163005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21460 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7741fe04

ARM64 simulator fix for EXTR · 123608ab

rodolph.perfetta@arm.com authored May 23, 2014

Fixes extract when imms = 0 because a left shift of 64 is not valid.

R=rodolph.perfetta@arm.com, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/286193004

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21459 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

123608ab

Avoid dynamic initial map check when inlining call-new. · a56bbe92

bmeurer@chromium.org authored May 23, 2014

This improves check elimination and removes a load plus
a map check for every inlined call-new.

R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/293223002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21458 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a56bbe92

Reland r21442 "Inobject slack tracking is done on a per-closure basis instead... · 4b9c0305

ishell@chromium.org authored May 23, 2014

Reland r21442 "Inobject slack tracking is done on a per-closure basis instead of per-shared info basis."
This fixes inobject slack tracking for prototype inheritance pattern that uses closures.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/292183008

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21457 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4b9c0305

Make v8::TryCatch able to consume natively thrown exceptions (again). · 473d3e1e

mstarzinger@chromium.org authored May 23, 2014

R=yangguo@chromium.org
BUG=chromium:362388
TEST=cctest/test-api/TryCatchNative
LOG=N

Review URL: https://codereview.chromium.org/291393002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21456 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

473d3e1e

Drop gitignore entry for now obsolete test262 archive · 6dd3cb07

jochen@chromium.org authored May 23, 2014

BUG=none
R=jkummerow@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/300453003

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21455 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6dd3cb07

Fix compilation errors. · 5ad9a3b4

bmeurer@chromium.org authored May 23, 2014

TBR=hpayer@chromium.org

Review URL: https://codereview.chromium.org/291343006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21454 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5ad9a3b4

If map was deprecated, abort compilation and allow re-compilation. · 261bc887

bmeurer@chromium.org authored May 23, 2014

Also print a message if either map became unstable or map was
deprecated, if --trace-opt is enabled.

R=hpayer@chromium.org

Review URL: https://codereview.chromium.org/292323005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21453 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

261bc887

Use the flow engine for HMergeRemovableSimulatesPhase. · f39d5859

svenpanne@chromium.org authored May 23, 2014

For now, this is a 1:1 reformulation of the block-local analysis, but
this will change.

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/294473015

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21452 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f39d5859

Add a bunch of files in my checkout to .gitignore · cff61d3b

jochen@chromium.org authored May 23, 2014

BUG=none
TBR=machenbach@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/296453020

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21451 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cff61d3b

Remove dummy harmony-promises flag · fe68f988

jochen@chromium.org authored May 23, 2014

BUG=none
LOG=n
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/292723002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21450 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fe68f988

Revert "Do away with variable length memcpy to Set/Get registers in simulator" · 83987813

svenpanne@chromium.org authored May 23, 2014

This reverts r21148, it broke tests in debug mode, e.g.
mjsunit/regress/regress-observe-map-cache or mjsunit/debug-stepout-scope-part5.

TBR=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/296823014

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21449 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

83987813

Do away with variable length memcpy to Set/Get registers in simulator · e61b69f5

svenpanne@chromium.org authored May 23, 2014

About a 32% boost.

Before - 5:31

Richards: 84.5
DeltaBlue: 128
Crypto: 65.3
RayTrace: 203
EarleyBoyer: 149
RegExp: 23.4
Splay: 121
NavierStokes: 98.9
----
Score (version 7): 93.8

After - 4:10

Richards: 107
DeltaBlue: 175
Crypto: 93.9
RayTrace: 258
EarleyBoyer: 186
RegExp: 32.7
Splay: 165
NavierStokes: 124
----
Score (version 7): 124

R=jacob.bramley@arm.com, svenpanne@chromium.org

Review URL: https://codereview.chromium.org/213943002

Patch from Fritz Koenig <frkoenig@google.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21448 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e61b69f5

22 May, 2014 12 commits

MIPS: Customized support for feedback on calls to Array. · c471c9e8

plind44@gmail.com authored May 22, 2014

Port r21429 (a88ba79)

Original commit message:
Gather transition feedback on array calls, and inline the Array
function call when it makes sense.

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/293063012

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21445 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c471c9e8

Revert "Reland r21346 "Inobject slack tracking is done on a per-closure basis... · 9f3183f7

ishell@chromium.org authored May 22, 2014

Revert "Reland r21346 "Inobject slack tracking is done on a per-closure basis instead of per-shared info basis.""

This reverts r21442.

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/292433016

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21444 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9f3183f7

MIPS: Allow specifying base offset when constructing Keyed hydrogen instructions. · 9fb4abb9

plind44@gmail.com authored May 22, 2014

Port r21426 (17e6338)

This is preparation for pending hydrogen stub work that needs to access memory using KeyedLoad/KeyedStore operations where the base offset used for the accesses are is the the default (e.g. the size of an FixedArray header for FixedArrays or zero for external arrays).

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/296983003

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21443 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9fb4abb9

Reland r21346 "Inobject slack tracking is done on a per-closure basis instead... · 00b8e612

ishell@chromium.org authored May 22, 2014

Reland r21346 "Inobject slack tracking is done on a per-closure basis instead of per-shared info basis."
This fixes inobject slack tracking for prototype inheritance pattern that uses closures.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/290993009

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21442 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

00b8e612

Consistently say 'own' property · 06f746a5

rossberg@chromium.org authored May 22, 2014

R=yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/291153005

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21441 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

06f746a5

ClearTypeFeedbackInfo() assumed we have a context in the isolate. · d2a32383

mvstanton@chromium.org authored May 22, 2014

Better, is to compare against the context for the JSFunction we are
currently looking at.

TBR=ulan@chromium.org

Review URL: https://codereview.chromium.org/294903013

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21440 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d2a32383

Harden a few builtins · d6a05b72

jkummerow@chromium.org authored May 22, 2014

Introducing BUILTIN_ASSERT, builtins' equivalent of RUNTIME_ASSERT.

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/292173011

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21439 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d6a05b72

If map became unstable, abort compilation and allow re-compilation. · 620f07e3

hpayer@chromium.org authored May 22, 2014

BUG=
R=danno@google.com

Review URL: https://codereview.chromium.org/291653006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21438 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

620f07e3

Revert "Inobject slack tracking is done on a per-closure basis instead of per-shared info basis." · 58932c6c

ishell@chromium.org authored May 22, 2014

This reverts r21436.

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/295933012

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21437 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

58932c6c

Inobject slack tracking is done on a per-closure basis instead of per-shared info basis. · 4a47cc5f

ishell@chromium.org authored May 22, 2014

This fixes inobject slack tracking for prototype inheritance pattern that uses closures.

R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/283383006

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21436 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4a47cc5f

GCMole evaluation order issue in CallIC::DoCustomHandler(). · 894df708

mvstanton@chromium.org authored May 22, 2014

R=jarin@chromium.org

Review URL: https://codereview.chromium.org/296693011

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21435 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

894df708

ClearTypeFeedbackInfo(): context may not be initialized. · 5392e94e

mvstanton@chromium.org authored May 22, 2014

SharedFunctionInfo::ClearTypeFeedbackInfo() wants to compare feedback
to the array JSFunction, but it's called at times when the context
isn't fully initialized. Be cautious about this check.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/298983002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21434 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5392e94e