- 06 May, 2016 11 commits
-
-
clemensh authored
This changes different locations to extract the reference to the wasm object and the function index from the stack trace, and make it available through all the APIs which process stack traces. The javascript CallSite object now has the new methods isWasm(), getWasmObject() and getWasmFunctionIndex(); the byte offset is available via getPosition(). Function names of wasm frames should be fully functional with this commit, position information works reliably for calls, but not for traps like unreachable or out-of-bounds accesses. R=titzer@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/1909353002 Cr-Commit-Position: refs/heads/master@{#36067}
-
titzer authored
Revert of [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. (patchset #2 id:20001 of https://codereview.chromium.org/1948453002/ ) Reason for revert: Breaks WASM; please also add tests when relanding. Original issue's description: > [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. > > Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use a memory operand if the load representation machine size is wide enough to represent the latter. > > Committed: https://crrev.com/a0543313dbd46b0c2e72c91ee3488a7dc6db73e4 > Cr-Commit-Position: refs/heads/master@{#36009} TBR=bmeurer@chromium.org,jfb@chromium.org,epertoso@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/1959603002 Cr-Commit-Position: refs/heads/master@{#36066}
-
machenbach authored
BUG=v8:4280 LOG=N NOTRY=true TBR=rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/1956663002 Cr-Commit-Position: refs/heads/master@{#36065}
-
machenbach authored
BUG=v8:4995 LOG=n NOTRY=true TBR=thakis@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/1955013002 Cr-Commit-Position: refs/heads/master@{#36064}
-
bmeurer authored
This operator was initially designed to handle arbitrary effect merging for effect relaxation, but we don't do that (at least currently). So no need to keep the dead operator around. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/1954983002 Cr-Commit-Position: refs/heads/master@{#36063}
-
mbrandy authored
R=bmeurer@chromium.org, jarin@chromium.org BUG= Review-Url: https://codereview.chromium.org/1945303003 Cr-Commit-Position: refs/heads/master@{#36062}
-
zhengxing.li authored
port d2efbf25 (r36000) original commit message: BUG= Review-Url: https://codereview.chromium.org/1947363002 Cr-Commit-Position: refs/heads/master@{#36061}
-
jochen authored
I want to stop using d8 from the chromium build, so we could potentially use it for running tests. BUG=chromium:609107 R=machenbach@chromium.org LOG=n Review-Url: https://codereview.chromium.org/1944353002 Cr-Commit-Position: refs/heads/master@{#36060}
-
v8-autoroll authored
Rolling v8/build to 119d5305247498fdd8a215b8e2b6c50223ac7d4b Rolling v8/tools/clang to 0bb0462a91310d88ab9d124d8db54a70c9e1d1b0 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/1953813004 Cr-Commit-Position: refs/heads/master@{#36059}
-
zhengxing.li authored
X87: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm memory size references in generated code. port 117a56b7 (r36044) original commit message: - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add relocation information to immediates in compare instructions. - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler BUG= Review-Url: https://codereview.chromium.org/1947413003 Cr-Commit-Position: refs/heads/master@{#36058}
-
zhengxing.li authored
X87: [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. port a0543313 (r36009) original commit message: Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use a memory operand if the load representation machine size is wide enough to represent the latter. BUG= Review-Url: https://codereview.chromium.org/1954963002 Cr-Commit-Position: refs/heads/master@{#36057}
-
- 05 May, 2016 9 commits
-
-
jyan authored
S390: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm memory size references in generated code. port 117a56b7 Original commit message: - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add relocation information to immediates in compare instructions. - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler R=gdeepti@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/1955593003 Cr-Commit-Position: refs/heads/master@{#36056}
-
mtrofin authored
BUG= Review-Url: https://codereview.chromium.org/1931293005 Cr-Commit-Position: refs/heads/master@{#36055}
-
bjaideep authored
PPC: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm memory size references in generated code. Port 117a56b7 Original commit message: - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add relocation information to immediates in compare instructions. - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler R=gdeepti@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Review-Url: https://codereview.chromium.org/1948263003 Cr-Commit-Position: refs/heads/master@{#36054}
-
akos.palfi authored
Port 81cb8411 BUG= Review-Url: https://codereview.chromium.org/1957463002 Cr-Commit-Position: refs/heads/master@{#36053}
-
titzer authored
R=bradnelson@chromium.org,rossberg@chromium.org BUG= Review-Url: https://codereview.chromium.org/1951013002 Cr-Commit-Position: refs/heads/master@{#36052}
-
zhengxing.li authored
port af677d7b (r35998) original commit message: https://codereview.chromium.org/1938213002 added xchg_b and xchg_w, but didn't add it to the disassembler, and there were no tests that caught it. BUG= Review-Url: https://codereview.chromium.org/1947843002 Cr-Commit-Position: refs/heads/master@{#36051}
-
v8-autoroll authored
Rolling v8/build to f80756f5df1d90cf1113a2ce335147482e36f65e Rolling v8/buildtools to 731bdb2af8b5839450605ddebdcf5de749cf9d17 Rolling v8/tools/clang to ee715658a19a60fc73b02532a077d9c96f291331 Rolling v8/tools/gyp to 02b145a1a4f4e1c62e8bae06045caf852d9ef17f TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/1945103004 Cr-Commit-Position: refs/heads/master@{#36050}
-
zhengxing.li authored
port 81cb8411 (r35993) original commit message: BUG= Review-Url: https://codereview.chromium.org/1947833002 Cr-Commit-Position: refs/heads/master@{#36049}
-
zhengxing.li authored
port fa570e55 (r35963) original commit message: BUG= Review-Url: https://codereview.chromium.org/1952583002 Cr-Commit-Position: refs/heads/master@{#36048}
-
- 04 May, 2016 20 commits
-
-
adamk authored
R=littledan@chromium.org BUG=v8:4974 LOG=n Review-Url: https://codereview.chromium.org/1949223002 Cr-Commit-Position: refs/heads/master@{#36047}
-
adamk authored
Scope analysis is over-conservative when treating variable resolutions as possibly-shadowed by a sloppy eval. In the attached bug, this comes into play since catch scopes have different behavior with respect to the "calls eval" in eager vs lazy compilation (in the latter, they are never marked as "calls eval" because CatchContexts don't have an associated ScopeInfo). This patch changes the scope-type check to also eliminate a few other cases where shadowing isn't possible, such as non-declaration block scopes. BUG=chromium:608279 LOG=n Review-Url: https://codereview.chromium.org/1950803002 Cr-Commit-Position: refs/heads/master@{#36046}
-
mike authored
As per the ES2015 spec, the value `-0` should be converted to `+0` prior to invocation of the species constructor. BUG=v8:4988 LOG=N R=littledan@chromium.org Review-Url: https://codereview.chromium.org/1950073002 Cr-Commit-Position: refs/heads/master@{#36045}
-
gdeepti authored
Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm memory size references in generated code. - Add new RelocInfo mode WASM_MEMORY_SIZE_REFERENCE in the assembler and add relocation information to immediates in compare instructions. - Use relocatable constants for MemSize/BoundsCheck in the wasm compiler R=titzer@chromium.org, yangguo@chromium.org, bradnelson@chromium.org Review-Url: https://codereview.chromium.org/1921203002 Cr-Commit-Position: refs/heads/master@{#36044}
-
mbrandy authored
TEST=mjsunit/array-constructor R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/1947233002 Cr-Commit-Position: refs/heads/master@{#36043}
-
alph authored
BUG=v8:4959 LOG=N Review-Url: https://codereview.chromium.org/1949693003 Cr-Commit-Position: refs/heads/master@{#36042}
-
jyan authored
R=joransiu@ca.ibm.com, cornacch@ca.ibm.com, mbrandy@us.ibm.com BUG= Review-Url: https://codereview.chromium.org/1948113002 Cr-Commit-Position: refs/heads/master@{#36041}
-
jyan authored
Port d2efbf25 R=danno@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=chromium:608675 LOG=N Review-Url: https://codereview.chromium.org/1946193004 Cr-Commit-Position: refs/heads/master@{#36040}
-
jyan authored
Port 81cb8411 R=binji@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4614 LOG=N Review-Url: https://codereview.chromium.org/1948043002 Cr-Commit-Position: refs/heads/master@{#36039}
-
pierre.langlois authored
A load instruction will implicitely clear the top 32 bits when writing to a W register. This patch avoids generating a `mov` instruction to zero-extend the result in this case. For example, this occurs in the generated code for dispatching to the next bytecode in the interpreter: kind = BYTECODE_HANDLER name = LdaZero compiler = turbofan Instructions (size = 36) 0x32e64c60 0 add x19, x19, #0x1 (1) 0x32e64c64 4 ldrb w0, [x20, x19] 0x32e64c68 8 mov w0, w0 ^^^^^^^^^^ 0x32e64c6c 12 lsl x0, x0, #3 0x32e64c70 16 ldr x1, [x21, x0] 0x32e64c74 20 movz x0, #0x0 0x32e64c78 24 br x1 BUG= Review-Url: https://codereview.chromium.org/1950013003 Cr-Commit-Position: refs/heads/master@{#36038}
-
jyan authored
Code common with ObjectHasOwnProperty builtin was moved to CodeStubAssembler. R=ishell@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:2743 LOG=Y Review-Url: https://codereview.chromium.org/1946303002 Cr-Commit-Position: refs/heads/master@{#36037}
-
bryleun authored
Port fa570e55 R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Review-Url: https://codereview.chromium.org/1952433002 Cr-Commit-Position: refs/heads/master@{#36036}
-
nikolaos authored
R=adamk@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/1952473003 Cr-Commit-Position: refs/heads/master@{#36035}
-
jyan authored
Move DCHECK to only check for necessary path. R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Review-Url: https://codereview.chromium.org/1946003003 Cr-Commit-Position: refs/heads/master@{#36034}
-
littledan authored
Previously, the species protector was invalidated whenever the __proto__ of an Array instance was manipulated. Then, if the map's new_target_is_base field remained set, it was correct to conclude that GetPrototypeOf(array) was %ArrayPrototype%. However, this choice caused the popular D3 framework to invalidate the species protector, causing many functions to become slower. This patch eliminates that aspect of the species protector. Instead, the check is to look at the instance->map()->prototype(). It is valid to look directly at the map's prototype slot, ignoring hidden prototypes and proxies, because - This is only called on Array instances, so the receiver cannot be a Proxy. - For hidden prototypes, any inaccuracy would only result in conservatively taking the slow path. Theoretically, this patch could make methods applied to arrays from other contexts slower. However, the slowdown would only affect a particular array instance and not have a global spill-over effect. Further, the slowdown could be addressed by tracking, either in the instance's map or in the actual prototype object, whether it is a %ArrayPrototype% from any context, in a way which is cheap to query, and use that rather than comparing to the currently executing native context. In interactive testing, this patch led the OnShape CAD system to experience faster load times (110+s -> 40s). BUG=chromium:606207 LOG=Y Review-Url: https://codereview.chromium.org/1936393002 Cr-Commit-Position: refs/heads/master@{#36033}
-
jyan authored
TEST=cctest/test-api/Regress470113 --ignition R=joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/1944333002 Cr-Commit-Position: refs/heads/master@{#36032}
-
kozyatinskiy authored
This method provides ability to get all properties of the object with passed filter in addition to existing GetOwnPropertyNames(context) method that returns only enumerable properties. BUG=v8:3861,chromium:581495 R=yangguo@chromium.org LOG=Y Review-Url: https://codereview.chromium.org/1943773002 Cr-Commit-Position: refs/heads/master@{#36031}
-
mstarzinger authored
This removes some low-level accessors from the CompilationInfo which only delegate to the ParseInfo. Instead we add a helper that computes the flags passed to DeclareGlobals for all backends. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/1952623002 Cr-Commit-Position: refs/heads/master@{#36030}
-
neis authored
We sometimes used to continue by jumping _back_ to the condition check at the top of the loop. After my recent generator-related changes, that check is no longer at the loop header, so a continue could create an additional loop. In order to avoid this, we now always set the continue target to be the first instruction following the loop body. BUG= Review-Url: https://codereview.chromium.org/1943383003 Cr-Commit-Position: refs/heads/master@{#36029}
-
mbrandy authored
Do not visit the constant pool pointer frame slot. TEST=cctest/test-api/Regress137496 --ignition R=danno@chromium.org, mcilroy@chromium.org, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/1950623002 Cr-Commit-Position: refs/heads/master@{#36028}
-