- 28 Jul, 2020 20 commits
-
-
Jakob Kummerow authored
This adds two convenience scripts: - update-vscode.sh downloads/updates Visual Studio Code - update-compile-commands.py prepares for code indexers like clangd by creating compile_commands.json (for all architectures), updating generated sources, and compiling the Torque Language Server. No-try: true Change-Id: I64a15dc298f4312a9b296762593234c40f542b06 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317355 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#69105}
-
Igor Sheludko authored
Also use outer-function name as a ZONE_NAME instead of file:line and give explicit names to parser and preparser zones. Bug: v8:10572 Change-Id: I9b5acb23322889d8538a34bc888fd6f610eb6893 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2322627 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#69104}
-
Milad Farazmand authored
Port 1250fd59 Original Commit Message: This generic wrapper builtin is currently used only when the wasm function has no parameters and no return value. Added a new V8 flag to use this generic wrapper. Also added a JS test function for this generic wrapper. R=evih@google.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ib1f14081779adaf3668c4936ba6afde0a782ce0d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2323310Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#69103}
-
Zeynep Cankara authored
This CL creates a timeline track component to make the timeline view extensible as different data sources added. The timeline track component will take data source and display it with respect to time axis of timeline overview. Bug: v8:10644, v8:10735 Change-Id: I1c88dd2dc967be68e6235e517dcf8554a891eee4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2302053 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
-
Dominik Inführ authored
On 32-bit systems the calculation could overflow, leading to an illegal limit of the LAB. Cast to uint64_t to avoid this. Add DCHECKs to catch this earlier. Bug: chromium:1110214, v8:10315 Change-Id: I73679a2daeb3b83bb303d411c77782a2172e98cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320654Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#69101}
-
Milad Farazmand authored
Port 51b53dd3 R=rstz@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ic2ee6e75afd5da8bb7f35dfde4b1d85231f1cf4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2318045Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Since we have an uninitialized TransitionArray that we want to insert an element (map1), we can't guarantee that said element would exist at the point of the search. Then, we search for an element guaranteed not to be (map2) and we check that we did not find it. If we have a data race, this would also trigger it. Bug: v8:7790 Change-Id: Ib90044d7c0901d599aed041f608f2c0bce506d67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2319995 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#69099}
-
Emanuel Ziegler authored
Add a framework for collecting event-based metrics like UKMs in V8 that is independent of the actual implementation. Design doc: https://docs.google.com/document/d/1vCZQCh4B05isqwJOwTPv7WqcnVp4KJITMgsHSBg35ZI/ R=ulan@chromium.org Bug: chromium:1101749 Change-Id: If3a5b954d1f0bcee4e06a03467b651feae378a5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2288231 Commit-Queue: Emanuel Ziegler <ecmziegler@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
evih authored
This generic wrapper builtin is currently used only when the wasm function has no parameters and no return value. Added a new V8 flag to use this generic wrapper. Also added a JS test function for this generic wrapper. Bug: v8:10701 Change-Id: Id8cd1771f26922927363b715d8a6ffd384a143ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2307240Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Eva Herencsárová <evih@google.com> Cr-Commit-Position: refs/heads/master@{#69097}
-
Marja Hölttä authored
As a downside, class-level static variables of FutexEmulation now have to be local to the .cc file. Bug: v8:10239 Change-Id: I3d00c65289f346cf2b16fea657f47bff69863b0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2319989Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
R=clemensb@chromium.org Bug: chromium:1110190 Change-Id: I75c8e47d738266927d717a09670473dc8a7eb210 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320656Reviewed-by:
-
Anton Bikineev authored
Bug: v8:10724 Change-Id: Ia0b6d6d25e6b9d7b44b4dfa94705e9cd5103cc8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316303Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#69094}
-
Zeynep Cankara authored
This CL use the introduce color variables to adapt light theme feature to increase accessibility. Bug: v8:10644 Change-Id: I179831aef384527b0457c6ae93fa4d42a1814834 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2305891 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Leszek Swirski authored
If we're close to a stack overflow when starting a script compile, we may get into a state where main-thread compilation would stack overflow, but background-thread compilation wouldn't. This triggers a failure of a CHECK under --stress-background-compile, but isn't actually an interesting failure. So, we loosen this CHECK to allow the main-thread having a stack overflow (strictly speaking, a RangeError) to count as a "success" for the purposes of comparing against a background compilation success. Bug: v8:10757 Change-Id: I7d687b52d178973b421c42ca0d89b4da0357232a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320649 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#69092}
-
Jakob Gruber authored
As an experiment to see how performance is impacted when changing inline definitions to normal definitions in a .cc file, this CL moves js-function-inl.h to js-function.cc. Bug: v8:10749 Change-Id: I97c3a0b7d20217f444c6891442bbe3c34f3b0cc9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2315993 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Isolate::PromiseHasUserDefinedRejectionHandler no longer descends recursively the outer_promise chain but uses an std::stack to avoid stack overflows with very long promise chains. Change-Id: Icdf86a34d89b734adc7139357b2ba6b37a7882ad Bug: chromium:1096139 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316298Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#69090}
-
Zhao Jiazhong authored
Port b64cede5 https://crrev.com/c/2289970 Port 5de28709 https://crrev.com/c/2316304 Change-Id: Ia4e24558b10adef196ab167137a9a5b6db98754b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2321950Reviewed-by:
-
Clemens Backes authored
If multiple isolates were involved, we did not always hit the breakpoint reliably in all isolates. This CL fixes this flake this via two changes: 1. Remove breakpoint info when tiering up. If we keep the breakpoint information, a second isolate that later sets the same breakpoint will see that the breakpoint already exists, and will not set it again, even though the code containing the breakpoint has been replaced at that point. This fixes a flake in the debug/wasm/breakpoints test. 2. Don't overwrite code with breakpoints by default "tiered down" code. This is achieved by introducing another state in the {ForDebugging} enum which marks that code contains breakpoints. Otherwise it could happen that two isolates start tiering down (both recompiling missing functions in Liftoff), one isolate finishes and immediately sets a breakpoint, then the other isolates finishes and overwrites the code with breakpoints by the usual {kForDebugging} code. Setting breakpoints is synchronized already, so overwriting breakpoint code with other breakpoint code is always safe. R=thibaudm@chromium.org Bug: v8:10611, v8:10359 Change-Id: I171d86b110a54f9eb5e4c3fa35108638904212e8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316080 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Clemens Backes authored
This follows https://crrev.com/c/2317298. TBR=machenbach@chromium.org No-Try: true Change-Id: I26608a7234145ac1f6cd234024054fc372946d3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320652 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5383c9f..483d965 Rolling v8/third_party/aemu-linux-x64: BSmiob0gPivtoM5FO4ByhQHofOIKJ7KxRVPyfzhrjTkC..nz3cLclK4lWm6gzvGCOHPQAKJUO8EsMBr7EIUXwS9SEC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/0606ae6..d292e89 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic65daec89acb3be7fc901e198cdcf175080ad339 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2321589Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#69086}
-
- 27 Jul, 2020 20 commits
-
-
Paolo Severini authored
Currently, when running with --trace-turbo, V8 generates a different .json file for each wasm-to-js thunk that it compiles, but these files all have the same name "turbo-wasm-to-js-0.json", and only one file is generated. This makes it difficult to actually examine the difference in the IR for this call wrappers produced for different signatures. This patch fixes this by naming each trace file as: "wasm-to-js-<kind>-<signature>-0.json", like for example "turbo-wasm-to-js-5-ii-i-0.json". Change-Id: Iebb73829cddd4f6bbf9d02ed1ce94a80dcfa5ca7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316834 Commit-Queue: Paolo Severini <paolosev@microsoft.com> Reviewed-by:
-
Shu-yu Guo authored
This reverts commit ce249dbb. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/32375 Original change's description: > [torque] Port some constructor builtins to Torque. > > - FastNewFunctionContextEval > - FastNewFunctionContextFunction > - CreateEmptyLiteralObject > - CreateRegExpLiteral > - CreateEmptyArrayLiteral > - CreateShallowArrayLiteral > - CreateShallowObjectLiteral > - NumberConstructor > - ObjectConstructor > - GenericLazyDeoptContinuation > > Bug: v8:9891 > > Change-Id: Idd4bf035d8dbeec03b9ef727e1bfb80eab4bc43c > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2311411 > Commit-Queue: Bill Budge <bbudge@chromium.org> > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69082} TBR=bbudge@chromium.org,jgruber@chromium.org,leszeks@chromium.org,tebbi@chromium.org Change-Id: I76272a4d439ef95213fdfb659bdbcb71e16daec6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9891 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2321111Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#69084}
-
Michael Achenbach authored
Updating was prepared on depot_tools side by https://crbug.com/1098560. No-Try: true Bug: v8:10619 Change-Id: If24aec3344e83857c09ce165be4203846b3a91b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316302Reviewed-by:
Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#69083}
-
Bill Budge authored
- FastNewFunctionContextEval - FastNewFunctionContextFunction - CreateEmptyLiteralObject - CreateRegExpLiteral - CreateEmptyArrayLiteral - CreateShallowArrayLiteral - CreateShallowObjectLiteral - NumberConstructor - ObjectConstructor - GenericLazyDeoptContinuation Bug: v8:9891 Change-Id: Idd4bf035d8dbeec03b9ef727e1bfb80eab4bc43c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2311411 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Shu-yu Guo authored
This reverts commit 482c3bbf. Reason for revert: Test failure https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/29160? Original change's description: > [Intl] Sync Intl.Segmenter to latest version > > https://tc39.es/proposal-intl-segmenter/ > > TC39 passed Intl.Segmenter to stage 3 in Jul 21. > This CL move our earlier prototype to the current spec. > > Bug: v8:6891 > Change-Id: I07234beed54f671c26bdbfb3983c5bc2fa5a29b0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219413 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Frank Tang <ftang@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#69080} TBR=jkummerow@chromium.org,tebbi@chromium.org,ftang@chromium.org,syg@chromium.org Change-Id: I1488d5fd50012c5e8873a4fed2fa7638d86d5c6a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6891 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320741Reviewed-by:
-
Frank Tang authored
https://tc39.es/proposal-intl-segmenter/ TC39 passed Intl.Segmenter to stage 3 in Jul 21. This CL move our earlier prototype to the current spec. Bug: v8:6891 Change-Id: I07234beed54f671c26bdbfb3983c5bc2fa5a29b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2219413Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#69080}
-
Andreas Haas authored
R=thibaudm@chromium.org Change-Id: I77711801a94ff8d57d66f2057b78a0d10521bbf1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320648Reviewed-by:
-
Sigurd Schneider authored
Currently, only a scriptURL is reported, which can be over-written by sourceURL comments of the script. This means a script can basically claim to come from anywhere. This means that DevTools doesn't know the resource name the embedder provided if there is a sourceURL comment. This CL adds a `embedderName` field to the scriptParsed and scriptFailedToParse events that reports the name the embedder associated with the script. Bug: chromium:974543 Change-Id: I9863f878f57638174847890d9a3818952b1efc27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317310 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#69078}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/bdbc779..5383c9f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/342ad52..0606ae6 Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/89bddfe..103247f TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8a016265af2d1426e35ba6aa3a8fcf8f702c31d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320429Reviewed-by:
-
Santiago Aboy Solanes authored
When we add safepointing, the source position address might change. Then, we need to use the handlified version for both concurrent-inlining and not. The logic for retrieving the Handle can be encapsulated in the BytecodeArrayRef, which can be reused in the other source_position_* methods. Bug: v8:7790 Change-Id: I3e5f937eb06153449cf6f720a2a4321cb338d903 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316301Reviewed-by:
-
Sathya Gunasekaran authored
This flag's name is slightly incorrect as it is possible to have more maps than this in the feecback vector. This flag doesn't account for deprecated maps in the feedback vector. To make this explicit, we change the flag to indicate that this only counts valid maps. Bug: v8:10582 Change-Id: Ib0cc425a03d590bb21184fc6b104d0ebee1d5b03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2319992Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69075}
-
Dominik Inführ authored
AllocateRaw(Aligned|Unaligned) will now refill LAB first and then invoke AllocateFast(Aligned|Unaligned) again. Bug: v8:10315 Change-Id: Ifa6e645b33a0c57a118de9cc15b0a38ad407a0c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2319991Reviewed-by:
-
Andreas Haas authored
R= ulan@chromium.org Bug: chromium:1104580 Change-Id: I5824de7aa4c71b1464fc8b2c35375bcb5d84f2e9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2320329Reviewed-by:
-
Marja Hölttä authored
This test should've been rewritten in the last batch rewrite but wasn't. Bug: v8:10239 Change-Id: Ic2949e6282f72975898ab7e9aefe3210bba71fbf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2319988 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 06bdd8d6 R=thibaudm@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I35cf8d96c542da6db840f90d30b3a77a8925fafb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2313316Reviewed-by:
-
Dominik Inführ authored
Change-Id: Ia071e8cfcb021ff7e80888370cafcc58c6cb0fca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317947 Auto-Submit: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#69070}
-
Tobias Tebbi authored
When mksnapshot fails on a static assert in Torque, print the statement and position from the Torque source. To enable special treatment, change the syntax of static asserts in Torque from StaticAssert() to static_assert() to align with assert() and check() statements. Bug: v8:7793 Change-Id: Idda8e3c342bdcefc893ff297f8d7727d2734c221 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317314 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#69069}
-
Santiago Aboy Solanes authored
This CL allows LocalHandles to be dereferenced by the same thread that created them, even if we have a DisallowHandleDereference scope. Bug: v8:7790 Change-Id: Ie227aaa4152c887d0d9c913dfa35217166726614 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2316111Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#69068}
-
Manos Koukoutos authored
Change-Id: I29ab5285b3284ebecb97902703f5f1c0cc8f8961 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317354Reviewed-by:
-
Zeynep Cankara authored
This CL adds a generic Event Class to unify common methods of IC and Map events. The Entry Class for IC Events and V8Map Class for Map Events inherits from this generic Event Class. Bug: v8:10644, v8:10735 Change-Id: I77d68fb40ee0ffbe297fcd1a13c3e2b746938168 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2317309 Commit-Queue: Zeynep Cankara <zcankara@google.com> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69066}
-
