- 03 Jul, 2020 7 commits
-
-
Dan Elphick authored
To get the Isolate from a HeapObject, rather than masking off the MemoryChunk and then loading the heap from the MemoryChunk (which won't work when RO_SPACE is shared between Isolates), get the Isolate by masking off the bottom 32 bits and apply the Isolate bias. Also fixes up a stale comment and makes several methods in RootsTable and Isolate const to support this change. Bug: v8:10454 Change-Id: I5f8eb873d8486b699460223dbe3454a5dcf1854f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280088 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#68671}
-
Ross McIlroy authored
After r68405 reduced the default stack size on Arm64 a couple of tests hit stack limits on the Arm64 android bots. Reduce the argument count on these tests to avoid this issue. BUG=chromium:1099623 Change-Id: I8957043b74bd416bb78223599b1a661a4887f54a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280095 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#68670}
-
Igor Sheludko authored
Bug: v8:10506 Change-Id: I9405616566aaec47bfc47cfe2290dc6953e532ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280082 Auto-Submit: Igor Sheludko <ishell@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:
Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#68669}
-
Manos Koukoutos authored
Change-Id: I991bcb5bc8a266ed4caa9ad4e8cb31fa6d30eef9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275966Reviewed-by:
-
Dominik Inführ authored
Introduce explicit fast path for allocation in PagedSpace. The slow path is moved into AllocateRawSlow which refills the LAB and retries the allocation. Reland of https://crrev.com/c/2277808, reverted because it broke the MSAN build in https://crrev.com/c/2275969. Bug: v8:10315 Change-Id: I7a3d32525fa12ea672c62f6297c92aaafc3d8157 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280081Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#68667}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cee6c15..a0f6c1b Rolling v8/third_party/aemu-linux-x64: NwKjfDOL_ugbEGGNcm2u6NzakaOJ9ad36bFd7bUVpXIC..sKz_Oq5M4tmZVE7eggzuhtTiKK3JNyylo9pt0tGLCg4C Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7bb44ab..447d835 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5b2ab91cadf0856b453eab0ff4528022b56b5f5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280445Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#68666}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I1c844768e09095ad85396f1752420b616048ec36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2278473 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#68665}
-
- 02 Jul, 2020 22 commits
-
-
Z Nguyen-Huu authored
The change instruments code generation for Gap Solver so that these counters are run-time and didn't impact register allocation. The implementation is put behind a flag to help better register allocation analysis. Bug: v8:10663 Change-Id: Ia342d990e2b2bfc6a7653a770f670e51eef71312 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2269362 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Seth Brenith <seth.brenith@microsoft.com> Cr-Commit-Position: refs/heads/master@{#68664}
-
Michael Lippautz authored
This adds Google benchmark for microbenchmarking C++ code as an optional dependency. To enable, add the following to the .gclient before syncing "custom_vars": { "checkout_google_benchmark": True } Change-Id: Id0eab772dd71558906658ef4bb60e31acd665948 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275964Reviewed-by:Hannes Payer <hpayer@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#68663}
-
Milad Farazmand authored
Fix GCC build because of missing header: template argument deduction/substitution failed: ../../third_party/inspector_protocol/crdtp/protocol_core.cc:123:8: note: candidate expects 3 arguments, 4 provided }); Change-Id: If977c6afc3f20c2faf40e02672b04e9679c1fda7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280243Reviewed-by:Yang Guo <yangguo@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#68662}
-
Michael Lippautz authored
Split off ConservativeMarkingVisitor from MarkingVisitor. After this change, MarkingVisitor and ConservativeMarkingVisitor are types that are instantiated with Marking and merely forward to MarkingState accrodingly. The two marking-related visitors can be passed along as interface types cppgc::Visitor and ConservativeTracingVisitor, respectively. Change-Id: Iad103dc3053c61d1a104a8802edd420d21cdf935 Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270538 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Split off MarkingState from MarkingVisitor. With this CL the marking implementation is moved to "MarkingState" which is the new bottleneck for marking a single object. MarkingVisitor merely forwards to MarkingState, which knows how to set the markbit and add the object to the worklist accordingly. This allows to have a "UnifiedHeapMarkingVisitor" in future which can easily reuse Marking to provide C++ marking. Change-Id: I87ebbe37e8e8cd841e872cae9dc3490e2b55c4dd Bug: chromium:1056170 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270172Reviewed-by:
-
Manos Koukoutos authored
Also shuffle HeapType helper functionality a bit Bug: chromium:1101629, v8:7748 Change-Id: I7c27dc96f02173c73dbac7b518e7936e4e0d5bf3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275965Reviewed-by:
-
Thibaud Michaud authored
R=ahaas@chromium.org Bug: v8:7431 Change-Id: Ie416ea6048ffed792225822b053aa3ed37aa4919 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2278468Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/master@{#68658}
-
Andrey Kosyakov authored
Note that changes in test expectation come from a more verbose error diagnostics for expected errors around input parameter validation. Original change: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/2270757 Bug: chromium:1099809 Change-Id: I4fc2efc9c89d0af645dad937d719fa36e1d33489 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277142Reviewed-by:
-
Seth Brenith authored
Currently, FindOptimalSpillingPos uses GetSpillState on the loop header block when attempting to find the live range that covers the top of the loop. However, GetSpillState represents the state at the end of a block, and is not written until the allocator leaves the block. So when `pos` is within the loop header block, FindOptimalSpillingPos is incorrectly recommending a split rather than recommending a spill of the live range covering the loop top. This change implements a better search for the live range that covers the beginning of the loop. Bug: v8:10606 Change-Id: I454a009b5806d1a01ee59d6d34b9e9ef8784d294 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274308Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Georgia Kouveli authored
Using x16/x17 for tail calls allows us to use a "BTI c" instead of "BTI jc" landing pad. This means that we cannot enter functions with a jump to a register other than x16/x17 anymore. Bug: v8:10026 Change-Id: If5af1af861acc19f9e0dfc19c38d6a57a6fb6b6d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276049Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com> Cr-Commit-Position: refs/heads/master@{#68655}
-
Maya Lekova authored
This reverts commit 099b1cf3. Reason for revert: Fails on MSAN - https://ci.chromium.org/p/v8/builders/ci/V8%20Clusterfuzz%20Linux%20MSAN%20no%20origins/16034? Original change's description: > [heap] Introduce fast path in PagedSpace::AllocateRaw > > Introduce explicit fast path for allocation in PagedSpace. The slow path > is moved into AllocateRawSlow which refills the LAB and retries the > allocation. > > Bug: v8:10315 > Change-Id: I807e56ccde833b0e9a42166b4883c1978d01e828 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277808 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68653} TBR=ulan@chromium.org,dinfuehr@chromium.org Change-Id: I11ce25da69a24a0a5ccc5e0324d1dfe71cdeaca0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:10315 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2275969Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#68654}
-
Dominik Inführ authored
Introduce explicit fast path for allocation in PagedSpace. The slow path is moved into AllocateRawSlow which refills the LAB and retries the allocation. Bug: v8:10315 Change-Id: I807e56ccde833b0e9a42166b4883c1978d01e828 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277808Reviewed-by:
-
Manos Koukoutos authored
- Adapt subtyping unittest to the new HeapType API - Generalize WASM_REF_TYPE macro Bug: v8:7748 Change-Id: Ifdb24408d7a34a6470ddccdf3dc8536cbb93dece Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274610 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Dominik Inführ authored
Restructure code to make slow path of allocation more obvious. Bug: v8:10315 Change-Id: Ic3e3b866b144b6f2877acac4accf87377f757172 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276273 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
-
Clemens Backes authored
This moves some more tracing functionality into the {TraceLine} helper, such that for most operations we only need to instantiate a {TraceLine} object via its constructor and be done with it. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: Ide368d4a52768089a23744b9e1e25df4b8fed2ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276275 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Santiago Aboy Solanes authored
Bug: v8:7790 Change-Id: I1b9116529575f56c890f93488a0ffdebfdfe5763 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2260873 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Santiago Aboy Solanes authored
Call synchronized_instance_descriptors only once in LookupTransition to make sure we have the same DescriptorArray in the method. Bug: v8:7790 Change-Id: Ie2a610d9c1229f7f467f56365498b89f078d6347 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2278043 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
zeynepCankara authored
This CL does attempt to modify Map Panel to ensure it follows web component standards. Change-Id: I1432d536d77233b6b8c45ff92dc8aba127f93510 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276044Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#68647}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: Ib5beeb55c3a9eba8fb23680e3845f80d55f3f154 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274633 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Change-Id: I24c70265bca0f6c5c9c55fabfa81eb34f2994407 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2278042Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#68645}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/29bc352..cee6c15 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/6099f10..6b2a302 Rolling v8/buildtools/linux64: git_revision:7d7e8deea36d126397bda2cf924682504271f0e1..git_revision:cd3869be2477f7ee1aa3f27f43ee934e74722dfb Rolling v8/third_party/aemu-linux-x64: OQ8c-S6dNd0LdVeElhAYBgsHeiiM4xyJ8E6hy3pRIUMC..NwKjfDOL_ugbEGGNcm2u6NzakaOJ9ad36bFd7bUVpXIC Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/3f5d1ca..7bb44ab Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/fdd2cd6..95099f4 TBR=machenbach@chromium.org,tmrts@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I58603a49de4941abc054b659ebe39a7dfce5c09d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2278769Reviewed-by:
-
Deepti Gandluri authored
- Add wasm opcode, decode and compiler code for v128.const - Add codegen implementations for v128.const on x64/Arm64 - Reuse/Rename some shuffle specific methods to handle generic 128-bit immediates - Tests Bug: v8:8460 Change-Id: Idc365c8f6402c13259400eac92e0b75bd0f991a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276176 Commit-Queue: Deepti Gandluri (OOO Till November) <gdeepti@chromium.org> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Reviewed-by:
-
- 01 Jul, 2020 11 commits
-
-
Jakob Kummerow authored
No changes, just rebasing. Original review: https://chromium-review.googlesource.com/c/v8/v8/+/2277889 Bug: v8:7748 Change-Id: Iea3bc881eaab28b14d4e2af9892ee74848c59f04 Tbr: ahaas@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2278463Reviewed-by:
-
Jakob Kummerow authored
This reverts commit 3f74ece9. Reason for revert: build breakage, rebasing issue Original change's description: > [wasm-gc] Implement ref.test and ref.cast > > Bug: v8:7748 > Change-Id: If0023edf2f27448c605bd8aa6402bf76c7983a6e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277889 > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#68640} TBR=jkummerow@chromium.org,ahaas@chromium.org Change-Id: Idd4eee1711aed3c0a9f89a36793738c72a34c783 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7748 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2278462Reviewed-by:
-
Jakob Kummerow authored
Bug: v8:7748 Change-Id: If0023edf2f27448c605bd8aa6402bf76c7983a6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277889Reviewed-by:
-
Santiago Aboy Solanes authored
What we need is a multiple readers single writer (MRSW) lock. The main thread is the only one that is going to be writing, while the readers might be either the main thread or background threads. The shared_mutex is in the isolate itself, so that different isolates will not block each other. Bug: v8:7790 Change-Id: Idd6bb1826bd0cc6279df1c0694a84e00d53a7eae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2241513 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Clemens Backes authored
This CL mostly removes code paths which join again after a big switch. Instead of updating a local variable (for the length of the decoded operation), and then breaking out of the switch just to return the value of that local variable, we now just return directly from within the switch. This will allow to 1) split the switch into individual methods per opcode, and 2) tail-call to helpers like {BuildSimpleOperator} or {DecodeNumericOpcode}. R=thibaudm@chromium.org Bug: v8:10576 Change-Id: I466068d3566c6bff8bd3ac78a2bba60c3663dd52 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2276274 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: -
Kim-Anh Tran authored
This makes the 4GB max length compilable for 32 bit MSVC. Bug: chromium:1095721 Change-Id: I2be9f69668687f18beb86028debb3fd5ff350202 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2272558Reviewed-by:
-
Victor Gomes authored
This changes the default scope info for SyntheticFunctionContexts to the EmptyScopeInfo which does not contain an extension slot. The bug happened because, previously, the native context scope info was used as dummy. Change-Id: I4d6bf6918c11c79201d16bde99ed76800ad6f6c5 Bug: v8:10629 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277806 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#68636}
-
Georg Neis authored
Also fix a typo in a log message. Change-Id: I247e5347b7f7d71b08630489896da463dd76b8a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277885 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#68635}
-
Clemens Backes authored
We spawn individual tests in their own shell, and then just kill that shell later. This often leaves the tests running (see linked bugs). By spawning the shell in its own new process group, we can just kill that whole process group later, which seems to work reliably for hanging tests. R=machenbach@chromium.org Bug: v8:8292, v8:8700 Change-Id: I6e38467d687cc0b395467d4b377644de7700f066 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274634Reviewed-by:
-
Manos Koukoutos authored
Motivation: We used to approximate s33/i33 value parsing by first checking for specific negative codes, and then parsing an u32 value if that failed. This is not correct in all cases. Changes: - Implement i33 parsing in Decoder. - Factor out parsing of heap types into read_heap_type. - Introduce HeapType::kBottom. - Introduce helper functions in WasmFeatures and value_type_reader. - Remove macros from the parsing of value types. - HeapType::code now returns an i32 for compatibility with the i33 requirement. - Introduce HeapType::Repr. - Renamings: HeapType::type() -> representation(), ValueType::heap() -> heap_representation() Bug: v8:7748 Change-Id: I04deabce8837a48af2226411cd706a397f9e5725 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2274118 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: -
Marja Hölttä authored
It's actually not an atomic variable, just raw memory, so this is technically not correct. However, the expert advice is to do this until atomic_ref is available. Change-Id: I4b74aa7123ed6ffeb2a06800c35b03e428861e80 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270162 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
