1. 23 Nov, 2018 7 commits
    • Jakob Kummerow's avatar
      [ubsan] Port HashTableBase and subclasses to the new design · a1c88a44
      Jakob Kummerow authored
      Bug: v8:3770
      Change-Id: I9a3f289ac6236b88476167150565e8183d6f5461
      Reviewed-on: https://chromium-review.googlesource.com/c/1345326
      Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
      Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
      Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57764}
      a1c88a44
    • Yang Guo's avatar
      Revert "[heap] Release dead young generation large objects in the Scavenger." · 33713b5b
      Yang Guo authored
      This reverts commit 40b448ea.
      
      Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win64/27711
      
      Original change's description:
      > [heap] Release dead young generation large objects in the Scavenger.
      > 
      > Bug: chromium:852420
      > Change-Id: Ieefbee7bfd625d62e9104950bdfa8e46d5f4270a
      > Reviewed-on: https://chromium-review.googlesource.com/c/1348081
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Commit-Queue: Hannes Payer <hpayer@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#57761}
      
      TBR=ulan@chromium.org,hpayer@chromium.org
      
      Change-Id: I6b57dd8ed92d85b5ce012da754611278ceaefe20
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:852420
      Reviewed-on: https://chromium-review.googlesource.com/c/1349270Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57763}
      33713b5b
    • Yang Guo's avatar
      Update WATCHLIST wrt yangguo · 5fc7356c
      Yang Guo authored
      R=jgruber@chromium.org
      
      Change-Id: I49c08217d0c8e452afe84ad76ae6d60367802e82
      Reviewed-on: https://chromium-review.googlesource.com/c/1348075Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57762}
      5fc7356c
    • Hannes Payer's avatar
      [heap] Release dead young generation large objects in the Scavenger. · 40b448ea
      Hannes Payer authored
      Bug: chromium:852420
      Change-Id: Ieefbee7bfd625d62e9104950bdfa8e46d5f4270a
      Reviewed-on: https://chromium-review.googlesource.com/c/1348081Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Hannes Payer <hpayer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57761}
      40b448ea
    • Dan Elphick's avatar
      Reland "[cleanup] Move methods to V8_DEPRECATED" · 83fb2f8d
      Dan Elphick authored
      This is a reland of a6e3cdd9
      
      Now only changes ObjectTemplate::NewInstance.
      
      Original change's description:
      > [cleanup] Move methods to V8_DEPRECATED
      >
      > Updates ObjectTemplate::NewInstance and FunctionTemplate::GetFunction
      > from V8_DEPRECATED_SOON to V8_DEPRECATED, now that they're unused in
      > chrome.
      >
      > Bug: v8:7294, v8:7295, v8:8238
      > Change-Id: Ic7cb2c410ff812f73cfd108551f2a1a20722df07
      > Reviewed-on: https://chromium-review.googlesource.com/c/1344151
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Commit-Queue: Dan Elphick <delphick@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#57657}
      
      Bug: v8:7294, v8:7295, v8:8238
      Change-Id: I52ec021bc92600f67cf27791d5b2df2a4342a4d5
      Reviewed-on: https://chromium-review.googlesource.com/c/1348079Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
      Commit-Queue: Dan Elphick <delphick@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57760}
      83fb2f8d
    • Yang Guo's avatar
      Revert "[heap] Improve embedder tracing during incremental marking" · cb93a308
      Yang Guo authored
      This reverts commit caed2cc0.
      
      Reason for revert: Breaks layout tests, e.g.
      
      https://test-results.appspot.com/data/layout_results/V8-Blink_Linux_64__dbg_/14924/webkit_layout_tests%20%28with%20patch%29/layout-test-results/results.html
      
      crash log for renderer (pid <unknown>):
      STDOUT: <empty>
      STDERR: 
      STDERR: 
      STDERR: #
      STDERR: # Fatal error in ../../v8/src/base/platform/elapsed-timer.h, line 24
      STDERR: # Debug check failed: !IsStarted().
      STDERR: #
      STDERR: #
      STDERR: #
      STDERR: #FailureMessage Object: 0x7ffc46707640#0 0x565409263b6f base::debug::StackTrace::StackTrace()
      STDERR: #1 0x56540a8a32fb gin::(anonymous namespace)::PrintStackTrace()
      STDERR: #2 0x56540a8980d8 V8_Fatal()
      STDERR: #3 0x56540a897e35 v8::base::(anonymous namespace)::DefaultDcheckHandler()
      STDERR: #4 0x565407971f02 v8::base::ElapsedTimer::Start()
      STDERR: #5 0x565407d08edf v8::internal::TimedHistogram::Start()
      STDERR: #6 0x565407e500d5 v8::internal::IncrementalMarking::AdvanceIncrementalMarkingOnAllocation()
      STDERR: #7 0x565407e4f977 v8::internal::IncrementalMarking::Observer::Step()
      STDERR: #8 0x565407e48092 v8::internal::AllocationObserver::AllocationStep()
      STDERR: #9 0x565407eb0751 v8::internal::SpaceWithLinearArea::InlineAllocationStep()
      STDERR: #10 0x565407eb3e44 v8::internal::NewSpace::EnsureAllocation()
      STDERR: #11 0x565407e258ff v8::internal::NewSpace::AllocateRaw()
      STDERR: #12 0x565407e06b2d v8::internal::Heap::AllocateRaw()
      STDERR: #13 0x565407e432ef v8::internal::Heap::AllocateRawWithLightRetry()
      STDERR: #14 0x565407e433cf v8::internal::Heap::AllocateRawWithRetryOrFail()
      STDERR: #15 0x565407e04d48 v8::internal::Factory::NewFixedArrayWithFiller()
      STDERR: #16 0x565407fd6339 v8::internal::HashTable<>::New()
      STDERR: #17 0x565407fd7be8 v8::internal::HashTable<>::EnsureCapacity()
      STDERR: #18 0x565407fc7e95 v8::internal::Dictionary<>::Add()
      STDERR: #19 0x565407fcf453 v8::internal::BaseNameDictionary<>::Add()
      STDERR: #20 0x565407f89ee4 v8::internal::LookupIterator::ApplyTransitionToDataProperty()
      STDERR: #21 0x5654080036e2 v8::internal::Object::AddDataProperty()
      STDERR: #22 0x56540793061f v8::internal::(anonymous namespace)::DefineDataProperty()
      STDERR: #23 0x56540792da59 v8::internal::(anonymous namespace)::InstantiateObject()
      STDERR: #24 0x56540792b75a v8::internal::(anonymous namespace)::InstantiateFunction()
      STDERR: #25 0x56540792b4db v8::internal::ApiNatives::InstantiateFunction()
      STDERR: #26 0x5654079594bf v8::FunctionTemplate::GetFunction()
      STDERR: #27 0x56540a7af74e blink::V8ObjectConstructor::CreateInterfaceObject()
      STDERR: #28 0x56540a7afe01 blink::V8PerContextData::ConstructorForTypeSlowCase()
      STDERR: #29 0x56540a7afdd6 blink::V8PerContextData::ConstructorForTypeSlowCase()
      STDERR: #30 0x56540a7afdd6 blink::V8PerContextData::ConstructorForTypeSlowCase()
      STDERR: #31 0x56540a7afcb4 blink::V8PerContextData::CreateWrapperFromCacheSlowCase()
      STDERR: #32 0x56540a7aef73 blink::V8DOMWrapper::CreateWrapper()
      STDERR: #33 0x56540a7abf6b blink::ScriptWrappable::Wrap()
      STDERR: #34 0x56540a677199 blink::V8Document::documentElementAttributeGetterCallback()
      STDERR: #35 0x565407a0aec3 v8::internal::FunctionCallbackArguments::Call()
      STDERR: #36 0x565407a097be v8::internal::(anonymous namespace)::HandleApiCallHelper<>()
      STDERR: #37 0x565407a0877b v8::internal::Builtins::InvokeApiFunction()
      STDERR: #38 0x565407fe785a v8::internal::Object::GetPropertyWithAccessor()
      STDERR: #39 0x565407fe697e v8::internal::Object::GetProperty()
      STDERR: #40 0x565407ec8c71 v8::internal::LoadIC::Load()
      STDERR: #41 0x565407ed6401 v8::internal::__RT_impl_Runtime_LoadIC_Miss()
      STDERR: #42 0x5654087593f2 <unknown>
      STDERR: [16162:16185:1122/143518.356897:WARNING:crash_handler_host_linux.cc(341)] Could not translate tid, attempt = 1 retry ...
      
      
      Original change's description:
      > [heap] Improve embedder tracing during incremental marking
      > 
      > Add a path into embedder tracing on allocation. This is safe as as Blink
      > is not allowed to call into V8 during object construction.
      > 
      > Bug: chromium:843903
      > Change-Id: I5af053c3169f5a33778ebce5d7c5c43e4efb1aa4
      > Reviewed-on: https://chromium-review.googlesource.com/c/1348749
      > Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
      > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#57757}
      
      TBR=ulan@chromium.org,mlippautz@chromium.org
      
      Change-Id: Ide2c0b284b52bee17573adcc89f14be4e40dab91
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: chromium:843903
      Reviewed-on: https://chromium-review.googlesource.com/c/1349189Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
      Commit-Queue: Yang Guo <yangguo@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#57759}
      cb93a308
    • v8-ci-autoroll-builder's avatar
      Update V8 DEPS. · c1b527f8
      v8-ci-autoroll-builder authored
      Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/05ea63b..cd7b727
      
      Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/aa21a92..4ed4737
      
      Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/d66dad7..25c4fce
      
      TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org
      
      Change-Id: Id8608976646cb19b61698a6bc824977c5d55357a
      Reviewed-on: https://chromium-review.googlesource.com/c/1349110
      Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
      Reviewed-by: 's avatarv8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#57758}
      c1b527f8
  2. 22 Nov, 2018 33 commits