Commits · a1bf04483824972013f80a9c7e497740d2ebab10 · Linshizhi / V8

28 Aug, 2013 22 commits

Fix Visual Studio debug build after r16398. · a1bf0448

bmeurer@chromium.org authored Aug 28, 2013

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/23624006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16399 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a1bf0448

Reland "Add Chromium-style TimeDelta, Time and TimeTicks classes, and a new ElapsedTimer class." · e2b45253

bmeurer@chromium.org authored Aug 28, 2013

These classes are meant to replace OS::Ticks() and OS::TimeCurrentMillis(),
which are broken in several ways. The ElapsedTimer class implements a
stopwatch using TimeTicks::HighResNow() for high resolution, monotonic
timing.

Also fix the CpuProfile::GetStartTime() and CpuProfile::GetEndTime()
methods to actually return the time relative to the unix epoch as stated
in the documentation (previously that was relative to some arbitrary
point in time, i.e. boot time).

BUG=v8:2853
R=machenbach@chromium.org

Review URL: https://codereview.chromium.org/23469013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16398 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e2b45253

Reuse AddFastPropertyUsingMap in AddFastProperty · 9d0b1590

verwaest@chromium.org authored Aug 28, 2013

R=bmeurer@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23465008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16397 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9d0b1590

Merge verbatim descriptors from other (the descriptor of the map being... · 652b174c

verwaest@chromium.org authored Aug 28, 2013

Merge verbatim descriptors from other (the descriptor of the map being updated) rather than this (descriptors of the most updated map found in the transition tree).

BUG=v8:2863
R=svenpanne@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23676003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16396 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

652b174c

Simplify logic by extracting local lookup before the switch. · 24bbfdfa

verwaest@chromium.org authored Aug 28, 2013

R=rossberg@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22901034

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16395 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

24bbfdfa

Fix lost store side effects with escape analysis. · 3b616a74

mstarzinger@chromium.org authored Aug 28, 2013

This preserves side effects from stores in HCapturedObject markers so
that simulates following these markers are not merged away.

R=titzer@chromium.org
TEST=mjsunit/compiler/escape-analysis --deopt-every-n-times [3,6,9]

Review URL: https://codereview.chromium.org/23554003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16394 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

3b616a74

Insert allocation memento clear instructions after the dominating allocate instruction. · 65843dbf

hpayer@chromium.org authored Aug 28, 2013

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23672004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16393 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

65843dbf

Replace OS::NumberOfCores() with CPU::NumberOfProcessorsOnline(). · caca2b32

bmeurer@chromium.org authored Aug 28, 2013

The name NumberOfCores is misleading, as it does not return the
actual number of cores. While NumberOfProcessorsOnline is also
not a great name, it's at least consistent with the operating
system terminology.

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23655004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16392 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

caca2b32

Revert "Add Chromium-style TimeDelta, Time and TimeTicks classes, and a new ElapsedTimer class." · 1d3f6815

bmeurer@chromium.org authored Aug 28, 2013

This reverts commit r16390 for breaking the Windows build. Will
reland fixed version, which also uses the platform/ folder instead
of time/ folder as per offline discussion.

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/23690003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16391 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1d3f6815

Add Chromium-style TimeDelta, Time and TimeTicks classes, and a new ElapsedTimer class. · fa5216a1

bmeurer@chromium.org authored Aug 28, 2013

These classes are meant to replace OS::Ticks() and OS::TimeCurrentMillis(),
which are broken in several ways. The ElapsedTimer class implements a
stopwatch using TimeTicks::HighResNow() for high resolution, monotonic
timing.

Also fix the CpuProfile::GetStartTime() and CpuProfile::GetEndTime()
methods to actually return the time relative to the unix epoch as stated
in the documentation (previously that was relative to some arbitrary
point in time, i.e. boot time).

BUG=v8:2853
R=machenbach@chromium.org, yurys@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16388

Review URL: https://codereview.chromium.org/23295034

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16390 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

fa5216a1

Revert "Add Chromium-style TimeDelta, Time and TimeTicks classes, and a new ElapsedTimer class." · cfb126c5

bmeurer@chromium.org authored Aug 28, 2013

This reverts commit r16388 for breaking build due to merge typo,
will reland with typo fixed.

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/23698002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16389 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

cfb126c5

Add Chromium-style TimeDelta, Time and TimeTicks classes, and a new ElapsedTimer class. · 8faf4d42

bmeurer@chromium.org authored Aug 28, 2013

These classes are meant to replace OS::Ticks() and OS::TimeCurrentMillis(),
which are broken in several ways. The ElapsedTimer class implements a
stopwatch using TimeTicks::HighResNow() for high resolution, monotonic
timing.

Also fix the CpuProfile::GetStartTime() and CpuProfile::GetEndTime()
methods to actually return the time relative to the unix epoch as stated
in the documentation (previously that was relative to some arbitrary
point in time, i.e. boot time).

BUG=v8:2853
R=machenbach@chromium.org, yurys@chromium.org

Review URL: https://codereview.chromium.org/23295034

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16388 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8faf4d42

Mark cpu profiler tests as flaky to avoid tree closing. · f156ae52

machenbach@chromium.org authored Aug 28, 2013

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/23600003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16387 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f156ae52

Fix accidential inclusion of <intrin.h> into namespace v8::internal. · bc4129c7

bmeurer@chromium.org authored Aug 28, 2013

Also cleanup the fallback __cpuid() implementation, and add
a comment about preserving the GOT pointer in case of PIC.

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/23464014

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16386 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bc4129c7

Drop unused and undocumented dummy_ from SaveContext. · f60defde

bmeurer@chromium.org authored Aug 28, 2013

Also remove the obsolte __GNUC_VERSION__ #define.

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23522003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16385 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f60defde

Prepare push to trunk. Now working on version 3.21.6. · f23e3049

verwaest@chromium.org authored Aug 28, 2013

R=jkummerow@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/23494008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16382 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f23e3049

Clear next map word when folding allocations into js arrays. · 4d7375ca

hpayer@chromium.org authored Aug 28, 2013

BUG=
R=mstarzinger@chromium.org, mvstanton@chromium.org

Review URL: https://codereview.chromium.org/22915007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16381 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4d7375ca

Fix compilation with recent MinGW64 versions. · 50f3a993

bmeurer@chromium.org authored Aug 28, 2013

Don't check for WIN32 define. Use V8_OS_* macros whenever
possible, and if not use _WIN32.

BUG=v8:2300
R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/23687003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16380 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

50f3a993

Remove deprecated methods from debugger API · 4f60ee6b

yurys@chromium.org authored Aug 28, 2013

Deleting SetDebugEventListener and SetMessageHandler from v8::Debug. this methods were deprecated in 3.20
https://code.google.com/p/v8/source/browse/branches/3.20/include/v8-debug.h but in fact they have been superseded by SetDebugEventListener2 and SetMessageHandler2 long ago.

BUG=None
R=bmeurer@chromium.org, loislo@chromium.org

Review URL: https://codereview.chromium.org/23576002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16379 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

4f60ee6b

Cosmetic fix wrt to V8_INLINE usage in cpu.cc. · eb64758d

bmeurer@chromium.org authored Aug 28, 2013

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23535003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16378 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

eb64758d

MIPS: Fix return-value from Array.push stub when pushing non-SMI value · b45fa062

plind44@gmail.com authored Aug 28, 2013

Load and update the arrays length in v0 to make sure the length gets
returned correctly when leaving the function.

Add new testcase.

TEST=mjsunit/array-push-non-smi-value

BUG=130022
R=jkummerow@chromium.org, plind44@gmail.com

Review URL: https://codereview.chromium.org/23589002

Patch from fs <fs@opera.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16377 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b45fa062

Introduce PushInt64AsTwoSmis and PopInt64AsTwoSmis macro instructions for X64 · 1e4f4077

haitao.feng@intel.com authored Aug 28, 2013

R=danno@chromium.org

Review URL: https://codereview.chromium.org/22348005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16376 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1e4f4077

27 Aug, 2013 18 commits

MIPS: Eliminate Smi check when changing from Smi to Integer32 · 6d1f0cc2

palfia@homejinni.com authored Aug 27, 2013

Port r16362 (6dd68a5c)

BUG=

Review URL: https://codereview.chromium.org/23462004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16375 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6d1f0cc2

MIPS: Eliminate intentional conversion from Smi to Int32 in HMul · 8a277a79

palfia@homejinni.com authored Aug 27, 2013

Port r16361 (b41ab14c)

Original commit message:
If not all uses of arithmetic binary operation can be truncated to Smi, check if they can be truncated to Int32 which could avoid minus zero check

Fixed DoMulI on X64 to adopt correct operand size when the representation is Smi

Fixed DoMulI on ARM. Constant right operand optimization is based on Integer 32 instead of its representation.

BUG=

Review URL: https://codereview.chromium.org/23644002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16374 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8a277a79

MIPS: cleanup api callbacks now that handles are never returned directly · 03644ab8

palfia@homejinni.com authored Aug 27, 2013

Port r16360 (72401868)

BUG=

Review URL: https://codereview.chromium.org/23604004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16373 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

03644ab8

MIPS: Fix Cluster Fuzz stack frame corruption bug. · 42b63dcb

palfia@homejinni.com authored Aug 27, 2013

Port r16358 (a8a679b9)

BUG=

Review URL: https://codereview.chromium.org/23583004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16372 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

42b63dcb

MIPS: Convert FastNewClosureStub into hydrogen. · 44ab0e15

palfia@homejinni.com authored Aug 27, 2013

Port r16356 (0a0ea300)

BUG=

Review URL: https://codereview.chromium.org/23618007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16371 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

44ab0e15

MIPS: remove old style callbacks · a7be0472

palfia@homejinni.com authored Aug 27, 2013

Port r16354 (559bc02d)

BUG=

Review URL: https://codereview.chromium.org/23479007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16370 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a7be0472

Remove implementation of CpuProfileNode methods deprecated in v8 3.20 · dc670f44

yurys@chromium.org authored Aug 27, 2013

GetTotalTime, GetSelfTime and GetTotalSamplesCount were deprecated in 3.20 (https://code.google.com/p/v8/source/browse/branches/3.20/include/v8-profiler.h) and can be safely removed.

BUG=None
R=bmeurer@chromium.org, loislo@chromium.org

Review URL: https://codereview.chromium.org/23554002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16367 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

dc670f44

Fix definition of V8_*_C() macros. · 5857d951

bmeurer@chromium.org authored Aug 27, 2013

Make V8_INT64_C() and V8_UINT64_C() available in 32-bit mode as well,
so we can write readable constants (base 10) instead of having to
obfuscate them using V8_2PART_UINT64_C().

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/23557002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16366 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

5857d951

Introduce SmiValuesAre31Bits and SmiValuesAre32Bits global predicate functions · b2ca7e0b

haitao.feng@intel.com authored Aug 27, 2013

R=danno@chromium.org

Review URL: https://codereview.chromium.org/22350005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16365 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b2ca7e0b

Fixed HMul::Canonicalize() to support SMI · 6be4e945

jkummerow@chromium.org authored Aug 27, 2013

Same idea for HDiv when the right oeprand is 1

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/23176002

Patch from Weiliang Lin <weiliang.lin2@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16364 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6be4e945

Drop platform-nullos stuff, which was already horribly out-of-date for a long time. · 6b760b92

bmeurer@chromium.org authored Aug 27, 2013

R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/23434004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16363 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6b760b92

Eliminate Smi check when changing from Smi to Integer32 · 6479ea33

verwaest@chromium.org authored Aug 27, 2013

BUG=
R=verwaest@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22824003

Patch from Weiliang Lin <weiliang.lin2@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16362 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6479ea33

Eliminate intentional conversion from Smi to Int32 in HMul · 78881124

verwaest@chromium.org authored Aug 27, 2013

If not all uses of arithmetic binary operation can be truncated to Smi, check if they can be truncated to Int32 which could avoid minus zero check

Fixed DoMulI on X64 to adopt correct operand size when the representation is Smi

Fixed DoMulI on ARM. Constant right operand optimization is based on Integer 32 instead of its representation.

BUG=
R=verwaest@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22600005

Patch from Weiliang Lin <weiliang.lin2@gmail.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16361 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

78881124

cleanup api callbacks now that handles are never returned directly · f55ba6b7

dcarney@chromium.org authored Aug 27, 2013

R=svenpanne@chromium.org
BUG=

Review URL: https://codereview.chromium.org/23588002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16360 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f55ba6b7

Eliminated manual allocation folding in BuildCloneShallowArray. · 6379e5dc

hpayer@chromium.org authored Aug 27, 2013

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/23038003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16359 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

6379e5dc

Fix Cluster Fuzz stack frame corruption bug. · 9d8684f8

hpayer@chromium.org authored Aug 27, 2013

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/23596002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16358 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9d8684f8

Prefill allocated objects with one word fillers if we do not use allocation folding. · 9f8f0c6d

hpayer@chromium.org authored Aug 27, 2013

BUG=
R=mstarzinger@chromium.org, titzer@chromium.org

Review URL: https://codereview.chromium.org/22903027

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16357 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9f8f0c6d

Convert FastNewClosureStub into hydrogen. · 7fea1936

mvstanton@chromium.org authored Aug 27, 2013

BUG=
R=mstarzinger@chromium.org

Review URL: https://codereview.chromium.org/22562002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16356 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

7fea1936