1. 11 Nov, 2016 1 commit
    • jgruber's avatar
      [debug-wrapper] Conditional breaks, locals, evaluate, scopes · b32ee40d
      jgruber authored
      This CL adds support for:
      * conditional breaks in setBreakpoint,
      * locals in frame.local{Count,Name,Value},
      * evaluation on a frame in frame.evaluate,
      * and more detailed scope information in scopeObject.
      
      Uses of several functions that are not covered by the
      inspector protocol and are only used in tests have been removed.
      
      Local handling has been modified to also include arguments as locals.
      Inspector differs in this regard from our FrameDetails in that
      arguments are always shown as locals. Argument-related functions
      were removed.
      
      BUG=v8:5530
      
      Review-Url: https://codereview.chromium.org/2491543002
      Cr-Commit-Position: refs/heads/master@{#40917}
      b32ee40d
  2. 09 Nov, 2016 1 commit
    • littledan's avatar
      Avoid calling out to JS during stack overflow · 5975c47a
      littledan authored
      If an exception is thrown when there is a Promise being created, the Promise
      catch prediction code would call into a part implemented in JavaScript to see if
      the Promise has a catch handler. If it is not possible to call back into JS,
      e.g., due to a stack overflow, then this would lead to a crash. This patch
      "speculates" that, if it's impossible to call back into JavaScript, then the
      error is unhandled, avoding the issue. In a future patch, the catch prediction
      logic should be entirely written in C++, but this patch adds a minimal fix to
      be more friendly to backports.
      
      BUG=chromium:662935
      R=jgruber
      
      Review-Url: https://codereview.chromium.org/2487833002
      Cr-Commit-Position: refs/heads/master@{#40851}
      5975c47a