1. 16 Oct, 2017 1 commit
    • peterwmwong's avatar
      [builtins] Port String.prototype.{padStart, padEnd} to CSA · 33b23529
      peterwmwong authored
      - Extract core StringPrototypeRepeat code into a TFS builtin (StringRepeat)
        - Assumes arguments are a string and smi (no range checks)
      - Add StringPrototypePadStart and StringPrototypePadEnd TFJ builtins
        - Added StringPadAssembler to ensure common behavior
      - Removed functionality from string.js
      
      A quick benchmark shows significant performance gains for unoptimized
      code (2.1x to 2.46x) and optimized code (1.03x - 1.56x).
      
      https: //github.com/peterwmwong/v8-perf/blob/master/string-pad/README.md
      Bug: v8:5049
      Change-Id: I6e4fe99fb62a3edb3d6906fd4f78b3576b5b0d13
      Reviewed-on: https://chromium-review.googlesource.com/720067
      Commit-Queue: Jakob Gruber <jgruber@chromium.org>
      Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#48595}
      33b23529
  2. 06 Jan, 2017 1 commit
    • adamk's avatar
      Include harmony-string-padding.js in the context snapshot · 02149d89
      adamk authored
      The attached chromium bug suggests that turning this on via a flag
      regressed a perf test. Having previously run into slowdowns due
      to experimental JS natives, my suspicion is that this regression
      can be fixed by including the new builtins in the snapshot.
      My intention is to land this patch to see if the regression
      goes away on the bots.
      
      Given the nature of this feature, it seems low-risk to remove
      the runtime flag. If need be, it would be trivial to craft
      a patch to remove these two methods from String.prototype
      if we run into web compat issues during the release (note
      that no release branch has yet picked up this feature).
      
      BUG=v8:4954, chromium:677444
      
      Review-Url: https://codereview.chromium.org/2610853010
      Cr-Commit-Position: refs/heads/master@{#42111}
      02149d89
  3. 27 Apr, 2016 1 commit
  4. 24 Mar, 2016 1 commit