1. 02 May, 2019 1 commit
  2. 27 Jul, 2018 1 commit
  3. 22 Feb, 2018 1 commit
    • Adam Klein's avatar
      ToString of a Proxied function should not throw · f7d7b5c6
      Adam Klein authored
      Without --harmony-function-tostring, anything other than a JSFunction
      or JSBoundFunction throw when Function.prototype.toString is called on
      them. But with the toString revision, anything callable allows toString
      (and for non-Functions returns the good old "function () { [native code] }"
      string).
      
      Bug: v8:7484
      Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
      Change-Id: I3540e213a40992151761b59666fe36e0510da908
      Reviewed-on: https://chromium-review.googlesource.com/932825
      Commit-Queue: Adam Klein <adamk@chromium.org>
      Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#51489}
      f7d7b5c6
  4. 06 Oct, 2017 1 commit
  5. 21 Mar, 2016 1 commit
  6. 17 Mar, 2016 1 commit
  7. 08 Jan, 2016 1 commit
  8. 07 Jan, 2016 1 commit
    • neis's avatar
      [tests] Fix bogus uses of assertThrows. · 837900ef
      neis authored
      Some tests passed a string as second argument to assertThrows, expecting it to
      be matched against the exception.  However, assertThrows simply ignored these.
      (Some other tests actually seem to use that argument as a comment ...)
      
      This CL
      - changes assertThrows to fail if the second argument is not a function,
      - adds assertThrowsEquals which compares the exception to a given value using
        assertEquals
      - fixes some bogus tests that got exposed by this.
      
      R=jarin@chromium.org
      BUG=
      
      Review URL: https://codereview.chromium.org/1544793002
      
      Cr-Commit-Position: refs/heads/master@{#33159}
      837900ef
  9. 17 Dec, 2015 1 commit
  10. 11 Dec, 2015 1 commit
  11. 13 Nov, 2015 1 commit
  12. 12 Nov, 2015 1 commit
  13. 04 Nov, 2015 1 commit
  14. 13 Jul, 2015 1 commit
  15. 15 Jun, 2015 1 commit
  16. 17 Apr, 2015 1 commit
  17. 26 Oct, 2014 1 commit
  18. 07 Aug, 2014 1 commit
  19. 21 Mar, 2014 1 commit
  20. 12 Feb, 2014 1 commit
  21. 26 Feb, 2013 1 commit
    • mstarzinger@chromium.org's avatar
      Make __proto__ a foreign callback on Object.prototype. · ce1e10f5
      mstarzinger@chromium.org authored
      This moves the __proto__ property to Object.prototype and turns it into
      a callback property actually present in the descriptor array as opposed
      to a hack in the properties lookup. For now it still is a "magic" data
      property using foreign callbacks and not an accessor property visible to
      JavaScript.
      
      The second effect of this change is that JSON.parse() no longer treats
      the __proto__ property specially, it will be defined as any other data
      property. Note that object literals still have their special handling.
      
      R=rossberg@chromium.org
      BUG=v8:621,v8:1949,v8:2441
      TEST=mjsunit,cctest,test262
      
      Review URL: https://codereview.chromium.org/12212011
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@13728 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      ce1e10f5
  22. 09 Nov, 2012 1 commit
  23. 01 Jun, 2012 1 commit
    • rossberg@chromium.org's avatar
      Implement correct checking for inherited readonliness on assignment. · e4c472a7
      rossberg@chromium.org authored
      Removes 6 out of 8 of our remaining unintentional failures on test262.
      
      Also fixes treatment of inherited setters added after the fact.
      
      Specifically:
      
      - In the runtime, when looking for setter callbacks in the prototype chain,
        also look for read-only properties. If one is found, reject (exception in
        strict mode). If a proxy is found, invoke proper trap.
        Note: this folds in the CanPut function from the spec and avoids an extra
        lookup over the prototype chain.
      
      - In generated code for stores, insert a test for the maps from the prototype
        chain, but only up to the object where the property already exists (which
        may be the object itself).
        In Hydrogen, if the found property is read-only or not cacheable (e.g. a
        proxy), bail out; in a stub, generate an unconditional miss (to get an
        exception in strict mode).
      
      - Add test cases and adapt existing test expectations.
      
      R=mstarzinger@chromium.org
      BUG=
      TEST=
      
      Review URL: https://chromiumcodereview.appspot.com/10388047
      
      git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@11694 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      e4c472a7
  24. 29 May, 2012 2 commits
  25. 23 Mar, 2012 1 commit
  26. 10 Nov, 2011 1 commit
  27. 26 Oct, 2011 1 commit
  28. 24 Oct, 2011 2 commits
  29. 10 Oct, 2011 2 commits
  30. 06 Oct, 2011 1 commit
  31. 22 Sep, 2011 3 commits
  32. 21 Sep, 2011 1 commit
  33. 16 Sep, 2011 2 commits
  34. 13 Sep, 2011 1 commit