- 02 Jul, 2013 1 commit
-
-
loislo@chromium.org authored
Each CpuProfileNode has resource_name string property. It cost us N * strlen(resource_name) where N is number of functions in the collected profile. We could transfer script_id instead of resource_name so it would reduce transfer size and help us to solve the problem with evals and sourceURL. BUG=none TEST=test-cpu-profiler/CollectCpuProfile R=jkummerow@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15429 Review URL: https://codereview.chromium.org/17642009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15433 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 01 Jul, 2013 29 commits
-
-
palfia@homejinni.com authored
Different register must be used to pass the test on target hardware. BUG= TEST=cctest/test-api/SetFunctionEntryHook Review URL: https://codereview.chromium.org/18368002 Patch from Balazs Kilvady <kilvadyb@homejinni.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15432 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
loislo@chromium.org authored
This reverts commit d575f6bc8b262dac08f02913ae6e7c504c9dd900. Check is failing on debug bots. TBR= yurys@chromium.org Review URL: https://chromiumcodereview.appspot.com/18332010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15431 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
loislo@chromium.org authored
Each CpuProfileNode has resource_name string property. It cost us N * strlen(resource_name) where N is number of functions in the collected profile. We could transfer script_id instead of resource_name so it would reduce transfer size and help us to solve the problem with evals and sourceURL. BUG=none TEST=test-cpu-profiler/CollectCpuProfile R=jkummerow@chromium.org, yurys@chromium.org Review URL: https://codereview.chromium.org/17642009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15429 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=hpayer@chromium.org BUG= Review URL: https://codereview.chromium.org/18364002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15428 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
danno@chromium.org authored
TBR=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/18357004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15427 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yurys@chromium.org authored
When current function is FunctionCall builtin we have no reliable way to determine its caller function (in many cases the top of the sampled stack contains address of the caller but sometimes it does not). Instead of dropping the sample or its two top frames we simply mark the caller frame as '(unresolved function)'. It seems like a better approach that dropping whole sample as knowing the top function and the rest of the stack the user should be able to figure out what the caller was. This change adds builtin id to CodeEntry objects. It will be used later to add similar top frame analysis for FunctionApply and probably other builtins. BUG=None R=jkummerow@chromium.org, loislo@chromium.org Review URL: https://codereview.chromium.org/18316004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15426 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
rossberg@chromium.org authored
Currently synthesizes Smi as the lower bound for numeric operations (except for +, which might result in a string). That would need to change in places where we want to track constants as type feedback. Does not do anything about variables yet. R=jkummerow@chromium.org BUG= Review URL: https://codereview.chromium.org/17842004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15422 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mstarzinger@chromium.org authored
R=rossberg@chromium.org BUG=v8:2753 TEST=mjsunit/harmony/collections Review URL: https://codereview.chromium.org/18352002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15421 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
prybin@chromium.org authored
Review URL: https://codereview.chromium.org/18349004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15420 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
danno@chromium.org authored
- Constants globals are inlined into Hydrogen code using code dependencies that invalidate the Crankshafted code when global PropertyCells or the global object change. - The more general case generates code that is just as good as the hand-written assembly stubs on all platforms. R=ulan@chromium.org Review URL: https://codereview.chromium.org/16925008 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15419 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
prybin@chromium.org authored
Review URL: https://codereview.chromium.org/18326007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15418 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mstarzinger@chromium.org authored
This makes sure that the same symbols are present, independent of which defines have been used while building V8. Otherwise only embedders with compatible defines would be able to link against that binary. R=danno@chromium.org BUG=chromium:255779 Review URL: https://codereview.chromium.org/18305004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15417 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
prybin@chromium.org authored
R=yangguo@chromium.org Review URL: https://codereview.chromium.org/16093040 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15416 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yurys@chromium.org authored
The only way to get v8::CpuProfiler instance in the V8 public API is to call v8::Iolate::GetCpuProfiler(). The method will return NULL if the isolate has not been initialized yet or has been torn down already. It is the client's reponsibility to make sure that CPU profiling has been stopped before disposing of the isolate. This CL adds a test for this and several ASSRTS enforcing that assumptions. This allowed to be sure that heap is always setup when CPU profiling is being started. Based on that the number of places where already compiled functions are reported to the profiler event processor boils down to the single place (CpuProfiler::StartProcessorIfNotStarted). I'm going to rely on this assumption in further changes. BUG=None R=loislo@chromium.org, yangguo@chromium.org Review URL: https://codereview.chromium.org/18336002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15415 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18345004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15414 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
Following up on https://codereview.chromium.org/18353002, there's no need to pass the profiles to ProfilerEventsProcessor's constructor. BUG= R=danno@chromium.org Review URL: https://codereview.chromium.org/18332004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15413 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
BUG= R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18353002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15412 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
bmeurer@chromium.org authored
BUG= R=danno@chromium.org Review URL: https://codereview.chromium.org/18324007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15411 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mvstanton@chromium.org authored
lm - list matching modules and details such as product version number found in the minidump. Also, enabled a mode to execute one command and exit. BUG= R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/18310003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15410 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
Add broader custom test expectations for blink tests to detect crashes. Remove also useless documentation. Most of these tests had some problems (failure, crash or timeout), but which problem exactly cannot be retrieved anymore. We let them rum for a while with a broader test expectation (pass fail slow) and analyse the results. Tests that crash get a crash expectation. Timeouts will get a timeout expectation. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18319005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15409 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
Based on a patch contributed by Andrew Paprocki <andrew@ishiboo.com>. R=jkummerow@chromium.org BUG= TEST=cctest/test-api/TryCatchNestedSyntax Review URL: https://codereview.chromium.org/17694002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15408 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
loislo@chromium.org authored
The bodies of methods in ProfilerEventProcessor were moved into CpuProfiler. Multiple NewCodeEntry methods in CpuProfilesCollection were replaced with one which simply passes arguments to the CodeEntry constructor. And CpuProfiler just calls this method when it needs a CodeEntry object. This NewCodeEntry method is required because CpuProfilesCollection keeps ownership of CodeEntry objects. BUG=255392 TEST=existing tests R=yangguo@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15405 Review URL: https://codereview.chromium.org/18053004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15407 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
loislo@chromium.org authored
This reverts commit 76adf84b83ec3c0b261cbc29369ce4ac83f9d002. windows compilation failed BUG=none TBR=yurys@chromium.org Review URL: https://codereview.chromium.org/18344002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15406 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
loislo@chromium.org authored
The bodies of methods in ProfilerEventProcessor were moved into CpuProfiler. Multiple NewCodeEntry methods in CpuProfilesCollection were replaced with one which simply passes arguments to the CodeEntry constructor. And CpuProfiler just calls this method when it needs a CodeEntry object. This NewCodeEntry method is required because CpuProfilesCollection keeps ownership of CodeEntry objects. BUG=255392 TEST=existing tests R=yangguo@chromium.org, yurys@chromium.org Review URL: https://codereview.chromium.org/18053004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15405 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
%CompleteOptimization attempts to install optimized functions that the parallel thread has put on the output queue, as long as the function is marked with a builtin. However, activating the debugger will set all functions to the lazy recompile builtin, without the function being on the parallel recompilation pipeline. So we wait for the function to finish parallel recompilation while it's marked by a builtin that's unrelated to parallel recompilation. R=hpayer@chromium.org BUG= Review URL: https://codereview.chromium.org/18129003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15404 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mvstanton@chromium.org authored
running crankshaft. Allow the test to tolerate --nocrankshaft. BUG= R=hpayer@chromium.org Review URL: https://codereview.chromium.org/18328002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15403 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
We use the patched version from the chromium project, as it already has a gyp file and allows for using the system icu instead of the bundled version if desired. This is in preparation of bringing in v8-i18n. R=jkummerow@chromium.org BUG=v8:2745 Review URL: https://codereview.chromium.org/17850002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15402 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
The file tests different CR and LF combinations that cannot be stored correctly in SVN. Since we do not need coverage here, we rather remove the test completely. R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18333002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15401 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
machenbach@chromium.org authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18324003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15398 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Jun, 2013 10 commits
-
-
palfia@homejinni.com authored
This commit fixes r15396. BUG= Review URL: https://codereview.chromium.org/18054020 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15397 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
palfia@homejinni.com authored
Port r15384 (d553efd) Original commit message: Adds more coverage for function entry hook, sufficient to capture profiles that are contiguous from C++, through JS and back out to C++. BUG= Review URL: https://codereview.chromium.org/18184011 Patch from Balazs Kilvady <kilvadyb@homejinni.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15396 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
palfia@homejinni.com authored
Port r15383 (3e90aaf) Original commit message: * Cleanup of LCallNewArray::PrintDataTo() method * Created HCallNewArray::PrintDataTo() * Created many more tests in array-constructor-feedback.js * Removed redundant instructions in GenerateRecordCallTarget * Bugfix in CreateArrayDispatchOneArgument: on a call to new Array(0), we'd like to set the type feedback cell to a packed elements kind, but we shouldn't do it if the cell contains the megamorphic sentinel. * When used from crankshaft, ArrayConstructorStubs can avoid verifying that the function being called is the array function from the current native context, relying instead on the fact that crankshaft issues an HCheckFunction to protect the constructor call. (this new minor key is used in LCodeGen::DoCallNewArray(), and influences code generation in CodeStubGraphBuilderBase::BuildArrayConstructor()). * Optimization: the array constructor specialized for FAST_SMI_ELEMENTS can save some instructions by looking up the correct map on the passed in constructor, rather than indexing into the array of cached maps per element kind. BUG= Review URL: https://codereview.chromium.org/18191007 Patch from Balazs Kilvady <kilvadyb@homejinni.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15395 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mstarzinger@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/18068002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15394 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
mstarzinger@chromium.org authored
R=jkummerow@chromium.org, titzer@chromium.org Review URL: https://codereview.chromium.org/17914002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15393 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
Add %_DebugBreakInOptimizedCode() pseudo function call to insert int3/stop instructions into optimized code R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/17870002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15392 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18037002 Patch from Haitao Feng <haitao.feng@intel.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15391 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18076002 Patch from Weiliang Lin <weiliang.lin2@gmail.com>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15390 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
This allows for compiling third-party code (such as ICU) with less strict flags. BUG=v8:2745 R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18181006 Patch from Jochen Eisinger <jochen@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15389 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jkummerow@chromium.org authored
r1656 contains a bug fix for the make generator to correctly regenerate Makefiles if a gyp was touched. Before, it would assume that it is running in the top-level directory. However, the v8 standalone build puts the generated Makefile into the out subdirectory, and so gyp failed to locate the gyp binary. BUG=none R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/18053015 Patch from Jochen Eisinger <jochen@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15388 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-